All of lore.kernel.org
 help / color / mirror / Atom feed
From: Claudio Fontana <cfontana@suse.de>
To: "Paolo Bonzini" <pbonzini@redhat.com>,
	"Richard Henderson" <richard.henderson@linaro.org>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>,
	"Eduardo Habkost" <ehabkost@redhat.com>,
	"Peter Maydell" <peter.maydell@linaro.org>,
	"Alex Bennée" <alex.bennee@linaro.org>
Cc: "Laurent Vivier" <lvivier@redhat.com>,
	"Thomas Huth" <thuth@redhat.com>,
	"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
	qemu-devel@nongnu.org, "Roman Bolshakov" <r.bolshakov@yadro.com>,
	"Claudio Fontana" <cfontana@suse.de>
Subject: [PATCH v26 01/20] target/i386: Rename helper_fldt, helper_fstt
Date: Mon,  1 Mar 2021 09:54:31 +0100	[thread overview]
Message-ID: <20210301085450.1732-2-cfontana@suse.de> (raw)
In-Reply-To: <20210301085450.1732-1-cfontana@suse.de>

From: Richard Henderson <richard.henderson@linaro.org>

Change the prefix from "helper" to "do".  The former should be
reserved for those functions that are called from TCG; the latter
is in use within the file already for those functions that are
called from the helper functions, adding a "retaddr" argument.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Claudio Fontana <cfontana@suse.de>
Tested-by: Claudio Fontana <cfontana@suse.de>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 target/i386/tcg/fpu_helper.c | 19 +++++++++----------
 1 file changed, 9 insertions(+), 10 deletions(-)

diff --git a/target/i386/tcg/fpu_helper.c b/target/i386/tcg/fpu_helper.c
index 60ed93520a..3d9b192901 100644
--- a/target/i386/tcg/fpu_helper.c
+++ b/target/i386/tcg/fpu_helper.c
@@ -117,8 +117,7 @@ static inline void fpop(CPUX86State *env)
     env->fpstt = (env->fpstt + 1) & 7;
 }
 
-static inline floatx80 helper_fldt(CPUX86State *env, target_ulong ptr,
-                                   uintptr_t retaddr)
+static floatx80 do_fldt(CPUX86State *env, target_ulong ptr, uintptr_t retaddr)
 {
     CPU_LDoubleU temp;
 
@@ -127,8 +126,8 @@ static inline floatx80 helper_fldt(CPUX86State *env, target_ulong ptr,
     return temp.d;
 }
 
-static inline void helper_fstt(CPUX86State *env, floatx80 f, target_ulong ptr,
-                               uintptr_t retaddr)
+static void do_fstt(CPUX86State *env, floatx80 f, target_ulong ptr,
+                    uintptr_t retaddr)
 {
     CPU_LDoubleU temp;
 
@@ -405,14 +404,14 @@ void helper_fldt_ST0(CPUX86State *env, target_ulong ptr)
     int new_fpstt;
 
     new_fpstt = (env->fpstt - 1) & 7;
-    env->fpregs[new_fpstt].d = helper_fldt(env, ptr, GETPC());
+    env->fpregs[new_fpstt].d = do_fldt(env, ptr, GETPC());
     env->fpstt = new_fpstt;
     env->fptags[new_fpstt] = 0; /* validate stack entry */
 }
 
 void helper_fstt_ST0(CPUX86State *env, target_ulong ptr)
 {
-    helper_fstt(env, ST0, ptr, GETPC());
+    do_fstt(env, ST0, ptr, GETPC());
 }
 
 void helper_fpush(CPUX86State *env)
@@ -2468,7 +2467,7 @@ void helper_fsave(CPUX86State *env, target_ulong ptr, int data32)
     ptr += (14 << data32);
     for (i = 0; i < 8; i++) {
         tmp = ST(i);
-        helper_fstt(env, tmp, ptr, GETPC());
+        do_fstt(env, tmp, ptr, GETPC());
         ptr += 10;
     }
 
@@ -2495,7 +2494,7 @@ void helper_frstor(CPUX86State *env, target_ulong ptr, int data32)
     ptr += (14 << data32);
 
     for (i = 0; i < 8; i++) {
-        tmp = helper_fldt(env, ptr, GETPC());
+        tmp = do_fldt(env, ptr, GETPC());
         ST(i) = tmp;
         ptr += 10;
     }
@@ -2539,7 +2538,7 @@ static void do_xsave_fpu(CPUX86State *env, target_ulong ptr, uintptr_t ra)
     addr = ptr + XO(legacy.fpregs);
     for (i = 0; i < 8; i++) {
         floatx80 tmp = ST(i);
-        helper_fstt(env, tmp, addr, ra);
+        do_fstt(env, tmp, addr, ra);
         addr += 16;
     }
 }
@@ -2703,7 +2702,7 @@ static void do_xrstor_fpu(CPUX86State *env, target_ulong ptr, uintptr_t ra)
 
     addr = ptr + XO(legacy.fpregs);
     for (i = 0; i < 8; i++) {
-        floatx80 tmp = helper_fldt(env, addr, ra);
+        floatx80 tmp = do_fldt(env, addr, ra);
         ST(i) = tmp;
         addr += 16;
     }
-- 
2.26.2



  reply	other threads:[~2021-03-01  8:56 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-01  8:54 [PATCH v26 00/20] i386 cleanup PART 2 Claudio Fontana
2021-03-01  8:54 ` Claudio Fontana [this message]
2021-03-01  8:54 ` [PATCH v26 02/20] target/i386: Split out do_fsave, do_frstor, do_fxsave, do_fxrstor Claudio Fontana
2021-03-01  8:54 ` [PATCH v26 03/20] i386: split cpu accelerators from cpu.c, using AccelCPUClass Claudio Fontana
2021-03-01  8:54 ` [PATCH v26 04/20] cpu: call AccelCPUClass::cpu_realizefn in cpu_exec_realizefn Claudio Fontana
2021-03-01  8:54 ` [PATCH v26 05/20] accel: introduce new accessor functions Claudio Fontana
2021-03-01  8:54 ` [PATCH v26 06/20] target/i386: fix host_cpu_adjust_phys_bits error handling Claudio Fontana
2021-03-01  8:54 ` [PATCH v26 07/20] accel-cpu: make cpu_realizefn return a bool Claudio Fontana
2021-03-01  8:54 ` [PATCH v26 08/20] meson: add target_user_arch Claudio Fontana
2021-03-01  8:54 ` [PATCH v26 09/20] i386: split off sysemu-only functionality in tcg-cpu Claudio Fontana
2021-03-01  8:54 ` [PATCH v26 10/20] i386: split smm helper (sysemu) Claudio Fontana
2021-03-01  8:54 ` [PATCH v26 11/20] i386: split tcg excp_helper into sysemu and user parts Claudio Fontana
2021-03-01  8:54 ` [PATCH v26 12/20] i386: move TCG bpt_helper into sysemu/ Claudio Fontana
2021-03-01  8:54 ` [PATCH v26 13/20] i386: split misc helper user stubs and sysemu part Claudio Fontana
2021-03-01  8:54 ` [PATCH v26 14/20] i386: separate fpu_helper sysemu-only parts Claudio Fontana
2021-03-01  8:54 ` [PATCH v26 15/20] i386: split svm_helper into sysemu and stub-only user Claudio Fontana
2021-03-01  8:54 ` [PATCH v26 16/20] i386: split seg_helper into user-only and sysemu parts Claudio Fontana
2021-03-01  8:54 ` [PATCH v26 17/20] i386: split off sysemu part of cpu.c Claudio Fontana
2021-03-01  8:54 ` [PATCH v26 18/20] target/i386: gdbstub: introduce aux functions to read/write CS64 regs Claudio Fontana
2021-03-01  8:54 ` [PATCH v26 19/20] target/i386: gdbstub: only write CR0/CR2/CR3/EFER for sysemu Claudio Fontana
2021-03-01  8:54 ` [PATCH v26 20/20] i386: make cpu_load_efer sysemu-only Claudio Fontana
2021-03-01  9:18 ` [PATCH v26 00/20] i386 cleanup PART 2 no-reply
2021-03-08 12:57 ` Claudio Fontana
2021-03-08 13:27   ` Philippe Mathieu-Daudé
2021-03-08 13:52     ` Claudio Fontana
2021-03-08 14:57       ` Philippe Mathieu-Daudé
2021-03-08 15:03         ` Claudio Fontana
2021-03-08 15:07         ` Daniel P. Berrangé
2021-03-08 14:02   ` Alex Bennée
2021-05-05  8:27     ` Claudio Fontana
2021-05-05 10:04       ` Alex Bennée
2021-05-05 12:15         ` Philippe Mathieu-Daudé
2021-05-05 12:24           ` Philippe Mathieu-Daudé
2021-05-05 19:31           ` Eduardo Habkost
2021-05-06  7:55             ` Claudio Fontana
2021-05-06  9:10               ` Philippe Mathieu-Daudé
2021-05-06  9:33                 ` Philippe Mathieu-Daudé
2021-05-12  7:17                   ` Philippe Mathieu-Daudé
2021-05-17  6:17                     ` Claudio Fontana
2021-05-19 18:17                       ` Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210301085450.1732-2-cfontana@suse.de \
    --to=cfontana@suse.de \
    --cc=alex.bennee@linaro.org \
    --cc=ehabkost@redhat.com \
    --cc=f4bug@amsat.org \
    --cc=lvivier@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=r.bolshakov@yadro.com \
    --cc=richard.henderson@linaro.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.