From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD085C433DB for ; Mon, 1 Mar 2021 10:10:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5D62E64E45 for ; Mon, 1 Mar 2021 10:10:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232156AbhCAKKB (ORCPT ); Mon, 1 Mar 2021 05:10:01 -0500 Received: from mx2.suse.de ([195.135.220.15]:36886 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232575AbhCAKIX (ORCPT ); Mon, 1 Mar 2021 05:08:23 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id D747AAAC5; Mon, 1 Mar 2021 10:07:40 +0000 (UTC) Date: Mon, 1 Mar 2021 11:07:38 +0100 From: Oscar Salvador To: David Hildenbrand Cc: Andrew Morton , Michal Hocko , VlastimilBabkavbabka@suse.cz, pasha.tatashin@soleen.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Anshuman Khandual Subject: Re: [PATCH v2 6/7] x86/Kconfig: Introduce ARCH_MHP_MEMMAP_ON_MEMORY_ENABLE Message-ID: <20210301100737.GB32425@linux> References: <20210209133854.17399-1-osalvador@suse.de> <20210209133854.17399-7-osalvador@suse.de> <20210226120451.GA3661@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 01, 2021 at 09:45:07AM +0100, David Hildenbrand wrote: > Take your config and set > X86_5LEVEL=n > (because it enforces SPARSEMEM_VMEMMAP) > and > SPARSEMEM_VMEMMAP=n > > When compiling, you'll end up with a config like > CONFIG_SPARSEMEM_VMEMMAP_ENABLE=y > # CONFIG_SPARSEMEM_VMEMMAP is not set I see > > Yet, with your patch you would get > > ARCH_MHP_MEMMAP_ON_MEMORY_ENABLE=y > > And it would not get fenced off in the code, right? > > > I think you either have to check (IS_ENABLED(CONFIG_SPARSEMEM_VMEMMAP)) in > addition in your code, or enforce it differently. Like > > > config MHP_MEMMAP_ON_MEMORY > depends on SPARSEMEM_VMEMMAP && ARCH_MHP_MEMMAP_ON_MEMORY_ENABLE > bool > > > Then you can simplify the arch Kconfig settings, removing the sparesemem > dependency there. Yes, will do it this way. Thanks! -- Oscar Salvador SUSE L3