From: Christian Brauner <christian.brauner@ubuntu.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Randy Dunlap <rdunlap@infradead.org>,
linux-kernel@vger.kernel.org, David Howells <dhowells@redhat.com>,
Al Viro <viro@zeniv.linux.org.uk>,
linux-fsdevel@vger.kernel.org,
"David P . Quigley" <dpquigl@tycho.nsa.gov>,
James Morris <jmorris@namei.org>
Subject: Re: [PATCH -next] fs: libfs: fix kernel-doc for mnt_userns
Date: Mon, 1 Mar 2021 12:54:39 +0100 [thread overview]
Message-ID: <20210301115439.2edodjidbi6kes2j@wittgenstein> (raw)
In-Reply-To: <20210216084825.GA23845@lst.de>
On Tue, Feb 16, 2021 at 09:48:25AM +0100, Christoph Hellwig wrote:
> On Mon, Feb 15, 2021 at 08:29:27PM -0800, Randy Dunlap wrote:
> > Fix kernel-doc warning in libfs.c.
> >
> > ../fs/libfs.c:498: warning: Function parameter or member 'mnt_userns' not described in 'simple_setattr'
>
> Shouldn't the subject say simple_setattr instead of mnt_userns?
>
> Otherwise looks good:
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
So I've picked this up but just as an fyi b4 fell all over its face on
this series always giving me partial patches or prefixing it with v2 or
v3 or sm. Really strange, I'll report this to Konstantin.
Christian
next prev parent reply other threads:[~2021-03-01 11:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-16 4:29 [PATCH -next] fs: fix new and older kernel-doc warnings in fs/ Randy Dunlap
2021-02-16 4:29 ` [PATCH -next] fs: libfs: fix kernel-doc for mnt_userns Randy Dunlap
2021-02-16 8:48 ` Christoph Hellwig
2021-02-16 9:41 ` Christian Brauner
2021-03-01 11:54 ` Christian Brauner [this message]
2021-02-16 4:29 ` [PATCH -next] fs: namei: fix kernel-doc for struct renamedata and more Randy Dunlap
2021-02-16 4:29 ` [PATCH -next] fs: xattr: fix kernel-doc for mnt_userns and vfs xattr helpers Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210301115439.2edodjidbi6kes2j@wittgenstein \
--to=christian.brauner@ubuntu.com \
--cc=dhowells@redhat.com \
--cc=dpquigl@tycho.nsa.gov \
--cc=hch@lst.de \
--cc=jmorris@namei.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.