All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Zbigniew Kempczyński" <zbigniew.kempczynski@intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t v21 31/35] tests/gem_mmap_offset: Use intel_buf wrapper code instead direct
Date: Mon,  1 Mar 2021 17:13:59 +0100	[thread overview]
Message-ID: <20210301161403.98278-32-zbigniew.kempczynski@intel.com> (raw)
In-Reply-To: <20210301161403.98278-1-zbigniew.kempczynski@intel.com>

Generally when playing with intel_buf we should use wrapper code
instead of adding it to intel_bb directly. Code checks required
alignment on specific gens so protects us from passing unaligned
properly addresses.

Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
Cc: Dominik Grzegorzek <dominik.grzegorzek@intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
---
 tests/i915/gem_mmap_offset.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/i915/gem_mmap_offset.c b/tests/i915/gem_mmap_offset.c
index 5e48cd697..8f2006274 100644
--- a/tests/i915/gem_mmap_offset.c
+++ b/tests/i915/gem_mmap_offset.c
@@ -614,8 +614,8 @@ static void blt_coherency(int i915)
 	dst = create_bo(bops, 1, width, height);
 	size = src->surface[0].size;
 
-	intel_bb_add_object(ibb, src->handle, size, src->addr.offset, 0, false);
-	intel_bb_add_object(ibb, dst->handle, size, dst->addr.offset, 0, true);
+	intel_bb_add_intel_buf(ibb, src, false);
+	intel_bb_add_intel_buf(ibb, dst, true);
 
 	intel_bb_blt_copy(ibb,
 			  src, 0, 0, src->surface[0].stride,
-- 
2.26.0

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

  parent reply	other threads:[~2021-03-01 16:14 UTC|newest]

Thread overview: 61+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-01 16:13 [igt-dev] [PATCH i-g-t v21 00/35] Introduce IGT allocator Zbigniew Kempczyński
2021-03-01 16:13 ` [igt-dev] [PATCH i-g-t v21 01/35] lib/gem_submission: Add gem_has_relocations() check Zbigniew Kempczyński
2021-03-04 14:09   ` Chris Wilson
2021-03-01 16:13 ` [igt-dev] [PATCH i-g-t v21 02/35] lib/igt_list: Add igt_list_del_init() Zbigniew Kempczyński
2021-03-04 14:09   ` Chris Wilson
2021-03-01 16:13 ` [igt-dev] [PATCH i-g-t v21 03/35] lib/igt_list: igt_hlist implementation Zbigniew Kempczyński
2021-03-01 16:13 ` [igt-dev] [PATCH i-g-t v21 04/35] lib/igt_map: Introduce igt_map Zbigniew Kempczyński
2021-03-01 16:13 ` [igt-dev] [PATCH i-g-t v21 05/35] lib/igt_core: Track child process pid and tid Zbigniew Kempczyński
2021-03-01 16:13 ` [igt-dev] [PATCH i-g-t v21 06/35] lib/intel_allocator_simple: Add simple allocator Zbigniew Kempczyński
2021-03-01 16:13 ` [igt-dev] [PATCH i-g-t v21 07/35] lib/intel_allocator_random: Add random allocator Zbigniew Kempczyński
2021-03-01 16:13 ` [igt-dev] [PATCH i-g-t v21 08/35] lib/intel_allocator: Add intel_allocator core Zbigniew Kempczyński
2021-03-04 16:23   ` Chris Wilson
2021-03-01 16:13 ` [igt-dev] [PATCH i-g-t v21 09/35] lib/intel_allocator: Try to stop smoothly instead of deinit Zbigniew Kempczyński
2021-03-05 14:16   ` Chris Wilson
2021-03-08  7:25     ` Zbigniew Kempczyński
2021-03-01 16:13 ` [igt-dev] [PATCH i-g-t v21 10/35] lib/intel_allocator_msgchannel: Scale to 4k of parallel clients Zbigniew Kempczyński
2021-03-01 16:13 ` [igt-dev] [PATCH i-g-t v21 11/35] lib/intel_allocator: Separate allocator multiprocess start Zbigniew Kempczyński
2021-03-01 16:13 ` [igt-dev] [PATCH i-g-t v21 12/35] lib/intel_bufops: Change size from 32->64 bit Zbigniew Kempczyński
2021-03-01 16:13 ` [igt-dev] [PATCH i-g-t v21 13/35] lib/intel_bufops: Add init with handle and size function Zbigniew Kempczyński
2021-03-01 16:13 ` [igt-dev] [PATCH i-g-t v21 14/35] lib/intel_batchbuffer: Integrate intel_bb with allocator Zbigniew Kempczyński
2021-03-05 14:23   ` Chris Wilson
2021-03-01 16:13 ` [igt-dev] [PATCH i-g-t v21 15/35] lib/intel_batchbuffer: Use relocations in intel-bb up to gen12 Zbigniew Kempczyński
2021-03-05 14:27   ` Chris Wilson
2021-03-01 16:13 ` [igt-dev] [PATCH i-g-t v21 16/35] lib/intel_batchbuffer: Create bb with strategy / vm ranges Zbigniew Kempczyński
2021-03-01 16:13 ` [igt-dev] [PATCH i-g-t v21 17/35] lib/intel_batchbuffer: Add tracking intel_buf to intel_bb Zbigniew Kempczyński
2021-03-05 14:33   ` Chris Wilson
2021-03-01 16:13 ` [igt-dev] [PATCH i-g-t v21 18/35] lib/igt_fb: Initialize intel_buf with same size as fb Zbigniew Kempczyński
2021-03-01 16:13 ` [igt-dev] [PATCH i-g-t v21 19/35] tests/api_intel_bb: Modify test to verify intel_bb with allocator Zbigniew Kempczyński
2021-03-05 14:39   ` Chris Wilson
2021-03-08  9:47     ` Zbigniew Kempczyński
2021-03-08 10:17       ` Chris Wilson
2021-03-01 16:13 ` [igt-dev] [PATCH i-g-t v21 20/35] tests/api_intel_bb: Add subtest to check render batch on the last page Zbigniew Kempczyński
2021-03-05 14:45   ` Chris Wilson
2021-03-09 20:29     ` Zbigniew Kempczyński
2021-03-01 16:13 ` [igt-dev] [PATCH i-g-t v21 21/35] tests/api_intel_bb: Add compressed->compressed copy Zbigniew Kempczyński
2021-03-01 16:13 ` [igt-dev] [PATCH i-g-t v21 22/35] tests/api_intel_bb: Add purge-bb test Zbigniew Kempczyński
2021-03-01 16:13 ` [igt-dev] [PATCH i-g-t v21 23/35] tests/api_intel_bb: Remove check-canonical test Zbigniew Kempczyński
2021-03-01 16:13 ` [igt-dev] [PATCH i-g-t v21 24/35] tests/api_intel_bb: Add simple intel-bb which uses allocator Zbigniew Kempczyński
2021-03-01 16:13 ` [igt-dev] [PATCH i-g-t v21 25/35] tests/api_intel_bb: Use allocator in delta-check test Zbigniew Kempczyński
2021-03-01 16:13 ` [igt-dev] [PATCH i-g-t v21 26/35] tests/api_intel_bb: Check switching vm in intel-bb Zbigniew Kempczyński
2021-03-05 14:51   ` Chris Wilson
2021-03-01 16:13 ` [igt-dev] [PATCH i-g-t v21 27/35] tests/api_intel_allocator: Simple allocator test suite Zbigniew Kempczyński
2021-03-01 16:13 ` [igt-dev] [PATCH i-g-t v21 28/35] tests/api_intel_allocator: Add execbuf with allocator example Zbigniew Kempczyński
2021-03-01 16:13 ` [igt-dev] [PATCH i-g-t v21 29/35] tests/gem_softpin: Verify allocator and execbuf pair work together Zbigniew Kempczyński
2021-03-01 16:13 ` [igt-dev] [PATCH i-g-t v21 30/35] tests/gem|kms: Remove intel_bb from fixture Zbigniew Kempczyński
2021-03-05 14:56   ` Chris Wilson
2021-03-01 16:13 ` Zbigniew Kempczyński [this message]
2021-03-05 14:56   ` [igt-dev] [PATCH i-g-t v21 31/35] tests/gem_mmap_offset: Use intel_buf wrapper code instead direct Chris Wilson
2021-03-01 16:14 ` [igt-dev] [PATCH i-g-t v21 32/35] tests/gem_ppgtt: Adopt test to use intel_bb with allocator Zbigniew Kempczyński
2021-03-05 15:00   ` Chris Wilson
2021-03-08 14:26     ` Zbigniew Kempczyński
2021-03-01 16:14 ` [igt-dev] [PATCH i-g-t v21 33/35] tests/gem_render_copy_redux: Adopt to use with intel_bb and allocator Zbigniew Kempczyński
2021-03-01 16:14 ` [igt-dev] [PATCH i-g-t v21 34/35] tests/perf.c: Remove buffer from batch Zbigniew Kempczyński
2021-03-01 16:14 ` [igt-dev] [PATCH i-g-t v21 35/35] tests/gem_linear_blits: Use intel allocator Zbigniew Kempczyński
2021-03-05 15:07   ` Chris Wilson
2021-03-01 17:02 ` [igt-dev] ✓ Fi.CI.BAT: success for Introduce IGT allocator (rev22) Patchwork
2021-03-01 17:09 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2021-03-02 11:29   ` Zbigniew Kempczyński
2021-03-02 12:41     ` Petri Latvala
2021-03-04 13:03 ` [igt-dev] ✓ Fi.CI.BAT: success for Introduce IGT allocator (rev23) Patchwork
2021-03-04 16:45 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210301161403.98278-32-zbigniew.kempczynski@intel.com \
    --to=zbigniew.kempczynski@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.