All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Behun <marek.behun@nic.cz>
To: u-boot@lists.denx.de
Subject: [PATCH v2 3/3] arm: mvebu: Initial ESPRESSOBin-Ultra board support
Date: Mon, 1 Mar 2021 18:13:04 +0100	[thread overview]
Message-ID: <20210301181304.12cbc71a@nic.cz> (raw)
In-Reply-To: <20210301154101.ke5j2r3lazjlxrsl@pali>

On Mon, 1 Mar 2021 16:41:01 +0100
Pali Roh?r <pali@kernel.org> wrote:

> On Sunday 28 February 2021 22:38:26 Luka Kovacic wrote:
> > Hello Marek,
> > 
> > On Sat, Feb 27, 2021 at 2:24 PM Marek Behun <marek.behun@nic.cz> wrote:  
> > >
> > > In Linux the DTS for espressobin-ultra includes
> > > armada-3720-espressobin.dtsi and just adds changes.
> > >
> > > If possible, please do this as is done in Linux. In fact we want to
> > > slowly move in the direction to have the dts files just copied from
> > > Linux.
> > >
> > > Marek  
> > 
> > Thanks for pointing this out.
> > As you and Pali have suggested, I will rework this patch to be as
> > close to the Linux dts as possible.
> > 
> > I'd go with the approach of just creating a dts with changes with
> > respect to the base ESPRESSOBin.
> > 
> > Kind regards,
> > Luka  
> 
> Hello Luka!
> 
> Linux kernel has currently 5 DTS files for espressobin (v5, v5-emmc, v7,
> v7-emmc, ultra) and all are using one common dtsi file.
> 
> In U-Boot now we have just one DTS file for all 4 variants (ultra
> variant is missing) and differences between emmc and non-emmc, v5 and v7
> variants is done at u-boot runtime code.
> 
> So this allows to have just one U-Boot binary for all espressobin
> boards.
> 
> Distributions (OpenWRT and Armbian) complained about need to have such
> many precompiled binaries for espressobin. And seems that after unifying
> u-boot to build just one espressobin binary, they are happy.
> 
> So, if it is possible, I would be happy if we can continue with this
> approach with just one DTS file and one U-Boot binary for all
> espressobin variants.
> 
> If it is needed to enable / disable some nodes in DTS file, it is
> possible at U-Boot runtime via board_fix_fdt() function in board code.
> Here can be e.g. code which checks if U-Boot is running at espressobin
> v7 or at espressobin ultra. Maybe this could help you with debugging...

In that case try to make the "one dts file to rule them all" to be the
same as the basic dts file in Linux, and do the necessary U-Boot
differences in armada-3720-espressobin-u-boot.dtsi file. Then fix the
necessary differences for variants in board code.

Marek

  reply	other threads:[~2021-03-01 17:13 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-15 19:59 [PATCH v2 0/3] Add support for the GST ESPRESSOBin-Ultra board Luka Kovacic
2021-02-15 19:59 ` [PATCH v2 1/3] cmd: mvebu: Implement the Marvell hw_info command Luka Kovacic
2021-02-16  3:35   ` Tom Rini
2021-02-27  1:09   ` Pali Rohár
2021-02-28 21:54     ` Luka Kovacic
2021-03-01 15:17       ` Pali Rohár
2021-02-27 13:05   ` Marek Behun
2021-02-28 22:03     ` Luka Kovacic
2021-02-28 23:45     ` Heinrich Schuchardt
2021-02-15 19:59 ` [PATCH v2 2/3] arm: mvebu: mvebu_armada-37xx: Define the loadaddr environment variable Luka Kovacic
2021-02-27  0:38   ` Pali Rohár
2021-02-28 21:26     ` Luka Kovacic
2021-03-01 15:05       ` Pali Rohár
2021-02-15 19:59 ` [PATCH v2 3/3] arm: mvebu: Initial ESPRESSOBin-Ultra board support Luka Kovacic
2021-02-27  0:48   ` Pali Rohár
2021-02-27 13:24   ` Marek Behun
2021-02-28 21:38     ` Luka Kovacic
2021-03-01 15:41       ` Pali Rohár
2021-03-01 17:13         ` Marek Behun [this message]
2021-03-01 17:14         ` Marek Behun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210301181304.12cbc71a@nic.cz \
    --to=marek.behun@nic.cz \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.