All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: alsa-devel@alsa-project.org
Cc: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>,
	Kai Vehmanen <kai.vehmanen@linux.intel.com>,
	arnd@arndb.de, tiwai@suse.de,
	Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
	vkoul@kernel.org, broonie@kernel.org,
	Bard Liao <bard.liao@intel.com>
Subject: [PATCH 5/7] ASoC: SOF: Intel: SoundWire: simplify Kconfig
Date: Mon,  1 Mar 2021 18:31:23 -0600	[thread overview]
Message-ID: <20210302003125.1178419-6-pierre-louis.bossart@linux.intel.com> (raw)
In-Reply-To: <20210302003125.1178419-1-pierre-louis.bossart@linux.intel.com>

The Kconfig file is way too convoluted. Track platforms where
SoundWire is supported, and add simpler conditions to make sure there
is no module/built-in issue.

The use of 'depends on' is less intuitive if a required 'depend' is
missing, but that's a small price to pay for clarity and simplicity.

Suggested-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Reviewed-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
Reviewed-by: Bard Liao <bard.liao@intel.com>
---
 sound/soc/sof/intel/Kconfig | 26 +++++++++-----------------
 1 file changed, 9 insertions(+), 17 deletions(-)

diff --git a/sound/soc/sof/intel/Kconfig b/sound/soc/sof/intel/Kconfig
index 7dcb61ba5763..21e24a3c64fb 100644
--- a/sound/soc/sof/intel/Kconfig
+++ b/sound/soc/sof/intel/Kconfig
@@ -276,29 +276,21 @@ config SND_SOC_SOF_HDA
 	  This option is not user-selectable but automagically handled by
 	  'select' statements at a higher level.
 
-config SND_SOC_SOF_INTEL_SOUNDWIRE_LINK
-	bool "SOF support for SoundWire"
-	depends on ACPI
-	help
-	  This adds support for SoundWire with Sound Open Firmware
-	  for Intel(R) platforms.
-	  Say Y if you want to enable SoundWire links with SOF.
-	  If unsure select "N".
-
 config SND_SOC_SOF_INTEL_SOUNDWIRE_LINK_BASELINE
 	tristate
-	select SND_SOC_SOF_INTEL_SOUNDWIRE if SND_SOC_SOF_INTEL_SOUNDWIRE_LINK
-	help
-	  This option is not user-selectable but automagically handled by
-	  'select' statements at a higher level.
 
 config SND_SOC_SOF_INTEL_SOUNDWIRE
-	tristate
-	select SOUNDWIRE
+	tristate "SOF support for SoundWire"
+	default SND_SOC_SOF_INTEL_SOUNDWIRE_LINK_BASELINE
+	depends on SND_SOC_SOF_INTEL_SOUNDWIRE_LINK_BASELINE
+	depends on ACPI && SOUNDWIRE
+	depends on !(SOUNDWIRE=m && SND_SOC_SOF_INTEL_SOUNDWIRE_LINK_BASELINE=y)
 	select SOUNDWIRE_INTEL
 	help
-	  This option is not user-selectable but automagically handled by
-	  'select' statements at a higher level.
+	  This adds support for SoundWire with Sound Open Firmware
+	  for Intel(R) platforms.
+	  Say Y if you want to enable SoundWire links with SOF.
+	  If unsure select "N".
 
 endif ## SND_SOC_SOF_INTEL_PCI
 
-- 
2.25.1


  parent reply	other threads:[~2021-03-02  0:35 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-02  0:31 [PATCH 0/7] ALSA/ASoC/SOF/SoundWire: fix Kconfig issues Pierre-Louis Bossart
2021-03-02  0:31 ` [PATCH 1/7] ASoC: soc-acpi: allow for partial match in parent name Pierre-Louis Bossart
2021-03-02  0:31 ` [PATCH 2/7] ASoC: SOF: ACPI: avoid reverse module dependency Pierre-Louis Bossart
2021-03-02  0:31 ` [PATCH 3/7] ASoC: SOF: pci: split PCI into different drivers Pierre-Louis Bossart
2021-03-02  0:31 ` [PATCH 4/7] ASoC: SOF: pci: move DSP_CONFIG use to platform-specific drivers Pierre-Louis Bossart
2021-03-02  0:31 ` Pierre-Louis Bossart [this message]
2021-03-02  0:31 ` [PATCH 6/7] ALSA: hda: move Intel SoundWire ACPI scan to dedicated module Pierre-Louis Bossart
2021-03-02 14:12   ` Vinod Koul
2021-03-02  0:31 ` [PATCH 7/7] ALSA: hda: intel-sdw-acpi: add missing include files Pierre-Louis Bossart
2021-03-02 12:43 ` [PATCH 0/7] ALSA/ASoC/SOF/SoundWire: fix Kconfig issues Mark Brown
2021-03-02 14:03 ` Takashi Iwai
2021-03-02 14:13   ` Vinod Koul
2021-03-02 14:43     ` Takashi Iwai
2021-03-02 14:52       ` Pierre-Louis Bossart
2021-03-02 15:03       ` Mark Brown
2021-03-02 15:16         ` Takashi Iwai
2021-03-02 15:34           ` Mark Brown
2021-07-26 18:59 ` Arnd Bergmann
2021-07-26 21:01   ` Pierre-Louis Bossart
2021-07-26 21:33     ` Arnd Bergmann
2021-07-28 15:39       ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210302003125.1178419-6-pierre-louis.bossart@linux.intel.com \
    --to=pierre-louis.bossart@linux.intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=arnd@arndb.de \
    --cc=bard.liao@intel.com \
    --cc=broonie@kernel.org \
    --cc=guennadi.liakhovetski@linux.intel.com \
    --cc=kai.vehmanen@linux.intel.com \
    --cc=tiwai@suse.de \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.