From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0147DC4332B for ; Tue, 2 Mar 2021 07:47:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B59BB61494 for ; Tue, 2 Mar 2021 07:47:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1576382AbhCBE2g (ORCPT ); Mon, 1 Mar 2021 23:28:36 -0500 Received: from szxga05-in.huawei.com ([45.249.212.191]:13017 "EHLO szxga05-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348821AbhCBBZs (ORCPT ); Mon, 1 Mar 2021 20:25:48 -0500 Received: from DGGEMS411-HUB.china.huawei.com (unknown [172.30.72.59]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4DqKBv1gxMzjV6J; Tue, 2 Mar 2021 09:23:19 +0800 (CST) Received: from DESKTOP-E0KHRBE.china.huawei.com (10.67.103.82) by DGGEMS411-HUB.china.huawei.com (10.3.19.211) with Microsoft SMTP Server id 14.3.498.0; Tue, 2 Mar 2021 09:24:49 +0800 From: Shaobo Huang To: CC: , , , , , , , , , , , , Subject: Re: [PATCH 4.4.y] arm: kprobes: Allow to handle reentered kprobe on single-stepping Date: Tue, 2 Mar 2021 09:24:49 +0800 Message-ID: <20210302012449.23428-1-huangshaobo6@huawei.com> X-Mailer: git-send-email 2.21.0.windows.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.67.103.82] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On March 1, 2021 at 11:30 AM, Greg KH wrote: > On Mon, Feb 27, 2021 at 05:17:01PM +0800, huangshaobo wrote: > > From: Masami Hiramatsu > > > > commit f3fbd7ec62dec1528fb8044034e2885f2b257941 upstream > > > > This is arm port of commit 6a5022a56ac3 ("kprobes/x86: Allow to handle > > reentered kprobe on single-stepping") > > > > Since the FIQ handlers can interrupt in the single stepping (or > > preparing the single stepping, do_debug etc.), we should consider a > > kprobe is hit in the NMI handler. Even in that case, the kprobe is > > allowed to be reentered as same as the kprobes hit in kprobe handlers > > (KPROBE_HIT_ACTIVE or KPROBE_HIT_SSDONE). > > > > The real issue will happen when a kprobe hit while another reentered > > kprobe is processing (KPROBE_REENTER), because we already consumed a > > saved-area for the previous kprobe. > > > > Signed-off-by: Masami Hiramatsu > > Signed-off-by: Jon Medhurst > > Fixes: 24ba613c9d6c ("ARM kprobes: core code") > > Cc: stable@vger.kernel.org #v2.6.25~v4.11 > > Signed-off-by: huangshaobo > > --- > > arch/arm/probes/kprobes/core.c | 6 ++++++ > > 1 file changed, 6 insertions(+) > > What about the 4.9.y tree as well? > > thanks, > > greg k-h Yes, I tested on the 4.4.y tree. From the code analysis, the same problem exists in the 2.6.25 to 4.11 trees, and of course the 4.9.y tree is also included. thanks, ShaoBo Huang From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CEBE1C433E0 for ; Tue, 2 Mar 2021 01:26:29 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7373160295 for ; Tue, 2 Mar 2021 01:26:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7373160295 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=J3i83kOg4TJzn2DZ7J59A2kYIYfhvgDnj/We5Akun2E=; b=K5qw6ez8/ZT95Kx5GnbWZzamp lxVpsq2o3HqGt3+hR6hg/2mW1uQ/RA4NgbvcuHQm0gGvYYS8yp02WQdNjA+ztYBN3RYzG9wnLhd7G I0ezTkoFpoUGWbOlnzhZVDBONPp+7geGLV57Yr4TeDNtuoa4560LyZ2ORF+2MCKsboTnWusYOs447 8ZwYeyTwQWvEbPC9Ulr0cecGa7Dntf+9h+5geNAPLR0SnHwJTte4bHSvik6w+gnqKD5q5BqFuOSXk rYYRMt5tEPxJSqTWRyFlWqjSZfNsN0YQ/HjqFFGaMTDgCuYWNqQWFqVNwG83mMXq6LlhmB3ftbB83 cEJomE32g==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1lGtmm-0001w1-JY; Tue, 02 Mar 2021 01:25:16 +0000 Received: from szxga05-in.huawei.com ([45.249.212.191]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1lGtmi-0001uE-KD for linux-arm-kernel@lists.infradead.org; Tue, 02 Mar 2021 01:25:14 +0000 Received: from DGGEMS411-HUB.china.huawei.com (unknown [172.30.72.59]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4DqKBv1gxMzjV6J; Tue, 2 Mar 2021 09:23:19 +0800 (CST) Received: from DESKTOP-E0KHRBE.china.huawei.com (10.67.103.82) by DGGEMS411-HUB.china.huawei.com (10.3.19.211) with Microsoft SMTP Server id 14.3.498.0; Tue, 2 Mar 2021 09:24:49 +0800 From: Shaobo Huang To: Subject: Re: [PATCH 4.4.y] arm: kprobes: Allow to handle reentered kprobe on single-stepping Date: Tue, 2 Mar 2021 09:24:49 +0800 Message-ID: <20210302012449.23428-1-huangshaobo6@huawei.com> X-Mailer: git-send-email 2.21.0.windows.1 In-Reply-To: References: MIME-Version: 1.0 X-Originating-IP: [10.67.103.82] X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210301_202513_512859_7B9780BC X-CRM114-Status: GOOD ( 17.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: tixy@linaro.org, young.liuyang@huawei.com, huangshaobo6@huawei.com, liucheng32@huawei.com, kepler.chenxin@huawei.com, xiaoqian9@huawei.com, linux-kernel@vger.kernel.org, zengweilin@huawei.com, mhiramat@kernel.org, linux@arm.linux.org.uk, chenzefeng2@huawei.com, nixiaoming@huawei.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On March 1, 2021 at 11:30 AM, Greg KH wrote: > On Mon, Feb 27, 2021 at 05:17:01PM +0800, huangshaobo wrote: > > From: Masami Hiramatsu > > > > commit f3fbd7ec62dec1528fb8044034e2885f2b257941 upstream > > > > This is arm port of commit 6a5022a56ac3 ("kprobes/x86: Allow to handle > > reentered kprobe on single-stepping") > > > > Since the FIQ handlers can interrupt in the single stepping (or > > preparing the single stepping, do_debug etc.), we should consider a > > kprobe is hit in the NMI handler. Even in that case, the kprobe is > > allowed to be reentered as same as the kprobes hit in kprobe handlers > > (KPROBE_HIT_ACTIVE or KPROBE_HIT_SSDONE). > > > > The real issue will happen when a kprobe hit while another reentered > > kprobe is processing (KPROBE_REENTER), because we already consumed a > > saved-area for the previous kprobe. > > > > Signed-off-by: Masami Hiramatsu > > Signed-off-by: Jon Medhurst > > Fixes: 24ba613c9d6c ("ARM kprobes: core code") > > Cc: stable@vger.kernel.org #v2.6.25~v4.11 > > Signed-off-by: huangshaobo > > --- > > arch/arm/probes/kprobes/core.c | 6 ++++++ > > 1 file changed, 6 insertions(+) > > What about the 4.9.y tree as well? > > thanks, > > greg k-h Yes, I tested on the 4.4.y tree. From the code analysis, the same problem exists in the 2.6.25 to 4.11 trees, and of course the 4.9.y tree is also included. thanks, ShaoBo Huang _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel