From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25053C4332E for ; Tue, 2 Mar 2021 16:39:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EEDE964F2B for ; Tue, 2 Mar 2021 16:39:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1839707AbhCBQh4 (ORCPT ); Tue, 2 Mar 2021 11:37:56 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:27512 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1351389AbhCBORX (ORCPT ); Tue, 2 Mar 2021 09:17:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1614694523; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rjOoUYxeG19DT5eJ2WuZnRhWzkvWoRa4HG3rYru+1nk=; b=TARHDRKxTcMj23Ok+2Ue2h34m0Or4hNvqr5wYCSrEogVGb6ZEih1dqQ1EZHQayfT86n6JE 7AzPiq9hhLfRYpCtyrtr69m1Ww6p6E7CBPmiXu9SqAFAS6rOgEW2LY/MI1Cj3+2HaLmVql xSwDW6xoum85NZDzoeoBWeEXQZ+cag8= Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-96-IqxeBnOwM9Cz7dCHYLynaQ-1; Tue, 02 Mar 2021 09:15:21 -0500 X-MC-Unique: IqxeBnOwM9Cz7dCHYLynaQ-1 Received: by mail-ed1-f70.google.com with SMTP id h5so598681edf.17 for ; Tue, 02 Mar 2021 06:15:21 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=rjOoUYxeG19DT5eJ2WuZnRhWzkvWoRa4HG3rYru+1nk=; b=jAfesyjiUlPRBm0YKC+I207QEW8hYr8whlPJAFsGv5rVHRB5xecgN0T94JavyBgkTo SBYYWfZCBYRASTli+xNWFeOy1ohy4SqxTBvl+bK4NsG2TR+2+C9vzqgVfJS1wE89fXzb sNbv2pZ/4DPk3ntyxSc9MnXl/bRnzWGVyNdPkPjZbMREJgSWfrVpNyx1/CltWeMIIWAS i/CV4kZBnNq9HlSCm5BZSJfm29okpUFGlt7njhppp83XuhNbFJJ9+yaJptLj6u/KyYEp zpE9OjCsbty1XV2dfzexHnQWUbX1eJkIuh+N2PUuG79DjaUSlDtsC45bdo8aQmikZXND UxNg== X-Gm-Message-State: AOAM532IXsH0xR802I35LJpBXUHCRmfmueX7i0nMEwyPaVhOD3gMahnC AfG8GfRe8P/QiL2rjBOomxQ2GheYJZ5a++KEdIdH8TX4XS/qylLkKN7YPdZPUUx4mus0KwRhppx ITWT8sb3vDb98tEeRbojcfOlE X-Received: by 2002:a17:906:f891:: with SMTP id lg17mr21120906ejb.69.1614694520479; Tue, 02 Mar 2021 06:15:20 -0800 (PST) X-Google-Smtp-Source: ABdhPJygE29SnX3D3HuuzIHfSkf8dbUaigd8KEMZKU0eY9r+w462+eOcRfQHeat9otGJbyl2OKaNyA== X-Received: by 2002:a17:906:f891:: with SMTP id lg17mr21120877ejb.69.1614694520244; Tue, 02 Mar 2021 06:15:20 -0800 (PST) Received: from steredhat (host-79-34-249-199.business.telecomitalia.it. [79.34.249.199]) by smtp.gmail.com with ESMTPSA id c17sm18013380edw.32.2021.03.02.06.15.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Mar 2021 06:15:19 -0800 (PST) Date: Tue, 2 Mar 2021 15:15:16 +0100 From: Stefano Garzarella To: Jason Wang Cc: virtualization@lists.linux-foundation.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, "Michael S. Tsirkin" Subject: Re: [RFC PATCH 01/10] vdpa: add get_config_size callback in vdpa_config_ops Message-ID: <20210302141516.oxsdb7jogrvu75yc@steredhat> References: <20210216094454.82106-1-sgarzare@redhat.com> <20210216094454.82106-2-sgarzare@redhat.com> <5de4cd5b-04cb-46ca-1717-075e5e8542fd@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <5de4cd5b-04cb-46ca-1717-075e5e8542fd@redhat.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 02, 2021 at 12:14:13PM +0800, Jason Wang wrote: > >On 2021/2/16 5:44 下午, Stefano Garzarella wrote: >>This new callback is used to get the size of the configuration space >>of vDPA devices. >> >>Signed-off-by: Stefano Garzarella >>--- >> include/linux/vdpa.h | 4 ++++ >> drivers/vdpa/ifcvf/ifcvf_main.c | 6 ++++++ >> drivers/vdpa/mlx5/net/mlx5_vnet.c | 6 ++++++ >> drivers/vdpa/vdpa_sim/vdpa_sim.c | 9 +++++++++ >> 4 files changed, 25 insertions(+) >> >>diff --git a/include/linux/vdpa.h b/include/linux/vdpa.h >>index 4ab5494503a8..fddf42b17573 100644 >>--- a/include/linux/vdpa.h >>+++ b/include/linux/vdpa.h >>@@ -150,6 +150,9 @@ struct vdpa_iova_range { >> * @set_status: Set the device status >> * @vdev: vdpa device >> * @status: virtio device status >>+ * @get_config_size: Get the size of the configuration space >>+ * @vdev: vdpa device >>+ * Returns size_t: configuration size > > >Rethink about this, how much we could gain by introducing a dedicated >ops here? E.g would it be simpler if we simply introduce a >max_config_size to vdpa device? Mainly because in this way we don't have to add new parameters to the vdpa_alloc_device() function. We do the same for example for 'get_device_id', 'get_vendor_id', 'get_vq_num_max'. All of these are usually static, but we have ops. I think because it's easier to extend. I don't know if it's worth adding a new structure for these static values at this point, like 'struct vdpa_config_params'. Thanks, Stefano From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5F99C433E0 for ; Tue, 2 Mar 2021 14:15:29 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DF6E564F0B for ; Tue, 2 Mar 2021 14:15:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DF6E564F0B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=virtualization-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 9861A43166; Tue, 2 Mar 2021 14:15:28 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id MDXufkLiyYDc; Tue, 2 Mar 2021 14:15:27 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp2.osuosl.org (Postfix) with ESMTP id 3D2D8430A2; Tue, 2 Mar 2021 14:15:27 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 10587C000A; Tue, 2 Mar 2021 14:15:27 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by lists.linuxfoundation.org (Postfix) with ESMTP id B1EADC0001 for ; Tue, 2 Mar 2021 14:15:25 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 972DB4F100 for ; Tue, 2 Mar 2021 14:15:25 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp4.osuosl.org (amavisd-new); dkim=pass (1024-bit key) header.d=redhat.com Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id K4t4Y2N0MtYx for ; Tue, 2 Mar 2021 14:15:24 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by smtp4.osuosl.org (Postfix) with ESMTPS id B6A274F0F3 for ; Tue, 2 Mar 2021 14:15:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1614694523; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rjOoUYxeG19DT5eJ2WuZnRhWzkvWoRa4HG3rYru+1nk=; b=TARHDRKxTcMj23Ok+2Ue2h34m0Or4hNvqr5wYCSrEogVGb6ZEih1dqQ1EZHQayfT86n6JE 7AzPiq9hhLfRYpCtyrtr69m1Ww6p6E7CBPmiXu9SqAFAS6rOgEW2LY/MI1Cj3+2HaLmVql xSwDW6xoum85NZDzoeoBWeEXQZ+cag8= Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-90-0faSmOTLOpioJv-ItkAA5A-1; Tue, 02 Mar 2021 09:15:21 -0500 X-MC-Unique: 0faSmOTLOpioJv-ItkAA5A-1 Received: by mail-ej1-f71.google.com with SMTP id n25so8538556ejd.5 for ; Tue, 02 Mar 2021 06:15:21 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=rjOoUYxeG19DT5eJ2WuZnRhWzkvWoRa4HG3rYru+1nk=; b=p/M0GlFXuPeQ3bn4hfK+IF4foKz0KVGbZ5gsRNP33HWR0Ze54zd48SFwKoFkrvinER Kn41LWluXfRjlBspkOQuV2HE8bx5k/ILWyZDyWJCq7IMoqRFQHjonCgxNtnuz+OlkaTL SEhuMNUXPMO3rC8NLdDuVp1SINPAhVAQjDNAiujq5w2/kUUVIMMDc7pY3O38gp0TxPaP 0EDlfN2O546K50cH5ixrlqSTn/EMhYzdg99L9V0lDmtR+Yc6MTspqHsvH1bMPAXezqTk faCejnu67FBGOEHQhjGdzIDI9p40hBCWxgsTnSufhJAndAqy4ZXFwZ8yXu88rmaA2/Pc 5GAA== X-Gm-Message-State: AOAM530pDoFHfcjiXK9Vk3o0jLWwlfI8roNDDj63NzCA4Up+RfvDA0mB S6TRzGFVsV3k5NweKpa+dMcJ7WZPgYFriWflsSD+QCjjg2hQIzcQI3KPc9itGR/QmGEz85enYKU tDJc9QlCpDddqblUisPQ4kPdfr2+ZxkUb1NDyvXYhVA== X-Received: by 2002:a17:906:f891:: with SMTP id lg17mr21120899ejb.69.1614694520442; Tue, 02 Mar 2021 06:15:20 -0800 (PST) X-Google-Smtp-Source: ABdhPJygE29SnX3D3HuuzIHfSkf8dbUaigd8KEMZKU0eY9r+w462+eOcRfQHeat9otGJbyl2OKaNyA== X-Received: by 2002:a17:906:f891:: with SMTP id lg17mr21120877ejb.69.1614694520244; Tue, 02 Mar 2021 06:15:20 -0800 (PST) Received: from steredhat (host-79-34-249-199.business.telecomitalia.it. [79.34.249.199]) by smtp.gmail.com with ESMTPSA id c17sm18013380edw.32.2021.03.02.06.15.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Mar 2021 06:15:19 -0800 (PST) Date: Tue, 2 Mar 2021 15:15:16 +0100 From: Stefano Garzarella To: Jason Wang Subject: Re: [RFC PATCH 01/10] vdpa: add get_config_size callback in vdpa_config_ops Message-ID: <20210302141516.oxsdb7jogrvu75yc@steredhat> References: <20210216094454.82106-1-sgarzare@redhat.com> <20210216094454.82106-2-sgarzare@redhat.com> <5de4cd5b-04cb-46ca-1717-075e5e8542fd@redhat.com> MIME-Version: 1.0 In-Reply-To: <5de4cd5b-04cb-46ca-1717-075e5e8542fd@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=sgarzare@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Cc: "Michael S. Tsirkin" , linux-kernel@vger.kernel.org, kvm@vger.kernel.org, virtualization@lists.linux-foundation.org X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" T24gVHVlLCBNYXIgMDIsIDIwMjEgYXQgMTI6MTQ6MTNQTSArMDgwMCwgSmFzb24gV2FuZyB3cm90 ZToKPgo+T24gMjAyMS8yLzE2IDU6NDQg5LiL5Y2ILCBTdGVmYW5vIEdhcnphcmVsbGEgd3JvdGU6 Cj4+VGhpcyBuZXcgY2FsbGJhY2sgaXMgdXNlZCB0byBnZXQgdGhlIHNpemUgb2YgdGhlIGNvbmZp Z3VyYXRpb24gc3BhY2UKPj5vZiB2RFBBIGRldmljZXMuCj4+Cj4+U2lnbmVkLW9mZi1ieTogU3Rl ZmFubyBHYXJ6YXJlbGxhIDxzZ2FyemFyZUByZWRoYXQuY29tPgo+Pi0tLQo+PiAgaW5jbHVkZS9s aW51eC92ZHBhLmggICAgICAgICAgICAgIHwgNCArKysrCj4+ICBkcml2ZXJzL3ZkcGEvaWZjdmYv aWZjdmZfbWFpbi5jICAgfCA2ICsrKysrKwo+PiAgZHJpdmVycy92ZHBhL21seDUvbmV0L21seDVf dm5ldC5jIHwgNiArKysrKysKPj4gIGRyaXZlcnMvdmRwYS92ZHBhX3NpbS92ZHBhX3NpbS5jICB8 IDkgKysrKysrKysrCj4+ICA0IGZpbGVzIGNoYW5nZWQsIDI1IGluc2VydGlvbnMoKykKPj4KPj5k aWZmIC0tZ2l0IGEvaW5jbHVkZS9saW51eC92ZHBhLmggYi9pbmNsdWRlL2xpbnV4L3ZkcGEuaAo+ PmluZGV4IDRhYjU0OTQ1MDNhOC4uZmRkZjQyYjE3NTczIDEwMDY0NAo+Pi0tLSBhL2luY2x1ZGUv bGludXgvdmRwYS5oCj4+KysrIGIvaW5jbHVkZS9saW51eC92ZHBhLmgKPj5AQCAtMTUwLDYgKzE1 MCw5IEBAIHN0cnVjdCB2ZHBhX2lvdmFfcmFuZ2Ugewo+PiAgICogQHNldF9zdGF0dXM6CQkJU2V0 IHRoZSBkZXZpY2Ugc3RhdHVzCj4+ICAgKgkJCQlAdmRldjogdmRwYSBkZXZpY2UKPj4gICAqCQkJ CUBzdGF0dXM6IHZpcnRpbyBkZXZpY2Ugc3RhdHVzCj4+KyAqIEBnZXRfY29uZmlnX3NpemU6CQlH ZXQgdGhlIHNpemUgb2YgdGhlIGNvbmZpZ3VyYXRpb24gc3BhY2UKPj4rICoJCQkJQHZkZXY6IHZk cGEgZGV2aWNlCj4+KyAqCQkJCVJldHVybnMgc2l6ZV90OiBjb25maWd1cmF0aW9uIHNpemUKPgo+ Cj5SZXRoaW5rIGFib3V0IHRoaXMsIGhvdyBtdWNoIHdlIGNvdWxkIGdhaW4gYnkgaW50cm9kdWNp bmcgYSBkZWRpY2F0ZWQgCj5vcHMgaGVyZT8gRS5nIHdvdWxkIGl0IGJlIHNpbXBsZXIgaWYgd2Ug c2ltcGx5IGludHJvZHVjZSBhIAo+bWF4X2NvbmZpZ19zaXplIHRvIHZkcGEgZGV2aWNlPwoKTWFp bmx5IGJlY2F1c2UgaW4gdGhpcyB3YXkgd2UgZG9uJ3QgaGF2ZSB0byBhZGQgbmV3IHBhcmFtZXRl cnMgdG8gdGhlIAp2ZHBhX2FsbG9jX2RldmljZSgpIGZ1bmN0aW9uLgoKV2UgZG8gdGhlIHNhbWUg Zm9yIGV4YW1wbGUgZm9yICdnZXRfZGV2aWNlX2lkJywgJ2dldF92ZW5kb3JfaWQnLCAKJ2dldF92 cV9udW1fbWF4Jy4gQWxsIG9mIHRoZXNlIGFyZSB1c3VhbGx5IHN0YXRpYywgYnV0IHdlIGhhdmUg b3BzLgpJIHRoaW5rIGJlY2F1c2UgaXQncyBlYXNpZXIgdG8gZXh0ZW5kLgoKSSBkb24ndCBrbm93 IGlmIGl0J3Mgd29ydGggYWRkaW5nIGEgbmV3IHN0cnVjdHVyZSBmb3IgdGhlc2Ugc3RhdGljIAp2 YWx1ZXMgYXQgdGhpcyBwb2ludCwgbGlrZSAnc3RydWN0IHZkcGFfY29uZmlnX3BhcmFtcycuCgpU aGFua3MsClN0ZWZhbm8KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fClZpcnR1YWxpemF0aW9uIG1haWxpbmcgbGlzdApWaXJ0dWFsaXphdGlvbkBsaXN0cy5s aW51eC1mb3VuZGF0aW9uLm9yZwpodHRwczovL2xpc3RzLmxpbnV4Zm91bmRhdGlvbi5vcmcvbWFp bG1hbi9saXN0aW5mby92aXJ0dWFsaXphdGlvbg==