From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88490C433E9 for ; Tue, 2 Mar 2021 20:31:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 489C264F21 for ; Tue, 2 Mar 2021 20:31:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1446162AbhCBU1i (ORCPT ); Tue, 2 Mar 2021 15:27:38 -0500 Received: from mail.kernel.org ([198.145.29.99]:54678 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349854AbhCBRhJ (ORCPT ); Tue, 2 Mar 2021 12:37:09 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id D8C7364F32; Tue, 2 Mar 2021 17:25:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1614705943; bh=wzxX6fB8ox2DNpZZ8LhGeG/FrKDK2EebFNNFbxqx7JM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=f1Pf6H+SbYeaOIFSpQ3JOAeTr6Dw84eJClIrlFPmfVDOpTWYy0yEAZTcnzidNGC2l pGyIdR0imIsR7LHvGcERf65jjYy4s1cqkFR4kreAaK1YD807JajOAkxZYhQdSeTnyz ShYqvpjXxT+IP5QBlY4aw2tPgLkXjEFMxfscxvC7Uc+VvDfsTc2cmnQPZ75I5l7ceZ 76EwYvMMbRScED51f1jE4G+Nmx5kO8uYzSv1xOz/NFwNlx29LnhicXpe9NaR/054Dp nNFA17Q9A3GqtYGb5vIBTk3+yojRm3iIqLchlTqApSnIBeIu5yghp8KzUNgflhe80o LQeQkz44p11Ew== Received: by earth.universe (Postfix, from userid 1000) id A4ABB3C0C96; Tue, 2 Mar 2021 18:25:40 +0100 (CET) Date: Tue, 2 Mar 2021 18:25:40 +0100 From: Sebastian Reichel To: Geert Uytterhoeven Cc: Magnus Damm , Saravana Kannan , Linux-Renesas , Linux ARM , Linux PM list , Linux Kernel Mailing List Subject: Re: [PATCH] soc: renesas: rmobile-sysc: Set OF_POPULATED and absorb reset handling Message-ID: <20210302172540.suq6m7cbulorp4at@earth.universe> References: <20210205133319.1921108-1-geert+renesas@glider.be> <20210302154406.n4d6euiruwan4pm5@earth.universe> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="4kn6yoahxuaazce6" Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --4kn6yoahxuaazce6 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Geert, On Tue, Mar 02, 2021 at 05:18:21PM +0100, Geert Uytterhoeven wrote: > Hi Sebastian, >=20 > On Tue, Mar 2, 2021 at 4:44 PM Sebastian Reichel wrote: > > On Fri, Feb 05, 2021 at 02:33:19PM +0100, Geert Uytterhoeven wrote: > > > Currently, there are two drivers binding to the R-Mobile System > > > Controller (SYSC): > > > - The rmobile-sysc driver registers PM domains from a core_initcall= (), > > > and does not use a platform driver, > > > - The rmobile-reset driver registers a reset handler, and does use a > > > platform driver. > > > > > > As fw_devlink only considers devices, it does not know that the > > > rmobile-sysc driver is ready. Hence if fw_devlink is enabled, probing > > > of on-chip devices that are part of the SYSC PM domain is deferred un= til > > > the optional rmobile-reset has been bound, which may happen too late > > > (for e.g. the system timer on SoCs lacking an ARM architectured or > > > global timer), or not at all, leading to complete system boot failure= s. > > > > > > Fix this by: > > > 1. Setting the OF_POPULATED flag for the SYSC device node after > > > successful initialization. > > > This will make of_link_to_phandle() ignore the SYSC device node = as > > > a dependency, making consumer devices probe again. > > > 2. Move reset handling from its own driver into the rmobile-sysc > > > driver. > > > This is needed because setting OF_POPULATED prevents the > > > rmobile-reset driver from binding against the same device. > > > > > > Signed-off-by: Geert Uytterhoeven > > > --- > > > To be queued in renesas-devel for v5.13. > > > > Acked-by: Sebastian Reichel >=20 > In the meantime, this has method been abandoned, and this patch was > superseded by "[PATCH v2] soc: renesas: rmobile-sysc: Mark fwnode when > PM domain is added" > https://lore.kernel.org/linux-arm-kernel/20210216123958.3180014-1-geert+r= enesas@glider.be/ Ah I remember seeing that, wondering why I am being CC'd and ignoring it :) Thanks for the pointer, -- Sebastian --4kn6yoahxuaazce6 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAmA+dQcACgkQ2O7X88g7 +pqc/w//W5vDfGs22TY9mzvMDs2b5bphnJBFMWzL7KQhHEsNXGmHGPI+nYg6N+GE gm5J0W0AwhVRmO1EY2Qcd+ls79eCnd2tVer7JWHwKXiGMpGq5qd8KjL8EilYluUG 62Rkc5mmECtq2qPqhqLblmdedJydoDbmENw3LlS6virxWx0MNSxe4ErF/BkNliqu sNJ1Qi2VS8e5rBAZDEXeg/ihZGaf1kWH41gnags1R+0QY1buu/MZz7I4Y1gzO9P9 oLCKxkcppNqfWwYgmehExokEd+46fYclpQD3xeoG9kez80dnb2oiTh305ZmCMedv XtjcDyNfC3X+QqA69lJtPttfzbzOGFY81bph3suQAwZaNCsdocLjSE9JrONMmJCB y5g8iKBJbe0tzqo7t2V8ZeZyjGg7OyyxKInuiuhhPl3lrTfqtdVAGM3JorUJBU+R FYeJ6fgicIuBwt3zXxTJAlzAG3pFm7GEkeB93+d1342Nex4Pbzgizf0EHrXJUl/7 b5O2O3/staEjsOKUMUDzNcvh1rkYKNSIQkMe/ohQB9JNOG8fSUXDDFPBFU0d9ap0 4Fd+/QKJbtXWITKvL36JmpAFsXDhmnax580sFAdpALzTLftenYOldFy1aT4fksCD Nt9Wz0RQQy6u0t/XfjRJQGS5lZeIkVqOnfD0/WznHZeA2W66v8M= =8pjj -----END PGP SIGNATURE----- --4kn6yoahxuaazce6-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B65BC433E0 for ; Wed, 3 Mar 2021 14:26:42 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 42DA064EDC for ; Wed, 3 Mar 2021 14:26:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 42DA064EDC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=vMY493dp7+zxS0cLPpTFDEaUX+c1MfVD3+go1VEwOr8=; b=fgmN9LK93UPgJHqRknMo2PtF2 LkY7x2lLLb663KpyaWZJ1C0qdaVIMlgDmtgA3QulWkgAfR+BTAZN+UMenPNF8CUXjnDKoEXjrZO7d mpfz/H/8NL/1wryTeR5LT6Xx3xQS3VuaIqsdqhhEGdi1MuwTffoJgIZUvWYUdBpWd1R7OT1lWpwPC joHb3hSeQeO4e6k1VtRj2VKTBfXcyOefHG+ix3KInYr5R7ZNmUAOmFCGt6KhGgWMS0hxii+H/uCo8 balXSwFxFFHtFhrrpE+KsySG4RAhvorbfN+EnYxg8ETEqNmprbS93VCDTqhTt51g9UV+fUXuoFmL9 JHylXoqSg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lHSP2-005711-Rk; Wed, 03 Mar 2021 14:23:22 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lHS7Z-0052om-KB for linux-arm-kernel@desiato.infradead.org; Wed, 03 Mar 2021 14:05:01 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=9QdtjIe0T2eitTCSuJ7LHSWk38X1zqrtAVxPMfKXz/0=; b=NkIpNLWbxNmMMKMfyIiRykqPMT bQ7eBzBf0VrNgEcB10OBGRJIBe+HKMxKeCy9CBixDMYhKftkUfNMJWLrPb4WeFTF5q5TkUr1I+BKp DTt/q5Z0FE5pM66NgwWlTnxS9v8zAYut4bPtpXk1egWWaSFJ+ND4O/hJ/kcZlMhbq6kZLzD6zxv5J Z0SXIjxm+rNpEepm2PVYFODCW+2+5Y6iBoFZIX3qSs8fs/kUUIWbaL0SdCCAF0VM2HXgmdw43DRYA sOEqNPF2lvE/5Sp/QsReDU6NPbuwi0PjhZroda1xdwirIBF+4ZrqUhgY4LW5LRNUu51RGtaydBkPD 2G5Q7rzw==; Received: from mail.kernel.org ([198.145.29.99]) by casper.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lH8mM-00HXld-2v for linux-arm-kernel@lists.infradead.org; Tue, 02 Mar 2021 17:25:55 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id D8C7364F32; Tue, 2 Mar 2021 17:25:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1614705943; bh=wzxX6fB8ox2DNpZZ8LhGeG/FrKDK2EebFNNFbxqx7JM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=f1Pf6H+SbYeaOIFSpQ3JOAeTr6Dw84eJClIrlFPmfVDOpTWYy0yEAZTcnzidNGC2l pGyIdR0imIsR7LHvGcERf65jjYy4s1cqkFR4kreAaK1YD807JajOAkxZYhQdSeTnyz ShYqvpjXxT+IP5QBlY4aw2tPgLkXjEFMxfscxvC7Uc+VvDfsTc2cmnQPZ75I5l7ceZ 76EwYvMMbRScED51f1jE4G+Nmx5kO8uYzSv1xOz/NFwNlx29LnhicXpe9NaR/054Dp nNFA17Q9A3GqtYGb5vIBTk3+yojRm3iIqLchlTqApSnIBeIu5yghp8KzUNgflhe80o LQeQkz44p11Ew== Received: by earth.universe (Postfix, from userid 1000) id A4ABB3C0C96; Tue, 2 Mar 2021 18:25:40 +0100 (CET) Date: Tue, 2 Mar 2021 18:25:40 +0100 From: Sebastian Reichel To: Geert Uytterhoeven Cc: Magnus Damm , Saravana Kannan , Linux-Renesas , Linux ARM , Linux PM list , Linux Kernel Mailing List Subject: Re: [PATCH] soc: renesas: rmobile-sysc: Set OF_POPULATED and absorb reset handling Message-ID: <20210302172540.suq6m7cbulorp4at@earth.universe> References: <20210205133319.1921108-1-geert+renesas@glider.be> <20210302154406.n4d6euiruwan4pm5@earth.universe> MIME-Version: 1.0 In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210302_172555_909671_F2967EB8 X-CRM114-Status: GOOD ( 25.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============8005903014864187474==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============8005903014864187474== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="4kn6yoahxuaazce6" Content-Disposition: inline --4kn6yoahxuaazce6 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Geert, On Tue, Mar 02, 2021 at 05:18:21PM +0100, Geert Uytterhoeven wrote: > Hi Sebastian, >=20 > On Tue, Mar 2, 2021 at 4:44 PM Sebastian Reichel wrote: > > On Fri, Feb 05, 2021 at 02:33:19PM +0100, Geert Uytterhoeven wrote: > > > Currently, there are two drivers binding to the R-Mobile System > > > Controller (SYSC): > > > - The rmobile-sysc driver registers PM domains from a core_initcall= (), > > > and does not use a platform driver, > > > - The rmobile-reset driver registers a reset handler, and does use a > > > platform driver. > > > > > > As fw_devlink only considers devices, it does not know that the > > > rmobile-sysc driver is ready. Hence if fw_devlink is enabled, probing > > > of on-chip devices that are part of the SYSC PM domain is deferred un= til > > > the optional rmobile-reset has been bound, which may happen too late > > > (for e.g. the system timer on SoCs lacking an ARM architectured or > > > global timer), or not at all, leading to complete system boot failure= s. > > > > > > Fix this by: > > > 1. Setting the OF_POPULATED flag for the SYSC device node after > > > successful initialization. > > > This will make of_link_to_phandle() ignore the SYSC device node = as > > > a dependency, making consumer devices probe again. > > > 2. Move reset handling from its own driver into the rmobile-sysc > > > driver. > > > This is needed because setting OF_POPULATED prevents the > > > rmobile-reset driver from binding against the same device. > > > > > > Signed-off-by: Geert Uytterhoeven > > > --- > > > To be queued in renesas-devel for v5.13. > > > > Acked-by: Sebastian Reichel >=20 > In the meantime, this has method been abandoned, and this patch was > superseded by "[PATCH v2] soc: renesas: rmobile-sysc: Mark fwnode when > PM domain is added" > https://lore.kernel.org/linux-arm-kernel/20210216123958.3180014-1-geert+r= enesas@glider.be/ Ah I remember seeing that, wondering why I am being CC'd and ignoring it :) Thanks for the pointer, -- Sebastian --4kn6yoahxuaazce6 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAmA+dQcACgkQ2O7X88g7 +pqc/w//W5vDfGs22TY9mzvMDs2b5bphnJBFMWzL7KQhHEsNXGmHGPI+nYg6N+GE gm5J0W0AwhVRmO1EY2Qcd+ls79eCnd2tVer7JWHwKXiGMpGq5qd8KjL8EilYluUG 62Rkc5mmECtq2qPqhqLblmdedJydoDbmENw3LlS6virxWx0MNSxe4ErF/BkNliqu sNJ1Qi2VS8e5rBAZDEXeg/ihZGaf1kWH41gnags1R+0QY1buu/MZz7I4Y1gzO9P9 oLCKxkcppNqfWwYgmehExokEd+46fYclpQD3xeoG9kez80dnb2oiTh305ZmCMedv XtjcDyNfC3X+QqA69lJtPttfzbzOGFY81bph3suQAwZaNCsdocLjSE9JrONMmJCB y5g8iKBJbe0tzqo7t2V8ZeZyjGg7OyyxKInuiuhhPl3lrTfqtdVAGM3JorUJBU+R FYeJ6fgicIuBwt3zXxTJAlzAG3pFm7GEkeB93+d1342Nex4Pbzgizf0EHrXJUl/7 b5O2O3/staEjsOKUMUDzNcvh1rkYKNSIQkMe/ohQB9JNOG8fSUXDDFPBFU0d9ap0 4Fd+/QKJbtXWITKvL36JmpAFsXDhmnax580sFAdpALzTLftenYOldFy1aT4fksCD Nt9Wz0RQQy6u0t/XfjRJQGS5lZeIkVqOnfD0/WznHZeA2W66v8M= =8pjj -----END PGP SIGNATURE----- --4kn6yoahxuaazce6-- --===============8005903014864187474== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============8005903014864187474==--