From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60548C4332B for ; Wed, 3 Mar 2021 07:23:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2777A64ECE for ; Wed, 3 Mar 2021 07:23:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1356129AbhCCHQG (ORCPT ); Wed, 3 Mar 2021 02:16:06 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:32049 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1351677AbhCBRiR (ORCPT ); Tue, 2 Mar 2021 12:38:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1614706609; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=jlIWIZYzHD1EhL2tb//404goYHuWYrN3TLsE76K2ILs=; b=X74xOsnTLCto7VVAKE5oIkZaCcJFHxt7akp0/5qrj0nV5cqTGwB2D3tRwZ9Yz1zmgA5L4T RyW1Qu0lbkDCbjdM5HvThAsxZ7MmyYtnGx6p/SmccpyQ5m9OQCUoX52oqUSYc7yfqoJDQ4 Lt4KAwH1XZ/3cyG9ovB8xkUDXXdfcAU= Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-379-EqTJIG6bMHyrS8gm0VWlJA-1; Tue, 02 Mar 2021 12:32:48 -0500 X-MC-Unique: EqTJIG6bMHyrS8gm0VWlJA-1 Received: by mail-qt1-f199.google.com with SMTP id r1so13708470qtu.9 for ; Tue, 02 Mar 2021 09:32:48 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=jlIWIZYzHD1EhL2tb//404goYHuWYrN3TLsE76K2ILs=; b=OwTpLhIV5GLtGm65fdUBmFKMx/IYIFUogVcsSkdLWL2TqjNaKm3m4C174eyhjekFpD m1yScGiTXCwZbcotga+pSVHoMLWjhfo0nmDhCI+e1Ssr89/JY9dtV6408AJTZSYy5XYL cAsnSMSGOx9uWvsVfHT1acFgIbOQVSfzaPkTNkUmOgFY/iTVHtyXGuMRYlTF0LPNHPeK pHQ/CY16Wxv2bnTba3KgOeH4SZq/VP9ywyyt52CmQWH9X+Op4DPBv/bqD3VeQyPJGn9B rZZgJ7/nMaCEtwZ/bZyE6rMOLvsCCq/sBgn6lEhRfg/jgIrF/hvTLbRS1UFoTgxRhq6V riRg== X-Gm-Message-State: AOAM530EWCUh1Ch1u2//ebo2OYbTySMYca8nbQA6T5aDDErWI6BOp7FX lkTfKl03ZPtNk8HxR/j0WBKytBxELi/NBHs143lOLROYFQtT7Ie03A59kLZvKwXL6fXsugCsUjV pBiS+taDy84Ro X-Received: by 2002:a05:620a:791:: with SMTP id 17mr2959826qka.170.1614706367958; Tue, 02 Mar 2021 09:32:47 -0800 (PST) X-Google-Smtp-Source: ABdhPJzv2aftS50+NpY5Rxj4Em9ob46tG7td8IRzqUVLX4ER2B33/0EUruRU/OkJS/3TfKMcJ1EG3Q== X-Received: by 2002:a05:620a:791:: with SMTP id 17mr2959801qka.170.1614706367704; Tue, 02 Mar 2021 09:32:47 -0800 (PST) Received: from xz-x1 (bras-vprn-toroon474qw-lp130-25-174-95-95-253.dsl.bell.ca. [174.95.95.253]) by smtp.gmail.com with ESMTPSA id o79sm5803300qka.116.2021.03.02.09.32.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Mar 2021 09:32:47 -0800 (PST) Date: Tue, 2 Mar 2021 12:32:43 -0500 From: Peter Xu To: David Hildenbrand Cc: qemu-devel@nongnu.org, "Michael S. Tsirkin" , Eduardo Habkost , "Dr. David Alan Gilbert" , Richard Henderson , Paolo Bonzini , Igor Mammedov , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Stefan Hajnoczi , Murilo Opsfelder Araujo , Greg Kurz , Liam Merwick , Christian Borntraeger , Cornelia Huck , Halil Pasic , Igor Kotrasinski , Juan Quintela , Stefan Weil , Thomas Huth , kvm@vger.kernel.org, qemu-s390x@nongnu.org Subject: Re: [PATCH v1 7/9] memory: introduce RAM_NORESERVE and wire it up in qemu_ram_mmap() Message-ID: <20210302173243.GM397383@xz-x1> References: <20210209134939.13083-1-david@redhat.com> <20210209134939.13083-8-david@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210209134939.13083-8-david@redhat.com> Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Tue, Feb 09, 2021 at 02:49:37PM +0100, David Hildenbrand wrote: > @@ -899,13 +899,17 @@ int kvm_s390_mem_op_pv(S390CPU *cpu, uint64_t offset, void *hostbuf, > * to grow. We also have to use MAP parameters that avoid > * read-only mapping of guest pages. > */ > -static void *legacy_s390_alloc(size_t size, uint64_t *align, bool shared) > +static void *legacy_s390_alloc(size_t size, uint64_t *align, bool shared, > + bool noreserve) > { > static void *mem; > > if (mem) { > /* we only support one allocation, which is enough for initial ram */ > return NULL; > + } else if (noreserve) { > + error_report("Skipping reservation of swap space is not supported."); > + return NULL Semicolon missing. > } > > mem = mmap((void *) 0x800000000ULL, size, > diff --git a/util/mmap-alloc.c b/util/mmap-alloc.c > index b50dc86a3c..bb99843106 100644 > --- a/util/mmap-alloc.c > +++ b/util/mmap-alloc.c > @@ -20,6 +20,7 @@ > #include "qemu/osdep.h" > #include "qemu/mmap-alloc.h" > #include "qemu/host-utils.h" > +#include "qemu/error-report.h" > > #define HUGETLBFS_MAGIC 0x958458f6 > > @@ -174,12 +175,18 @@ void *qemu_ram_mmap(int fd, > size_t align, > bool readonly, > bool shared, > - bool is_pmem) > + bool is_pmem, > + bool noreserve) Maybe at some point we should use flags too here to cover all bools. Thanks, -- Peter Xu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF40EC433DB for ; Tue, 2 Mar 2021 17:33:37 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 03A4864F23 for ; Tue, 2 Mar 2021 17:33:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 03A4864F23 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:60172 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lH8ts-0007kM-1T for qemu-devel@archiver.kernel.org; Tue, 02 Mar 2021 12:33:36 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:52932) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lH8tC-0007HJ-9f for qemu-devel@nongnu.org; Tue, 02 Mar 2021 12:32:54 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:28139) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1lH8tA-0003UO-0H for qemu-devel@nongnu.org; Tue, 02 Mar 2021 12:32:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1614706371; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=jlIWIZYzHD1EhL2tb//404goYHuWYrN3TLsE76K2ILs=; b=KrxPefr/MwQwK+vPPUiHrAyOK2k6JARAabN/RTMMPOnbYrjK7y6Jz6zfDwyFeKUtO00XNS vM6nU+xpo8ghrs38mHs3TsriSK8EljUBm41uBfFpFND7fMJ1u0Xf+Wf1KKcVsAojJdK2RQ uZOdhHvXKq4SJZ6bwDteMU/X35va3AU= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-501-bp553fcANYy_ma8nC9X_ag-1; Tue, 02 Mar 2021 12:32:48 -0500 X-MC-Unique: bp553fcANYy_ma8nC9X_ag-1 Received: by mail-qv1-f70.google.com with SMTP id n1so15403015qvi.4 for ; Tue, 02 Mar 2021 09:32:48 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=jlIWIZYzHD1EhL2tb//404goYHuWYrN3TLsE76K2ILs=; b=k3V49xMEF/KXg+D0wjkwLX3Ospvvw98ga/E+zib6Qx/Qxr16mE2qmK2r/aU//JTWUI XRohqAarkMcyl2mZrQUInUq8UEPVakVN9k7266QyGniKQomq5DLVs5qRlQ8nI6ns2OXu 9d4X+zktM58td7nzagMLJHQHCg2Ho4nz0Wv5GFfRFNe3EQY2KDYeb9E9KPOh7cExQpaW vQvkdy2k5TwpYcWRlo6Dhi2qMRhrApril0JJ5kxbCYgF0nrHWj0LV1rgZf4l8SKIzVUN OBVhW8D2+zgP/NZTVEcjGSGFJ5GN49vi/gz/7hY/qh0OmbxoiU9iIPhc3EXYQ+QlVKpK sH5Q== X-Gm-Message-State: AOAM530qVjZzHXGFbdIVQw1Y54crypMijX8kH3kywvuQzRPjgaCzz/fC KYBN0ahj3VllMBM8p1SsiXwvU7N7EiJXWBUbntJgfhVoBZlf+MehPJWmm/iyt6qgT/yZB4AbI9t PcBcb07T11kjiOsk= X-Received: by 2002:a05:620a:791:: with SMTP id 17mr2959840qka.170.1614706367960; Tue, 02 Mar 2021 09:32:47 -0800 (PST) X-Google-Smtp-Source: ABdhPJzv2aftS50+NpY5Rxj4Em9ob46tG7td8IRzqUVLX4ER2B33/0EUruRU/OkJS/3TfKMcJ1EG3Q== X-Received: by 2002:a05:620a:791:: with SMTP id 17mr2959801qka.170.1614706367704; Tue, 02 Mar 2021 09:32:47 -0800 (PST) Received: from xz-x1 (bras-vprn-toroon474qw-lp130-25-174-95-95-253.dsl.bell.ca. [174.95.95.253]) by smtp.gmail.com with ESMTPSA id o79sm5803300qka.116.2021.03.02.09.32.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Mar 2021 09:32:47 -0800 (PST) Date: Tue, 2 Mar 2021 12:32:43 -0500 From: Peter Xu To: David Hildenbrand Subject: Re: [PATCH v1 7/9] memory: introduce RAM_NORESERVE and wire it up in qemu_ram_mmap() Message-ID: <20210302173243.GM397383@xz-x1> References: <20210209134939.13083-1-david@redhat.com> <20210209134939.13083-8-david@redhat.com> MIME-Version: 1.0 In-Reply-To: <20210209134939.13083-8-david@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=peterx@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Received-SPF: pass client-ip=216.205.24.124; envelope-from=peterx@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Huth , Cornelia Huck , Eduardo Habkost , kvm@vger.kernel.org, "Michael S. Tsirkin" , qemu-s390x@nongnu.org, Stefan Weil , Murilo Opsfelder Araujo , Richard Henderson , "Dr. David Alan Gilbert" , Juan Quintela , qemu-devel@nongnu.org, Halil Pasic , Christian Borntraeger , Greg Kurz , Stefan Hajnoczi , Igor Mammedov , Paolo Bonzini , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Igor Kotrasinski Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue, Feb 09, 2021 at 02:49:37PM +0100, David Hildenbrand wrote: > @@ -899,13 +899,17 @@ int kvm_s390_mem_op_pv(S390CPU *cpu, uint64_t offset, void *hostbuf, > * to grow. We also have to use MAP parameters that avoid > * read-only mapping of guest pages. > */ > -static void *legacy_s390_alloc(size_t size, uint64_t *align, bool shared) > +static void *legacy_s390_alloc(size_t size, uint64_t *align, bool shared, > + bool noreserve) > { > static void *mem; > > if (mem) { > /* we only support one allocation, which is enough for initial ram */ > return NULL; > + } else if (noreserve) { > + error_report("Skipping reservation of swap space is not supported."); > + return NULL Semicolon missing. > } > > mem = mmap((void *) 0x800000000ULL, size, > diff --git a/util/mmap-alloc.c b/util/mmap-alloc.c > index b50dc86a3c..bb99843106 100644 > --- a/util/mmap-alloc.c > +++ b/util/mmap-alloc.c > @@ -20,6 +20,7 @@ > #include "qemu/osdep.h" > #include "qemu/mmap-alloc.h" > #include "qemu/host-utils.h" > +#include "qemu/error-report.h" > > #define HUGETLBFS_MAGIC 0x958458f6 > > @@ -174,12 +175,18 @@ void *qemu_ram_mmap(int fd, > size_t align, > bool readonly, > bool shared, > - bool is_pmem) > + bool is_pmem, > + bool noreserve) Maybe at some point we should use flags too here to cover all bools. Thanks, -- Peter Xu