All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Nguyen <anthony.l.nguyen@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH S55 09/14] ice: remove unnecessary duplicated AQ command flag setting
Date: Tue,  2 Mar 2021 10:12:08 -0800	[thread overview]
Message-ID: <20210302181213.51718-9-anthony.l.nguyen@intel.com> (raw)
In-Reply-To: <20210302181213.51718-1-anthony.l.nguyen@intel.com>

From: Bruce Allan <bruce.w.allan@intel.com>

Commit a012dca9f7a2 ("ice: add ethtool -m support for reading i2c eeprom
modules") unnecessarily added the ICE_AQ_FLAG_BUF flag to the descriptor
when sending the indirect Read/Write SFF EEPROM AQ command. The flag is
already added later in the code flow for all indirect AQ commands, i.e.
commands that provide an additional data buffer.

Signed-off-by: Bruce Allan <bruce.w.allan@intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
---
 drivers/net/ethernet/intel/ice/ice_common.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/intel/ice/ice_common.c b/drivers/net/ethernet/intel/ice/ice_common.c
index a20edf1538a0..105504c8cfe7 100644
--- a/drivers/net/ethernet/intel/ice/ice_common.c
+++ b/drivers/net/ethernet/intel/ice/ice_common.c
@@ -3186,7 +3186,7 @@ ice_aq_sff_eeprom(struct ice_hw *hw, u16 lport, u8 bus_addr,
 
 	ice_fill_dflt_direct_cmd_desc(&desc, ice_aqc_opc_sff_eeprom);
 	cmd = &desc.params.read_write_sff_param;
-	desc.flags = cpu_to_le16(ICE_AQ_FLAG_RD | ICE_AQ_FLAG_BUF);
+	desc.flags = cpu_to_le16(ICE_AQ_FLAG_RD);
 	cmd->lport_num = (u8)(lport & 0xff);
 	cmd->lport_num_valid = (u8)((lport >> 8) & 0x01);
 	cmd->i2c_bus_addr = cpu_to_le16(((bus_addr >> 1) &
-- 
2.20.1


  parent reply	other threads:[~2021-03-02 18:12 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-02 18:12 [Intel-wired-lan] [PATCH S55 01/14] ice: warn about potentially malicious VFs Tony Nguyen
2021-03-02 18:12 ` [Intel-wired-lan] [PATCH S55 02/14] ice: Allow ignoring opcodes on specific VF Tony Nguyen
2021-04-21 18:48   ` Jankowski, Konrad0
2021-03-02 18:12 ` [Intel-wired-lan] [PATCH S55 03/14] ice: Add Support for XPS Tony Nguyen
2021-03-12 22:13   ` Brelinski, TonyX
2021-03-02 18:12 ` [Intel-wired-lan] [PATCH S55 04/14] ice: Delay netdev registration Tony Nguyen
2021-03-10 23:44   ` Brelinski, TonyX
2021-03-02 18:12 ` [Intel-wired-lan] [PATCH S55 05/14] ice: Update to use package info from ice segment Tony Nguyen
2021-03-11  0:02   ` Brelinski, TonyX
2021-03-02 18:12 ` [Intel-wired-lan] [PATCH S55 06/14] ice: handle increasing Tx or Rx ring sizes Tony Nguyen
2021-03-11  0:27   ` Brelinski, TonyX
2021-03-02 18:12 ` [Intel-wired-lan] [PATCH S55 07/14] ice: use kernel definitions for IANA protocol ports and ether-types Tony Nguyen
2021-03-19 22:43   ` Brelinski, TonyX
2021-03-02 18:12 ` [Intel-wired-lan] [PATCH S55 08/14] ice: change link misconfiguration message Tony Nguyen
2021-03-11  0:31   ` Brelinski, TonyX
2021-03-02 18:12 ` Tony Nguyen [this message]
2021-03-11  0:33   ` [Intel-wired-lan] [PATCH S55 09/14] ice: remove unnecessary duplicated AQ command flag setting Brelinski, TonyX
2021-03-02 18:12 ` [Intel-wired-lan] [PATCH S55 10/14] ice: Check for bail out condition early Tony Nguyen
2021-03-11 22:52   ` Brelinski, TonyX
2021-03-02 18:12 ` [Intel-wired-lan] [PATCH S55 11/14] ice: correct memory allocation call Tony Nguyen
2021-03-11 22:53   ` Brelinski, TonyX
2021-03-02 18:12 ` [Intel-wired-lan] [PATCH S55 12/14] ice: rename ptype bitmap Tony Nguyen
2021-03-11 22:55   ` Brelinski, TonyX
2021-03-02 18:12 ` [Intel-wired-lan] [PATCH S55 13/14] ice: Advertise virtchnl UDP segmentation offload capability Tony Nguyen
2021-04-16 12:27   ` Jankowski, Konrad0
2021-03-02 18:12 ` [Intel-wired-lan] [PATCH S55 14/14] iavf: add support for UDP Segmentation Offload Tony Nguyen
2021-04-16 12:28   ` Jankowski, Konrad0
2021-04-21 18:49 ` [Intel-wired-lan] [PATCH S55 01/14] ice: warn about potentially malicious VFs Jankowski, Konrad0

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210302181213.51718-9-anthony.l.nguyen@intel.com \
    --to=anthony.l.nguyen@intel.com \
    --cc=intel-wired-lan@osuosl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.