All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dario Binacchi <dariobin@libero.it>
To: linux-kernel@vger.kernel.org
Cc: Alexander Stein <alexander.stein@systec-electronic.com>,
	Federico Vaga <federico.vaga@gmail.com>,
	Dario Binacchi <dariobin@libero.it>,
	"David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	Marc Kleine-Budde <mkl@pengutronix.de>,
	Oliver Hartkopp <socketcan@hartkopp.net>,
	Vincent Mailhol <mailhol.vincent@wanadoo.fr>,
	Wolfgang Grandegger <wg@grandegger.com>,
	YueHaibing <yuehaibing@huawei.com>,
	Zhang Qilong <zhangqilong3@huawei.com>,
	linux-can@vger.kernel.org, netdev@vger.kernel.org
Subject: [PATCH v4 3/6] can: c_can: add a comment about IF_RX interface's use
Date: Tue,  2 Mar 2021 22:54:32 +0100	[thread overview]
Message-ID: <20210302215435.18286-4-dariobin@libero.it> (raw)
In-Reply-To: <20210302215435.18286-1-dariobin@libero.it>

After reading the commit 640916db2bf7 ("can: c_can: Make it SMP safe")
it may sound strange to see the IF_RX interface used by the
can_inval_tx_object function. A comment was added to avoid any
misunderstanding.

Signed-off-by: Dario Binacchi <dariobin@libero.it>

---

Changes in v4:
- Restore IF_RX interface.
- Add a comment to clarify why IF_RX interface is used instead of IF_TX.

 drivers/net/can/c_can/c_can.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/net/can/c_can/c_can.c b/drivers/net/can/c_can/c_can.c
index dbcc1c1c92d6..6c6d0d0ff7b8 100644
--- a/drivers/net/can/c_can/c_can.c
+++ b/drivers/net/can/c_can/c_can.c
@@ -732,6 +732,12 @@ static void c_can_do_tx(struct net_device *dev)
 		idx--;
 		pend &= ~(1 << idx);
 		obj = idx + C_CAN_MSG_OBJ_TX_FIRST;
+
+		/*
+		 * We use IF_RX interface instead of IF_TX because we are
+		 * called from c_can_poll(), which runs inside NAPI. We are
+		 * not trasmitting.
+		 */
 		c_can_inval_tx_object(dev, IF_RX, obj);
 		can_get_echo_skb(dev, idx, NULL);
 		bytes += priv->dlc[idx];
-- 
2.17.1


  parent reply	other threads:[~2021-03-03  0:12 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-02 21:54 [PATCH v4 0/6] can: c_can: add support to 64 message objects Dario Binacchi
2021-03-02 21:54 ` [PATCH v4 1/6] can: c_can: remove unused code Dario Binacchi
2021-03-02 21:54 ` [PATCH v4 2/6] can: c_can: fix indentation Dario Binacchi
2021-03-02 21:54 ` Dario Binacchi [this message]
2021-03-02 21:54 ` [PATCH v4 4/6] can: c_can: use 32-bit write to set arbitration register Dario Binacchi
2021-03-02 21:54 ` [PATCH v4 5/6] can: c_can: prepare to up the message objects number Dario Binacchi
2021-03-04 15:26   ` Marc Kleine-Budde
2021-03-05 11:14     ` Dario Binacchi
2021-03-02 21:54 ` [PATCH v4 6/6] can: c_can: add support to 64 message objects Dario Binacchi
2021-03-04 14:33 ` [PATCH v4 0/6] " Marc Kleine-Budde

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210302215435.18286-4-dariobin@libero.it \
    --to=dariobin@libero.it \
    --cc=alexander.stein@systec-electronic.com \
    --cc=davem@davemloft.net \
    --cc=federico.vaga@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-can@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mailhol.vincent@wanadoo.fr \
    --cc=mkl@pengutronix.de \
    --cc=netdev@vger.kernel.org \
    --cc=socketcan@hartkopp.net \
    --cc=wg@grandegger.com \
    --cc=yuehaibing@huawei.com \
    --cc=zhangqilong3@huawei.com \
    --subject='Re: [PATCH v4 3/6] can: c_can: add a comment about IF_RX interface'\''s use' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.