* [PATCH] crypto: mediatek - remove obsolete documentation
@ 2021-03-03 9:39 ` Vic Wu
0 siblings, 0 replies; 12+ messages in thread
From: Vic Wu @ 2021-03-03 9:39 UTC (permalink / raw)
To: Matthias Brugger, Rob Herring
Cc: Ryder Lee, devicetree, linux-arm-kernel, linux-mediatek,
linux-kernel, Vic Wu
The crypto mediatek driver has been replaced by the inside-secure driver now.
Remove DT bindings documentation and update crypto engine nodes to the mt7623.dtsi files.
Signed-off-by: Vic Wu <vic.wu@mediatek.com>
Acked-by: Ryder Lee <ryder.lee@mediatek.com>
---
Documentation/devicetree/bindings/crypto/mediatek-crypto.txt | 25 -------------------
arch/arm/boot/dts/mt7623.dtsi | 8 +++---
2 files changed, 3 insertions(+), 30 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/crypto/mediatek-crypto.txt
diff --git a/Documentation/devicetree/bindings/crypto/mediatek-crypto.txt b/Documentation/devicetree/bindings/crypto/mediatek-crypto.txt
deleted file mode 100644
index 450da3661cad..000000000000
--- a/Documentation/devicetree/bindings/crypto/mediatek-crypto.txt
+++ /dev/null
@@ -1,25 +0,0 @@
-MediaTek cryptographic accelerators
-
-Required properties:
-- compatible: Should be "mediatek,eip97-crypto"
-- reg: Address and length of the register set for the device
-- interrupts: Should contain the five crypto engines interrupts in numeric
- order. These are global system and four descriptor rings.
-- clocks: the clock used by the core
-- clock-names: Must contain "cryp".
-- power-domains: Must contain a reference to the PM domain.
-
-
-Example:
- crypto: crypto@1b240000 {
- compatible = "mediatek,eip97-crypto";
- reg = <0 0x1b240000 0 0x20000>;
- interrupts = <GIC_SPI 82 IRQ_TYPE_LEVEL_LOW>,
- <GIC_SPI 83 IRQ_TYPE_LEVEL_LOW>,
- <GIC_SPI 84 IRQ_TYPE_LEVEL_LOW>,
- <GIC_SPI 91 IRQ_TYPE_LEVEL_LOW>,
- <GIC_SPI 97 IRQ_TYPE_LEVEL_LOW>;
- clocks = <ðsys CLK_ETHSYS_CRYPTO>;
- clock-names = "cryp";
- power-domains = <&scpsys MT2701_POWER_DOMAIN_ETH>;
- };
diff --git a/arch/arm/boot/dts/mt7623.dtsi b/arch/arm/boot/dts/mt7623.dtsi
index aea6809500d7..25e3f3b04123 100644
--- a/arch/arm/boot/dts/mt7623.dtsi
+++ b/arch/arm/boot/dts/mt7623.dtsi
@@ -949,16 +949,14 @@
};
crypto: crypto@1b240000 {
- compatible = "mediatek,eip97-crypto";
+ compatible = "inside-secure,safexcel-eip97";
reg = <0 0x1b240000 0 0x20000>;
interrupts = <GIC_SPI 82 IRQ_TYPE_LEVEL_LOW>,
<GIC_SPI 83 IRQ_TYPE_LEVEL_LOW>,
<GIC_SPI 84 IRQ_TYPE_LEVEL_LOW>,
- <GIC_SPI 91 IRQ_TYPE_LEVEL_LOW>,
- <GIC_SPI 97 IRQ_TYPE_LEVEL_LOW>;
+ <GIC_SPI 91 IRQ_TYPE_LEVEL_LOW>;
+ interrupt-names = "ring0", "ring1", "ring2", "ring3";
clocks = <ðsys CLK_ETHSYS_CRYPTO>;
- clock-names = "cryp";
- power-domains = <&scpsys MT2701_POWER_DOMAIN_ETH>;
status = "disabled";
};
--
2.18.0
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH] crypto: mediatek - remove obsolete documentation
@ 2021-03-03 9:39 ` Vic Wu
0 siblings, 0 replies; 12+ messages in thread
From: Vic Wu @ 2021-03-03 9:39 UTC (permalink / raw)
To: Matthias Brugger, Rob Herring
Cc: Ryder Lee, devicetree, linux-arm-kernel, linux-mediatek,
linux-kernel, Vic Wu
The crypto mediatek driver has been replaced by the inside-secure driver now.
Remove DT bindings documentation and update crypto engine nodes to the mt7623.dtsi files.
Signed-off-by: Vic Wu <vic.wu@mediatek.com>
Acked-by: Ryder Lee <ryder.lee@mediatek.com>
---
Documentation/devicetree/bindings/crypto/mediatek-crypto.txt | 25 -------------------
arch/arm/boot/dts/mt7623.dtsi | 8 +++---
2 files changed, 3 insertions(+), 30 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/crypto/mediatek-crypto.txt
diff --git a/Documentation/devicetree/bindings/crypto/mediatek-crypto.txt b/Documentation/devicetree/bindings/crypto/mediatek-crypto.txt
deleted file mode 100644
index 450da3661cad..000000000000
--- a/Documentation/devicetree/bindings/crypto/mediatek-crypto.txt
+++ /dev/null
@@ -1,25 +0,0 @@
-MediaTek cryptographic accelerators
-
-Required properties:
-- compatible: Should be "mediatek,eip97-crypto"
-- reg: Address and length of the register set for the device
-- interrupts: Should contain the five crypto engines interrupts in numeric
- order. These are global system and four descriptor rings.
-- clocks: the clock used by the core
-- clock-names: Must contain "cryp".
-- power-domains: Must contain a reference to the PM domain.
-
-
-Example:
- crypto: crypto@1b240000 {
- compatible = "mediatek,eip97-crypto";
- reg = <0 0x1b240000 0 0x20000>;
- interrupts = <GIC_SPI 82 IRQ_TYPE_LEVEL_LOW>,
- <GIC_SPI 83 IRQ_TYPE_LEVEL_LOW>,
- <GIC_SPI 84 IRQ_TYPE_LEVEL_LOW>,
- <GIC_SPI 91 IRQ_TYPE_LEVEL_LOW>,
- <GIC_SPI 97 IRQ_TYPE_LEVEL_LOW>;
- clocks = <ðsys CLK_ETHSYS_CRYPTO>;
- clock-names = "cryp";
- power-domains = <&scpsys MT2701_POWER_DOMAIN_ETH>;
- };
diff --git a/arch/arm/boot/dts/mt7623.dtsi b/arch/arm/boot/dts/mt7623.dtsi
index aea6809500d7..25e3f3b04123 100644
--- a/arch/arm/boot/dts/mt7623.dtsi
+++ b/arch/arm/boot/dts/mt7623.dtsi
@@ -949,16 +949,14 @@
};
crypto: crypto@1b240000 {
- compatible = "mediatek,eip97-crypto";
+ compatible = "inside-secure,safexcel-eip97";
reg = <0 0x1b240000 0 0x20000>;
interrupts = <GIC_SPI 82 IRQ_TYPE_LEVEL_LOW>,
<GIC_SPI 83 IRQ_TYPE_LEVEL_LOW>,
<GIC_SPI 84 IRQ_TYPE_LEVEL_LOW>,
- <GIC_SPI 91 IRQ_TYPE_LEVEL_LOW>,
- <GIC_SPI 97 IRQ_TYPE_LEVEL_LOW>;
+ <GIC_SPI 91 IRQ_TYPE_LEVEL_LOW>;
+ interrupt-names = "ring0", "ring1", "ring2", "ring3";
clocks = <ðsys CLK_ETHSYS_CRYPTO>;
- clock-names = "cryp";
- power-domains = <&scpsys MT2701_POWER_DOMAIN_ETH>;
status = "disabled";
};
--
2.18.0
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH] crypto: mediatek - remove obsolete documentation
@ 2021-03-03 9:39 ` Vic Wu
0 siblings, 0 replies; 12+ messages in thread
From: Vic Wu @ 2021-03-03 9:39 UTC (permalink / raw)
To: Matthias Brugger, Rob Herring
Cc: Ryder Lee, devicetree, linux-arm-kernel, linux-mediatek,
linux-kernel, Vic Wu
The crypto mediatek driver has been replaced by the inside-secure driver now.
Remove DT bindings documentation and update crypto engine nodes to the mt7623.dtsi files.
Signed-off-by: Vic Wu <vic.wu@mediatek.com>
Acked-by: Ryder Lee <ryder.lee@mediatek.com>
---
Documentation/devicetree/bindings/crypto/mediatek-crypto.txt | 25 -------------------
arch/arm/boot/dts/mt7623.dtsi | 8 +++---
2 files changed, 3 insertions(+), 30 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/crypto/mediatek-crypto.txt
diff --git a/Documentation/devicetree/bindings/crypto/mediatek-crypto.txt b/Documentation/devicetree/bindings/crypto/mediatek-crypto.txt
deleted file mode 100644
index 450da3661cad..000000000000
--- a/Documentation/devicetree/bindings/crypto/mediatek-crypto.txt
+++ /dev/null
@@ -1,25 +0,0 @@
-MediaTek cryptographic accelerators
-
-Required properties:
-- compatible: Should be "mediatek,eip97-crypto"
-- reg: Address and length of the register set for the device
-- interrupts: Should contain the five crypto engines interrupts in numeric
- order. These are global system and four descriptor rings.
-- clocks: the clock used by the core
-- clock-names: Must contain "cryp".
-- power-domains: Must contain a reference to the PM domain.
-
-
-Example:
- crypto: crypto@1b240000 {
- compatible = "mediatek,eip97-crypto";
- reg = <0 0x1b240000 0 0x20000>;
- interrupts = <GIC_SPI 82 IRQ_TYPE_LEVEL_LOW>,
- <GIC_SPI 83 IRQ_TYPE_LEVEL_LOW>,
- <GIC_SPI 84 IRQ_TYPE_LEVEL_LOW>,
- <GIC_SPI 91 IRQ_TYPE_LEVEL_LOW>,
- <GIC_SPI 97 IRQ_TYPE_LEVEL_LOW>;
- clocks = <ðsys CLK_ETHSYS_CRYPTO>;
- clock-names = "cryp";
- power-domains = <&scpsys MT2701_POWER_DOMAIN_ETH>;
- };
diff --git a/arch/arm/boot/dts/mt7623.dtsi b/arch/arm/boot/dts/mt7623.dtsi
index aea6809500d7..25e3f3b04123 100644
--- a/arch/arm/boot/dts/mt7623.dtsi
+++ b/arch/arm/boot/dts/mt7623.dtsi
@@ -949,16 +949,14 @@
};
crypto: crypto@1b240000 {
- compatible = "mediatek,eip97-crypto";
+ compatible = "inside-secure,safexcel-eip97";
reg = <0 0x1b240000 0 0x20000>;
interrupts = <GIC_SPI 82 IRQ_TYPE_LEVEL_LOW>,
<GIC_SPI 83 IRQ_TYPE_LEVEL_LOW>,
<GIC_SPI 84 IRQ_TYPE_LEVEL_LOW>,
- <GIC_SPI 91 IRQ_TYPE_LEVEL_LOW>,
- <GIC_SPI 97 IRQ_TYPE_LEVEL_LOW>;
+ <GIC_SPI 91 IRQ_TYPE_LEVEL_LOW>;
+ interrupt-names = "ring0", "ring1", "ring2", "ring3";
clocks = <ðsys CLK_ETHSYS_CRYPTO>;
- clock-names = "cryp";
- power-domains = <&scpsys MT2701_POWER_DOMAIN_ETH>;
status = "disabled";
};
--
2.18.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH] crypto: mediatek - remove obsolete documentation
2021-03-03 9:39 ` Vic Wu
(?)
@ 2021-03-08 20:07 ` Rob Herring
-1 siblings, 0 replies; 12+ messages in thread
From: Rob Herring @ 2021-03-08 20:07 UTC (permalink / raw)
To: Vic Wu
Cc: Matthias Brugger, Ryder Lee, devicetree, linux-arm-kernel,
linux-mediatek, linux-kernel
On Wed, Mar 03, 2021 at 05:39:50PM +0800, Vic Wu wrote:
> The crypto mediatek driver has been replaced by the inside-secure driver now.
> Remove DT bindings documentation and update crypto engine nodes to the mt7623.dtsi files.
Wrap lines.
>
> Signed-off-by: Vic Wu <vic.wu@mediatek.com>
> Acked-by: Ryder Lee <ryder.lee@mediatek.com>
> ---
> Documentation/devicetree/bindings/crypto/mediatek-crypto.txt | 25 -------------------
> arch/arm/boot/dts/mt7623.dtsi | 8 +++---
> 2 files changed, 3 insertions(+), 30 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/crypto/mediatek-crypto.txt
>
> diff --git a/Documentation/devicetree/bindings/crypto/mediatek-crypto.txt b/Documentation/devicetree/bindings/crypto/mediatek-crypto.txt
> deleted file mode 100644
> index 450da3661cad..000000000000
> --- a/Documentation/devicetree/bindings/crypto/mediatek-crypto.txt
> +++ /dev/null
> @@ -1,25 +0,0 @@
> -MediaTek cryptographic accelerators
> -
> -Required properties:
> -- compatible: Should be "mediatek,eip97-crypto"
> -- reg: Address and length of the register set for the device
> -- interrupts: Should contain the five crypto engines interrupts in numeric
> - order. These are global system and four descriptor rings.
> -- clocks: the clock used by the core
> -- clock-names: Must contain "cryp".
> -- power-domains: Must contain a reference to the PM domain.
> -
> -
> -Example:
> - crypto: crypto@1b240000 {
> - compatible = "mediatek,eip97-crypto";
> - reg = <0 0x1b240000 0 0x20000>;
> - interrupts = <GIC_SPI 82 IRQ_TYPE_LEVEL_LOW>,
> - <GIC_SPI 83 IRQ_TYPE_LEVEL_LOW>,
> - <GIC_SPI 84 IRQ_TYPE_LEVEL_LOW>,
> - <GIC_SPI 91 IRQ_TYPE_LEVEL_LOW>,
> - <GIC_SPI 97 IRQ_TYPE_LEVEL_LOW>;
> - clocks = <ðsys CLK_ETHSYS_CRYPTO>;
> - clock-names = "cryp";
> - power-domains = <&scpsys MT2701_POWER_DOMAIN_ETH>;
> - };
> diff --git a/arch/arm/boot/dts/mt7623.dtsi b/arch/arm/boot/dts/mt7623.dtsi
> index aea6809500d7..25e3f3b04123 100644
> --- a/arch/arm/boot/dts/mt7623.dtsi
> +++ b/arch/arm/boot/dts/mt7623.dtsi
> @@ -949,16 +949,14 @@
> };
>
> crypto: crypto@1b240000 {
> - compatible = "mediatek,eip97-crypto";
> + compatible = "inside-secure,safexcel-eip97";
Please read what the new binding says about this compatible string.
> reg = <0 0x1b240000 0 0x20000>;
> interrupts = <GIC_SPI 82 IRQ_TYPE_LEVEL_LOW>,
> <GIC_SPI 83 IRQ_TYPE_LEVEL_LOW>,
> <GIC_SPI 84 IRQ_TYPE_LEVEL_LOW>,
> - <GIC_SPI 91 IRQ_TYPE_LEVEL_LOW>,
> - <GIC_SPI 97 IRQ_TYPE_LEVEL_LOW>;
> + <GIC_SPI 91 IRQ_TYPE_LEVEL_LOW>;
Where did the extra interrupt go?
> + interrupt-names = "ring0", "ring1", "ring2", "ring3";
> clocks = <ðsys CLK_ETHSYS_CRYPTO>;
> - clock-names = "cryp";
> - power-domains = <&scpsys MT2701_POWER_DOMAIN_ETH>;
Suddenly the h/w is not in a power domain?
Seems to me 'mediatek,eip97-crypto' should be added to the common driver
without having a dts change.
Rob
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] crypto: mediatek - remove obsolete documentation
@ 2021-03-08 20:07 ` Rob Herring
0 siblings, 0 replies; 12+ messages in thread
From: Rob Herring @ 2021-03-08 20:07 UTC (permalink / raw)
To: Vic Wu
Cc: Matthias Brugger, Ryder Lee, devicetree, linux-arm-kernel,
linux-mediatek, linux-kernel
On Wed, Mar 03, 2021 at 05:39:50PM +0800, Vic Wu wrote:
> The crypto mediatek driver has been replaced by the inside-secure driver now.
> Remove DT bindings documentation and update crypto engine nodes to the mt7623.dtsi files.
Wrap lines.
>
> Signed-off-by: Vic Wu <vic.wu@mediatek.com>
> Acked-by: Ryder Lee <ryder.lee@mediatek.com>
> ---
> Documentation/devicetree/bindings/crypto/mediatek-crypto.txt | 25 -------------------
> arch/arm/boot/dts/mt7623.dtsi | 8 +++---
> 2 files changed, 3 insertions(+), 30 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/crypto/mediatek-crypto.txt
>
> diff --git a/Documentation/devicetree/bindings/crypto/mediatek-crypto.txt b/Documentation/devicetree/bindings/crypto/mediatek-crypto.txt
> deleted file mode 100644
> index 450da3661cad..000000000000
> --- a/Documentation/devicetree/bindings/crypto/mediatek-crypto.txt
> +++ /dev/null
> @@ -1,25 +0,0 @@
> -MediaTek cryptographic accelerators
> -
> -Required properties:
> -- compatible: Should be "mediatek,eip97-crypto"
> -- reg: Address and length of the register set for the device
> -- interrupts: Should contain the five crypto engines interrupts in numeric
> - order. These are global system and four descriptor rings.
> -- clocks: the clock used by the core
> -- clock-names: Must contain "cryp".
> -- power-domains: Must contain a reference to the PM domain.
> -
> -
> -Example:
> - crypto: crypto@1b240000 {
> - compatible = "mediatek,eip97-crypto";
> - reg = <0 0x1b240000 0 0x20000>;
> - interrupts = <GIC_SPI 82 IRQ_TYPE_LEVEL_LOW>,
> - <GIC_SPI 83 IRQ_TYPE_LEVEL_LOW>,
> - <GIC_SPI 84 IRQ_TYPE_LEVEL_LOW>,
> - <GIC_SPI 91 IRQ_TYPE_LEVEL_LOW>,
> - <GIC_SPI 97 IRQ_TYPE_LEVEL_LOW>;
> - clocks = <ðsys CLK_ETHSYS_CRYPTO>;
> - clock-names = "cryp";
> - power-domains = <&scpsys MT2701_POWER_DOMAIN_ETH>;
> - };
> diff --git a/arch/arm/boot/dts/mt7623.dtsi b/arch/arm/boot/dts/mt7623.dtsi
> index aea6809500d7..25e3f3b04123 100644
> --- a/arch/arm/boot/dts/mt7623.dtsi
> +++ b/arch/arm/boot/dts/mt7623.dtsi
> @@ -949,16 +949,14 @@
> };
>
> crypto: crypto@1b240000 {
> - compatible = "mediatek,eip97-crypto";
> + compatible = "inside-secure,safexcel-eip97";
Please read what the new binding says about this compatible string.
> reg = <0 0x1b240000 0 0x20000>;
> interrupts = <GIC_SPI 82 IRQ_TYPE_LEVEL_LOW>,
> <GIC_SPI 83 IRQ_TYPE_LEVEL_LOW>,
> <GIC_SPI 84 IRQ_TYPE_LEVEL_LOW>,
> - <GIC_SPI 91 IRQ_TYPE_LEVEL_LOW>,
> - <GIC_SPI 97 IRQ_TYPE_LEVEL_LOW>;
> + <GIC_SPI 91 IRQ_TYPE_LEVEL_LOW>;
Where did the extra interrupt go?
> + interrupt-names = "ring0", "ring1", "ring2", "ring3";
> clocks = <ðsys CLK_ETHSYS_CRYPTO>;
> - clock-names = "cryp";
> - power-domains = <&scpsys MT2701_POWER_DOMAIN_ETH>;
Suddenly the h/w is not in a power domain?
Seems to me 'mediatek,eip97-crypto' should be added to the common driver
without having a dts change.
Rob
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] crypto: mediatek - remove obsolete documentation
@ 2021-03-08 20:07 ` Rob Herring
0 siblings, 0 replies; 12+ messages in thread
From: Rob Herring @ 2021-03-08 20:07 UTC (permalink / raw)
To: Vic Wu
Cc: Matthias Brugger, Ryder Lee, devicetree, linux-arm-kernel,
linux-mediatek, linux-kernel
On Wed, Mar 03, 2021 at 05:39:50PM +0800, Vic Wu wrote:
> The crypto mediatek driver has been replaced by the inside-secure driver now.
> Remove DT bindings documentation and update crypto engine nodes to the mt7623.dtsi files.
Wrap lines.
>
> Signed-off-by: Vic Wu <vic.wu@mediatek.com>
> Acked-by: Ryder Lee <ryder.lee@mediatek.com>
> ---
> Documentation/devicetree/bindings/crypto/mediatek-crypto.txt | 25 -------------------
> arch/arm/boot/dts/mt7623.dtsi | 8 +++---
> 2 files changed, 3 insertions(+), 30 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/crypto/mediatek-crypto.txt
>
> diff --git a/Documentation/devicetree/bindings/crypto/mediatek-crypto.txt b/Documentation/devicetree/bindings/crypto/mediatek-crypto.txt
> deleted file mode 100644
> index 450da3661cad..000000000000
> --- a/Documentation/devicetree/bindings/crypto/mediatek-crypto.txt
> +++ /dev/null
> @@ -1,25 +0,0 @@
> -MediaTek cryptographic accelerators
> -
> -Required properties:
> -- compatible: Should be "mediatek,eip97-crypto"
> -- reg: Address and length of the register set for the device
> -- interrupts: Should contain the five crypto engines interrupts in numeric
> - order. These are global system and four descriptor rings.
> -- clocks: the clock used by the core
> -- clock-names: Must contain "cryp".
> -- power-domains: Must contain a reference to the PM domain.
> -
> -
> -Example:
> - crypto: crypto@1b240000 {
> - compatible = "mediatek,eip97-crypto";
> - reg = <0 0x1b240000 0 0x20000>;
> - interrupts = <GIC_SPI 82 IRQ_TYPE_LEVEL_LOW>,
> - <GIC_SPI 83 IRQ_TYPE_LEVEL_LOW>,
> - <GIC_SPI 84 IRQ_TYPE_LEVEL_LOW>,
> - <GIC_SPI 91 IRQ_TYPE_LEVEL_LOW>,
> - <GIC_SPI 97 IRQ_TYPE_LEVEL_LOW>;
> - clocks = <ðsys CLK_ETHSYS_CRYPTO>;
> - clock-names = "cryp";
> - power-domains = <&scpsys MT2701_POWER_DOMAIN_ETH>;
> - };
> diff --git a/arch/arm/boot/dts/mt7623.dtsi b/arch/arm/boot/dts/mt7623.dtsi
> index aea6809500d7..25e3f3b04123 100644
> --- a/arch/arm/boot/dts/mt7623.dtsi
> +++ b/arch/arm/boot/dts/mt7623.dtsi
> @@ -949,16 +949,14 @@
> };
>
> crypto: crypto@1b240000 {
> - compatible = "mediatek,eip97-crypto";
> + compatible = "inside-secure,safexcel-eip97";
Please read what the new binding says about this compatible string.
> reg = <0 0x1b240000 0 0x20000>;
> interrupts = <GIC_SPI 82 IRQ_TYPE_LEVEL_LOW>,
> <GIC_SPI 83 IRQ_TYPE_LEVEL_LOW>,
> <GIC_SPI 84 IRQ_TYPE_LEVEL_LOW>,
> - <GIC_SPI 91 IRQ_TYPE_LEVEL_LOW>,
> - <GIC_SPI 97 IRQ_TYPE_LEVEL_LOW>;
> + <GIC_SPI 91 IRQ_TYPE_LEVEL_LOW>;
Where did the extra interrupt go?
> + interrupt-names = "ring0", "ring1", "ring2", "ring3";
> clocks = <ðsys CLK_ETHSYS_CRYPTO>;
> - clock-names = "cryp";
> - power-domains = <&scpsys MT2701_POWER_DOMAIN_ETH>;
Suddenly the h/w is not in a power domain?
Seems to me 'mediatek,eip97-crypto' should be added to the common driver
without having a dts change.
Rob
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] crypto: mediatek - remove obsolete documentation
2021-03-03 8:09 ` Vic Wu
(?)
@ 2021-03-03 8:45 ` Herbert Xu
-1 siblings, 0 replies; 12+ messages in thread
From: Herbert Xu @ 2021-03-03 8:45 UTC (permalink / raw)
To: Vic Wu
Cc: David S . Miller, Ryder Lee, linux-crypto, linux-arm-kernel,
linux-mediatek, linux-kernel
On Wed, Mar 03, 2021 at 04:09:23PM +0800, Vic Wu wrote:
> The crypto mediatek driver has been replaced by the inside-secure driver now.
> Remove DT bindings documentation and update crypto engine nodes to the mt7623.dtsi files.
>
> Signed-off-by: Vic Wu <vic.wu@mediatek.com>
> Acked-by: Ryder Lee <ryder.lee@mediatek.com>
> ---
> Documentation/devicetree/bindings/crypto/mediatek-crypto.txt | 25 -------------------
> arch/arm/boot/dts/mt7623.dtsi | 8 +++---
> 2 files changed, 3 insertions(+), 30 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/crypto/mediatek-crypto.txt
Shouldn't this go through Matthias Brugger <matthias.bgg@gmail.com>?
Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] crypto: mediatek - remove obsolete documentation
@ 2021-03-03 8:45 ` Herbert Xu
0 siblings, 0 replies; 12+ messages in thread
From: Herbert Xu @ 2021-03-03 8:45 UTC (permalink / raw)
To: Vic Wu
Cc: David S . Miller, Ryder Lee, linux-crypto, linux-arm-kernel,
linux-mediatek, linux-kernel
On Wed, Mar 03, 2021 at 04:09:23PM +0800, Vic Wu wrote:
> The crypto mediatek driver has been replaced by the inside-secure driver now.
> Remove DT bindings documentation and update crypto engine nodes to the mt7623.dtsi files.
>
> Signed-off-by: Vic Wu <vic.wu@mediatek.com>
> Acked-by: Ryder Lee <ryder.lee@mediatek.com>
> ---
> Documentation/devicetree/bindings/crypto/mediatek-crypto.txt | 25 -------------------
> arch/arm/boot/dts/mt7623.dtsi | 8 +++---
> 2 files changed, 3 insertions(+), 30 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/crypto/mediatek-crypto.txt
Shouldn't this go through Matthias Brugger <matthias.bgg@gmail.com>?
Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] crypto: mediatek - remove obsolete documentation
@ 2021-03-03 8:45 ` Herbert Xu
0 siblings, 0 replies; 12+ messages in thread
From: Herbert Xu @ 2021-03-03 8:45 UTC (permalink / raw)
To: Vic Wu
Cc: David S . Miller, Ryder Lee, linux-crypto, linux-arm-kernel,
linux-mediatek, linux-kernel
On Wed, Mar 03, 2021 at 04:09:23PM +0800, Vic Wu wrote:
> The crypto mediatek driver has been replaced by the inside-secure driver now.
> Remove DT bindings documentation and update crypto engine nodes to the mt7623.dtsi files.
>
> Signed-off-by: Vic Wu <vic.wu@mediatek.com>
> Acked-by: Ryder Lee <ryder.lee@mediatek.com>
> ---
> Documentation/devicetree/bindings/crypto/mediatek-crypto.txt | 25 -------------------
> arch/arm/boot/dts/mt7623.dtsi | 8 +++---
> 2 files changed, 3 insertions(+), 30 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/crypto/mediatek-crypto.txt
Shouldn't this go through Matthias Brugger <matthias.bgg@gmail.com>?
Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH] crypto: mediatek - remove obsolete documentation
@ 2021-03-03 8:09 ` Vic Wu
0 siblings, 0 replies; 12+ messages in thread
From: Vic Wu @ 2021-03-03 8:09 UTC (permalink / raw)
To: Herbert Xu
Cc: David S . Miller, Ryder Lee, linux-crypto, linux-arm-kernel,
linux-mediatek, linux-kernel, Vic Wu
The crypto mediatek driver has been replaced by the inside-secure driver now.
Remove DT bindings documentation and update crypto engine nodes to the mt7623.dtsi files.
Signed-off-by: Vic Wu <vic.wu@mediatek.com>
Acked-by: Ryder Lee <ryder.lee@mediatek.com>
---
Documentation/devicetree/bindings/crypto/mediatek-crypto.txt | 25 -------------------
arch/arm/boot/dts/mt7623.dtsi | 8 +++---
2 files changed, 3 insertions(+), 30 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/crypto/mediatek-crypto.txt
diff --git a/Documentation/devicetree/bindings/crypto/mediatek-crypto.txt b/Documentation/devicetree/bindings/crypto/mediatek-crypto.txt
deleted file mode 100644
index 450da3661cad..000000000000
--- a/Documentation/devicetree/bindings/crypto/mediatek-crypto.txt
+++ /dev/null
@@ -1,25 +0,0 @@
-MediaTek cryptographic accelerators
-
-Required properties:
-- compatible: Should be "mediatek,eip97-crypto"
-- reg: Address and length of the register set for the device
-- interrupts: Should contain the five crypto engines interrupts in numeric
- order. These are global system and four descriptor rings.
-- clocks: the clock used by the core
-- clock-names: Must contain "cryp".
-- power-domains: Must contain a reference to the PM domain.
-
-
-Example:
- crypto: crypto@1b240000 {
- compatible = "mediatek,eip97-crypto";
- reg = <0 0x1b240000 0 0x20000>;
- interrupts = <GIC_SPI 82 IRQ_TYPE_LEVEL_LOW>,
- <GIC_SPI 83 IRQ_TYPE_LEVEL_LOW>,
- <GIC_SPI 84 IRQ_TYPE_LEVEL_LOW>,
- <GIC_SPI 91 IRQ_TYPE_LEVEL_LOW>,
- <GIC_SPI 97 IRQ_TYPE_LEVEL_LOW>;
- clocks = <ðsys CLK_ETHSYS_CRYPTO>;
- clock-names = "cryp";
- power-domains = <&scpsys MT2701_POWER_DOMAIN_ETH>;
- };
diff --git a/arch/arm/boot/dts/mt7623.dtsi b/arch/arm/boot/dts/mt7623.dtsi
index aea6809500d7..25e3f3b04123 100644
--- a/arch/arm/boot/dts/mt7623.dtsi
+++ b/arch/arm/boot/dts/mt7623.dtsi
@@ -949,16 +949,14 @@
};
crypto: crypto@1b240000 {
- compatible = "mediatek,eip97-crypto";
+ compatible = "inside-secure,safexcel-eip97";
reg = <0 0x1b240000 0 0x20000>;
interrupts = <GIC_SPI 82 IRQ_TYPE_LEVEL_LOW>,
<GIC_SPI 83 IRQ_TYPE_LEVEL_LOW>,
<GIC_SPI 84 IRQ_TYPE_LEVEL_LOW>,
- <GIC_SPI 91 IRQ_TYPE_LEVEL_LOW>,
- <GIC_SPI 97 IRQ_TYPE_LEVEL_LOW>;
+ <GIC_SPI 91 IRQ_TYPE_LEVEL_LOW>;
+ interrupt-names = "ring0", "ring1", "ring2", "ring3";
clocks = <ðsys CLK_ETHSYS_CRYPTO>;
- clock-names = "cryp";
- power-domains = <&scpsys MT2701_POWER_DOMAIN_ETH>;
status = "disabled";
};
--
2.18.0
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH] crypto: mediatek - remove obsolete documentation
@ 2021-03-03 8:09 ` Vic Wu
0 siblings, 0 replies; 12+ messages in thread
From: Vic Wu @ 2021-03-03 8:09 UTC (permalink / raw)
To: Herbert Xu
Cc: David S . Miller, Ryder Lee, linux-crypto, linux-arm-kernel,
linux-mediatek, linux-kernel, Vic Wu
The crypto mediatek driver has been replaced by the inside-secure driver now.
Remove DT bindings documentation and update crypto engine nodes to the mt7623.dtsi files.
Signed-off-by: Vic Wu <vic.wu@mediatek.com>
Acked-by: Ryder Lee <ryder.lee@mediatek.com>
---
Documentation/devicetree/bindings/crypto/mediatek-crypto.txt | 25 -------------------
arch/arm/boot/dts/mt7623.dtsi | 8 +++---
2 files changed, 3 insertions(+), 30 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/crypto/mediatek-crypto.txt
diff --git a/Documentation/devicetree/bindings/crypto/mediatek-crypto.txt b/Documentation/devicetree/bindings/crypto/mediatek-crypto.txt
deleted file mode 100644
index 450da3661cad..000000000000
--- a/Documentation/devicetree/bindings/crypto/mediatek-crypto.txt
+++ /dev/null
@@ -1,25 +0,0 @@
-MediaTek cryptographic accelerators
-
-Required properties:
-- compatible: Should be "mediatek,eip97-crypto"
-- reg: Address and length of the register set for the device
-- interrupts: Should contain the five crypto engines interrupts in numeric
- order. These are global system and four descriptor rings.
-- clocks: the clock used by the core
-- clock-names: Must contain "cryp".
-- power-domains: Must contain a reference to the PM domain.
-
-
-Example:
- crypto: crypto@1b240000 {
- compatible = "mediatek,eip97-crypto";
- reg = <0 0x1b240000 0 0x20000>;
- interrupts = <GIC_SPI 82 IRQ_TYPE_LEVEL_LOW>,
- <GIC_SPI 83 IRQ_TYPE_LEVEL_LOW>,
- <GIC_SPI 84 IRQ_TYPE_LEVEL_LOW>,
- <GIC_SPI 91 IRQ_TYPE_LEVEL_LOW>,
- <GIC_SPI 97 IRQ_TYPE_LEVEL_LOW>;
- clocks = <ðsys CLK_ETHSYS_CRYPTO>;
- clock-names = "cryp";
- power-domains = <&scpsys MT2701_POWER_DOMAIN_ETH>;
- };
diff --git a/arch/arm/boot/dts/mt7623.dtsi b/arch/arm/boot/dts/mt7623.dtsi
index aea6809500d7..25e3f3b04123 100644
--- a/arch/arm/boot/dts/mt7623.dtsi
+++ b/arch/arm/boot/dts/mt7623.dtsi
@@ -949,16 +949,14 @@
};
crypto: crypto@1b240000 {
- compatible = "mediatek,eip97-crypto";
+ compatible = "inside-secure,safexcel-eip97";
reg = <0 0x1b240000 0 0x20000>;
interrupts = <GIC_SPI 82 IRQ_TYPE_LEVEL_LOW>,
<GIC_SPI 83 IRQ_TYPE_LEVEL_LOW>,
<GIC_SPI 84 IRQ_TYPE_LEVEL_LOW>,
- <GIC_SPI 91 IRQ_TYPE_LEVEL_LOW>,
- <GIC_SPI 97 IRQ_TYPE_LEVEL_LOW>;
+ <GIC_SPI 91 IRQ_TYPE_LEVEL_LOW>;
+ interrupt-names = "ring0", "ring1", "ring2", "ring3";
clocks = <ðsys CLK_ETHSYS_CRYPTO>;
- clock-names = "cryp";
- power-domains = <&scpsys MT2701_POWER_DOMAIN_ETH>;
status = "disabled";
};
--
2.18.0
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH] crypto: mediatek - remove obsolete documentation
@ 2021-03-03 8:09 ` Vic Wu
0 siblings, 0 replies; 12+ messages in thread
From: Vic Wu @ 2021-03-03 8:09 UTC (permalink / raw)
To: Herbert Xu
Cc: David S . Miller, Ryder Lee, linux-crypto, linux-arm-kernel,
linux-mediatek, linux-kernel, Vic Wu
The crypto mediatek driver has been replaced by the inside-secure driver now.
Remove DT bindings documentation and update crypto engine nodes to the mt7623.dtsi files.
Signed-off-by: Vic Wu <vic.wu@mediatek.com>
Acked-by: Ryder Lee <ryder.lee@mediatek.com>
---
Documentation/devicetree/bindings/crypto/mediatek-crypto.txt | 25 -------------------
arch/arm/boot/dts/mt7623.dtsi | 8 +++---
2 files changed, 3 insertions(+), 30 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/crypto/mediatek-crypto.txt
diff --git a/Documentation/devicetree/bindings/crypto/mediatek-crypto.txt b/Documentation/devicetree/bindings/crypto/mediatek-crypto.txt
deleted file mode 100644
index 450da3661cad..000000000000
--- a/Documentation/devicetree/bindings/crypto/mediatek-crypto.txt
+++ /dev/null
@@ -1,25 +0,0 @@
-MediaTek cryptographic accelerators
-
-Required properties:
-- compatible: Should be "mediatek,eip97-crypto"
-- reg: Address and length of the register set for the device
-- interrupts: Should contain the five crypto engines interrupts in numeric
- order. These are global system and four descriptor rings.
-- clocks: the clock used by the core
-- clock-names: Must contain "cryp".
-- power-domains: Must contain a reference to the PM domain.
-
-
-Example:
- crypto: crypto@1b240000 {
- compatible = "mediatek,eip97-crypto";
- reg = <0 0x1b240000 0 0x20000>;
- interrupts = <GIC_SPI 82 IRQ_TYPE_LEVEL_LOW>,
- <GIC_SPI 83 IRQ_TYPE_LEVEL_LOW>,
- <GIC_SPI 84 IRQ_TYPE_LEVEL_LOW>,
- <GIC_SPI 91 IRQ_TYPE_LEVEL_LOW>,
- <GIC_SPI 97 IRQ_TYPE_LEVEL_LOW>;
- clocks = <ðsys CLK_ETHSYS_CRYPTO>;
- clock-names = "cryp";
- power-domains = <&scpsys MT2701_POWER_DOMAIN_ETH>;
- };
diff --git a/arch/arm/boot/dts/mt7623.dtsi b/arch/arm/boot/dts/mt7623.dtsi
index aea6809500d7..25e3f3b04123 100644
--- a/arch/arm/boot/dts/mt7623.dtsi
+++ b/arch/arm/boot/dts/mt7623.dtsi
@@ -949,16 +949,14 @@
};
crypto: crypto@1b240000 {
- compatible = "mediatek,eip97-crypto";
+ compatible = "inside-secure,safexcel-eip97";
reg = <0 0x1b240000 0 0x20000>;
interrupts = <GIC_SPI 82 IRQ_TYPE_LEVEL_LOW>,
<GIC_SPI 83 IRQ_TYPE_LEVEL_LOW>,
<GIC_SPI 84 IRQ_TYPE_LEVEL_LOW>,
- <GIC_SPI 91 IRQ_TYPE_LEVEL_LOW>,
- <GIC_SPI 97 IRQ_TYPE_LEVEL_LOW>;
+ <GIC_SPI 91 IRQ_TYPE_LEVEL_LOW>;
+ interrupt-names = "ring0", "ring1", "ring2", "ring3";
clocks = <ðsys CLK_ETHSYS_CRYPTO>;
- clock-names = "cryp";
- power-domains = <&scpsys MT2701_POWER_DOMAIN_ETH>;
status = "disabled";
};
--
2.18.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 12+ messages in thread
end of thread, other threads:[~2021-03-08 20:11 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-03 9:39 [PATCH] crypto: mediatek - remove obsolete documentation Vic Wu
2021-03-03 9:39 ` Vic Wu
2021-03-03 9:39 ` Vic Wu
2021-03-08 20:07 ` Rob Herring
2021-03-08 20:07 ` Rob Herring
2021-03-08 20:07 ` Rob Herring
-- strict thread matches above, loose matches on Subject: below --
2021-03-03 8:09 Vic Wu
2021-03-03 8:09 ` Vic Wu
2021-03-03 8:09 ` Vic Wu
2021-03-03 8:45 ` Herbert Xu
2021-03-03 8:45 ` Herbert Xu
2021-03-03 8:45 ` Herbert Xu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.