* [PATCH] can: m_can: m_can_do_rx_poll(): fix extraneous msg loss warning
@ 2021-03-03 10:31 Torin Cooper-Bennun
2021-03-04 13:22 ` Marc Kleine-Budde
0 siblings, 1 reply; 2+ messages in thread
From: Torin Cooper-Bennun @ 2021-03-03 10:31 UTC (permalink / raw)
To: linux-can; +Cc: mkl, Torin Cooper-Bennun, Mariusz Madej
Message loss from RX FIFO 0 is already handled in m_can_handle_lost_msg,
with netdev output included.
Removing this warning also improves driver performance under heavy load,
where m_can_do_rx_poll may be called many times before this interrupt is
cleared, causing this message to be output many times (thanks Mariusz
Madej for this report).
Cc: Mariusz Madej <mariusz.madej@xtrack.com>
Signed-off-by: Torin Cooper-Bennun <torin@maxiluxsystems.com>
---
drivers/net/can/m_can/m_can.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/net/can/m_can/m_can.c b/drivers/net/can/m_can/m_can.c
index 3752520a7d4b..d783c46cac16 100644
--- a/drivers/net/can/m_can/m_can.c
+++ b/drivers/net/can/m_can/m_can.c
@@ -501,9 +501,6 @@ static int m_can_do_rx_poll(struct net_device *dev, int quota)
}
while ((rxfs & RXFS_FFL_MASK) && (quota > 0)) {
- if (rxfs & RXFS_RFL)
- netdev_warn(dev, "Rx FIFO 0 Message Lost\n");
-
m_can_read_fifo(dev, rxfs);
quota--;
--
2.30.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] can: m_can: m_can_do_rx_poll(): fix extraneous msg loss warning
2021-03-03 10:31 [PATCH] can: m_can: m_can_do_rx_poll(): fix extraneous msg loss warning Torin Cooper-Bennun
@ 2021-03-04 13:22 ` Marc Kleine-Budde
0 siblings, 0 replies; 2+ messages in thread
From: Marc Kleine-Budde @ 2021-03-04 13:22 UTC (permalink / raw)
To: Torin Cooper-Bennun, linux-can; +Cc: Mariusz Madej
[-- Attachment #1.1: Type: text/plain, Size: 853 bytes --]
On 3/3/21 11:31 AM, Torin Cooper-Bennun wrote:
> Message loss from RX FIFO 0 is already handled in m_can_handle_lost_msg,
> with netdev output included.
>
> Removing this warning also improves driver performance under heavy load,
> where m_can_do_rx_poll may be called many times before this interrupt is
> cleared, causing this message to be output many times (thanks Mariusz
> Madej for this report).
>
> Cc: Mariusz Madej <mariusz.madej@xtrack.com>
> Signed-off-by: Torin Cooper-Bennun <torin@maxiluxsystems.com>
Applied to linux-can/testing.
regards,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-03-04 13:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-03 10:31 [PATCH] can: m_can: m_can_do_rx_poll(): fix extraneous msg loss warning Torin Cooper-Bennun
2021-03-04 13:22 ` Marc Kleine-Budde
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.