From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1lHWag-0003uJ-LM for mharc-grub-devel@gnu.org; Wed, 03 Mar 2021 13:51:22 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:34784) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lHWae-0003pD-0S for grub-devel@gnu.org; Wed, 03 Mar 2021 13:51:20 -0500 Received: from dibed.net-space.pl ([84.10.22.86]:53556) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_3DES_EDE_CBC_SHA1:192) (Exim 4.90_1) (envelope-from ) id 1lHWac-0000lQ-0j for grub-devel@gnu.org; Wed, 03 Mar 2021 13:51:19 -0500 Received: from router-fw.i.net-space.pl ([192.168.52.1]:45076 "EHLO tomti.i.net-space.pl") by router-fw-old.i.net-space.pl with ESMTP id S2092013AbhCCSRe (ORCPT ); Wed, 3 Mar 2021 19:17:34 +0100 X-Comment: RFC 2476 MSA function at dibed.net-space.pl logged sender identity as: dkiper Date: Wed, 3 Mar 2021 19:17:31 +0100 From: Daniel Kiper To: Glenn Washburn Cc: grub-devel@gnu.org Subject: Re: [PATCH v4 12/13] error: Use format code llu for 64-bit uint bp->blk_prop in grub_error Message-ID: <20210303181731.oqxbgiy7itr6b3hk@tomti.i.net-space.pl> References: <041adc37aa48c09c7e63f07406afe9b0b4031f50.1613700218.git.development@efficientek.com> <20210227120509.gabuyn5xrqcddovc@tomti.i.net-space.pl> <20210228151052.0b667476@crass-HP-ZBook-15-G2> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210228151052.0b667476@crass-HP-ZBook-15-G2> User-Agent: NeoMutt/20170113 (1.7.2) Received-SPF: pass client-ip=84.10.22.86; envelope-from=dkiper@net-space.pl; helo=dibed.net-space.pl X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Mar 2021 18:51:20 -0000 On Sun, Feb 28, 2021 at 03:10:52PM -0600, Glenn Washburn wrote: > On Sat, 27 Feb 2021 13:05:09 +0100 > Daniel Kiper wrote: > > > On Thu, Feb 18, 2021 at 08:47:13PM -0600, Glenn Washburn wrote: > > > For some reason PRIuGRUB_UINT64_T is not expanding to llu, but to > > > lu, which causes the format string check to fail. Use literal and > > > force cast until this is debugged. > > > > I think the problem is that currently BF64_DECODE() uses "1ULL". I > > think it should look like this > > > > #define BF64_DECODE(x, low, len) P2PHASE((x) >> (low), > > ((grub_uint64_t) 1) << (len)) > > > > instead of > > > > #define BF64_DECODE(x, low, len) P2PHASE((x) >> (low), 1ULL << > > (len)) > > > > Same or similar for other macros there. > > > > I would prefer if you fix macros in include/grub/zfs/spa.h first and > > then do proper fix here. > > Yep, completely agree, just hadn't figured out a proper solution. And > not being familiar with the code and not doing the zfs functional tests > (GitLab CI shared runners do not have zfs kernel support), I'm hesitant > to make such intrusive changes. However, your suggestion is the better > way to do it and I've confirmed that it work on i386 and x86_64. I'll > update the patch in the next patch series. I am still afraid doing that before release until we are able to confirm that everything works for 32-bit and 64-bit architectures. If not I would not merge this patch and next one at this point. Daniel