All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Hannes Reinecke <hare@suse.de>
Cc: Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
	Keith Busch <keith.busch@wdc.com>,
	Daniel Wagner <dwagner@suse.de>, Chao Leng <lengchao@huawei.com>,
	linux-nvme@lists.infradead.org
Subject: Re: [PATCH 1/3] nvme: fixup kato deadlock
Date: Thu, 4 Mar 2021 09:02:41 +0100	[thread overview]
Message-ID: <20210304080241.GA12617@lst.de> (raw)
In-Reply-To: <9ea53e09-2ab5-733a-7f1d-fd2404794149@suse.de>

On Wed, Mar 03, 2021 at 03:23:12PM +0100, Hannes Reinecke wrote:
> Actually, having thought a bit more, I'm not sure if we should change
> that. Changing the number of reserved commands _will_ have an impact on
> error recovery, up to the point that we cannot issue a 'connect' command
> if a keep-alive command is still running.
> Which means we might be seeing spurious connection failures during
> recovery, something which I'd be very cautious about.

We always do a blk_mq_tagset_busy_iter that cancels all requests before
reconnecting.

_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

  reply	other threads:[~2021-03-04  8:41 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-02  9:26 [PATCHv2 0/3] nvme: sanitize KATO handling Hannes Reinecke
2021-03-02  9:26 ` [PATCH 1/3] nvme: fixup kato deadlock Hannes Reinecke
2021-03-03  8:42   ` Christoph Hellwig
2021-03-03 12:01     ` Hannes Reinecke
2021-03-03 12:35       ` Christoph Hellwig
2021-03-03 13:11         ` Hannes Reinecke
2021-03-03 14:23           ` Hannes Reinecke
2021-03-04  8:02             ` Christoph Hellwig [this message]
2021-03-04  8:56               ` Hannes Reinecke
2021-03-02  9:26 ` [PATCH 2/3] nvme: sanitize KATO setting Hannes Reinecke
2021-03-03  8:53   ` Chao Leng
2021-03-03 12:40     ` Christoph Hellwig
2021-03-05 20:38   ` Sagi Grimberg
2021-03-08 13:11   ` Max Gurtovoy
2021-03-08 13:54     ` Hannes Reinecke
2021-03-02  9:26 ` [PATCH 3/3] nvme: add 'kato' sysfs attribute Hannes Reinecke
2021-03-05 20:38   ` Sagi Grimberg
2021-03-08 13:06   ` Max Gurtovoy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210304080241.GA12617@lst.de \
    --to=hch@lst.de \
    --cc=dwagner@suse.de \
    --cc=hare@suse.de \
    --cc=keith.busch@wdc.com \
    --cc=lengchao@huawei.com \
    --cc=linux-nvme@lists.infradead.org \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.