From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Torin Cooper-Bennun <torin@maxiluxsystems.com>
Cc: linux-can@vger.kernel.org
Subject: Re: [PATCH] can: m_can: m_can_rx_peripheral: fix RX being blocked by errors
Date: Thu, 4 Mar 2021 14:57:37 +0100 [thread overview]
Message-ID: <20210304135737.bmjlj3pmunvd3bbx@pengutronix.de> (raw)
In-Reply-To: <20210303144350.4093750-1-torin@maxiluxsystems.com>
[-- Attachment #1: Type: text/plain, Size: 840 bytes --]
On 03.03.2021 14:43:51, Torin Cooper-Bennun wrote:
> For M_CAN peripherals, m_can_rx_handler was called with quota = 1, which
> caused any error handling to block RX from taking place until the next
> time the IRQ handler is called. This had been observed to cause RX to be
> blocked indefinitely in some cases.
>
> This is fixed by calling m_can_rx_handler with a sensibly high quota.
>
> Suggested-by: Marc Kleine-Budde <mkl@pengutronix.de>
> Signed-off-by: Torin Cooper-Bennun <torin@maxiluxsystems.com>
Applied to linux-can/testing.
Thanks,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2021-03-04 13:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-03 14:43 [PATCH] can: m_can: m_can_rx_peripheral: fix RX being blocked by errors Torin Cooper-Bennun
2021-03-04 13:57 ` Marc Kleine-Budde [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210304135737.bmjlj3pmunvd3bbx@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=linux-can@vger.kernel.org \
--cc=torin@maxiluxsystems.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.