From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [PATCH v4 05/16] gpio: Drop dm_gpio_set_dir()
Date: Thu, 4 Mar 2021 10:09:29 -0500 [thread overview]
Message-ID: <20210304150929.GV1310@bill-the-cat> (raw)
In-Reply-To: <CAPnjgZ08f-=dPvGL22fj4iB8ENms51Ma-HL94uWSruqR+-iY-A@mail.gmail.com>
On Thu, Mar 04, 2021 at 09:22:35AM -0500, Simon Glass wrote:
> Hi Tom,
>
> On Wed, 3 Mar 2021 at 15:39, Tom Rini <trini@konsulko.com> wrote:
> >
> > On Thu, Feb 04, 2021 at 09:21:58PM -0700, Simon Glass wrote:
> >
> > > This function is not used. Drop it.
> > >
> > > Signed-off-by: Simon Glass <sjg@chromium.org>
> > >
> > > Reviewed-by: Patrick Delaunay <patrick.delaunay@foss.st.com>
> >
> > I'm dropping this patch as it seems to be an explicit break of:
> > commit 6befb51f349459c96ed64412070feda7472cf152
> > Author: Harm Berntsen <harm.berntsen@nedap.com>
> > Date: Sun Nov 29 09:47:15 2020 +0000
> >
> > i2c: i2c-gpio: Fix GPIO output
> >
> > The dm_gpio_set_dir_flags function cannot be used to update the
> > configuration of a GPIO pin because it does a bitwise OR with the
> > existing flags. Looks like commit 788ea834124b ("gpio: add function
> > _dm_gpio_set_dir_flags") has introduced this behaviour and the i2c-gpio
> > driver has been broken since.
> >
> > Signed-off-by: Harm Berntsen <harm.berntsen@nedap.com>
> > CC: Heiko Schocher <hs@denx.de>
> > CC: Patrick Delaunay <patrick.delaunay@st.com>
>
> Yes I noticed that but only recently, somehow. I have a patch to adjust it.
>
> Does this mean you are planning to apply the rest of the series? If so
> I'll see how things land and send a patch after that.
Yes, I have the rest of the series about to go in to -next.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20210304/9d3e8396/attachment.sig>
next prev parent reply other threads:[~2021-03-04 15:09 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-05 4:21 [PATCH v4 00/16] gpio: Update and simplify the uclass API Simon Glass
2021-02-05 4:21 ` [PATCH v4 01/16] gpio: Disable functions not used with of-platdata Simon Glass
2021-03-04 18:13 ` Tom Rini
2021-02-05 4:21 ` [PATCH v4 02/16] dm: gpio: Rename set_dir_flags() method to update_flags() Simon Glass
2021-03-04 18:14 ` Tom Rini
2021-02-05 4:21 ` [PATCH v4 03/16] dm: gpio: Rename get_dir_flags() method to get_flags() Simon Glass
2021-03-04 18:14 ` Tom Rini
2021-02-05 4:21 ` [PATCH v4 04/16] gpio: Rename dm_gpio_get_dir_flags() to dm_gpio_get_flags() Simon Glass
2021-03-04 18:14 ` Tom Rini
2021-02-05 4:21 ` [PATCH v4 05/16] gpio: Drop dm_gpio_set_dir() Simon Glass
2021-03-03 20:39 ` Tom Rini
2021-03-04 14:22 ` Simon Glass
2021-03-04 15:09 ` Tom Rini [this message]
2021-02-05 4:21 ` [PATCH v4 06/16] gpio: sandbox: Rename GPIO dir_flags to flags Simon Glass
2021-03-04 18:14 ` Tom Rini
2021-02-05 4:22 ` [PATCH v4 07/16] gpio: sandbox: Use a separate flag for the value Simon Glass
2021-03-04 18:14 ` Tom Rini
2021-02-05 4:22 ` [PATCH v4 08/16] gpio: sandbox: Fully separate pin value from output value Simon Glass
2021-03-04 18:14 ` Tom Rini
2021-02-05 4:22 ` [PATCH v4 09/16] gpio: sandbox: Make sandbox_gpio_set_flags() set all flags Simon Glass
2021-03-04 18:14 ` Tom Rini
2021-02-05 4:22 ` [PATCH v4 10/16] dm: gpio: Add a way to update flags Simon Glass
2021-02-08 9:00 ` Köry Maincent
2021-02-08 17:33 ` Patrick DELAUNAY
2021-02-09 4:28 ` Simon Glass
2021-02-10 8:38 ` Patrick DELAUNAY
2021-02-13 4:17 ` Simon Glass
2021-03-04 18:14 ` Tom Rini
2021-02-05 4:22 ` [PATCH v4 11/16] gpio: Replace direction_input() and direction_output() Simon Glass
2021-03-04 18:14 ` Tom Rini
2021-02-05 4:22 ` [PATCH v4 12/16] gpio: Use an 'ops' variable everywhere Simon Glass
2021-03-04 18:14 ` Tom Rini
2021-02-05 4:22 ` [PATCH v4 13/16] gpio: x86: Drop the deprecated methods in intel_gpio Simon Glass
2021-03-04 18:15 ` Tom Rini
2021-02-05 4:22 ` [PATCH v4 14/16] gpio: sandbox: Track whether a GPIO is driven Simon Glass
2021-03-04 18:15 ` Tom Rini
2021-02-05 4:22 ` [PATCH v4 15/16] gpio: Define the log category in the uclass Simon Glass
2021-03-04 18:15 ` Tom Rini
2021-02-05 4:22 ` [PATCH v4 16/16] gpio: Add a way to read 3-way strapping pins Simon Glass
2021-02-08 18:13 ` Patrick DELAUNAY
2021-02-08 23:41 ` Simon Glass
2021-03-04 18:15 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210304150929.GV1310@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.