* [Intel-gfx] [PATCH 0/4] drm/i915: Silence pipe tracepoint WARNs
@ 2021-03-04 17:04 Ville Syrjala
2021-03-04 17:04 ` [Intel-gfx] [PATCH 1/4] drm/i915: Move pipe enable/disable tracepoints to intel_crtc_vblank_{on, off}() Ville Syrjala
` (7 more replies)
0 siblings, 8 replies; 10+ messages in thread
From: Ville Syrjala @ 2021-03-04 17:04 UTC (permalink / raw)
To: intel-gfx; +Cc: Steven Rostedt
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
I believe this should silence the WARN spew from the
pipe disable tracepoint Steve reported. And I tossed in
a few other minor improvements as well.
Cc: Steven Rostedt <rostedt@goodmis.org>
Ville Syrjälä (4):
drm/i915: Move pipe enable/disable tracepoints to
intel_crtc_vblank_{on,off}()
drm/i915: Don't try to query the frame counter for disabled pipes
drm/i915: Return zero as the scanline counter for disabled pipes
drm/i915: Fix DSI TE max_vblank_count handling
drivers/gpu/drm/i915/display/intel_crtc.c | 24 +++++++++++++++++---
drivers/gpu/drm/i915/display/intel_display.c | 8 +------
drivers/gpu/drm/i915/i915_irq.c | 2 +-
3 files changed, 23 insertions(+), 11 deletions(-)
--
2.26.2
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Intel-gfx] [PATCH 1/4] drm/i915: Move pipe enable/disable tracepoints to intel_crtc_vblank_{on, off}()
2021-03-04 17:04 [Intel-gfx] [PATCH 0/4] drm/i915: Silence pipe tracepoint WARNs Ville Syrjala
@ 2021-03-04 17:04 ` Ville Syrjala
2021-03-04 17:04 ` [Intel-gfx] [PATCH 2/4] drm/i915: Don't try to query the frame counter for disabled pipes Ville Syrjala
` (6 subsequent siblings)
7 siblings, 0 replies; 10+ messages in thread
From: Ville Syrjala @ 2021-03-04 17:04 UTC (permalink / raw)
To: intel-gfx; +Cc: Steven Rostedt
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
On platforms/outputs without a working frame counter we rely
on the vblank code to cook up the frame counter from the timestamps.
That requires that vblank support is enabled. Thus we need to
move the pipe enable/disable tracepoints to the other side
of the drm_vblank_{on,off}() calls. There shouldn't really be
much happening between these old and new call sites so the
tracepoints should still provide reasonable data.
The alternative would be to give up on having the frame counter
values in the trace which would render the tracepoints more or
less pointless.
Reported-by: Steven Rostedt <rostedt@goodmis.org>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/i915/display/intel_crtc.c | 16 ++++++++++++++++
drivers/gpu/drm/i915/display/intel_display.c | 8 +-------
2 files changed, 17 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_crtc.c b/drivers/gpu/drm/i915/display/intel_crtc.c
index 88b44ac50aae..fd8a66cece80 100644
--- a/drivers/gpu/drm/i915/display/intel_crtc.c
+++ b/drivers/gpu/drm/i915/display/intel_crtc.c
@@ -28,6 +28,8 @@
#include "i9xx_plane.h"
#include "skl_universal_plane.h"
+#include "i915_trace.h"
+
static void assert_vblank_disabled(struct drm_crtc *crtc)
{
if (I915_STATE_WARN_ON(drm_crtc_vblank_get(crtc) == 0))
@@ -84,12 +86,26 @@ void intel_crtc_vblank_on(const struct intel_crtc_state *crtc_state)
drm_crtc_set_max_vblank_count(&crtc->base,
intel_crtc_max_vblank_count(crtc_state));
drm_crtc_vblank_on(&crtc->base);
+
+ /*
+ * Should really happen exactly when we enable the pipe
+ * but we want the frame counters in the trace, and that
+ * requires vblank support on some platforms/outputs.
+ */
+ trace_intel_pipe_enable(crtc);
}
void intel_crtc_vblank_off(const struct intel_crtc_state *crtc_state)
{
struct intel_crtc *crtc = to_intel_crtc(crtc_state->uapi.crtc);
+ /*
+ * Should really happen exactly when we disable the pipe
+ * but we want the frame counters in the trace, and that
+ * requires vblank support on some platforms/outputs.
+ */
+ trace_intel_pipe_disable(crtc);
+
drm_crtc_vblank_off(&crtc->base);
assert_vblank_disabled(&crtc->base);
}
diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
index b346f6ceb4a2..16b5cb73ddac 100644
--- a/drivers/gpu/drm/i915/display/intel_display.c
+++ b/drivers/gpu/drm/i915/display/intel_display.c
@@ -794,8 +794,6 @@ void intel_enable_pipe(const struct intel_crtc_state *new_crtc_state)
/* FIXME: assert CPU port conditions for SNB+ */
}
- trace_intel_pipe_enable(crtc);
-
reg = PIPECONF(cpu_transcoder);
val = intel_de_read(dev_priv, reg);
if (val & PIPECONF_ENABLE) {
@@ -835,8 +833,6 @@ void intel_disable_pipe(const struct intel_crtc_state *old_crtc_state)
*/
assert_planes_disabled(crtc);
- trace_intel_pipe_disable(crtc);
-
reg = PIPECONF(cpu_transcoder);
val = intel_de_read(dev_priv, reg);
if ((val & PIPECONF_ENABLE) == 0)
@@ -4023,10 +4019,8 @@ static void hsw_crtc_enable(struct intel_atomic_state *state,
if (INTEL_GEN(dev_priv) >= 11)
icl_pipe_mbus_enable(crtc);
- if (new_crtc_state->bigjoiner_slave) {
- trace_intel_pipe_enable(crtc);
+ if (new_crtc_state->bigjoiner_slave)
intel_crtc_vblank_on(new_crtc_state);
- }
intel_encoders_enable(state, crtc);
--
2.26.2
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [Intel-gfx] [PATCH 2/4] drm/i915: Don't try to query the frame counter for disabled pipes
2021-03-04 17:04 [Intel-gfx] [PATCH 0/4] drm/i915: Silence pipe tracepoint WARNs Ville Syrjala
2021-03-04 17:04 ` [Intel-gfx] [PATCH 1/4] drm/i915: Move pipe enable/disable tracepoints to intel_crtc_vblank_{on, off}() Ville Syrjala
@ 2021-03-04 17:04 ` Ville Syrjala
2021-03-04 17:04 ` [Intel-gfx] [PATCH 3/4] drm/i915: Return zero as the scanline " Ville Syrjala
` (5 subsequent siblings)
7 siblings, 0 replies; 10+ messages in thread
From: Ville Syrjala @ 2021-03-04 17:04 UTC (permalink / raw)
To: intel-gfx; +Cc: Steven Rostedt
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
For platforms/outputs without hardware frame counters we can't
call drm_crtc_accurate_vblank_count() when the vblank support is
disabled or we just get a WARN due to the crtc timings
(vblank->hwmode) being considered invalid. Note that until the
pipe in question has been enabled and drm_crtc_set_max_vblank_count()
has been called on it we would also take this path on platforms
which have a working frame counter. So getting the WARN is rather
likely on any platform unless you always boot with lots of displays
plugged in.
Also even on hardware with a working frame counter we may not be
able to read the actual frame counter register on disabled pipes
due the relevant power well being disabled. Ie. would just result
in the unclaimed reg spew.
So let's just avoid all this an directly report zero in case
the pipe is disabled.
Reported-by: Steven Rostedt <rostedt@goodmis.org>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/i915/display/intel_crtc.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/i915/display/intel_crtc.c b/drivers/gpu/drm/i915/display/intel_crtc.c
index fd8a66cece80..34ff40852a37 100644
--- a/drivers/gpu/drm/i915/display/intel_crtc.c
+++ b/drivers/gpu/drm/i915/display/intel_crtc.c
@@ -41,6 +41,9 @@ u32 intel_crtc_get_vblank_counter(struct intel_crtc *crtc)
struct drm_device *dev = crtc->base.dev;
struct drm_vblank_crtc *vblank = &dev->vblank[drm_crtc_index(&crtc->base)];
+ if (!crtc->active)
+ return 0;
+
if (!vblank->max_vblank_count)
return (u32)drm_crtc_accurate_vblank_count(&crtc->base);
--
2.26.2
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [Intel-gfx] [PATCH 3/4] drm/i915: Return zero as the scanline counter for disabled pipes
2021-03-04 17:04 [Intel-gfx] [PATCH 0/4] drm/i915: Silence pipe tracepoint WARNs Ville Syrjala
2021-03-04 17:04 ` [Intel-gfx] [PATCH 1/4] drm/i915: Move pipe enable/disable tracepoints to intel_crtc_vblank_{on, off}() Ville Syrjala
2021-03-04 17:04 ` [Intel-gfx] [PATCH 2/4] drm/i915: Don't try to query the frame counter for disabled pipes Ville Syrjala
@ 2021-03-04 17:04 ` Ville Syrjala
2021-03-04 17:04 ` [Intel-gfx] [PATCH 4/4] drm/i915: Fix DSI TE max_vblank_count handling Ville Syrjala
` (4 subsequent siblings)
7 siblings, 0 replies; 10+ messages in thread
From: Ville Syrjala @ 2021-03-04 17:04 UTC (permalink / raw)
To: intel-gfx; +Cc: Steven Rostedt
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
We print the scanline counters as unsigned integers so the -1
here just makes the debugs/traces look a bit messy. Zero seems
equally valid for this usecase.
Cc: Steven Rostedt <rostedt@goodmis.org>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/i915/i915_irq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
index 01c409005f6f..44aed4cbf894 100644
--- a/drivers/gpu/drm/i915/i915_irq.c
+++ b/drivers/gpu/drm/i915/i915_irq.c
@@ -794,7 +794,7 @@ static int __intel_get_crtc_scanline(struct intel_crtc *crtc)
int position, vtotal;
if (!crtc->active)
- return -1;
+ return 0;
vblank = &crtc->base.dev->vblank[drm_crtc_index(&crtc->base)];
mode = &vblank->hwmode;
--
2.26.2
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [Intel-gfx] [PATCH 4/4] drm/i915: Fix DSI TE max_vblank_count handling
2021-03-04 17:04 [Intel-gfx] [PATCH 0/4] drm/i915: Silence pipe tracepoint WARNs Ville Syrjala
` (2 preceding siblings ...)
2021-03-04 17:04 ` [Intel-gfx] [PATCH 3/4] drm/i915: Return zero as the scanline " Ville Syrjala
@ 2021-03-04 17:04 ` Ville Syrjala
2021-03-04 17:43 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Silence pipe tracepoint WARNs Patchwork
` (3 subsequent siblings)
7 siblings, 0 replies; 10+ messages in thread
From: Ville Syrjala @ 2021-03-04 17:04 UTC (permalink / raw)
To: intel-gfx; +Cc: Jani Nikula, Steven Rostedt
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
commit 33267703df15 ("drm/i915/dsi: Enable software vblank counter")
claims to get the mode_flags from the crtc_state, but in fact does
not. Fix it to do it right.
Cc: Vandita Kulkarni <vandita.kulkarni@intel.com>
Cc: Jani Nikula <jani.nikula@intel.com>
Cc: Steven Rostedt <rostedt@goodmis.org>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/i915/display/intel_crtc.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_crtc.c b/drivers/gpu/drm/i915/display/intel_crtc.c
index 34ff40852a37..7dcbec3a3ca5 100644
--- a/drivers/gpu/drm/i915/display/intel_crtc.c
+++ b/drivers/gpu/drm/i915/display/intel_crtc.c
@@ -53,8 +53,6 @@ u32 intel_crtc_get_vblank_counter(struct intel_crtc *crtc)
u32 intel_crtc_max_vblank_count(const struct intel_crtc_state *crtc_state)
{
struct drm_i915_private *dev_priv = to_i915(crtc_state->uapi.crtc->dev);
- struct intel_crtc *crtc = to_intel_crtc(crtc_state->uapi.crtc);
- u32 mode_flags = crtc->mode_flags;
/*
* From Gen 11, In case of dsi cmd mode, frame counter wouldnt
@@ -62,7 +60,8 @@ u32 intel_crtc_max_vblank_count(const struct intel_crtc_state *crtc_state)
* the hw counter, then we would find it updated in only
* the next TE, hence switching to sw counter.
*/
- if (mode_flags & (I915_MODE_FLAG_DSI_USE_TE0 | I915_MODE_FLAG_DSI_USE_TE1))
+ if (crtc_state->mode_flags & (I915_MODE_FLAG_DSI_USE_TE0 |
+ I915_MODE_FLAG_DSI_USE_TE1))
return 0;
/*
--
2.26.2
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Silence pipe tracepoint WARNs
2021-03-04 17:04 [Intel-gfx] [PATCH 0/4] drm/i915: Silence pipe tracepoint WARNs Ville Syrjala
` (3 preceding siblings ...)
2021-03-04 17:04 ` [Intel-gfx] [PATCH 4/4] drm/i915: Fix DSI TE max_vblank_count handling Ville Syrjala
@ 2021-03-04 17:43 ` Patchwork
2021-03-04 19:20 ` [Intel-gfx] [PATCH 0/4] " Steven Rostedt
` (2 subsequent siblings)
7 siblings, 0 replies; 10+ messages in thread
From: Patchwork @ 2021-03-04 17:43 UTC (permalink / raw)
To: Ville Syrjala; +Cc: intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 4649 bytes --]
== Series Details ==
Series: drm/i915: Silence pipe tracepoint WARNs
URL : https://patchwork.freedesktop.org/series/87637/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_9831 -> Patchwork_19757
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19757/index.html
Known issues
------------
Here are the changes found in Patchwork_19757 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_gttfill@basic:
- fi-kbl-8809g: [PASS][1] -> [TIMEOUT][2] ([i915#3145])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9831/fi-kbl-8809g/igt@gem_exec_gttfill@basic.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19757/fi-kbl-8809g/igt@gem_exec_gttfill@basic.html
* igt@gem_huc_copy@huc-copy:
- fi-byt-j1900: NOTRUN -> [SKIP][3] ([fdo#109271]) +27 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19757/fi-byt-j1900/igt@gem_huc_copy@huc-copy.html
* igt@i915_selftest@live@hangcheck:
- fi-snb-2600: [PASS][4] -> [INCOMPLETE][5] ([i915#2782])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9831/fi-snb-2600/igt@i915_selftest@live@hangcheck.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19757/fi-snb-2600/igt@i915_selftest@live@hangcheck.html
* igt@kms_chamelium@hdmi-crc-fast:
- fi-byt-j1900: NOTRUN -> [SKIP][6] ([fdo#109271] / [fdo#111827]) +8 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19757/fi-byt-j1900/igt@kms_chamelium@hdmi-crc-fast.html
#### Possible fixes ####
* igt@gem_linear_blits@basic:
- fi-kbl-8809g: [TIMEOUT][7] ([i915#2502]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9831/fi-kbl-8809g/igt@gem_linear_blits@basic.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19757/fi-kbl-8809g/igt@gem_linear_blits@basic.html
* igt@gem_tiled_fence_blits@basic:
- fi-kbl-8809g: [TIMEOUT][9] ([i915#3145]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9831/fi-kbl-8809g/igt@gem_tiled_fence_blits@basic.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19757/fi-kbl-8809g/igt@gem_tiled_fence_blits@basic.html
* igt@i915_module_load@reload:
- fi-tgl-u2: [DMESG-WARN][11] ([i915#1982] / [k.org#205379]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9831/fi-tgl-u2/igt@i915_module_load@reload.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19757/fi-tgl-u2/igt@i915_module_load@reload.html
#### Warnings ####
* igt@i915_pm_rpm@module-reload:
- fi-glk-dsi: [DMESG-WARN][13] ([i915#1982]) -> [DMESG-WARN][14] ([i915#1982] / [i915#3143])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9831/fi-glk-dsi/igt@i915_pm_rpm@module-reload.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19757/fi-glk-dsi/igt@i915_pm_rpm@module-reload.html
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2502]: https://gitlab.freedesktop.org/drm/intel/issues/2502
[i915#2782]: https://gitlab.freedesktop.org/drm/intel/issues/2782
[i915#3143]: https://gitlab.freedesktop.org/drm/intel/issues/3143
[i915#3145]: https://gitlab.freedesktop.org/drm/intel/issues/3145
[k.org#205379]: https://bugzilla.kernel.org/show_bug.cgi?id=205379
Participating hosts (45 -> 41)
------------------------------
Additional (1): fi-byt-j1900
Missing (5): fi-ilk-m540 fi-hsw-4200u fi-bsw-n3050 fi-bsw-cyan fi-bdw-samus
Build changes
-------------
* Linux: CI_DRM_9831 -> Patchwork_19757
CI-20190529: 20190529
CI_DRM_9831: cd9d321c49fde8049da5a9569839aeffcb6fc964 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6022: 3c3d08ad629c404ace39256da334e4317b550de6 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_19757: d46ca721a906163531d0851c4fd201ca2bc2fd0f @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
d46ca721a906 drm/i915: Fix DSI TE max_vblank_count handling
929c4e1755da drm/i915: Return zero as the scanline counter for disabled pipes
620967eed766 drm/i915: Don't try to query the frame counter for disabled pipes
0753358edc3d drm/i915: Move pipe enable/disable tracepoints to intel_crtc_vblank_{on, off}()
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19757/index.html
[-- Attachment #1.2: Type: text/html, Size: 5722 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Intel-gfx] [PATCH 0/4] drm/i915: Silence pipe tracepoint WARNs
2021-03-04 17:04 [Intel-gfx] [PATCH 0/4] drm/i915: Silence pipe tracepoint WARNs Ville Syrjala
` (4 preceding siblings ...)
2021-03-04 17:43 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Silence pipe tracepoint WARNs Patchwork
@ 2021-03-04 19:20 ` Steven Rostedt
2021-03-05 15:38 ` Ville Syrjälä
2021-03-04 23:51 ` [Intel-gfx] ✗ Fi.CI.IGT: failure for " Patchwork
2021-03-05 8:45 ` [Intel-gfx] [PATCH 0/4] " Jani Nikula
7 siblings, 1 reply; 10+ messages in thread
From: Steven Rostedt @ 2021-03-04 19:20 UTC (permalink / raw)
To: Ville Syrjala; +Cc: intel-gfx
On Thu, 4 Mar 2021 19:04:17 +0200
Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> I believe this should silence the WARN spew from the
> pipe disable tracepoint Steve reported. And I tossed in
> a few other minor improvements as well.
>
> Cc: Steven Rostedt <rostedt@goodmis.org>
It seemed to have stopped the general protection faults when tracing all
events on my machine.
Reported-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
Tested-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
-- Steve
>
> Ville Syrjälä (4):
> drm/i915: Move pipe enable/disable tracepoints to
> intel_crtc_vblank_{on,off}()
> drm/i915: Don't try to query the frame counter for disabled pipes
> drm/i915: Return zero as the scanline counter for disabled pipes
> drm/i915: Fix DSI TE max_vblank_count handling
>
> drivers/gpu/drm/i915/display/intel_crtc.c | 24 +++++++++++++++++---
> drivers/gpu/drm/i915/display/intel_display.c | 8 +------
> drivers/gpu/drm/i915/i915_irq.c | 2 +-
> 3 files changed, 23 insertions(+), 11 deletions(-)
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Silence pipe tracepoint WARNs
2021-03-04 17:04 [Intel-gfx] [PATCH 0/4] drm/i915: Silence pipe tracepoint WARNs Ville Syrjala
` (5 preceding siblings ...)
2021-03-04 19:20 ` [Intel-gfx] [PATCH 0/4] " Steven Rostedt
@ 2021-03-04 23:51 ` Patchwork
2021-03-05 8:45 ` [Intel-gfx] [PATCH 0/4] " Jani Nikula
7 siblings, 0 replies; 10+ messages in thread
From: Patchwork @ 2021-03-04 23:51 UTC (permalink / raw)
To: Ville Syrjala; +Cc: intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 30262 bytes --]
== Series Details ==
Series: drm/i915: Silence pipe tracepoint WARNs
URL : https://patchwork.freedesktop.org/series/87637/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_9831_full -> Patchwork_19757_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_19757_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_19757_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_19757_full:
### IGT changes ###
#### Possible regressions ####
* igt@gem_mmap_gtt@big-copy-xy:
- shard-glk: [PASS][1] -> [FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9831/shard-glk9/igt@gem_mmap_gtt@big-copy-xy.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19757/shard-glk9/igt@gem_mmap_gtt@big-copy-xy.html
* igt@gem_mmap_offset@clear:
- shard-iclb: [PASS][3] -> [FAIL][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9831/shard-iclb3/igt@gem_mmap_offset@clear.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19757/shard-iclb8/igt@gem_mmap_offset@clear.html
Known issues
------------
Here are the changes found in Patchwork_19757_full that come from known issues:
### CI changes ###
#### Possible fixes ####
* boot:
- shard-skl: ([PASS][5], [PASS][6], [PASS][7], [PASS][8], [PASS][9], [PASS][10], [PASS][11], [PASS][12], [PASS][13], [PASS][14], [PASS][15], [PASS][16], [PASS][17], [PASS][18], [PASS][19], [PASS][20], [FAIL][21], [PASS][22], [PASS][23], [PASS][24], [PASS][25], [PASS][26], [PASS][27], [PASS][28]) ([i915#2813]) -> ([PASS][29], [PASS][30], [PASS][31], [PASS][32], [PASS][33], [PASS][34], [PASS][35], [PASS][36], [PASS][37], [PASS][38], [PASS][39], [PASS][40], [PASS][41], [PASS][42], [PASS][43], [PASS][44], [PASS][45], [PASS][46], [PASS][47], [PASS][48], [PASS][49], [PASS][50], [PASS][51], [PASS][52])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9831/shard-skl9/boot.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9831/shard-skl9/boot.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9831/shard-skl9/boot.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9831/shard-skl8/boot.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9831/shard-skl8/boot.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9831/shard-skl8/boot.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9831/shard-skl7/boot.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9831/shard-skl7/boot.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9831/shard-skl6/boot.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9831/shard-skl6/boot.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9831/shard-skl6/boot.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9831/shard-skl6/boot.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9831/shard-skl5/boot.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9831/shard-skl4/boot.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9831/shard-skl4/boot.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9831/shard-skl3/boot.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9831/shard-skl3/boot.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9831/shard-skl2/boot.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9831/shard-skl2/boot.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9831/shard-skl2/boot.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9831/shard-skl10/boot.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9831/shard-skl10/boot.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9831/shard-skl1/boot.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9831/shard-skl1/boot.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19757/shard-skl9/boot.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19757/shard-skl9/boot.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19757/shard-skl8/boot.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19757/shard-skl8/boot.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19757/shard-skl8/boot.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19757/shard-skl7/boot.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19757/shard-skl7/boot.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19757/shard-skl6/boot.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19757/shard-skl6/boot.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19757/shard-skl5/boot.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19757/shard-skl5/boot.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19757/shard-skl4/boot.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19757/shard-skl4/boot.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19757/shard-skl4/boot.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19757/shard-skl3/boot.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19757/shard-skl2/boot.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19757/shard-skl2/boot.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19757/shard-skl2/boot.html
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19757/shard-skl10/boot.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19757/shard-skl10/boot.html
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19757/shard-skl10/boot.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19757/shard-skl1/boot.html
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19757/shard-skl1/boot.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19757/shard-skl1/boot.html
### IGT changes ###
#### Issues hit ####
* igt@gem_create@create-clear:
- shard-glk: [PASS][53] -> [FAIL][54] ([i915#1888])
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9831/shard-glk8/igt@gem_create@create-clear.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19757/shard-glk4/igt@gem_create@create-clear.html
* igt@gem_ctx_persistence@legacy-engines-mixed:
- shard-snb: NOTRUN -> [SKIP][55] ([fdo#109271] / [i915#1099]) +3 similar issues
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19757/shard-snb6/igt@gem_ctx_persistence@legacy-engines-mixed.html
* igt@gem_eio@unwedge-stress:
- shard-tglb: [PASS][56] -> [TIMEOUT][57] ([i915#3063])
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9831/shard-tglb7/igt@gem_eio@unwedge-stress.html
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19757/shard-tglb8/igt@gem_eio@unwedge-stress.html
- shard-iclb: [PASS][58] -> [TIMEOUT][59] ([i915#2481] / [i915#3070])
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9831/shard-iclb3/igt@gem_eio@unwedge-stress.html
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19757/shard-iclb1/igt@gem_eio@unwedge-stress.html
* igt@gem_exec_fair@basic-pace@rcs0:
- shard-tglb: [PASS][60] -> [FAIL][61] ([i915#2842]) +1 similar issue
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9831/shard-tglb8/igt@gem_exec_fair@basic-pace@rcs0.html
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19757/shard-tglb5/igt@gem_exec_fair@basic-pace@rcs0.html
* igt@gem_exec_fair@basic-pace@vcs0:
- shard-iclb: [PASS][62] -> [FAIL][63] ([i915#2842])
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9831/shard-iclb8/igt@gem_exec_fair@basic-pace@vcs0.html
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19757/shard-iclb2/igt@gem_exec_fair@basic-pace@vcs0.html
* igt@gem_exec_fair@basic-pace@vcs1:
- shard-iclb: NOTRUN -> [FAIL][64] ([i915#2842])
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19757/shard-iclb2/igt@gem_exec_fair@basic-pace@vcs1.html
- shard-kbl: [PASS][65] -> [SKIP][66] ([fdo#109271])
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9831/shard-kbl1/igt@gem_exec_fair@basic-pace@vcs1.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19757/shard-kbl4/igt@gem_exec_fair@basic-pace@vcs1.html
* igt@gem_exec_fair@basic-throttle@rcs0:
- shard-glk: [PASS][67] -> [FAIL][68] ([i915#2842])
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9831/shard-glk7/igt@gem_exec_fair@basic-throttle@rcs0.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19757/shard-glk9/igt@gem_exec_fair@basic-throttle@rcs0.html
- shard-iclb: [PASS][69] -> [FAIL][70] ([i915#2849])
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9831/shard-iclb1/igt@gem_exec_fair@basic-throttle@rcs0.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19757/shard-iclb8/igt@gem_exec_fair@basic-throttle@rcs0.html
* igt@gem_exec_whisper@basic-fds-priority:
- shard-glk: [PASS][71] -> [DMESG-WARN][72] ([i915#118] / [i915#95]) +1 similar issue
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9831/shard-glk4/igt@gem_exec_whisper@basic-fds-priority.html
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19757/shard-glk3/igt@gem_exec_whisper@basic-fds-priority.html
* igt@gem_huc_copy@huc-copy:
- shard-tglb: [PASS][73] -> [SKIP][74] ([i915#2190])
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9831/shard-tglb2/igt@gem_huc_copy@huc-copy.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19757/shard-tglb6/igt@gem_huc_copy@huc-copy.html
- shard-apl: NOTRUN -> [SKIP][75] ([fdo#109271] / [i915#2190])
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19757/shard-apl3/igt@gem_huc_copy@huc-copy.html
* igt@gem_userptr_blits@input-checking:
- shard-apl: NOTRUN -> [DMESG-WARN][76] ([i915#3002])
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19757/shard-apl7/igt@gem_userptr_blits@input-checking.html
* igt@gem_userptr_blits@vma-merge:
- shard-snb: NOTRUN -> [FAIL][77] ([i915#2724])
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19757/shard-snb5/igt@gem_userptr_blits@vma-merge.html
* igt@gem_vm_create@destroy-race:
- shard-tglb: [PASS][78] -> [TIMEOUT][79] ([i915#2795])
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9831/shard-tglb2/igt@gem_vm_create@destroy-race.html
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19757/shard-tglb6/igt@gem_vm_create@destroy-race.html
* igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-dp:
- shard-apl: NOTRUN -> [SKIP][80] ([fdo#109271] / [i915#1937])
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19757/shard-apl7/igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-dp.html
* igt@i915_pm_rpm@modeset-non-lpsp-stress:
- shard-apl: NOTRUN -> [TIMEOUT][81] ([i915#1288])
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19757/shard-apl7/igt@i915_pm_rpm@modeset-non-lpsp-stress.html
* igt@kms_chamelium@hdmi-edid-change-during-suspend:
- shard-apl: NOTRUN -> [SKIP][82] ([fdo#109271] / [fdo#111827]) +17 similar issues
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19757/shard-apl2/igt@kms_chamelium@hdmi-edid-change-during-suspend.html
* igt@kms_color_chamelium@pipe-a-ctm-0-75:
- shard-kbl: NOTRUN -> [SKIP][83] ([fdo#109271] / [fdo#111827]) +1 similar issue
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19757/shard-kbl3/igt@kms_color_chamelium@pipe-a-ctm-0-75.html
* igt@kms_color_chamelium@pipe-d-ctm-red-to-blue:
- shard-skl: NOTRUN -> [SKIP][84] ([fdo#109271] / [fdo#111827]) +16 similar issues
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19757/shard-skl6/igt@kms_color_chamelium@pipe-d-ctm-red-to-blue.html
* igt@kms_color_chamelium@pipe-invalid-ctm-matrix-sizes:
- shard-snb: NOTRUN -> [SKIP][85] ([fdo#109271] / [fdo#111827]) +12 similar issues
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19757/shard-snb6/igt@kms_color_chamelium@pipe-invalid-ctm-matrix-sizes.html
* igt@kms_content_protection@lic:
- shard-apl: NOTRUN -> [TIMEOUT][86] ([i915#1319])
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19757/shard-apl7/igt@kms_content_protection@lic.html
* igt@kms_content_protection@uevent:
- shard-apl: NOTRUN -> [FAIL][87] ([i915#2105])
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19757/shard-apl2/igt@kms_content_protection@uevent.html
* igt@kms_cursor_edge_walk@pipe-d-128x128-right-edge:
- shard-skl: NOTRUN -> [SKIP][88] ([fdo#109271]) +111 similar issues
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19757/shard-skl10/igt@kms_cursor_edge_walk@pipe-d-128x128-right-edge.html
* igt@kms_cursor_legacy@cursora-vs-flipa-atomic:
- shard-skl: NOTRUN -> [DMESG-WARN][89] ([i915#1982])
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19757/shard-skl6/igt@kms_cursor_legacy@cursora-vs-flipa-atomic.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:
- shard-skl: NOTRUN -> [FAIL][90] ([i915#2346] / [i915#533])
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19757/shard-skl9/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
* igt@kms_cursor_legacy@pipe-d-single-bo:
- shard-apl: NOTRUN -> [SKIP][91] ([fdo#109271] / [i915#533])
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19757/shard-apl1/igt@kms_cursor_legacy@pipe-d-single-bo.html
* igt@kms_fbcon_fbt@fbc-suspend:
- shard-kbl: [PASS][92] -> [INCOMPLETE][93] ([i915#155] / [i915#180] / [i915#636])
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9831/shard-kbl2/igt@kms_fbcon_fbt@fbc-suspend.html
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19757/shard-kbl4/igt@kms_fbcon_fbt@fbc-suspend.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@c-edp1:
- shard-skl: [PASS][94] -> [FAIL][95] ([i915#79])
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9831/shard-skl4/igt@kms_flip@flip-vs-expired-vblank-interruptible@c-edp1.html
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19757/shard-skl10/igt@kms_flip@flip-vs-expired-vblank-interruptible@c-edp1.html
* igt@kms_flip@flip-vs-suspend-interruptible@a-dp1:
- shard-kbl: [PASS][96] -> [DMESG-WARN][97] ([i915#180]) +6 similar issues
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9831/shard-kbl3/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19757/shard-kbl1/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html
- shard-apl: NOTRUN -> [DMESG-WARN][98] ([i915#180])
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19757/shard-apl7/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html
* igt@kms_flip@plain-flip-fb-recreate@c-edp1:
- shard-skl: [PASS][99] -> [FAIL][100] ([i915#2122])
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9831/shard-skl10/igt@kms_flip@plain-flip-fb-recreate@c-edp1.html
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19757/shard-skl9/igt@kms_flip@plain-flip-fb-recreate@c-edp1.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile:
- shard-snb: NOTRUN -> [SKIP][101] ([fdo#109271]) +238 similar issues
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19757/shard-snb6/igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile.html
- shard-apl: NOTRUN -> [SKIP][102] ([fdo#109271] / [i915#2642])
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19757/shard-apl2/igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile.html
* igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-16bpp-ytile:
- shard-apl: NOTRUN -> [FAIL][103] ([i915#2641])
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19757/shard-apl1/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-16bpp-ytile.html
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-draw-blt:
- shard-kbl: NOTRUN -> [SKIP][104] ([fdo#109271]) +30 similar issues
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19757/shard-kbl3/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-draw-blt.html
* igt@kms_frontbuffer_tracking@psr-2p-primscrn-pri-indfb-draw-blt:
- shard-apl: NOTRUN -> [SKIP][105] ([fdo#109271]) +165 similar issues
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19757/shard-apl1/igt@kms_frontbuffer_tracking@psr-2p-primscrn-pri-indfb-draw-blt.html
* igt@kms_hdr@bpc-switch-dpms:
- shard-skl: [PASS][106] -> [FAIL][107] ([i915#1188])
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9831/shard-skl5/igt@kms_hdr@bpc-switch-dpms.html
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19757/shard-skl7/igt@kms_hdr@bpc-switch-dpms.html
* igt@kms_hdr@bpc-switch-suspend:
- shard-skl: NOTRUN -> [FAIL][108] ([i915#1188])
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19757/shard-skl5/igt@kms_hdr@bpc-switch-suspend.html
* igt@kms_pipe_crc_basic@disable-crc-after-crtc-pipe-d:
- shard-skl: NOTRUN -> [SKIP][109] ([fdo#109271] / [i915#533])
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19757/shard-skl6/igt@kms_pipe_crc_basic@disable-crc-after-crtc-pipe-d.html
* igt@kms_plane_alpha_blend@pipe-a-alpha-transparent-fb:
- shard-apl: NOTRUN -> [FAIL][110] ([i915#265])
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19757/shard-apl2/igt@kms_plane_alpha_blend@pipe-a-alpha-transparent-fb.html
* igt@kms_plane_alpha_blend@pipe-b-alpha-basic:
- shard-apl: NOTRUN -> [FAIL][111] ([fdo#108145] / [i915#265])
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19757/shard-apl3/igt@kms_plane_alpha_blend@pipe-b-alpha-basic.html
* igt@kms_plane_alpha_blend@pipe-c-constant-alpha-max:
- shard-skl: NOTRUN -> [FAIL][112] ([fdo#108145] / [i915#265])
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19757/shard-skl6/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-max.html
* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: [PASS][113] -> [FAIL][114] ([fdo#108145] / [i915#265])
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9831/shard-skl6/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19757/shard-skl2/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
* igt@kms_psr2_sf@cursor-plane-update-sf:
- shard-skl: NOTRUN -> [SKIP][115] ([fdo#109271] / [i915#658]) +2 similar issues
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19757/shard-skl6/igt@kms_psr2_sf@cursor-plane-update-sf.html
* igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-4:
- shard-apl: NOTRUN -> [SKIP][116] ([fdo#109271] / [i915#658]) +5 similar issues
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19757/shard-apl3/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-4.html
* igt@kms_psr@psr2_sprite_plane_move:
- shard-iclb: [PASS][117] -> [SKIP][118] ([fdo#109441]) +2 similar issues
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9831/shard-iclb2/igt@kms_psr@psr2_sprite_plane_move.html
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19757/shard-iclb4/igt@kms_psr@psr2_sprite_plane_move.html
* igt@kms_vblank@pipe-b-ts-continuation-suspend:
- shard-apl: [PASS][119] -> [DMESG-WARN][120] ([i915#180]) +1 similar issue
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9831/shard-apl3/igt@kms_vblank@pipe-b-ts-continuation-suspend.html
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19757/shard-apl8/igt@kms_vblank@pipe-b-ts-continuation-suspend.html
* igt@kms_writeback@writeback-fb-id:
- shard-apl: NOTRUN -> [SKIP][121] ([fdo#109271] / [i915#2437])
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19757/shard-apl2/igt@kms_writeback@writeback-fb-id.html
* igt@sysfs_clients@busy@vecs0:
- shard-kbl: [PASS][122] -> [FAIL][123] ([i915#3009])
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9831/shard-kbl2/igt@sysfs_clients@busy@vecs0.html
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19757/shard-kbl3/igt@sysfs_clients@busy@vecs0.html
* igt@sysfs_clients@split-10@rcs0:
- shard-apl: [PASS][124] -> [SKIP][125] ([fdo#109271] / [i915#3026])
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9831/shard-apl8/igt@sysfs_clients@split-10@rcs0.html
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19757/shard-apl3/igt@sysfs_clients@split-10@rcs0.html
#### Possible fixes ####
* igt@gem_ctx_isolation@preservation-s3@vcs1:
- shard-kbl: [DMESG-WARN][126] ([i915#180]) -> [PASS][127]
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9831/shard-kbl1/igt@gem_ctx_isolation@preservation-s3@vcs1.html
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19757/shard-kbl3/igt@gem_ctx_isolation@preservation-s3@vcs1.html
* igt@gem_eio@in-flight-contexts-immediate:
- shard-tglb: [TIMEOUT][128] ([i915#3063]) -> [PASS][129]
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9831/shard-tglb6/igt@gem_eio@in-flight-contexts-immediate.html
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19757/shard-tglb5/igt@gem_eio@in-flight-contexts-immediate.html
* igt@gem_exec_endless@dispatch@vcs0:
- shard-iclb: [INCOMPLETE][130] ([i915#2502]) -> [PASS][131]
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9831/shard-iclb3/igt@gem_exec_endless@dispatch@vcs0.html
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19757/shard-iclb1/igt@gem_exec_endless@dispatch@vcs0.html
* igt@gem_exec_fair@basic-deadline:
- shard-kbl: [FAIL][132] ([i915#2846]) -> [PASS][133]
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9831/shard-kbl4/igt@gem_exec_fair@basic-deadline.html
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19757/shard-kbl1/igt@gem_exec_fair@basic-deadline.html
* igt@gem_exec_fair@basic-none-solo@rcs0:
- shard-apl: [FAIL][134] ([i915#2842]) -> [PASS][135]
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9831/shard-apl7/igt@gem_exec_fair@basic-none-solo@rcs0.html
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19757/shard-apl6/igt@gem_exec_fair@basic-none-solo@rcs0.html
* igt@gem_exec_fair@basic-none@vcs0:
- shard-kbl: [FAIL][136] ([i915#2842]) -> [PASS][137]
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9831/shard-kbl3/igt@gem_exec_fair@basic-none@vcs0.html
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19757/shard-kbl7/igt@gem_exec_fair@basic-none@vcs0.html
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-tglb: [FAIL][138] ([i915#2842]) -> [PASS][139]
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9831/shard-tglb8/igt@gem_exec_fair@basic-pace-share@rcs0.html
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19757/shard-tglb8/igt@gem_exec_fair@basic-pace-share@rcs0.html
* igt@gem_exec_whisper@basic-queues-forked:
- shard-glk: [DMESG-WARN][140] ([i915#118] / [i915#95]) -> [PASS][141]
[140]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9831/shard-glk8/igt@gem_exec_whisper@basic-queues-forked.html
[141]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19757/shard-glk1/igt@gem_exec_whisper@basic-queues-forked.html
* igt@gem_mmap_gtt@big-copy-odd:
- shard-skl: [FAIL][142] -> [PASS][143] +1 similar issue
[142]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9831/shard-skl10/igt@gem_mmap_gtt@big-copy-odd.html
[143]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19757/shard-skl9/igt@gem_mmap_gtt@big-copy-odd.html
* igt@gem_mmap_gtt@cpuset-big-copy-odd:
- shard-iclb: [FAIL][144] ([i915#2428]) -> [PASS][145]
[144]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9831/shard-iclb5/igt@gem_mmap_gtt@cpuset-big-copy-odd.html
[145]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19757/shard-iclb2/igt@gem_mmap_gtt@cpuset-big-copy-odd.html
- shard-glk: [FAIL][146] -> [PASS][147]
[146]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9831/shard-glk9/igt@gem_mmap_gtt@cpuset-big-copy-odd.html
[147]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19757/shard-glk9/igt@gem_mmap_gtt@cpuset-big-copy-odd.html
* igt@kms_color@pipe-a-ctm-0-5:
- shard-skl: [DMESG-WARN][148] ([i915#1982]) -> [PASS][149] +1 similar issue
[148]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9831/shard-skl10/igt@kms_color@pipe-a-ctm-0-5.html
[149]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19757/shard-skl7/igt@kms_color@pipe-a-ctm-0-5.html
* igt@kms_cursor_crc@pipe-a-cursor-256x85-onscreen:
- shard-skl: [FAIL][150] ([i915#54]) -> [PASS][151] +1 similar issue
[150]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9831/shard-skl8/igt@kms_cursor_crc@pipe-a-cursor-256x85-onscreen.html
[151]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19757/shard-skl4/igt@kms_cursor_crc@pipe-a-cursor-256x85-onscreen.html
* igt@kms_cursor_legacy@flip-vs-cursor-toggle:
- shard-tglb: [FAIL][152] ([i915#2346]) -> [PASS][153]
[152]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9831/shard-tglb2/igt@kms_cursor_legacy@flip-vs-cursor-toggle.html
[153]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19757/shard-tglb6/igt@kms_cursor_legacy@flip-vs-cursor-toggle.html
* igt@kms_flip@flip-vs-suspend-interruptible@c-edp1:
- shard-skl: [INCOMPLETE][154] ([i915#198]) -> [PASS][155]
[154]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9831/shard-skl2/igt@kms_flip@flip-vs-suspend-interruptible@c-edp1.html
[155]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19757/shard-skl5/igt@kms_flip@flip-vs-suspend-interruptible@c-edp1.html
* igt@kms_flip@flip-vs-suspend@c-dp1:
- shard-apl: [DMESG-WARN][156] ([i915#180]) -> [PASS][157] +1 similar issue
[156]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9831/shard-apl6/igt@kms_flip@flip-vs-suspend@c-dp1.html
[157]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19757/shard-apl7/igt@kms_flip@flip-vs-suspend@c-dp1.html
* igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min:
- shard-apl: [FAIL][158] ([fdo#108145] / [i915#265]) -> [PASS][159]
[158]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9831/shard-apl2/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min.html
[159]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19757/shard-apl7/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min.html
* igt@kms_psr2_su@frontbuffer:
- shard-iclb: [SKIP][160] ([fdo#109642] / [fdo#111068] / [i915#658]) -> [PASS][161]
[160]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9831/shard-iclb8/igt@kms_psr2_su@frontbuffer.html
[161]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19757/shard-iclb2/igt@kms_psr2_su@frontbuffer.html
* igt@kms_psr@psr2_suspend:
- shard-iclb: [SKIP][162] ([fdo#109441]) -> [PASS][163]
[162]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9831/shard-iclb5/igt@kms_psr@psr2_suspend.html
[163]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19757/shard-iclb2/igt@kms_psr@psr2_suspend.html
* igt@sysfs_clients@recycle:
- shard-glk: [FAIL][164] ([i915#3028]) -> [PASS][165]
[164]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9831/shard-glk1/igt@sysfs_clients@recycle.html
[165]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19757/shard-glk8/igt@sysfs_clients@recycle.html
* igt@sysfs_clients@recycle-many:
- shard-iclb: [FAIL][166] ([i915#3028]) -> [PASS][167] +1 similar issue
[166]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9831/shard-iclb6/igt@sysfs_clients@recycle-many.html
[167]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19757/shard-iclb5/igt@sysfs_clients@recycle-many.html
- shard-tglb: [FAIL][168] ([i915#3028]) -> [PASS][169] +1 similar issue
[168]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9831/shard-tglb6/igt@sysfs_clients@recycle-many.html
[169]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19757/shard-tglb3/igt@sysfs_clients@recycle-many.html
* igt@sysfs_clients@split-10@vcs0:
- shard-apl: [SKIP][170] ([fdo#109271] / [i915#3026]) -> [PASS][171]
[170]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9831/shard-apl8/igt@sysfs_clients@split-10@vcs0.html
[171]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19757/shard-apl3/igt@sysfs_clients@split-10@vcs0.html
* igt@sysfs_heartbeat_interval@mixed@vecs0:
- shard-kbl: [INCOMPLETE][172] ([i915#1731]) -> [PASS][173]
[172]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9831/shard-kbl6/igt@sysfs_heartbeat_interval@mixed@vecs0.html
[173]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19757/shard-kbl6/igt@sysfs_heartbeat_interval@mixed@vecs0.html
#### Warnings ####
* igt@gem_exec_balancer@hang:
- shard-iclb: [INCOMPLETE][174] ([i915#1895]) -> [INCOMPLETE][175] ([i915#1895] / [i915#3031])
[174]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9831/shard-iclb2/igt@gem_exec_balancer@hang.html
[175]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_1975
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19757/index.html
[-- Attachment #1.2: Type: text/html, Size: 33388 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Intel-gfx] [PATCH 0/4] drm/i915: Silence pipe tracepoint WARNs
2021-03-04 17:04 [Intel-gfx] [PATCH 0/4] drm/i915: Silence pipe tracepoint WARNs Ville Syrjala
` (6 preceding siblings ...)
2021-03-04 23:51 ` [Intel-gfx] ✗ Fi.CI.IGT: failure for " Patchwork
@ 2021-03-05 8:45 ` Jani Nikula
7 siblings, 0 replies; 10+ messages in thread
From: Jani Nikula @ 2021-03-05 8:45 UTC (permalink / raw)
To: Ville Syrjala, intel-gfx; +Cc: Steven Rostedt
On Thu, 04 Mar 2021, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> I believe this should silence the WARN spew from the
> pipe disable tracepoint Steve reported. And I tossed in
> a few other minor improvements as well.
On some of the patches I'll just have to take your word for what it says
in the commit messages, but the patches do what they say. On the series,
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
>
> Cc: Steven Rostedt <rostedt@goodmis.org>
>
> Ville Syrjälä (4):
> drm/i915: Move pipe enable/disable tracepoints to
> intel_crtc_vblank_{on,off}()
> drm/i915: Don't try to query the frame counter for disabled pipes
> drm/i915: Return zero as the scanline counter for disabled pipes
> drm/i915: Fix DSI TE max_vblank_count handling
>
> drivers/gpu/drm/i915/display/intel_crtc.c | 24 +++++++++++++++++---
> drivers/gpu/drm/i915/display/intel_display.c | 8 +------
> drivers/gpu/drm/i915/i915_irq.c | 2 +-
> 3 files changed, 23 insertions(+), 11 deletions(-)
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Intel-gfx] [PATCH 0/4] drm/i915: Silence pipe tracepoint WARNs
2021-03-04 19:20 ` [Intel-gfx] [PATCH 0/4] " Steven Rostedt
@ 2021-03-05 15:38 ` Ville Syrjälä
0 siblings, 0 replies; 10+ messages in thread
From: Ville Syrjälä @ 2021-03-05 15:38 UTC (permalink / raw)
To: Steven Rostedt; +Cc: intel-gfx
On Thu, Mar 04, 2021 at 02:20:22PM -0500, Steven Rostedt wrote:
> On Thu, 4 Mar 2021 19:04:17 +0200
> Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
>
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > I believe this should silence the WARN spew from the
> > pipe disable tracepoint Steve reported. And I tossed in
> > a few other minor improvements as well.
> >
> > Cc: Steven Rostedt <rostedt@goodmis.org>
>
> It seemed to have stopped the general protection faults when tracing all
> events on my machine.
>
> Reported-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
> Tested-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
Series pushed to drm-intel-next. Thanks for reporting the problem.
>
> -- Steve
>
> >
> > Ville Syrjälä (4):
> > drm/i915: Move pipe enable/disable tracepoints to
> > intel_crtc_vblank_{on,off}()
> > drm/i915: Don't try to query the frame counter for disabled pipes
> > drm/i915: Return zero as the scanline counter for disabled pipes
> > drm/i915: Fix DSI TE max_vblank_count handling
> >
> > drivers/gpu/drm/i915/display/intel_crtc.c | 24 +++++++++++++++++---
> > drivers/gpu/drm/i915/display/intel_display.c | 8 +------
> > drivers/gpu/drm/i915/i915_irq.c | 2 +-
> > 3 files changed, 23 insertions(+), 11 deletions(-)
> >
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2021-03-05 15:38 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-04 17:04 [Intel-gfx] [PATCH 0/4] drm/i915: Silence pipe tracepoint WARNs Ville Syrjala
2021-03-04 17:04 ` [Intel-gfx] [PATCH 1/4] drm/i915: Move pipe enable/disable tracepoints to intel_crtc_vblank_{on, off}() Ville Syrjala
2021-03-04 17:04 ` [Intel-gfx] [PATCH 2/4] drm/i915: Don't try to query the frame counter for disabled pipes Ville Syrjala
2021-03-04 17:04 ` [Intel-gfx] [PATCH 3/4] drm/i915: Return zero as the scanline " Ville Syrjala
2021-03-04 17:04 ` [Intel-gfx] [PATCH 4/4] drm/i915: Fix DSI TE max_vblank_count handling Ville Syrjala
2021-03-04 17:43 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Silence pipe tracepoint WARNs Patchwork
2021-03-04 19:20 ` [Intel-gfx] [PATCH 0/4] " Steven Rostedt
2021-03-05 15:38 ` Ville Syrjälä
2021-03-04 23:51 ` [Intel-gfx] ✗ Fi.CI.IGT: failure for " Patchwork
2021-03-05 8:45 ` [Intel-gfx] [PATCH 0/4] " Jani Nikula
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.