From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E93AC433DB for ; Thu, 4 Mar 2021 19:36:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3AF3F64F64 for ; Thu, 4 Mar 2021 19:36:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234691AbhCDTgU (ORCPT ); Thu, 4 Mar 2021 14:36:20 -0500 Received: from mail.kernel.org ([198.145.29.99]:45124 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230409AbhCDTfq (ORCPT ); Thu, 4 Mar 2021 14:35:46 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 320AE64F60; Thu, 4 Mar 2021 19:35:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1614886506; bh=yYKWZ6QndHwWfsOdgKSOMpZxTE7UTXV1JxyvIovkYDE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZpNz8lFeg3deiGdXUSucIiLylskK5XGCqj1AwyqBAb+2N8gZ5XpzwPPTSSHvhQoEx ehvWad8VPCVuHb/IPoGG9lnq9HMJstraBLRB+ntMWb/3Qss8JcVGqLtoic7SHvG5Bb AjFJ5CIAWumqND6y6Ys73womqixyps7o6Zpy7QWU8YYAOcq+Dkm5GLmEutN9D8ykRh w/qrsBjcwcX1jkDf6avPi3fDaVD/G91LUCi/8R70jepn057vy7WEET763yakPLpuDp AsfovY+zS9jTC+Zzw7V3u7ZCgoc3mOPGNr8R3A4lEjlvuoMuvNeezxn9Qp5qFy4p/t 7KNucS/DhjuLQ== Date: Thu, 4 Mar 2021 19:35:00 +0000 From: Will Deacon To: Quentin Perret Cc: catalin.marinas@arm.com, maz@kernel.org, james.morse@arm.com, julien.thierry.kdev@gmail.com, suzuki.poulose@arm.com, android-kvm@google.com, linux-kernel@vger.kernel.org, kernel-team@android.com, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, tabba@google.com, mark.rutland@arm.com, dbrazdil@google.com, mate.toth-pal@arm.com, seanjc@google.com, robh+dt@kernel.org Subject: Re: [PATCH v3 20/32] KVM: arm64: Refactor kvm_arm_setup_stage2() Message-ID: <20210304193459.GA21950@willie-the-truck> References: <20210302150002.3685113-1-qperret@google.com> <20210302150002.3685113-21-qperret@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210302150002.3685113-21-qperret@google.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 02, 2021 at 02:59:50PM +0000, Quentin Perret wrote: > In order to re-use some of the stage 2 setup code at EL2, factor parts > of kvm_arm_setup_stage2() out into separate functions. > > No functional change intended. > > Signed-off-by: Quentin Perret > --- > arch/arm64/include/asm/kvm_pgtable.h | 26 +++++++++++++++++ > arch/arm64/kvm/hyp/pgtable.c | 32 +++++++++++++++++++++ > arch/arm64/kvm/reset.c | 42 +++------------------------- > 3 files changed, 62 insertions(+), 38 deletions(-) Looks much better than the big header in v2, thanks! Acked-by: Will Deacon Will From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4100C433DB for ; Thu, 4 Mar 2021 19:35:12 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id 3901864F6D for ; Thu, 4 Mar 2021 19:35:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3901864F6D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id B3EEC4B439; Thu, 4 Mar 2021 14:35:11 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@kernel.org Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9KS+S0sGr-L5; Thu, 4 Mar 2021 14:35:09 -0500 (EST) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 257944B43D; Thu, 4 Mar 2021 14:35:09 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 15E504B349 for ; Thu, 4 Mar 2021 14:35:08 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 4mKyzYnOTz0M for ; Thu, 4 Mar 2021 14:35:07 -0500 (EST) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id 071C74B33E for ; Thu, 4 Mar 2021 14:35:06 -0500 (EST) Received: by mail.kernel.org (Postfix) with ESMTPSA id 320AE64F60; Thu, 4 Mar 2021 19:35:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1614886506; bh=yYKWZ6QndHwWfsOdgKSOMpZxTE7UTXV1JxyvIovkYDE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZpNz8lFeg3deiGdXUSucIiLylskK5XGCqj1AwyqBAb+2N8gZ5XpzwPPTSSHvhQoEx ehvWad8VPCVuHb/IPoGG9lnq9HMJstraBLRB+ntMWb/3Qss8JcVGqLtoic7SHvG5Bb AjFJ5CIAWumqND6y6Ys73womqixyps7o6Zpy7QWU8YYAOcq+Dkm5GLmEutN9D8ykRh w/qrsBjcwcX1jkDf6avPi3fDaVD/G91LUCi/8R70jepn057vy7WEET763yakPLpuDp AsfovY+zS9jTC+Zzw7V3u7ZCgoc3mOPGNr8R3A4lEjlvuoMuvNeezxn9Qp5qFy4p/t 7KNucS/DhjuLQ== Date: Thu, 4 Mar 2021 19:35:00 +0000 From: Will Deacon To: Quentin Perret Subject: Re: [PATCH v3 20/32] KVM: arm64: Refactor kvm_arm_setup_stage2() Message-ID: <20210304193459.GA21950@willie-the-truck> References: <20210302150002.3685113-1-qperret@google.com> <20210302150002.3685113-21-qperret@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210302150002.3685113-21-qperret@google.com> User-Agent: Mutt/1.10.1 (2018-07-13) Cc: android-kvm@google.com, catalin.marinas@arm.com, mate.toth-pal@arm.com, seanjc@google.com, tabba@google.com, linux-kernel@vger.kernel.org, robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org, maz@kernel.org, kernel-team@android.com, kvmarm@lists.cs.columbia.edu X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu On Tue, Mar 02, 2021 at 02:59:50PM +0000, Quentin Perret wrote: > In order to re-use some of the stage 2 setup code at EL2, factor parts > of kvm_arm_setup_stage2() out into separate functions. > > No functional change intended. > > Signed-off-by: Quentin Perret > --- > arch/arm64/include/asm/kvm_pgtable.h | 26 +++++++++++++++++ > arch/arm64/kvm/hyp/pgtable.c | 32 +++++++++++++++++++++ > arch/arm64/kvm/reset.c | 42 +++------------------------- > 3 files changed, 62 insertions(+), 38 deletions(-) Looks much better than the big header in v2, thanks! Acked-by: Will Deacon Will _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B13BC433DB for ; Thu, 4 Mar 2021 19:37:18 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 649C164F60 for ; Thu, 4 Mar 2021 19:37:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 649C164F60 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=xpskzRq1Sp712AZ7NgsYrcb8jZxqHRoRWlqkGcCpUYo=; b=MC4zuQXcArEzHmh8ICMn1rqui cpURrbPajFS+ZyvGpzKPW9Hkf6i2PHOV9VlBkCSgcNHL1gOU5hwPuSuojhijn/U86u0uX904QFw68 o6hVF4Fb7Cu78E36D9X/rpy42WFdEaz3ebdONFzb8cACfig1gOCA3bG0gpygOxffN0kC7CJZda0qM sSyCCMDEjkyn0KqdldaeHe0xT5TvEmGRHMPYCPoBCOA5gehpKX+rSYQZC3N3H2N1sf26SdMi0xJsO LuBX5vfH7s7KvVkNVxC3oOkxJwllS0FX6l+hwhJcz5B9BhWX0VIdqfbRQ/oC7qrsYV5+QZzIdntq7 08lmyFVzA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lHtki-009mrP-9o; Thu, 04 Mar 2021 19:35:16 +0000 Received: from mail.kernel.org ([198.145.29.99]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lHtkZ-009mqF-59 for linux-arm-kernel@lists.infradead.org; Thu, 04 Mar 2021 19:35:08 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 320AE64F60; Thu, 4 Mar 2021 19:35:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1614886506; bh=yYKWZ6QndHwWfsOdgKSOMpZxTE7UTXV1JxyvIovkYDE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZpNz8lFeg3deiGdXUSucIiLylskK5XGCqj1AwyqBAb+2N8gZ5XpzwPPTSSHvhQoEx ehvWad8VPCVuHb/IPoGG9lnq9HMJstraBLRB+ntMWb/3Qss8JcVGqLtoic7SHvG5Bb AjFJ5CIAWumqND6y6Ys73womqixyps7o6Zpy7QWU8YYAOcq+Dkm5GLmEutN9D8ykRh w/qrsBjcwcX1jkDf6avPi3fDaVD/G91LUCi/8R70jepn057vy7WEET763yakPLpuDp AsfovY+zS9jTC+Zzw7V3u7ZCgoc3mOPGNr8R3A4lEjlvuoMuvNeezxn9Qp5qFy4p/t 7KNucS/DhjuLQ== Date: Thu, 4 Mar 2021 19:35:00 +0000 From: Will Deacon To: Quentin Perret Cc: catalin.marinas@arm.com, maz@kernel.org, james.morse@arm.com, julien.thierry.kdev@gmail.com, suzuki.poulose@arm.com, android-kvm@google.com, linux-kernel@vger.kernel.org, kernel-team@android.com, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, tabba@google.com, mark.rutland@arm.com, dbrazdil@google.com, mate.toth-pal@arm.com, seanjc@google.com, robh+dt@kernel.org Subject: Re: [PATCH v3 20/32] KVM: arm64: Refactor kvm_arm_setup_stage2() Message-ID: <20210304193459.GA21950@willie-the-truck> References: <20210302150002.3685113-1-qperret@google.com> <20210302150002.3685113-21-qperret@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210302150002.3685113-21-qperret@google.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Mar 02, 2021 at 02:59:50PM +0000, Quentin Perret wrote: > In order to re-use some of the stage 2 setup code at EL2, factor parts > of kvm_arm_setup_stage2() out into separate functions. > > No functional change intended. > > Signed-off-by: Quentin Perret > --- > arch/arm64/include/asm/kvm_pgtable.h | 26 +++++++++++++++++ > arch/arm64/kvm/hyp/pgtable.c | 32 +++++++++++++++++++++ > arch/arm64/kvm/reset.c | 42 +++------------------------- > 3 files changed, 62 insertions(+), 38 deletions(-) Looks much better than the big header in v2, thanks! Acked-by: Will Deacon Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel