From: Denys Dmytriyenko <denis@denix.org>
To: Nishanth Menon <nm@ti.com>
Cc: meta-arago <meta-arago@arago-project.org>
Subject: Re: [PATCH dunfell] cryptodev: Move to 1.12 revision
Date: Thu, 4 Mar 2021 14:48:36 -0500 [thread overview]
Message-ID: <20210304194836.GK4892@denix.org> (raw)
In-Reply-To: <20210304184811.GF4892@denix.org>
BTW, you'd need to ensure updating cryptodev from 1.10 to 1.12 does not affect
current 5.4-based builds and/or releases. I'm sure it will build fine against
this older kernel (most of Makefile changes), but concerned about any run-time
regressions (the actual code changes).
On Thu, Mar 04, 2021 at 01:48:11PM -0500, Denys Dmytriyenko wrote:
> On Thu, Mar 04, 2021 at 12:52:00AM -0600, Nishanth Menon wrote:
> > Cryptodev out of kernel module and suite has yet another set of
> > challenge with broken API compatibility. However, the complete list of
> > patches beteween dunfell's default 1.10 and current latest 1.12 revisions:
> > e0c25e289d6b (tag: cryptodev-linux-1.12) Release version 1.12
> > 55c6315058fc Fix build for Linux 5.11-rc1
> > 2f5e08aebf92 Fix build for Linux 5.9-rc1
> > e8263d2d682b remove VLA usage from authenc.c
> > dafa42cadc86 Fix for change in Kernel 4.4.168
> > f4d3653c8dcb Release version 1.11
> > 9e765068582a Fix build for Linux 5.8-rc1
> > 7e72f6758f2d enabled the support for TLS1.1 - AES128-SHA1 - AES256-SHA1
> > 98b163a23f6b cryptlib.c: fix build on kernel v5.5+
> > a1e738aef624 tests: cipher-aead-srtp: Fix cao->dst alignment
> > f971e0cd4a0e Fix module loading with Linux v5.0-rc5
> >
> > We have the following choices
> > 1) just cherry-pick minimum set of kernel patches relevant for kernel
> > compatibility
> > OR
> > 2) switch to a newer version with richer set of fixups
> >
> > Attempting to switch to 1.12 version with minimal changes as a better
> > option to get a wider swath of kernel compatibility.
> >
> > Signed-off-by: Nishanth Menon <nm@ti.com>
> > ---
> >
> > DISCLAIMER: This is probably a dumb way of switching to 1.12.. open to
> > suggestions.
>
> It is still probably the cleanest - just 2 vars in 3 bbappends. You might want
> to mention that you need this for 5.10 (or 5.9+) kernel upgrade.
>
> The issue is due to upgrading the kernel from one LTS to the next, while
> staying on the older Yocto LTS, which was 5.4-specific... BTW, I haven't yet
> reviewed your meta-ti patches, will do that next.
>
>
> > NOTE:
> > a) master is already on 1.12 -> So, I am suggesting this only for dunfell at the
> > moment: http://git.openembedded.org/openembedded-core/tree/meta/recipes-kernel/cryptodev?h=master
> >
> > b) gatesgarth is on 1.11 -> we wont get the fixes needed for newer
> > kernel, so a variant of this will be needed.. http://git.openembedded.org/openembedded-core/tree/meta/recipes-kernel/cryptodev?h=gatesgarth
> >
> > c) dunfell is still on 1.10 -> Same story as gatesgarth.. http://git.openembedded.org/openembedded-core/tree/meta/recipes-kernel/cryptodev?h=dunfell
> >
> > .../recipes-kernel/cryptodev/cryptodev-linux_%.bbappend | 5 +++++
> > .../recipes-kernel/cryptodev/cryptodev-module_%.bbappend | 5 +++++
> > .../recipes-kernel/cryptodev/cryptodev-tests_%.bbappend | 6 ++++++
> > 3 files changed, 16 insertions(+)
> > create mode 100644 meta-arago-distro/recipes-kernel/cryptodev/cryptodev-linux_%.bbappend
> > create mode 100644 meta-arago-distro/recipes-kernel/cryptodev/cryptodev-tests_%.bbappend
> >
> > diff --git a/meta-arago-distro/recipes-kernel/cryptodev/cryptodev-linux_%.bbappend b/meta-arago-distro/recipes-kernel/cryptodev/cryptodev-linux_%.bbappend
> > new file mode 100644
> > index 000000000000..a3fb634463fd
> > --- /dev/null
> > +++ b/meta-arago-distro/recipes-kernel/cryptodev/cryptodev-linux_%.bbappend
> > @@ -0,0 +1,5 @@
> > +# Bring in fixes including https://github.com/cryptodev-linux/cryptodev-linux/pull/55
> > +# just pull 1.12 revision, everything else remains the same.
> > +PR = "1.12"
>
> PV here. Stands for Package Version. And PR is for Package Revision (i.e.
> repackaging of the same version)
>
>
> > +PR_append = ".arago0"
>
> Not necessarily needed, if PV is set correctly _and_ SRCREV matches the one
> from OE-Core master for 1.12.
>
>
> > +SRCREV = "e0c25e289d6baf1d83c2b9cb523d3bc237d0c0c9"
> > diff --git a/meta-arago-distro/recipes-kernel/cryptodev/cryptodev-module_%.bbappend b/meta-arago-distro/recipes-kernel/cryptodev/cryptodev-module_%.bbappend
> > index f8a35cd73765..602ada0daf3a 100644
> > --- a/meta-arago-distro/recipes-kernel/cryptodev/cryptodev-module_%.bbappend
> > +++ b/meta-arago-distro/recipes-kernel/cryptodev/cryptodev-module_%.bbappend
> > @@ -1,3 +1,8 @@
> > +# Bring in fixes including https://github.com/cryptodev-linux/cryptodev-linux/pull/55
> > +# just pull 1.12 revision, everything else remains the same.
> > +
> > +PR = "1.12"
>
> Same.
>
>
> > PR_append = ".arago0"
>
> This one was already there due to KERNEL_MODULE_AUTOLOAD below.
>
>
> > +SRCREV = "e0c25e289d6baf1d83c2b9cb523d3bc237d0c0c9"
> >
> > KERNEL_MODULE_AUTOLOAD += "cryptodev"
> > diff --git a/meta-arago-distro/recipes-kernel/cryptodev/cryptodev-tests_%.bbappend b/meta-arago-distro/recipes-kernel/cryptodev/cryptodev-tests_%.bbappend
> > new file mode 100644
> > index 000000000000..dee8f40862cb
> > --- /dev/null
> > +++ b/meta-arago-distro/recipes-kernel/cryptodev/cryptodev-tests_%.bbappend
> > @@ -0,0 +1,6 @@
> > +# Bring in fixes including https://github.com/cryptodev-linux/cryptodev-linux/pull/55
> > +# just pull 1.12 revision, everything else remains the same.
> > +
> > +PR = "1.12"
>
> Same.
>
>
> > +PR_append = ".arago0"
>
> Same.
>
>
> > +SRCREV = "e0c25e289d6baf1d83c2b9cb523d3bc237d0c0c9"
> > --
> > 2.25.1.377.g2d2118b814c1
> >
> > _______________________________________________
> > meta-arago mailing list
> > meta-arago@arago-project.org
> > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
> >
>
> --
> Regards,
> Denys Dmytriyenko <denis@denix.org>
> PGP: 0x420902729A92C964 - https://denix.org/0x420902729A92C964
> Fingerprint: 25FC E4A5 8A72 2F69 1186 6D76 4209 0272 9A92 C964
> _______________________________________________
> meta-arago mailing list
> meta-arago@arago-project.org
> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
>
next prev parent reply other threads:[~2021-03-04 19:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-04 6:52 [PATCH dunfell] cryptodev: Move to 1.12 revision Nishanth Menon
2021-03-04 18:48 ` Denys Dmytriyenko
2021-03-04 19:48 ` Denys Dmytriyenko [this message]
2021-03-04 23:14 ` Nishanth Menon
2021-03-05 0:58 ` Denys Dmytriyenko
2021-03-05 1:24 ` Nishanth Menon
2021-03-05 2:26 ` Denys Dmytriyenko
2021-03-05 2:34 ` Nishanth Menon
2021-03-04 23:18 ` Nishanth Menon
2021-03-05 0:27 ` Denys Dmytriyenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210304194836.GK4892@denix.org \
--to=denis@denix.org \
--cc=meta-arago@arago-project.org \
--cc=nm@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.