All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Winkler <danielwinkler@google.com>
To: linux-bluetooth@vger.kernel.org, luiz.dentz@gmail.com
Cc: chromeos-bluetooth-upstreaming@chromium.org,
	Daniel Winkler <danielwinkler@google.com>
Subject: [Bluez PATCH v2 0/3] Bluetooth: Fix scannable broadcast advertising on extended APIs
Date: Thu,  4 Mar 2021 12:24:49 -0800	[thread overview]
Message-ID: <20210304202452.1998022-1-danielwinkler@google.com> (raw)

Hello Maintainers,

We have discovered that when userspace registers a broadcast
(non-connectable) advertisement with scan response data, it exposes a
limitation in the new extended MGMT APIs. At the time that the
parameters are registered with the controller, kernel does not yet have
the advertising data and scan response (coming in a separate MGMT call),
and will default to a non-scannable PDU. When the MGMT call for
data/scan response is received, the controller will either fail when we
request to set the scan response, or return success and not use it.

This series along with another in kernel will allow userspace to pass a
flag with the params request indicating if the advertisement contains a
scan response. This allows kernel to register the parameters correctly
with the controller.

The patch is tested with a scannable broadcast advertisement on Hatch
and Kukui chromebooks (ext and non-ext capabilities) and ensuring a
peripheral device can detect the scan response.

Best,
Daniel

Changes in v2:
- Check kernel supports flag before setting it

Daniel Winkler (3):
  advertising: Generate advertising data earlier in pipeline
  advertising: Create and use scannable adv param flag
  doc/mgmt-api: Update documentation for scan_rsp param flag

 doc/mgmt-api.txt  |  5 +++
 lib/mgmt.h        |  1 +
 src/advertising.c | 87 ++++++++++++++++++++++++++---------------------
 3 files changed, 55 insertions(+), 38 deletions(-)

-- 
2.30.1.766.gb4fecdf3b7-goog


             reply	other threads:[~2021-03-04 20:26 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-04 20:24 Daniel Winkler [this message]
2021-03-04 20:24 ` [Bluez PATCH v2 1/3] advertising: Generate advertising data earlier in pipeline Daniel Winkler
2021-03-04 22:49   ` Luiz Augusto von Dentz
2021-03-04 23:27     ` Daniel Winkler
2021-03-04 23:43       ` Luiz Augusto von Dentz
2021-03-16 22:51         ` Daniel Winkler
2021-03-04 20:24 ` [Bluez PATCH v2 2/3] advertising: Create and use scannable adv param flag Daniel Winkler
2021-03-04 20:24 ` [Bluez PATCH v2 3/3] doc/mgmt-api: Update documentation for scan_rsp " Daniel Winkler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210304202452.1998022-1-danielwinkler@google.com \
    --to=danielwinkler@google.com \
    --cc=chromeos-bluetooth-upstreaming@chromium.org \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=luiz.dentz@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.