All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Nikhil Devshatwar" <nikhil.nd@ti.com>
To: Denys Dmytriyenko <denis@denix.org>, <meta-ti@yoctoproject.org>,
	<praneeth@ti.com>, <lokeshvutla@ti.com>, <kishon@ti.com>,
	<nsekhar@ti.com>, <hnagalla@ti.com>, <saurabhnarang@ti.com>
Subject: Re: [meta-ti][PATCH] recipes-bsp: wl18xx-fw: update SRCREV to latest
Date: Fri, 5 Mar 2021 16:00:55 +0530	[thread overview]
Message-ID: <20210305103055.3uf5ypbaxsx2yezb@NiksLab> (raw)
In-Reply-To: <166969EA2A6821A6.22430@lists.yoctoproject.org>

On 15:29-20210305, Nikhil Devshatwar via lists.yoctoproject.org wrote:
> On 13:17-20210303, Denys Dmytriyenko wrote:
> > On Wed, Mar 03, 2021 at 11:39:17PM +0530, Nikhil Devshatwar via lists.yoctoproject.org wrote:
> > > Update the wl18xx firmware recipe to latest version 8.9.0.0.86
> > 
> > Do you also need to update the version from 8.7.3 to 8.9.x?
> 
> I am not sure how the recipe version is decided.
> Old commit ID had the firmware version 8.9.0.0.76 which is now
> changed to 8.9.0.0.86
> 
> I don't know how the recipe version is tied to the firmware version.
> Hari, Do you know?

I looked at the git history of the firmware and the last commit was
tagged with R8.7_SP3 Maybe this is used to derive the firmware version
8.7.3

But since the last tag in 2017, there haven't been new tags but the
firmware has been updated 7 times.

In this case, the recipe is adding only a single file, so let's just use
the firmware version in the recipe rather than using tags from the repo.

While at it, maybe it does not make sense to keep renaming the file for
every version change, so we just make it _git.bb and set
PV += "8.9.0.0.86"

Regards,
Nikhil Devshatwar

> 
> Regards,
> Nikhil Devshatwar
> > 
> > 
> > > Signed-off-by: Nikhil Devshatwar <nikhil.nd@ti.com>
> > > ---
> > >  recipes-bsp/wl18xx-fw/wl18xx-fw_8.7.3.bb | 3 +--
> > >  1 file changed, 1 insertion(+), 2 deletions(-)
> > > 
> > > diff --git a/recipes-bsp/wl18xx-fw/wl18xx-fw_8.7.3.bb b/recipes-bsp/wl18xx-fw/wl18xx-fw_8.7.3.bb
> > > index a52ec898..50b6c297 100644
> > > --- a/recipes-bsp/wl18xx-fw/wl18xx-fw_8.7.3.bb
> > > +++ b/recipes-bsp/wl18xx-fw/wl18xx-fw_8.7.3.bb
> > > @@ -7,8 +7,7 @@ SRC_URI = " \
> > >  	file://0001-Add-Makefile-to-install-firmware-files.patch \
> > >  "
> > >  
> > > -# Tag: R8.7-SP3 (8.7.3)
> > > -SRCREV = "f659be25473e4bde8dc790bff703ecacde6e21da"
> > > +SRCREV = "5ec05007f2662f460f881c5868311fd3ab7e6e71"
> > >  BRANCH = "master"
> > >  
> > >  S = "${WORKDIR}/git"
> > > -- 
> > > 2.17.1
> > 
> > -- 
> > Regards,
> > Denys Dmytriyenko <denis@denix.org>
> > PGP: 0x420902729A92C964 - https://denix.org/0x420902729A92C964
> > Fingerprint: 25FC E4A5 8A72 2F69 1186  6D76 4209 0272 9A92 C964

> 
> 
> 


  parent reply	other threads:[~2021-03-05 10:31 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-03 18:09 [meta-ti][PATCH] recipes-bsp: wl18xx-fw: update SRCREV to latest Nikhil Devshatwar
2021-03-03 18:17 ` Denys Dmytriyenko
2021-03-05  9:59   ` Nikhil Devshatwar
2021-03-09  3:44     ` Denys Dmytriyenko
     [not found]   ` <166969EA2A6821A6.22430@lists.yoctoproject.org>
2021-03-05 10:30     ` Nikhil Devshatwar [this message]
2021-03-09  3:48       ` Denys Dmytriyenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210305103055.3uf5ypbaxsx2yezb@NiksLab \
    --to=nikhil.nd@ti.com \
    --cc=denis@denix.org \
    --cc=hnagalla@ti.com \
    --cc=kishon@ti.com \
    --cc=lokeshvutla@ti.com \
    --cc=meta-ti@yoctoproject.org \
    --cc=nsekhar@ti.com \
    --cc=praneeth@ti.com \
    --cc=saurabhnarang@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.