From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 212EEC4332B for ; Fri, 5 Mar 2021 10:47:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F3E8364FDF for ; Fri, 5 Mar 2021 10:47:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229723AbhCEKrD (ORCPT ); Fri, 5 Mar 2021 05:47:03 -0500 Received: from jabberwock.ucw.cz ([46.255.230.98]:45984 "EHLO jabberwock.ucw.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229558AbhCEKqk (ORCPT ); Fri, 5 Mar 2021 05:46:40 -0500 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id 57AFC1C0B7D; Fri, 5 Mar 2021 11:46:35 +0100 (CET) Date: Fri, 5 Mar 2021 11:46:35 +0100 From: Pavel Machek To: Johan Hovold Cc: Rob Herring , Tony Lindgren , Greg Kroah-Hartman , Alan Cox , Lee Jones , Jiri Slaby , Merlijn Wajer , Peter Hurley , Sebastian Reichel , linux-serial@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org Subject: Re: [PATCH 3/6] dt-bindings: serdev: ngsm: Add binding for GNSS child node Message-ID: <20210305104635.GA16695@duo.ucw.cz> References: <20200512214713.40501-1-tony@atomide.com> <20200512214713.40501-4-tony@atomide.com> <20200527192817.GA2587830@bogus> <20200528095151.GE10358@localhost> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="CE+1k2dSO48ffgeK" Content-Disposition: inline In-Reply-To: <20200528095151.GE10358@localhost> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --CE+1k2dSO48ffgeK Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > > > For motorola modem case, we may have a GNSS device on channel 4. > > > Let's add that to the binding and example. > > >=20 > > > Signed-off-by: Tony Lindgren > > > --- > > > .../devicetree/bindings/serdev/serdev-ngsm.yaml | 9 +++++++= ++ > > > 1 file changed, 9 insertions(+) >=20 > And since we're describing a mux, I think you need nodes for the virtual > ports rather than a reg property in what should be a serial client. That > is something like >=20 > serial@nnn { > modem { > compatible =3D "etsi,ts27001-mux"; >=20 > serial@4 { > compatible =3D "etsi,ts27001-serial"; > reg =3D <4>; >=20 > gnss { > compatible =3D "motorola,motmdm-gnss"; > }; > }; > }; > }; >=20 > This way you can actually use serdev for the client drivers (e.g. for > gnss), and those drivers also be used for non-muxed ports if needed > (e.g. over USB). I have done changes you requested, and then hit "serdev is busy because it can have at most one child" limit in the code. You have pretty clean driver in your inbox, and no reply. No help with serdev core limitations, either. Can you start to communicate? Best regards, Pavel --=20 http://www.livejournal.com/~pavelmachek --CE+1k2dSO48ffgeK Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABECAB0WIQRPfPO7r0eAhk010v0w5/Bqldv68gUCYEIMCwAKCRAw5/Bqldv6 8vX6AKDEZXZzQRsFq96/zZjnwyH4M5OK9ACgvXWJAfROdL/PovAeI57QNdO1xfY= =nOBS -----END PGP SIGNATURE----- --CE+1k2dSO48ffgeK--