Re: [PATCH] tools/memory-model: Fix smp_mb__after_spinlock() spelling

From: "Paul E. McKenney" <paulmck@kernel.org>
To: "Björn Töpel" <bjorn.topel@intel.com>
Cc: "Alan Stern" <stern@rowland.harvard.edu>,
	"Björn Töpel" <bjorn.topel@gmail.com>,
	linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
	"Andrea Parri" <parri.andrea@gmail.com>,
	"Will Deacon" <will@kernel.org>,
	"Peter Zijlstra" <peterz@infradead.org>,
	"Boqun Feng" <boqun.feng@gmail.com>,
	"Nicholas Piggin" <npiggin@gmail.com>,
	"David Howells" <dhowells@redhat.com>,
	"Jade Alglave" <j.alglave@ucl.ac.uk>,
	"Luc Maranget" <luc.maranget@inria.fr>,
	"Akira Yokosawa" <akiyks@gmail.com>,
	"Daniel Lustig" <dlustig@nvidia.com>,
	"Joel Fernandes" <joel@joelfernandes.org>
Subject: Re: [PATCH] tools/memory-model: Fix smp_mb__after_spinlock() spelling
Date: Fri, 5 Mar 2021 10:26:50 -0800	[thread overview]
Message-ID: <20210305182650.GA2713@paulmck-ThinkPad-P72> (raw)
In-Reply-To: <e90fee12-a29e-cddb-5db3-24d92d4e03f8@intel.com>

On Fri, Mar 05, 2021 at 04:41:49PM +0100, Björn Töpel wrote:
> On 2021-03-05 16:36, Alan Stern wrote:
> > On Fri, Mar 05, 2021 at 11:28:23AM +0100, Björn Töpel wrote:
> > > From: Björn Töpel <bjorn.topel@intel.com>
> > > 
> > > A misspelled invokation of git-grep, revealed that
> > -------------------^
> > 
> > Smetimes my brain is a little slow...  Do you confirm that this is a
> > joke?
> > 
> 
> I wish, Alan. I wish.
> 
> Looks like I can only spel function names correctly.

Heh!  I missed that one completely.  Please see below for a wortschmied
commit.

							Thanx, Paul

------------------------------------------------------------------------

commit 1c737ce34715db9431f6b034f92dbf09d954126d
Author: Björn Töpel <bjorn.topel@intel.com>
Date:   Fri Mar 5 11:28:23 2021 +0100

    tools/memory-model: Fix smp_mb__after_spinlock() spelling
    
    A misspelled git-grep regex revealed that smp_mb__after_spinlock()
    was misspelled in explanation.txt.
    
    This commit adds the missing "_" to smp_mb__after_spinlock().
    
    Fixes: 1c27b644c0fd ("Automate memory-barriers.txt; provide Linux-kernel memory model")
    [ paulmck: Apply Alan Stern commit-log feedback. ]
    Signed-off-by: Björn Töpel <bjorn.topel@intel.com>
    Signed-off-by: Paul E. McKenney <paulmck@kernel.org>

diff --git a/tools/memory-model/Documentation/explanation.txt b/tools/memory-model/Documentation/explanation.txt
index f9d610d..5d72f31 100644
--- a/tools/memory-model/Documentation/explanation.txt
+++ b/tools/memory-model/Documentation/explanation.txt
@@ -2510,7 +2510,7 @@ they behave as follows:
 	smp_mb__after_atomic() orders po-earlier atomic updates and
 	the events preceding them against all po-later events;
 
-	smp_mb_after_spinlock() orders po-earlier lock acquisition
+	smp_mb__after_spinlock() orders po-earlier lock acquisition
 	events and the events preceding them against all po-later
 	events.
 
