From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F30DC433E6 for ; Fri, 5 Mar 2021 18:54:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C0440650A1 for ; Fri, 5 Mar 2021 18:54:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230023AbhCESx6 (ORCPT ); Fri, 5 Mar 2021 13:53:58 -0500 Received: from mail-ot1-f53.google.com ([209.85.210.53]:39766 "EHLO mail-ot1-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229488AbhCESxv (ORCPT ); Fri, 5 Mar 2021 13:53:51 -0500 Received: by mail-ot1-f53.google.com with SMTP id h22so2782597otr.6; Fri, 05 Mar 2021 10:53:50 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=fneTq2063McDFfTPtwQtaMOm7W8A1xMYIqx5C0mAJsk=; b=LHFk0fOiOzO4eQl17wFViJkzaZtB4b4EDWnB9cTpSrZ2hT9g7MpQ72nhmGJ8TlDmj8 8Mfqd/9WuI4m516rHg/HpBT4FwDkfTwPiyBP/IZkbgfzCnLEKSonY7JJNQoeu8KxQea5 1igol/OwEDO53xhzcSxoVogY4KORblYMOzzc8p+7sK2X/yCH2LWSmSAlybyTBuV+G6zy 8YbaeK2mLi6w0RNIxyAi7i+Gu4jhftKUSLoMvNLFele5tIa6OO3VRlgmjrCb662iif5P mDjzOdGrSdDGWFwvlEWsGdUEJnBYrmwbJ+l+ufTMwWD852HBzWkxxLD7iIqRHGEDJRKw mMpA== X-Gm-Message-State: AOAM531TqLvtb0mH9lFIDHqZq7Nvp364ClyzJ+qqgTy4Q8KICCPiM81p 6OV5MDucqQURkqlVsnpjH/0LLvq7ag== X-Google-Smtp-Source: ABdhPJx2eP3/GWFcePScRRMJu4lNsYmW8oQimLQi+5KHkY5RbcmejQsXuc9T1SCDS/k9iNKR7cLyrA== X-Received: by 2002:a9d:73ce:: with SMTP id m14mr8673721otk.57.1614970430386; Fri, 05 Mar 2021 10:53:50 -0800 (PST) Received: from robh.at.kernel.org (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id h20sm765795otr.2.2021.03.05.10.53.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Mar 2021 10:53:49 -0800 (PST) Received: (nullmailer pid 468180 invoked by uid 1000); Fri, 05 Mar 2021 18:53:47 -0000 Date: Fri, 5 Mar 2021 12:53:47 -0600 From: Rob Herring To: Valentin Caron Cc: Alexandre Torgue , Greg Kroah-Hartman , Maxime Coquelin , Erwan Le Ray , linux-serial@vger.kernel.org, devicetree@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] dt-bindings: serial: stm32: add examples Message-ID: <20210305185347.GA466473@robh.at.kernel.org> References: <20210209095948.15889-1-valentin.caron@foss.st.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210209095948.15889-1-valentin.caron@foss.st.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 09, 2021 at 10:59:48AM +0100, Valentin Caron wrote: > From: Valentin Caron > > Add examples to show more use cases : > - uart2 with hardware flow control > - uart4 without flow control Why do I need these? I can go read your dts files if I need more examples. > > Signed-off-by: Valentin Caron > --- > .../bindings/serial/st,stm32-uart.yaml | 20 +++++++++++++++++++ > 1 file changed, 20 insertions(+) > > diff --git a/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml b/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml > index 06d5f251ec88..3a4aab5d1862 100644 > --- a/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml > +++ b/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml > @@ -82,6 +82,26 @@ additionalProperties: false > examples: > - | > #include > + > + usart4: serial@40004c00 { > + compatible = "st,stm32-uart"; > + reg = <0x40004c00 0x400>; > + interrupts = <52>; > + clocks = <&clk_pclk1>; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_usart4>; > + }; > + > + usart2: serial@40004400 { > + compatible = "st,stm32-uart"; > + reg = <0x40004400 0x400>; > + interrupts = <38>; > + clocks = <&clk_pclk1>; > + st,hw-flow-ctrl; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_usart2 &pinctrl_usart2_rtscts>; > + }; > + > usart1: serial@40011000 { > compatible = "st,stm32-uart"; > reg = <0x40011000 0x400>; > -- > 2.17.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0982C433DB for ; Fri, 5 Mar 2021 18:56:17 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 564C86509A for ; Fri, 5 Mar 2021 18:56:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 564C86509A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=FExm0+EpSrzWnacmvtNW3mIyrhKYS/uM/1qaZXhA3D4=; b=kxnTla0us6YQpE0Zhkg8dmnDi EHh1oB/FQM+rOcUtYcbUKFr49vBpPyTpIH1d2VpRejuELQ4mpt7d0yHs2rVZDI6VdYAYkAg3JXvD9 myiG17RZSmlVR3O1Wtr1j9HrWUiqjem8zGnQuouF9uOZTXJon0s1slj1llz/UEYLp3haja+Zn/sc6 D6Hcn6KXk/CF8RZrS8YAbkJPV8gvdLM2ChjRO0VVB1DoFysSTkzriFxm4P2JmM5VZ3AFOVF7yd62r cRYs8F8KYej2f/7XSr5uK9X4mNfJadOB+rzYr0a4lcgjXEWW2FXeX5bJvgIlGH+5sCNO+GcPxDXnD PYI1zhf8w==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lIFb3-00G3Qt-Sr; Fri, 05 Mar 2021 18:54:46 +0000 Received: from mail-ot1-f50.google.com ([209.85.210.50]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lIFaB-00G2yR-JL for linux-arm-kernel@lists.infradead.org; Fri, 05 Mar 2021 18:53:55 +0000 Received: by mail-ot1-f50.google.com with SMTP id 97so2741677otf.13 for ; Fri, 05 Mar 2021 10:53:51 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=fneTq2063McDFfTPtwQtaMOm7W8A1xMYIqx5C0mAJsk=; b=dmI/C4GMIDIFEvvfj+cBSsi4gDKHy6wqc7QHYUhSzV5Syb8msNqjqgvY5jtFjNWFlr YowUkfBOr7bSUKbjPU60JEIge5SgEf+doMIrQrBeQvEBEKuLptA447AIGSwRdZNL0DaG SFa9owbCFth2h0MIqYUXPyPQnfStcH1JyCuaUw+4L5A2OTxcneU1F4WMrsUFfzM3Re6d 11OT0+IYc7VmFKS9sc4rPzx84hXdM7xKMSZ7mMIqSxmUclNQp+HzG1ATBj8l9fk8oKgc 1xSQJ18B29TgnD6NXlzsdvEYeY6MPMZaoUc71DPEOCH2ib8PUL8cP5U/d1THYHx9EZSY 41yw== X-Gm-Message-State: AOAM531cwWnzHm5KHcyDM24ypW9PID5vyEJJbOueh9lNaj3k8pIdMoeJ kQf2XlxVq/gFesxzJVLkNQ== X-Google-Smtp-Source: ABdhPJx2eP3/GWFcePScRRMJu4lNsYmW8oQimLQi+5KHkY5RbcmejQsXuc9T1SCDS/k9iNKR7cLyrA== X-Received: by 2002:a9d:73ce:: with SMTP id m14mr8673721otk.57.1614970430386; Fri, 05 Mar 2021 10:53:50 -0800 (PST) Received: from robh.at.kernel.org (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id h20sm765795otr.2.2021.03.05.10.53.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Mar 2021 10:53:49 -0800 (PST) Received: (nullmailer pid 468180 invoked by uid 1000); Fri, 05 Mar 2021 18:53:47 -0000 Date: Fri, 5 Mar 2021 12:53:47 -0600 From: Rob Herring To: Valentin Caron Cc: Alexandre Torgue , Greg Kroah-Hartman , Maxime Coquelin , Erwan Le Ray , linux-serial@vger.kernel.org, devicetree@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] dt-bindings: serial: stm32: add examples Message-ID: <20210305185347.GA466473@robh.at.kernel.org> References: <20210209095948.15889-1-valentin.caron@foss.st.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210209095948.15889-1-valentin.caron@foss.st.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210305_185352_108649_193DE86F X-CRM114-Status: GOOD ( 16.20 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Feb 09, 2021 at 10:59:48AM +0100, Valentin Caron wrote: > From: Valentin Caron > > Add examples to show more use cases : > - uart2 with hardware flow control > - uart4 without flow control Why do I need these? I can go read your dts files if I need more examples. > > Signed-off-by: Valentin Caron > --- > .../bindings/serial/st,stm32-uart.yaml | 20 +++++++++++++++++++ > 1 file changed, 20 insertions(+) > > diff --git a/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml b/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml > index 06d5f251ec88..3a4aab5d1862 100644 > --- a/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml > +++ b/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml > @@ -82,6 +82,26 @@ additionalProperties: false > examples: > - | > #include > + > + usart4: serial@40004c00 { > + compatible = "st,stm32-uart"; > + reg = <0x40004c00 0x400>; > + interrupts = <52>; > + clocks = <&clk_pclk1>; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_usart4>; > + }; > + > + usart2: serial@40004400 { > + compatible = "st,stm32-uart"; > + reg = <0x40004400 0x400>; > + interrupts = <38>; > + clocks = <&clk_pclk1>; > + st,hw-flow-ctrl; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_usart2 &pinctrl_usart2_rtscts>; > + }; > + > usart1: serial@40011000 { > compatible = "st,stm32-uart"; > reg = <0x40011000 0x400>; > -- > 2.17.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel