From: Rob Herring <robh@kernel.org>
To: Maxime Chevallier <maxime.chevallier@bootlin.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Paul Kocialkowski <paul.kocialkowski@bootlin.com>
Subject: Re: [PATCH v4 2/3] media: dt-bindings: media: i2c: Add bindings for TW9900
Date: Fri, 5 Mar 2021 16:58:26 -0600 [thread overview]
Message-ID: <20210305225826.GA794278@robh.at.kernel.org> (raw)
In-Reply-To: <20210219081514.1592033-3-maxime.chevallier@bootlin.com>
On Fri, Feb 19, 2021 at 09:15:13AM +0100, Maxime Chevallier wrote:
> The Techwell TW9900 is a video decoder supporting multiple input
> standards, such as PAL, NTSC and SECAM, and outputs a BT.656 video
> signal.
>
> It's designed to be low-power, posesses some features such as a
> programmable comb-filter, and automatic input standard detection.
>
> Signed-off-by: Maxime Chevallier <maxime.chevallier@bootlin.com>
> ---
> V2->V3 : Fix the example not compiling due to a typo in the reset-gpios
> node.
>
> V3->V4 : Add the missing reset-gpios node to the binding
>
> .../devicetree/bindings/media/i2c/tw9900.yaml | 64 +++++++++++++++++++
Use the compatible string for the filename.
> 1 file changed, 64 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/media/i2c/tw9900.yaml
>
> diff --git a/Documentation/devicetree/bindings/media/i2c/tw9900.yaml b/Documentation/devicetree/bindings/media/i2c/tw9900.yaml
> new file mode 100644
> index 000000000000..d27196e37416
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/i2c/tw9900.yaml
> @@ -0,0 +1,64 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/media/i2c/tw9900.yaml#
Don't forget to update this...
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Techwell TW9900 NTSC/PAL/SECAM video decoder
> +
> +maintainers:
> + - Maxime Chevallier <maxime.chevallier@bootlin.com>
> +
> +description:
> + The tw9900 is a multi-standard video decoder, supporting NTSC, PAL and SECAM
> + standards with auto-detection features.
> +
> +properties:
> + compatible:
> + items:
> + - enum:
> + - techwell,tw9900
> +
> + reg:
> + maxItems: 1
> +
> + vdd-supply:
> + description: VDD power supply
> +
> + reset-gpios:
> + description: GPIO descriptor for the RESET input pin
> + maxItems: 1
> +
> + port:
> + type: object
> + description:
> + A node containing a single endpoint as doucmented in
> + Documentation/devicetree/bindings/media/video-interfaces.txt
It's now video-interfaces.yaml, but you aren't using anything from it.
You need to reference graph.yaml though. See the examples in the tree
now.
> +
> +additionalProperties: false
> +
> +required:
> + - compatible
> + - reg
> +
> +examples:
> + - |
> + #include <dt-bindings/gpio/gpio.h>
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + tw9900: tw9900@44 {
> + compatible = "techwell,tw9900";
> + reg = <0x44>;
> +
> + vdd-supply = <&tw9900_supply>;
> + reset-gpios = <&gpio2 5 GPIO_ACTIVE_LOW>;
> +
> + port {
> + tw9900_out: endpoint {
> + remote-endpoint = <&vip_in>;
> + };
> + };
> + };
> + };
> --
> 2.25.4
>
next prev parent reply other threads:[~2021-03-05 22:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-19 8:15 [PATCH v4 0/3] media: i2c: Introduce driver for the TW9900 decoder Maxime Chevallier
2021-02-19 8:15 ` [PATCH v4 1/3] dt-bindings: vendor-prefixes: Add techwell vendor prefix Maxime Chevallier
2021-02-19 8:15 ` [PATCH v4 2/3] media: dt-bindings: media: i2c: Add bindings for TW9900 Maxime Chevallier
2021-03-05 22:58 ` Rob Herring [this message]
2021-02-19 8:15 ` [PATCH v4 3/3] media: i2c: Introduce a driver for the Techwell TW9900 decoder Maxime Chevallier
2021-03-04 15:37 ` Hans Verkuil
2021-03-11 13:09 ` Maxime Chevallier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210305225826.GA794278@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=maxime.chevallier@bootlin.com \
--cc=mchehab@kernel.org \
--cc=miquel.raynal@bootlin.com \
--cc=paul.kocialkowski@bootlin.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.