From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1EBF9C4332B for ; Sat, 6 Mar 2021 08:07:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CF9EF65016 for ; Sat, 6 Mar 2021 08:07:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230087AbhCFIHB (ORCPT ); Sat, 6 Mar 2021 03:07:01 -0500 Received: from elvis.franken.de ([193.175.24.41]:48060 "EHLO elvis.franken.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229917AbhCFIGV (ORCPT ); Sat, 6 Mar 2021 03:06:21 -0500 Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1lIRx3-0004K9-01; Sat, 06 Mar 2021 09:06:17 +0100 Received: by alpha.franken.de (Postfix, from userid 1000) id 738F3C112A; Sat, 6 Mar 2021 09:00:07 +0100 (CET) Date: Sat, 6 Mar 2021 09:00:07 +0100 From: Thomas Bogendoerfer To: =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= Cc: Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= , =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= , "open list:BROADCOM NVRAM DRIVER" , Florian Fainelli , Vivek Unune , bcm-kernel-feedback-list , open list , kernel test robot Subject: Re: [PATCH V2 mips/linux.git] firmware: bcm47xx_nvram: refactor finding & reading NVRAM Message-ID: <20210306080007.GB4744@alpha.franken.de> References: <20210304072357.31108-1-zajec5@gmail.com> <20210305055501.13099-1-zajec5@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 05, 2021 at 12:56:55PM +0100, Rafał Miłecki wrote: > On 05.03.2021 12:47, Philippe Mathieu-Daudé wrote: > > On Fri, Mar 5, 2021 at 11:16 AM Rafał Miłecki wrote: > > > On 05.03.2021 10:58, Philippe Mathieu-Daudé wrote: > > > > On Fri, Mar 5, 2021 at 6:55 AM Rafał Miłecki wrote: > > > > > > > > > > From: Rafał Miłecki > > > > > > > > > > 1. Use meaningful variable names (e.g. "flash_start", "res_size" instead > > > > > of e.g. "iobase", "end") > > > > > 2. Always operate on "offset" instead of mix of start, end, size, etc. > > > > > > > > "instead of a mix" > > > > > > > > > 3. Add helper checking for NVRAM to avoid duplicating code > > > > > 4. Use "found" variable instead of goto > > > > > 5. Use simpler checking of offsets and sizes (2 nested loops with > > > > > trivial check instead of extra function) > > > > > > > > This could be a series of trivial patches, why did you choose to make a mixed > > > > bag harder to review? > > > > > > It's a subjective thing and often a matter of maintainer taste. I can > > > say that after contributing to various Linux subsystems. If you split a > > > similar patch for MTD subsystem you'll get complains about making > > > changes too small & too hard to review (sic!). > > > > Fine. MTD subsystem developers are probably smarter than I'm :) > > > > > This isn't a bomb really: 63 insertions(+), 48 deletions(-) > > > > Too many changes at once for my brain stack doesn't mean others are > > willing to review it. But to me that means each time I'll have to pass over > > it while bisecting or reviewing git history I'll suffer the same overflow. > > Anyway, matter of taste as you said. > > If I hear another voice for splitting this change into smaller patches > I'm 100% happy to do so. Honestly! > > I just don't know if by splitting I won't annoy other people by making > changes too small. > > Please speak up! :) please split it. IMHO the current is patch is hard to review, because of the different changes mixed together. Thank you. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]