From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42E70C433E0 for ; Sun, 7 Mar 2021 13:41:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 170FA65105 for ; Sun, 7 Mar 2021 13:41:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231400AbhCGNk3 (ORCPT ); Sun, 7 Mar 2021 08:40:29 -0500 Received: from mail.kernel.org ([198.145.29.99]:37494 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231393AbhCGNkE (ORCPT ); Sun, 7 Mar 2021 08:40:04 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 955E66509B; Sun, 7 Mar 2021 13:40:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1615124404; bh=KAdEzK9L5PScgpNAXea/SaJwnc31diz8Kc4lZDKBNQI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ODp56EExQBe5YBqwFMwKZFkQS82V2r/lVxi3enrxB8rg7DOX/AeqQWV90hw2t2GCH FxSLhQxMhKAufgWdvnAgMRx+w2rKi9PaQbqhNwHbHOHI1nxyc8w7wp8XGezbB6vvr3 DB8asULJ3DNPWARceFOaoTuKJBYftGTAsur8kEFDnCnf9zRIJNTRGp9kazg+oanhIw E9ThWB9iY3acPTle3GhyNQgapKYxZHkyqnGImKRFdbuTB28dhYIy6Tr0lkDAtAcIvj 7UFEqNAd4m8ORMoVl0ry2ib3j9ZMCUjmJkHge6xwtrMKK4uBs3X+TkkV0VFC7uGbWP J9gPRfV6qU5KA== Date: Sun, 7 Mar 2021 21:39:59 +0800 From: Shawn Guo To: Martin Kepplinger Cc: robh@kernel.org, festevam@gmail.com, kernel@pengutronix.de, linux-imx@nxp.com, krzk@kernel.org, kernel@puri.sm, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Angus Ainslie Subject: Re: [PATCH v3 4/5] arm64: dts: librem5: protect some partitions of the nor-flash Message-ID: <20210307133958.GH543@dragon> References: <20210219100439.9428-1-martin.kepplinger@puri.sm> <20210219100439.9428-5-martin.kepplinger@puri.sm> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210219100439.9428-5-martin.kepplinger@puri.sm> User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 19, 2021 at 11:04:38AM +0100, Martin Kepplinger wrote: > From: Angus Ainslie > > These sections should be read only as they contain important data. > > Signed-off-by: Angus Ainslie > Signed-off-by: Martin Kepplinger > --- > .../boot/dts/freescale/imx8mq-librem5.dtsi | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi > index c2bbbdeb93e3..d39ae27c8e42 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi > @@ -258,6 +258,23 @@ > compatible = "jedec,spi-nor"; > reg = <0>; > spi-max-frequency = <1000000>; > + #address-cells = <1>; > + #size-cells = <1>; > + > + partition@0 { > + label = "protected0"; > + reg = <0x0 0x30000>; > + read-only; > + }; > + partition@30000 { > + label = "protected1"; > + reg = <0x30000 0x10000>; > + read-only; > + }; Please have a newline between nodes. I fixed it up when applying. Shawn > + partition@40000 { > + label = "rw"; > + reg = <0x40000 0x1C0000>; > + }; > }; > }; > > -- > 2.20.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8EBD5C433DB for ; Sun, 7 Mar 2021 13:41:33 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2142A650F3 for ; Sun, 7 Mar 2021 13:41:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2142A650F3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=1ONQwvwWEniFBbAAr0qcmRtfYfjC1prUP9kfScgM5Zo=; b=nUyKubnJ0uUavYPKSiFmmRWEY +gSzEw8z9zjSoIlwoy4FNivgPPsH5erfOiqolxqsJCvEINtx+TGqWh8DZYSAzvYdvxtBMBjn8MEMV gntSH2kMfA0SbRgmRmZQ+KXq5lgVB3neTMx8gmIBrD0I9Ax+y1ud/Y+EkbSnv5UhXewl16H6CLdJ0 CMOTDdpwTj4B+UW/g2VhH7M0/E4Tq8UI23cTUMYbKC5UcftI1BKZNMObHMtA7NRhBKOkwf6DthIkE juOeM+k+fu/WUkorl9uJst/8rTVK8mGV3afx0mPlswySIH/Ppc20PMNHFvGFtjlELNm5c3otdanq5 pAt2kSurg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lItdi-00AFN0-9L; Sun, 07 Mar 2021 13:40:10 +0000 Received: from mail.kernel.org ([198.145.29.99]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lItde-00AFLU-41 for linux-arm-kernel@lists.infradead.org; Sun, 07 Mar 2021 13:40:07 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 955E66509B; Sun, 7 Mar 2021 13:40:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1615124404; bh=KAdEzK9L5PScgpNAXea/SaJwnc31diz8Kc4lZDKBNQI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ODp56EExQBe5YBqwFMwKZFkQS82V2r/lVxi3enrxB8rg7DOX/AeqQWV90hw2t2GCH FxSLhQxMhKAufgWdvnAgMRx+w2rKi9PaQbqhNwHbHOHI1nxyc8w7wp8XGezbB6vvr3 DB8asULJ3DNPWARceFOaoTuKJBYftGTAsur8kEFDnCnf9zRIJNTRGp9kazg+oanhIw E9ThWB9iY3acPTle3GhyNQgapKYxZHkyqnGImKRFdbuTB28dhYIy6Tr0lkDAtAcIvj 7UFEqNAd4m8ORMoVl0ry2ib3j9ZMCUjmJkHge6xwtrMKK4uBs3X+TkkV0VFC7uGbWP J9gPRfV6qU5KA== Date: Sun, 7 Mar 2021 21:39:59 +0800 From: Shawn Guo To: Martin Kepplinger Cc: robh@kernel.org, festevam@gmail.com, kernel@pengutronix.de, linux-imx@nxp.com, krzk@kernel.org, kernel@puri.sm, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Angus Ainslie Subject: Re: [PATCH v3 4/5] arm64: dts: librem5: protect some partitions of the nor-flash Message-ID: <20210307133958.GH543@dragon> References: <20210219100439.9428-1-martin.kepplinger@puri.sm> <20210219100439.9428-5-martin.kepplinger@puri.sm> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210219100439.9428-5-martin.kepplinger@puri.sm> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210307_134006_408293_516D041F X-CRM114-Status: GOOD ( 15.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Feb 19, 2021 at 11:04:38AM +0100, Martin Kepplinger wrote: > From: Angus Ainslie > > These sections should be read only as they contain important data. > > Signed-off-by: Angus Ainslie > Signed-off-by: Martin Kepplinger > --- > .../boot/dts/freescale/imx8mq-librem5.dtsi | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi > index c2bbbdeb93e3..d39ae27c8e42 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi > @@ -258,6 +258,23 @@ > compatible = "jedec,spi-nor"; > reg = <0>; > spi-max-frequency = <1000000>; > + #address-cells = <1>; > + #size-cells = <1>; > + > + partition@0 { > + label = "protected0"; > + reg = <0x0 0x30000>; > + read-only; > + }; > + partition@30000 { > + label = "protected1"; > + reg = <0x30000 0x10000>; > + read-only; > + }; Please have a newline between nodes. I fixed it up when applying. Shawn > + partition@40000 { > + label = "rw"; > + reg = <0x40000 0x1C0000>; > + }; > }; > }; > > -- > 2.20.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel