From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andre Przywara <andre.przywara@arm.com>
Date: Mon, 8 Mar 2021 00:12:24 +0000
Subject: [PATCH] configs: add PineTab defconfig
In-Reply-To: <YETM5Nx10Fi8uwN2@nicolasthinkpad>
References: <YETM5Nx10Fi8uwN2@nicolasthinkpad>
Message-ID: <20210308001224.753bba4c@slackpad.fritz.box>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Sun, 7 Mar 2021 13:53:56 +0100
Nicolas Boulenguez <nicolas@debian.org> wrote:

Hi,

> From: Arnaud Ferraris <arnaud.ferraris@collabora.com>
> 
> The PineTab device-tree is already in u-boot, this commit adds the corresponding
> defconfig, based on pinephone_defconfig.
> 
> Signed-off-by: Arnaud Ferraris <arnaud.ferraris@collabora.com>
> 
> --- a/board/sunxi/MAINTAINERS
> +++ b/board/sunxi/MAINTAINERS
> @@ -471,6 +471,11 @@ M:	Samuel Holland <samuel@sholland.org>
>  S:	Maintained
>  F:	configs/pinephone_defconfig
>  
> +PINETAB BOARD
> +M:	Arnaud Ferraris <arnaud.ferraris@collabora.com>
> +S:	Maintained
> +F:	configs/pinetab_defconfig

Arnaud, do you agree with this?
Happy to take your patch via Nicolas, but for the maintainer entry I
would like to have some confirmation.

> +
>  R16 EVB PARROT BOARD
>  M:	Quentin Schulz <quentin.schulz@free-electrons.com>
>  S:	Maintained
> --- /dev/null
> +++ b/configs/pinetab_defconfig
> @@ -0,0 +1,21 @@
> +CONFIG_ARM=y
> +CONFIG_ARCH_SUNXI=y
> +CONFIG_SPL=y
> +CONFIG_IDENT_STRING=""

Having "Allwinner Technology" here is indeed weird and probably not
really justified anymore, given the "support" we see from Allwinner.
I wonder if we should scrap this for all boards. Also it makes the line
longer than 80 characters.

> +CONFIG_MACH_SUN50I=y
> +CONFIG_SUNXI_DRAM_LPDDR3_STOCK=y
> +CONFIG_DRAM_CLK=552
> +CONFIG_DRAM_ZQ=3881949
> +CONFIG_MMC_SUNXI_SLOT_EXTRA=2
> +# CONFIG_VIDEO_DE2 is not set
> +CONFIG_DEFAULT_DEVICE_TREE="sun50i-a64-pinetab"
> +# CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
> +CONFIG_BOOTDELAY=0

I answered in the other email about the boot delay already.

So what is the reason for all those other options below?
Is there any particular reason they were all disabled?
I can buy CONFIG_NET, but the rest seems unnecessary. There doesn't
seem to be a driver for the PineTab panel in U-Boot, so this is solely
suppressing a few lines on the serial? Since this would be surely for
debug only, I think it's useful to have them, normal users wouldn't see
them anyway.

> +CONFIG_SYS_CONSOLE_INFO_QUIET=y
> +# CONFIG_DISPLAY_CPUINFO is not set
> +# CONFIG_DISPLAY_BOARDINFO is not set
> +# CONFIG_SPL_RAW_IMAGE_SUPPORT is not set
> +# CONFIG_SPL_BANNER_PRINT is not set
> +# CONFIG_SPL_POWER_SUPPORT is not set
> +# CONFIG_NET is not set
> +# CONFIG_EFI_LOADER is not set

We should definitely keep EFI_LOADER.

Cheers,
Andre