* [PATCH 01/18] arm64: qcom: apq8016-sbc: drop qcom,sbc
2021-03-08 6:08 [PATCH 00/18] arm64: qcom: fix dtbs_check warning Vinod Koul
@ 2021-03-08 6:08 ` Vinod Koul
2021-03-08 6:08 ` [PATCH 02/18] arm64: qcom: msm8916: don't use empty memory node Vinod Koul
` (16 subsequent siblings)
17 siblings, 0 replies; 24+ messages in thread
From: Vinod Koul @ 2021-03-08 6:08 UTC (permalink / raw)
To: Bjorn Andersson
Cc: linux-arm-msm, Vinod Koul, Andy Gross, Rob Herring, devicetree,
linux-kernel
apq8016-sbc is one of the compaitibles for this board, but is not
documented, so drop it. This fixes these two warns:
arch/arm64/boot/dts/qcom/apq8016-sbc.dt.yaml: /: compatible: ['qcom,apq8016-sbc', 'qcom,apq8016', 'qcom,sbc']
is not valid under any of the given schemas (Possible causes of the failure):
arch/arm64/boot/dts/qcom/apq8016-sbc.dt.yaml: /: compatible: ['qcom,apq8016-sbc', 'qcom,apq8016', 'qcom,sbc'] is too long
arch/arm64/boot/dts/qcom/apq8016-sbc.dt.yaml: /: compatible:0: 'qcom,apq8016-sbc'
is not one of ['qcom,apq8064-cm-qs600', 'qcom,apq8064-ifc6410']
arch/arm64/boot/dts/qcom/apq8016-sbc.dt.yaml: /: compatible:0: 'qcom,apq8016-sbc'
is not one of ['qcom,apq8074-dragonboard']
Signed-off-by: Vinod Koul <vkoul@kernel.org>
---
arch/arm64/boot/dts/qcom/apq8016-sbc.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/apq8016-sbc.dts b/arch/arm64/boot/dts/qcom/apq8016-sbc.dts
index 48bd1c2874de..f3c0dbfd0a23 100644
--- a/arch/arm64/boot/dts/qcom/apq8016-sbc.dts
+++ b/arch/arm64/boot/dts/qcom/apq8016-sbc.dts
@@ -9,5 +9,5 @@
/ {
model = "Qualcomm Technologies, Inc. APQ 8016 SBC";
- compatible = "qcom,apq8016-sbc", "qcom,apq8016", "qcom,sbc";
+ compatible = "qcom,apq8016-sbc", "qcom,apq8016";
};
--
2.26.2
^ permalink raw reply related [flat|nested] 24+ messages in thread
* [PATCH 02/18] arm64: qcom: msm8916: don't use empty memory node
2021-03-08 6:08 [PATCH 00/18] arm64: qcom: fix dtbs_check warning Vinod Koul
2021-03-08 6:08 ` [PATCH 01/18] arm64: qcom: apq8016-sbc: drop qcom,sbc Vinod Koul
@ 2021-03-08 6:08 ` Vinod Koul
2021-03-08 6:08 ` [PATCH 03/18] dt-bindings: arm: qcom: Document ipq6018-cp01 board Vinod Koul
` (15 subsequent siblings)
17 siblings, 0 replies; 24+ messages in thread
From: Vinod Koul @ 2021-03-08 6:08 UTC (permalink / raw)
To: Bjorn Andersson
Cc: linux-arm-msm, Vinod Koul, Andy Gross, Rob Herring, devicetree,
linux-kernel
We expect bootloader to full memory details but passing empty values
gives warning, so add a default value
arch/arm64/boot/dts/qcom/apq8016-sbc.dt.yaml: /: memory:
False schema does not allow {'device_type': ['memory'], 'reg': [[0, 0, 0, 0]]}
Signed-off-by: Vinod Koul <vkoul@kernel.org>
---
arch/arm64/boot/dts/qcom/msm8916.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/msm8916.dtsi b/arch/arm64/boot/dts/qcom/msm8916.dtsi
index 5353da521974..4c155735fbc9 100644
--- a/arch/arm64/boot/dts/qcom/msm8916.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8916.dtsi
@@ -25,10 +25,10 @@ aliases {
chosen { };
- memory {
+ memory@80000000 {
device_type = "memory";
/* We expect the bootloader to fill in the reg */
- reg = <0 0 0 0>;
+ reg = <0 0x80000000 0 0>;
};
reserved-memory {
--
2.26.2
^ permalink raw reply related [flat|nested] 24+ messages in thread
* [PATCH 03/18] dt-bindings: arm: qcom: Document ipq6018-cp01 board
2021-03-08 6:08 [PATCH 00/18] arm64: qcom: fix dtbs_check warning Vinod Koul
2021-03-08 6:08 ` [PATCH 01/18] arm64: qcom: apq8016-sbc: drop qcom,sbc Vinod Koul
2021-03-08 6:08 ` [PATCH 02/18] arm64: qcom: msm8916: don't use empty memory node Vinod Koul
@ 2021-03-08 6:08 ` Vinod Koul
2021-03-08 6:08 ` [PATCH 04/18] arm64: qcom: msm8994: don't use empty memory node Vinod Koul
` (14 subsequent siblings)
17 siblings, 0 replies; 24+ messages in thread
From: Vinod Koul @ 2021-03-08 6:08 UTC (permalink / raw)
To: Bjorn Andersson
Cc: linux-arm-msm, Vinod Koul, Andy Gross, Rob Herring, devicetree,
linux-kernel
Document the ipq6018-cp01 board. It was missing leading to warning:
arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dt.yaml: /: compatible: 'oneOf' conditional failed, one must be fixed:
['qcom,ipq6018-cp01', 'qcom,ipq6018'] is too short
['qcom,ipq6018-cp01', 'qcom,ipq6018'] is too long
Additional items are not allowed ('qcom,ipq6018' was unexpected)
Signed-off-by: Vinod Koul <vkoul@kernel.org>
---
Documentation/devicetree/bindings/arm/qcom.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
index 174134f920e1..74610f1d1407 100644
--- a/Documentation/devicetree/bindings/arm/qcom.yaml
+++ b/Documentation/devicetree/bindings/arm/qcom.yaml
@@ -176,6 +176,7 @@ properties:
- items:
- enum:
+ - qcom,ipq6018-cp01
- qcom,ipq6018-cp01-c1
- const: qcom,ipq6018
--
2.26.2
^ permalink raw reply related [flat|nested] 24+ messages in thread
* [PATCH 04/18] arm64: qcom: msm8994: don't use empty memory node
2021-03-08 6:08 [PATCH 00/18] arm64: qcom: fix dtbs_check warning Vinod Koul
` (2 preceding siblings ...)
2021-03-08 6:08 ` [PATCH 03/18] dt-bindings: arm: qcom: Document ipq6018-cp01 board Vinod Koul
@ 2021-03-08 6:08 ` Vinod Koul
2021-03-08 6:08 ` [PATCH 05/18] dt-bindings: arm: qcom: Document sony boards for apq8094 Vinod Koul
` (13 subsequent siblings)
17 siblings, 0 replies; 24+ messages in thread
From: Vinod Koul @ 2021-03-08 6:08 UTC (permalink / raw)
To: Bjorn Andersson
Cc: linux-arm-msm, Vinod Koul, Andy Gross, Rob Herring, devicetree,
linux-kernel
We expect bootloader to full memory details but passing empty values
gives warning, so add a default value
arch/arm64/boot/dts/qcom/apq8094-sony-xperia-kitakami-karin_windy.dt.yaml: /: memory:
False schema does not allow {'device_type': ['memory'], 'reg': [[0, 0, 0, 0]]}
Signed-off-by: Vinod Koul <vkoul@kernel.org>
---
arch/arm64/boot/dts/qcom/msm8994.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/msm8994.dtsi b/arch/arm64/boot/dts/qcom/msm8994.dtsi
index f49d442d2edf..f9f0b5aa6a26 100644
--- a/arch/arm64/boot/dts/qcom/msm8994.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8994.dtsi
@@ -149,10 +149,10 @@ scm {
};
};
- memory {
+ memory@80000000 {
device_type = "memory";
/* We expect the bootloader to fill in the reg */
- reg = <0 0 0 0>;
+ reg = <0 0x80000000 0 0>;
};
tcsr_mutex: hwlock {
--
2.26.2
^ permalink raw reply related [flat|nested] 24+ messages in thread
* [PATCH 05/18] dt-bindings: arm: qcom: Document sony boards for apq8094
2021-03-08 6:08 [PATCH 00/18] arm64: qcom: fix dtbs_check warning Vinod Koul
` (3 preceding siblings ...)
2021-03-08 6:08 ` [PATCH 04/18] arm64: qcom: msm8994: don't use empty memory node Vinod Koul
@ 2021-03-08 6:08 ` Vinod Koul
2021-03-10 13:41 ` Konrad Dybcio
2021-03-08 6:08 ` [PATCH 06/18] dt-bindings: arm: qcom: Document alcatel,idol347 board Vinod Koul
` (12 subsequent siblings)
17 siblings, 1 reply; 24+ messages in thread
From: Vinod Koul @ 2021-03-08 6:08 UTC (permalink / raw)
To: Bjorn Andersson
Cc: linux-arm-msm, Vinod Koul, Andy Gross, Rob Herring, devicetree,
linux-kernel
Document the various sony boards for apq8094. These are used in various
sony dts files but not documented
Signed-off-by: Vinod Koul <vkoul@kernel.org>
---
Documentation/devicetree/bindings/arm/qcom.yaml | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
index 74610f1d1407..dc87238d411b 100644
--- a/Documentation/devicetree/bindings/arm/qcom.yaml
+++ b/Documentation/devicetree/bindings/arm/qcom.yaml
@@ -136,6 +136,16 @@ properties:
- samsung,a5u-eur
- const: qcom,msm8916
+ - items:
+ - enum:
+ - sony,karin_windy
+ - sony,karin-row
+ - sony,satsuki-row
+ - sony,sumire-row
+ - sony,suzuran-row
+ - qcom,msm8994
+ - const: qcom,apq8094
+
- items:
- const: qcom,msm8996-mtp
--
2.26.2
^ permalink raw reply related [flat|nested] 24+ messages in thread
* Re: [PATCH 05/18] dt-bindings: arm: qcom: Document sony boards for apq8094
2021-03-08 6:08 ` [PATCH 05/18] dt-bindings: arm: qcom: Document sony boards for apq8094 Vinod Koul
@ 2021-03-10 13:41 ` Konrad Dybcio
0 siblings, 0 replies; 24+ messages in thread
From: Konrad Dybcio @ 2021-03-10 13:41 UTC (permalink / raw)
To: Vinod Koul, Bjorn Andersson
Cc: linux-arm-msm, Andy Gross, Rob Herring, devicetree, linux-kernel
Hi!
> + - items:
> + - enum:
> + - sony,karin_windy
> + - sony,karin-row
> + - sony,satsuki-row
> + - sony,sumire-row
> + - sony,suzuran-row
> + - qcom,msm8994
> + - const: qcom,apq8094
> +
> - items:
> - const: qcom,msm8996-mtp
>
>
APQ8094 and MSM8994 are separate (though still very similar) SoCs, so they should probably have their own const:'s.
karin_windy is based on APQ and all the rest are based on MSM. Sorry for not having documented these when first adding support for them.
Konrad
^ permalink raw reply [flat|nested] 24+ messages in thread
* [PATCH 06/18] dt-bindings: arm: qcom: Document alcatel,idol347 board
2021-03-08 6:08 [PATCH 00/18] arm64: qcom: fix dtbs_check warning Vinod Koul
` (4 preceding siblings ...)
2021-03-08 6:08 ` [PATCH 05/18] dt-bindings: arm: qcom: Document sony boards for apq8094 Vinod Koul
@ 2021-03-08 6:08 ` Vinod Koul
2021-03-10 13:42 ` Konrad Dybcio
2021-03-08 6:08 ` [PATCH 07/18] dt-bindings: arm: qcom: Drop qcom,mtp Vinod Koul
` (11 subsequent siblings)
17 siblings, 1 reply; 24+ messages in thread
From: Vinod Koul @ 2021-03-08 6:08 UTC (permalink / raw)
To: Bjorn Andersson
Cc: linux-arm-msm, Vinod Koul, Andy Gross, Rob Herring, devicetree,
linux-kernel
Document the alcatel,idol347 board. It was missing leading to warning:
arch/arm64/boot/dts/qcom/msm8916-alcatel-idol347.dt.yaml: /: compatible: 'oneOf' conditional failed, one must be fixed:
Additional items are not allowed ('qcom,msm8916' was unexpected)
Signed-off-by: Vinod Koul <vkoul@kernel.org>
---
Documentation/devicetree/bindings/arm/qcom.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
index dc87238d411b..7d97246dc379 100644
--- a/Documentation/devicetree/bindings/arm/qcom.yaml
+++ b/Documentation/devicetree/bindings/arm/qcom.yaml
@@ -125,6 +125,8 @@ properties:
- const: qcom,msm8974
- items:
+ - enum:
+ - alcatel,idol347
- const: qcom,msm8916-mtp/1
- const: qcom,msm8916-mtp
- const: qcom,msm8916
--
2.26.2
^ permalink raw reply related [flat|nested] 24+ messages in thread
* Re: [PATCH 06/18] dt-bindings: arm: qcom: Document alcatel,idol347 board
2021-03-08 6:08 ` [PATCH 06/18] dt-bindings: arm: qcom: Document alcatel,idol347 board Vinod Koul
@ 2021-03-10 13:42 ` Konrad Dybcio
0 siblings, 0 replies; 24+ messages in thread
From: Konrad Dybcio @ 2021-03-10 13:42 UTC (permalink / raw)
To: Vinod Koul, Bjorn Andersson
Cc: linux-arm-msm, Andy Gross, Rob Herring, devicetree, linux-kernel
> @@ -125,6 +125,8 @@ properties:
> - const: qcom,msm8974
>
> - items:
> + - enum:
> + - alcatel,idol347
> - const: qcom,msm8916-mtp/1
> - const: qcom,msm8916-mtp
> - const: qcom,msm8916
>
qcom,msm8916-mtp/1 and -mtp are separate boards and therefore should probably also go into the enum.
Konrad
^ permalink raw reply [flat|nested] 24+ messages in thread
* [PATCH 07/18] dt-bindings: arm: qcom: Drop qcom,mtp
2021-03-08 6:08 [PATCH 00/18] arm64: qcom: fix dtbs_check warning Vinod Koul
` (5 preceding siblings ...)
2021-03-08 6:08 ` [PATCH 06/18] dt-bindings: arm: qcom: Document alcatel,idol347 board Vinod Koul
@ 2021-03-08 6:08 ` Vinod Koul
2021-03-08 6:08 ` [PATCH 08/18] arm64: qcom: msm8994: don't use underscore in node name Vinod Koul
` (10 subsequent siblings)
17 siblings, 0 replies; 24+ messages in thread
From: Vinod Koul @ 2021-03-08 6:08 UTC (permalink / raw)
To: Bjorn Andersson
Cc: linux-arm-msm, Vinod Koul, Andy Gross, Rob Herring, devicetree,
linux-kernel
qcom,mtp is used msm8916-mtp.dts but not documented, it is a generic mtp
compatible and we have specfifc ones for each mtp so drop this
arch/arm64/boot/dts/qcom/msm8916-mtp.dt.yaml: /: compatible: 'oneOf' conditional failed, one must be fixed:
['qcom,msm8916-mtp', 'qcom,msm8916-mtp/1', 'qcom,msm8916', 'qcom,mtp'] is too long
Additional items are not allowed ('qcom,msm8916', 'qcom,mtp' were unexpected)
Additional items are not allowed ('qcom,mtp' was unexpected)
Signed-off-by: Vinod Koul <vkoul@kernel.org>
---
arch/arm64/boot/dts/qcom/msm8916-mtp.dts | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/msm8916-mtp.dts b/arch/arm64/boot/dts/qcom/msm8916-mtp.dts
index c3f885923127..d66c15538785 100644
--- a/arch/arm64/boot/dts/qcom/msm8916-mtp.dts
+++ b/arch/arm64/boot/dts/qcom/msm8916-mtp.dts
@@ -9,6 +9,5 @@
/ {
model = "Qualcomm Technologies, Inc. MSM 8916 MTP";
- compatible = "qcom,msm8916-mtp", "qcom,msm8916-mtp/1",
- "qcom,msm8916", "qcom,mtp";
+ compatible = "qcom,msm8916-mtp", "qcom,msm8916-mtp/1", "qcom,msm8916";
};
--
2.26.2
^ permalink raw reply related [flat|nested] 24+ messages in thread
* [PATCH 08/18] arm64: qcom: msm8994: don't use underscore in node name
2021-03-08 6:08 [PATCH 00/18] arm64: qcom: fix dtbs_check warning Vinod Koul
` (6 preceding siblings ...)
2021-03-08 6:08 ` [PATCH 07/18] dt-bindings: arm: qcom: Drop qcom,mtp Vinod Koul
@ 2021-03-08 6:08 ` Vinod Koul
2021-03-08 6:08 ` [PATCH 09/18] arm64: qcom: msm8996: " Vinod Koul
` (9 subsequent siblings)
17 siblings, 0 replies; 24+ messages in thread
From: Vinod Koul @ 2021-03-08 6:08 UTC (permalink / raw)
To: Bjorn Andersson
Cc: linux-arm-msm, Vinod Koul, Andy Gross, Rob Herring, devicetree,
linux-kernel
We have underscore (_) in node name leading to warning:
arch/arm64/boot/dts/qcom/msm8994-msft-lumia-octagon-cityman.dt.yaml: clocks: xo_board: {'type': 'object'} is not allowed for {'compatible': ['fixed-clock'], '#clock-cells': [[0]], 'clock-frequency': [[19200000]], 'phandle': [[26]]}
arch/arm64/boot/dts/qcom/msm8994-msft-lumia-octagon-cityman.dt.yaml: clocks: sleep_clk: {'type': 'object'} is not allowed for {'compatible': ['fixed-clock'], '#clock-cells': [[0]], 'clock-frequency': [[32768]]}
Fix this by changing node name to use dash (-)
Signed-off-by: Vinod Koul <vkoul@kernel.org>
---
arch/arm64/boot/dts/qcom/msm8994.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/msm8994.dtsi b/arch/arm64/boot/dts/qcom/msm8994.dtsi
index f9f0b5aa6a26..6596559a82b7 100644
--- a/arch/arm64/boot/dts/qcom/msm8994.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8994.dtsi
@@ -15,13 +15,13 @@ / {
chosen { };
clocks {
- xo_board: xo_board {
+ xo_board: xo-board {
compatible = "fixed-clock";
#clock-cells = <0>;
clock-frequency = <19200000>;
};
- sleep_clk: sleep_clk {
+ sleep_clk: sleep-clk {
compatible = "fixed-clock";
#clock-cells = <0>;
clock-frequency = <32768>;
--
2.26.2
^ permalink raw reply related [flat|nested] 24+ messages in thread
* [PATCH 09/18] arm64: qcom: msm8996: don't use underscore in node name
2021-03-08 6:08 [PATCH 00/18] arm64: qcom: fix dtbs_check warning Vinod Koul
` (7 preceding siblings ...)
2021-03-08 6:08 ` [PATCH 08/18] arm64: qcom: msm8994: don't use underscore in node name Vinod Koul
@ 2021-03-08 6:08 ` Vinod Koul
2021-03-08 6:08 ` [PATCH 10/18] arm64: qcom: sdm630: " Vinod Koul
` (8 subsequent siblings)
17 siblings, 0 replies; 24+ messages in thread
From: Vinod Koul @ 2021-03-08 6:08 UTC (permalink / raw)
To: Bjorn Andersson
Cc: linux-arm-msm, Vinod Koul, Andy Gross, Rob Herring, devicetree,
linux-kernel
We have underscore (_) in node name leading to warning:
arch/arm64/boot/dts/qcom/apq8096-db820c.dt.yaml: clocks: $nodename:0: 'clocks' does not match '^([a-z][a-z0-9\\-]+-bus|bus|soc|axi|ahb|apb)(@[0-9a-f]+)?$'
arch/arm64/boot/dts/qcom/apq8096-db820c.dt.yaml: clocks: xo_board: {'type': 'object'} is not allowed for {'compatible': ['fixed-clock'], '#clock-cells': [[0]], 'clock-frequency': [[19200000]], 'clock-output-names': ['xo_board'], 'phandle': [[115]]}
Fix this by changing node name to use dash (-)
Signed-off-by: Vinod Koul <vkoul@kernel.org>
---
arch/arm64/boot/dts/qcom/msm8996.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi
index ce430ba9c118..957487f84ead 100644
--- a/arch/arm64/boot/dts/qcom/msm8996.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi
@@ -17,14 +17,14 @@ / {
chosen { };
clocks {
- xo_board: xo_board {
+ xo_board: xo-board {
compatible = "fixed-clock";
#clock-cells = <0>;
clock-frequency = <19200000>;
clock-output-names = "xo_board";
};
- sleep_clk: sleep_clk {
+ sleep_clk: sleep-clk {
compatible = "fixed-clock";
#clock-cells = <0>;
clock-frequency = <32764>;
--
2.26.2
^ permalink raw reply related [flat|nested] 24+ messages in thread
* [PATCH 10/18] arm64: qcom: sdm630: don't use underscore in node name
2021-03-08 6:08 [PATCH 00/18] arm64: qcom: fix dtbs_check warning Vinod Koul
` (8 preceding siblings ...)
2021-03-08 6:08 ` [PATCH 09/18] arm64: qcom: msm8996: " Vinod Koul
@ 2021-03-08 6:08 ` Vinod Koul
2021-03-08 6:08 ` [PATCH 11/18] arm64: qcom: sdm660: " Vinod Koul
` (7 subsequent siblings)
17 siblings, 0 replies; 24+ messages in thread
From: Vinod Koul @ 2021-03-08 6:08 UTC (permalink / raw)
To: Bjorn Andersson
Cc: linux-arm-msm, Vinod Koul, Andy Gross, Rob Herring, devicetree,
linux-kernel
We have underscore (_) in node name so fix that up as well.
Fix this by changing node name to use dash (-)
Signed-off-by: Vinod Koul <vkoul@kernel.org>
---
arch/arm64/boot/dts/qcom/sdm630.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sdm630.dtsi b/arch/arm64/boot/dts/qcom/sdm630.dtsi
index f91a928466c3..5a7cf85d0cf1 100644
--- a/arch/arm64/boot/dts/qcom/sdm630.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm630.dtsi
@@ -17,14 +17,14 @@ / {
chosen { };
clocks {
- xo_board: xo_board {
+ xo_board: xo-board {
compatible = "fixed-clock";
#clock-cells = <0>;
clock-frequency = <19200000>;
clock-output-names = "xo_board";
};
- sleep_clk: sleep_clk {
+ sleep_clk: sleep-clk {
compatible = "fixed-clock";
#clock-cells = <0>;
clock-frequency = <32764>;
--
2.26.2
^ permalink raw reply related [flat|nested] 24+ messages in thread
* [PATCH 11/18] arm64: qcom: sdm660: don't use underscore in node name
2021-03-08 6:08 [PATCH 00/18] arm64: qcom: fix dtbs_check warning Vinod Koul
` (9 preceding siblings ...)
2021-03-08 6:08 ` [PATCH 10/18] arm64: qcom: sdm630: " Vinod Koul
@ 2021-03-08 6:08 ` Vinod Koul
2021-03-10 14:48 ` Konrad Dybcio
2021-03-08 6:08 ` [PATCH 12/18] arm64: qcom: msm8996: don't use empty memory node Vinod Koul
` (6 subsequent siblings)
17 siblings, 1 reply; 24+ messages in thread
From: Vinod Koul @ 2021-03-08 6:08 UTC (permalink / raw)
To: Bjorn Andersson
Cc: linux-arm-msm, Vinod Koul, Andy Gross, Rob Herring, devicetree,
linux-kernel
We have underscore (_) in node name so fix that up as well.
Fix this by changing node name to use dash (-)
Signed-off-by: Vinod Koul <vkoul@kernel.org>
---
arch/arm64/boot/dts/qcom/sdm660.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sdm660.dtsi b/arch/arm64/boot/dts/qcom/sdm660.dtsi
index 4abbdd03d1e7..a1133f23593a 100644
--- a/arch/arm64/boot/dts/qcom/sdm660.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm660.dtsi
@@ -16,14 +16,14 @@ / {
chosen { };
clocks {
- xo_board: xo_board {
+ xo_board: xo-board {
compatible = "fixed-clock";
#clock-cells = <0>;
clock-frequency = <19200000>;
clock-output-names = "xo_board";
};
- sleep_clk: sleep_clk {
+ sleep_clk: sleep-clk {
compatible = "fixed-clock";
#clock-cells = <0>;
clock-frequency = <32764>;
--
2.26.2
^ permalink raw reply related [flat|nested] 24+ messages in thread
* Re: [PATCH 11/18] arm64: qcom: sdm660: don't use underscore in node name
2021-03-08 6:08 ` [PATCH 11/18] arm64: qcom: sdm660: " Vinod Koul
@ 2021-03-10 14:48 ` Konrad Dybcio
0 siblings, 0 replies; 24+ messages in thread
From: Konrad Dybcio @ 2021-03-10 14:48 UTC (permalink / raw)
To: Vinod Koul, Bjorn Andersson
Cc: linux-arm-msm, Andy Gross, Rob Herring, devicetree, linux-kernel
On 08.03.2021 07:08, Vinod Koul wrote:
> We have underscore (_) in node name so fix that up as well.
>
> Fix this by changing node name to use dash (-)
>
> Signed-off-by: Vinod Koul <vkoul@kernel.org>
> ---
> arch/arm64/boot/dts/qcom/sdm660.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
We might want to omit
this one,
arm64: qcom: sdm660: don't use empty memory node,
and
arm64: qcom: sdm660: use reg value for memory node
as our huge-630/660-feature-drop patchset removes all of the nodes in question from sdm660.dtsi and will hopefully be merged in this window
Konrad
^ permalink raw reply [flat|nested] 24+ messages in thread
* [PATCH 12/18] arm64: qcom: msm8996: don't use empty memory node
2021-03-08 6:08 [PATCH 00/18] arm64: qcom: fix dtbs_check warning Vinod Koul
` (10 preceding siblings ...)
2021-03-08 6:08 ` [PATCH 11/18] arm64: qcom: sdm660: " Vinod Koul
@ 2021-03-08 6:08 ` Vinod Koul
2021-03-10 14:46 ` Konrad Dybcio
2021-03-08 6:08 ` [PATCH 13/18] arm64: qcom: msm8998: " Vinod Koul
` (5 subsequent siblings)
17 siblings, 1 reply; 24+ messages in thread
From: Vinod Koul @ 2021-03-08 6:08 UTC (permalink / raw)
To: Bjorn Andersson
Cc: linux-arm-msm, Vinod Koul, Andy Gross, Rob Herring, devicetree,
linux-kernel
We expect bootloader to full memory details but passing empty values
can give warning, so add a default value
Signed-off-by: Vinod Koul <vkoul@kernel.org>
---
arch/arm64/boot/dts/qcom/msm8996.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi
index 957487f84ead..0e2df537fb69 100644
--- a/arch/arm64/boot/dts/qcom/msm8996.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi
@@ -133,10 +133,10 @@ tcsr_mutex: hwlock {
#hwlock-cells = <1>;
};
- memory {
+ memory@80000000 {
device_type = "memory";
/* We expect the bootloader to fill in the reg */
- reg = <0 0 0 0>;
+ reg = <0x0 0x80000000 0x0 0x0>;
};
psci {
--
2.26.2
^ permalink raw reply related [flat|nested] 24+ messages in thread
* Re: [PATCH 12/18] arm64: qcom: msm8996: don't use empty memory node
2021-03-08 6:08 ` [PATCH 12/18] arm64: qcom: msm8996: don't use empty memory node Vinod Koul
@ 2021-03-10 14:46 ` Konrad Dybcio
0 siblings, 0 replies; 24+ messages in thread
From: Konrad Dybcio @ 2021-03-10 14:46 UTC (permalink / raw)
To: Vinod Koul, Bjorn Andersson
Cc: linux-arm-msm, Andy Gross, Rob Herring, devicetree, linux-kernel
On 08.03.2021 07:08, Vinod Koul wrote:
> We expect bootloader to full memory details but passing empty values
> can give warning, so add a default value
>
> Signed-off-by: Vinod Koul <vkoul@kernel.org>
> ---
> arch/arm64/boot/dts/qcom/msm8996.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
MSM8996 SONY Kagura boots.
Tested-by: Konrad Dybcio <konrad.dybcio@somainline.org>
^ permalink raw reply [flat|nested] 24+ messages in thread
* [PATCH 13/18] arm64: qcom: msm8998: don't use empty memory node
2021-03-08 6:08 [PATCH 00/18] arm64: qcom: fix dtbs_check warning Vinod Koul
` (11 preceding siblings ...)
2021-03-08 6:08 ` [PATCH 12/18] arm64: qcom: msm8996: don't use empty memory node Vinod Koul
@ 2021-03-08 6:08 ` Vinod Koul
2021-03-08 6:08 ` [PATCH 14/18] arm64: qcom: sdm630: " Vinod Koul
` (4 subsequent siblings)
17 siblings, 0 replies; 24+ messages in thread
From: Vinod Koul @ 2021-03-08 6:08 UTC (permalink / raw)
To: Bjorn Andersson
Cc: linux-arm-msm, Vinod Koul, Andy Gross, Rob Herring, devicetree,
linux-kernel
We expect bootloader to full memory details but passing empty values
can give warning, so add a default value
Signed-off-by: Vinod Koul <vkoul@kernel.org>
---
arch/arm64/boot/dts/qcom/msm8998.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/msm8998.dtsi b/arch/arm64/boot/dts/qcom/msm8998.dtsi
index 1f2e93aa6553..2949be4740f1 100644
--- a/arch/arm64/boot/dts/qcom/msm8998.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8998.dtsi
@@ -18,10 +18,10 @@ / {
chosen { };
- memory {
+ memory@80000000 {
device_type = "memory";
/* We expect the bootloader to fill in the reg */
- reg = <0 0 0 0>;
+ reg = <0x0 0x80000000 0x0 0x0>;
};
reserved-memory {
--
2.26.2
^ permalink raw reply related [flat|nested] 24+ messages in thread
* [PATCH 14/18] arm64: qcom: sdm630: don't use empty memory node
2021-03-08 6:08 [PATCH 00/18] arm64: qcom: fix dtbs_check warning Vinod Koul
` (12 preceding siblings ...)
2021-03-08 6:08 ` [PATCH 13/18] arm64: qcom: msm8998: " Vinod Koul
@ 2021-03-08 6:08 ` Vinod Koul
2021-03-10 13:49 ` Konrad Dybcio
2021-03-08 6:08 ` [PATCH 15/18] arm64: qcom: sdm660: " Vinod Koul
` (3 subsequent siblings)
17 siblings, 1 reply; 24+ messages in thread
From: Vinod Koul @ 2021-03-08 6:08 UTC (permalink / raw)
To: Bjorn Andersson
Cc: linux-arm-msm, Vinod Koul, Andy Gross, Rob Herring, devicetree,
linux-kernel
We expect bootloader to full memory details but passing empty values
can give warning, so add a default value
Signed-off-by: Vinod Koul <vkoul@kernel.org>
---
arch/arm64/boot/dts/qcom/sdm630.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sdm630.dtsi b/arch/arm64/boot/dts/qcom/sdm630.dtsi
index 5a7cf85d0cf1..23679b9e5e60 100644
--- a/arch/arm64/boot/dts/qcom/sdm630.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm630.dtsi
@@ -311,10 +311,10 @@ scm {
};
};
- memory {
+ memory@80000000 {
device_type = "memory";
/* We expect the bootloader to fill in the reg */
- reg = <0 0 0 0>;
+ reg = <0x0 0x80000000 0x0 0x0>;
};
pmu {
--
2.26.2
^ permalink raw reply related [flat|nested] 24+ messages in thread
* Re: [PATCH 14/18] arm64: qcom: sdm630: don't use empty memory node
2021-03-08 6:08 ` [PATCH 14/18] arm64: qcom: sdm630: " Vinod Koul
@ 2021-03-10 13:49 ` Konrad Dybcio
0 siblings, 0 replies; 24+ messages in thread
From: Konrad Dybcio @ 2021-03-10 13:49 UTC (permalink / raw)
To: Vinod Koul, Bjorn Andersson
Cc: linux-arm-msm, Andy Gross, Rob Herring, devicetree, linux-kernel
On 08.03.2021 07:08, Vinod Koul wrote:
> We expect bootloader to full memory details but passing empty values
> can give warning, so add a default value
>
> Signed-off-by: Vinod Koul <vkoul@kernel.org>
> ---
> arch/arm64/boot/dts/qcom/sdm630.dtsi | 4 ++--
SDM630 SONY Kirin boots.
Tested-by: Konrad Dybcio <konrad.dybcio@somainline.org>
^ permalink raw reply [flat|nested] 24+ messages in thread
* [PATCH 15/18] arm64: qcom: sdm660: don't use empty memory node
2021-03-08 6:08 [PATCH 00/18] arm64: qcom: fix dtbs_check warning Vinod Koul
` (13 preceding siblings ...)
2021-03-08 6:08 ` [PATCH 14/18] arm64: qcom: sdm630: " Vinod Koul
@ 2021-03-08 6:08 ` Vinod Koul
2021-03-08 6:08 ` [PATCH 16/18] arm64: qcom: ipq8074: fix pci node reg property Vinod Koul
` (2 subsequent siblings)
17 siblings, 0 replies; 24+ messages in thread
From: Vinod Koul @ 2021-03-08 6:08 UTC (permalink / raw)
To: Bjorn Andersson
Cc: linux-arm-msm, Vinod Koul, Andy Gross, Rob Herring, devicetree,
linux-kernel
We expect bootloader to full memory details but passing empty values
can give warning, so add a default value
Signed-off-by: Vinod Koul <vkoul@kernel.org>
---
arch/arm64/boot/dts/qcom/sdm660.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sdm660.dtsi b/arch/arm64/boot/dts/qcom/sdm660.dtsi
index a1133f23593a..077abcb195ce 100644
--- a/arch/arm64/boot/dts/qcom/sdm660.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm660.dtsi
@@ -208,10 +208,10 @@ scm {
};
};
- memory {
+ memory@80000000 {
device_type = "memory";
/* We expect the bootloader to fill in the reg */
- reg = <0 0 0 0>;
+ reg = <0x0 0x80000000 0x0 0x0>;
};
psci {
--
2.26.2
^ permalink raw reply related [flat|nested] 24+ messages in thread
* [PATCH 16/18] arm64: qcom: ipq8074: fix pci node reg property
2021-03-08 6:08 [PATCH 00/18] arm64: qcom: fix dtbs_check warning Vinod Koul
` (14 preceding siblings ...)
2021-03-08 6:08 ` [PATCH 15/18] arm64: qcom: sdm660: " Vinod Koul
@ 2021-03-08 6:08 ` Vinod Koul
2021-03-08 6:08 ` [PATCH 17/18] arm64: qcom: sdm660: use reg value for memory node Vinod Koul
2021-03-08 6:08 ` [PATCH 18/18] arm64: qcom: ipq6018: drop '0x' from unit address Vinod Koul
17 siblings, 0 replies; 24+ messages in thread
From: Vinod Koul @ 2021-03-08 6:08 UTC (permalink / raw)
To: Bjorn Andersson
Cc: linux-arm-msm, Vinod Koul, Andy Gross, Rob Herring, devicetree,
linux-kernel
reg property should be array of values, here it is a single array,
leading to below warning:
arch/arm64/boot/dts/qcom/ipq8074-hk01.dt.yaml: soc: pci@10000000:reg:0: [268435456, 3869, 268439328, 168, 557056, 8192, 269484032, 4096] is too long
arch/arm64/boot/dts/qcom/ipq8074-hk01.dt.yaml: soc: pci@10000000:ranges: 'oneOf' conditional failed, one must be fixed:
arch/arm64/boot/dts/qcom/ipq8074-hk01.dt.yaml: soc: pci@10000000:ranges: 'oneOf' conditional failed, one must be fixed:
[[2164260864, 0, 270532608, 270532608, 0, 1048576, 2181038080, 0, 271581184, 271581184, 0, 13631488]] is not of type 'null'
[2164260864, 0, 270532608, 270532608, 0, 1048576, 2181038080, 0, 271581184, 271581184, 0, 13631488] is too long
arch/arm64/boot/dts/qcom/ipq8074-hk01.dt.yaml: soc: pci@20000000:reg:0: [536870912, 3869, 536874784, 168, 524288, 8192, 537919488, 4096] is too long
arch/arm64/boot/dts/qcom/ipq8074-hk01.dt.yaml: soc: pci@20000000:ranges: 'oneOf' conditional failed, one must be fixed:
arch/arm64/boot/dts/qcom/ipq8074-hk01.dt.yaml: soc: pci@20000000:ranges: 'oneOf' conditional failed, one must be fixed:
[[2164260864, 0, 538968064, 538968064, 0, 1048576, 2181038080, 0, 540016640, 540016640, 0, 13631488]] is not of type 'null'
[2164260864, 0, 538968064, 538968064, 0, 1048576, 2181038080, 0, 540016640, 540016640, 0, 13631488] is too long
Signed-off-by: Vinod Koul <vkoul@kernel.org>
---
arch/arm64/boot/dts/qcom/ipq8074.dtsi | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/ipq8074.dtsi b/arch/arm64/boot/dts/qcom/ipq8074.dtsi
index a32e5e79ab0b..e8db62470b23 100644
--- a/arch/arm64/boot/dts/qcom/ipq8074.dtsi
+++ b/arch/arm64/boot/dts/qcom/ipq8074.dtsi
@@ -567,10 +567,10 @@ frame@b128000 {
pcie1: pci@10000000 {
compatible = "qcom,pcie-ipq8074";
- reg = <0x10000000 0xf1d
- 0x10000f20 0xa8
- 0x00088000 0x2000
- 0x10100000 0x1000>;
+ reg = <0x10000000 0xf1d>,
+ <0x10000f20 0xa8>,
+ <0x00088000 0x2000>,
+ <0x10100000 0x1000>;
reg-names = "dbi", "elbi", "parf", "config";
device_type = "pci";
linux,pci-domain = <1>;
@@ -629,10 +629,10 @@ IRQ_TYPE_LEVEL_HIGH>, /* int_c */
pcie0: pci@20000000 {
compatible = "qcom,pcie-ipq8074";
- reg = <0x20000000 0xf1d
- 0x20000f20 0xa8
- 0x00080000 0x2000
- 0x20100000 0x1000>;
+ reg = <0x20000000 0xf1d>,
+ <0x20000f20 0xa8>,
+ <0x00080000 0x2000>,
+ <0x20100000 0x1000>;
reg-names = "dbi", "elbi", "parf", "config";
device_type = "pci";
linux,pci-domain = <0>;
--
2.26.2
^ permalink raw reply related [flat|nested] 24+ messages in thread
* [PATCH 17/18] arm64: qcom: sdm660: use reg value for memory node
2021-03-08 6:08 [PATCH 00/18] arm64: qcom: fix dtbs_check warning Vinod Koul
` (15 preceding siblings ...)
2021-03-08 6:08 ` [PATCH 16/18] arm64: qcom: ipq8074: fix pci node reg property Vinod Koul
@ 2021-03-08 6:08 ` Vinod Koul
2021-03-08 6:08 ` [PATCH 18/18] arm64: qcom: ipq6018: drop '0x' from unit address Vinod Koul
17 siblings, 0 replies; 24+ messages in thread
From: Vinod Koul @ 2021-03-08 6:08 UTC (permalink / raw)
To: Bjorn Andersson
Cc: linux-arm-msm, Vinod Koul, Andy Gross, Rob Herring, devicetree,
linux-kernel
memory node like other node should be node@reg, which is missing in this
case, so fix it up
arch/arm64/boot/dts/qcom/ipq8074-hk01.dt.yaml: /: memory: False schema does not allow {'device_type': ['memory'], 'reg': [[0, 1073741824, 0, 536870912]]}
Signed-off-by: Vinod Koul <vkoul@kernel.org>
---
arch/arm64/boot/dts/qcom/ipq8074-hk01.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/ipq8074-hk01.dts b/arch/arm64/boot/dts/qcom/ipq8074-hk01.dts
index e8c37a1693d3..cc08dc4eb56a 100644
--- a/arch/arm64/boot/dts/qcom/ipq8074-hk01.dts
+++ b/arch/arm64/boot/dts/qcom/ipq8074-hk01.dts
@@ -20,7 +20,7 @@ chosen {
stdout-path = "serial0";
};
- memory {
+ memory@40000000 {
device_type = "memory";
reg = <0x0 0x40000000 0x0 0x20000000>;
};
--
2.26.2
^ permalink raw reply related [flat|nested] 24+ messages in thread
* [PATCH 18/18] arm64: qcom: ipq6018: drop '0x' from unit address
2021-03-08 6:08 [PATCH 00/18] arm64: qcom: fix dtbs_check warning Vinod Koul
` (16 preceding siblings ...)
2021-03-08 6:08 ` [PATCH 17/18] arm64: qcom: sdm660: use reg value for memory node Vinod Koul
@ 2021-03-08 6:08 ` Vinod Koul
17 siblings, 0 replies; 24+ messages in thread
From: Vinod Koul @ 2021-03-08 6:08 UTC (permalink / raw)
To: Bjorn Andersson
Cc: linux-arm-msm, Vinod Koul, Andy Gross, Rob Herring, devicetree,
linux-kernel
Nodes need not contain '0x' for the unit address. Drop it to fix the
below warning:
arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dt.yaml: reserved-memory:
'memory@0x60000' does not match any of the regexes
Signed-off-by: Vinod Koul <vkoul@kernel.org>
---
arch/arm64/boot/dts/qcom/ipq6018.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/ipq6018.dtsi b/arch/arm64/boot/dts/qcom/ipq6018.dtsi
index 9fa5b028e4f3..23ee1bfa4318 100644
--- a/arch/arm64/boot/dts/qcom/ipq6018.dtsi
+++ b/arch/arm64/boot/dts/qcom/ipq6018.dtsi
@@ -151,7 +151,7 @@ reserved-memory {
#size-cells = <2>;
ranges;
- rpm_msg_ram: memory@0x60000 {
+ rpm_msg_ram: memory@60000 {
reg = <0x0 0x60000 0x0 0x6000>;
no-map;
};
--
2.26.2
^ permalink raw reply related [flat|nested] 24+ messages in thread