From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 899DAC433E9 for ; Mon, 8 Mar 2021 09:51:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 56A20651B6 for ; Mon, 8 Mar 2021 09:51:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230489AbhCHJuv (ORCPT ); Mon, 8 Mar 2021 04:50:51 -0500 Received: from elvis.franken.de ([193.175.24.41]:57382 "EHLO elvis.franken.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230455AbhCHJuT (ORCPT ); Mon, 8 Mar 2021 04:50:19 -0500 Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1lJCWn-0002nE-00; Mon, 08 Mar 2021 10:50:17 +0100 Received: by alpha.franken.de (Postfix, from userid 1000) id 96E91C1214; Mon, 8 Mar 2021 10:49:47 +0100 (CET) Date: Mon, 8 Mar 2021 10:49:47 +0100 From: Thomas Bogendoerfer To: Jiaxun Yang Cc: Qing Zhang , Huacai Chen , Thomas Gleixner , Marc Zyngier , "linux-mips@vger.kernel.org" , linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] MIPS: Loongson64: Move loongson_system_configuration to loongson.h Message-ID: <20210308094947.GA4924@alpha.franken.de> References: <20210304110057.22144-1-zhangqing@loongson.cn> <20210304110057.22144-3-zhangqing@loongson.cn> <20210306080337.GC4744@alpha.franken.de> <20210306095308.GA5751@alpha.franken.de> <3a5481f9-d1d5-4439-9679-ad7615ba8009@www.fastmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3a5481f9-d1d5-4439-9679-ad7615ba8009@www.fastmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Mar 06, 2021 at 06:55:41PM +0800, Jiaxun Yang wrote: > > > On Sat, Mar 6, 2021, at 5:53 PM, Thomas Bogendoerfer wrote: > [...] > > Just to understand you, you want > > > > arch/mips/include/asm/loongson/2ef > > arch/mips/include/asm/loongson/32 > > arch/mips/include/asm/loongson/64 > > Yeah it looks reasonable but from my point of view doing these movement > brings no actual benefit :-( oh it does for sure. There will no more build errors for non loogson configs for things like #include because it will not work for loongson either. And it will be clear, which of the 3 loongson.h is used. Which then gives chances for even more cleanups. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]