From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_GIT autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0661AC433DB for ; Mon, 8 Mar 2021 14:31:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AB141651DE for ; Mon, 8 Mar 2021 14:31:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229893AbhCHOag (ORCPT ); Mon, 8 Mar 2021 09:30:36 -0500 Received: from mailgw02.mediatek.com ([210.61.82.184]:49547 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S229899AbhCHOaQ (ORCPT ); Mon, 8 Mar 2021 09:30:16 -0500 X-UUID: c11648237da4410b8d16389ad7ef6373-20210308 X-UUID: c11648237da4410b8d16389ad7ef6373-20210308 Received: from mtkexhb02.mediatek.inc [(172.21.101.103)] by mailgw02.mediatek.com (envelope-from ) (Cellopoint E-mail Firewall v4.1.14 Build 0819 with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 680947260; Mon, 08 Mar 2021 22:30:13 +0800 Received: from MTKCAS06.mediatek.inc (172.21.101.30) by mtkmbs05n2.mediatek.inc (172.21.101.140) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 8 Mar 2021 22:30:12 +0800 Received: from mtksdccf07.mediatek.inc (172.21.84.99) by MTKCAS06.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Mon, 8 Mar 2021 22:30:12 +0800 From: Mark-PK Tsai To: , Mark-PK Tsai CC: , , , , , , , Subject: Re: [PATCH v2] irqchip/irq-mst: Support polarity configuration Date: Mon, 8 Mar 2021 22:30:11 +0800 Message-ID: <20210308143011.24538-1-mark-pk.tsai@mediatek.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain X-MTK: N Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Daniel Palmer >On Mon, 8 Mar 2021 at 15:05, Mark-PK Tsai wrote: >> +static int mst_irq_chip_set_type(struct irq_data *data, unsigned int type) > > +{ >> + if (type != IRQ_TYPE_LEVEL_LOW && type != IRQ_TYPE_LEVEL_HIGH) >> + return -EINVAL; >> + > >Does this mean we can't do rising or falling edge interrupts? Yes, the interrupt of mst-intc is either level high or level low. Actually the input signal can be pulse, but it will be converted to level by the latch in mst-intc. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_GIT autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BFFF5C433E0 for ; Mon, 8 Mar 2021 14:30:48 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 34C0E6519C for ; Mon, 8 Mar 2021 14:30:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 34C0E6519C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID:Date: Subject:CC:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=xjLgg4/4v21YhM3919ZavooEJshZ59AI4kxDv9JRP4g=; b=drL2rmADXMcDLJtJWVcZUqZQW akyjX80jBCHZ/F/R6h8pDjwZnqHejBDxGYvOSG3oulpJpE3Bde5ZgHeeVr3H5Rhp0HezV0ZKaV1bF CTRPZeoenrxKr79oRm0uoRcd0O7vjMW5zLP2dr9HaUZNnb0dLqqr2NV52/7sJrz5ToQfjpTYoWLc1 8SBCILw9fazzMtjMv2k4ss498Weh63ZmUO4vu5Wog3cqLP8IcfNltd11BzIsROrk5deE659Y3+x9A WotNMS5DvmjNFSpCvcV/Kz6RLzIIlLkmFwpfXFuAM+NJIPjfzYYT0JJkarYzE2zXoN6jAKbbSRWSS C3XD65vkQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lJGu1-000F3e-Va; Mon, 08 Mar 2021 14:30:34 +0000 Received: from mailgw01.mediatek.com ([66.171.122.165]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lJGtt-000F0h-CN; Mon, 08 Mar 2021 14:30:32 +0000 X-UUID: 80ef19772f8643a09e1bd9825a285b76-20210308 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:CC:To:From; bh=+FRrggcAXOSprzwXzMlc9ZGi7hukd7oHo51GH8hPbLU=; b=lMx26hi6sh3dPj+rhTfcAVOrC50LxtZubgVT2kEUBdQhYnDqLV1J6azpD3Lk9HnJONW79yDBqYkTaxhFC8Pejhu6FQtg4t7aHzSFGjTuyAHL7Wa2c4lpptur1ebnMs30HwrFjWW+yXNAPYkDivtFQjkiI+z2YhZNKevsAkM32gs=; X-UUID: 80ef19772f8643a09e1bd9825a285b76-20210308 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 2094700522; Mon, 08 Mar 2021 06:30:21 -0800 Received: from mtkmbs05n2.mediatek.inc (172.21.101.140) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 8 Mar 2021 06:30:14 -0800 Received: from MTKCAS06.mediatek.inc (172.21.101.30) by mtkmbs05n2.mediatek.inc (172.21.101.140) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 8 Mar 2021 22:30:12 +0800 Received: from mtksdccf07.mediatek.inc (172.21.84.99) by MTKCAS06.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Mon, 8 Mar 2021 22:30:12 +0800 From: Mark-PK Tsai To: , Mark-PK Tsai CC: , , , , , , , Subject: Re: [PATCH v2] irqchip/irq-mst: Support polarity configuration Date: Mon, 8 Mar 2021 22:30:11 +0800 Message-ID: <20210308143011.24538-1-mark-pk.tsai@mediatek.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: References: MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210308_143027_033019_A4A98FE1 X-CRM114-Status: UNSURE ( 7.65 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org From: Daniel Palmer >On Mon, 8 Mar 2021 at 15:05, Mark-PK Tsai wrote: >> +static int mst_irq_chip_set_type(struct irq_data *data, unsigned int type) > > +{ >> + if (type != IRQ_TYPE_LEVEL_LOW && type != IRQ_TYPE_LEVEL_HIGH) >> + return -EINVAL; >> + > >Does this mean we can't do rising or falling edge interrupts? Yes, the interrupt of mst-intc is either level high or level low. Actually the input signal can be pulse, but it will be converted to level by the latch in mst-intc. _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_GIT autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6558AC433E0 for ; Mon, 8 Mar 2021 14:32:22 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E5525651A2 for ; Mon, 8 Mar 2021 14:32:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E5525651A2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID:Date: Subject:CC:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=XWNedYL9ESrIzClYp5j6jXsW3kY0IQY2pdNFjm+MHMk=; b=RcGl2MnvO/8tva4RSa4TzQgdm sNblwKk7+bAD5v1INY+SChKrGws8p7PjgR0pw9GkCDYFN6xb/59ldIJqJT1figbfVb2E39oktzm25 XXozp5ijVwSvnfdkn+hKOYI4mRrV4aQgH97/KvzhGa8IFTEoByC417QLx2xd0ByY5At24YryHTBpv VEFIlgQERprRM4NhOwQepyxFqPrL3rN62MPpxJ13vpUpFotIzOEVVOES2KfIjNCRgfuUEd8I/CekO FcHrxEsJfEhsOpRUfvfa4u8+HbmNHjZT1LvEsVB7XEE9LCbrTWrwEGYqCtzYnodVrqQ4+akHit4I4 0JOJcmCDA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lJGu5-000F4K-78; Mon, 08 Mar 2021 14:30:37 +0000 Received: from mailgw01.mediatek.com ([66.171.122.165]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lJGtt-000F0h-CN; Mon, 08 Mar 2021 14:30:32 +0000 X-UUID: 80ef19772f8643a09e1bd9825a285b76-20210308 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:CC:To:From; bh=+FRrggcAXOSprzwXzMlc9ZGi7hukd7oHo51GH8hPbLU=; b=lMx26hi6sh3dPj+rhTfcAVOrC50LxtZubgVT2kEUBdQhYnDqLV1J6azpD3Lk9HnJONW79yDBqYkTaxhFC8Pejhu6FQtg4t7aHzSFGjTuyAHL7Wa2c4lpptur1ebnMs30HwrFjWW+yXNAPYkDivtFQjkiI+z2YhZNKevsAkM32gs=; X-UUID: 80ef19772f8643a09e1bd9825a285b76-20210308 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 2094700522; Mon, 08 Mar 2021 06:30:21 -0800 Received: from mtkmbs05n2.mediatek.inc (172.21.101.140) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 8 Mar 2021 06:30:14 -0800 Received: from MTKCAS06.mediatek.inc (172.21.101.30) by mtkmbs05n2.mediatek.inc (172.21.101.140) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 8 Mar 2021 22:30:12 +0800 Received: from mtksdccf07.mediatek.inc (172.21.84.99) by MTKCAS06.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Mon, 8 Mar 2021 22:30:12 +0800 From: Mark-PK Tsai To: , Mark-PK Tsai CC: , , , , , , , Subject: Re: [PATCH v2] irqchip/irq-mst: Support polarity configuration Date: Mon, 8 Mar 2021 22:30:11 +0800 Message-ID: <20210308143011.24538-1-mark-pk.tsai@mediatek.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: References: MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210308_143027_033019_A4A98FE1 X-CRM114-Status: UNSURE ( 7.65 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Daniel Palmer >On Mon, 8 Mar 2021 at 15:05, Mark-PK Tsai wrote: >> +static int mst_irq_chip_set_type(struct irq_data *data, unsigned int type) > > +{ >> + if (type != IRQ_TYPE_LEVEL_LOW && type != IRQ_TYPE_LEVEL_HIGH) >> + return -EINVAL; >> + > >Does this mean we can't do rising or falling edge interrupts? Yes, the interrupt of mst-intc is either level high or level low. Actually the input signal can be pulse, but it will be converted to level by the latch in mst-intc. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel