From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-22.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22C51C433E0 for ; Mon, 8 Mar 2021 14:39:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E84FB64EDE for ; Mon, 8 Mar 2021 14:39:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231221AbhCHOip (ORCPT ); Mon, 8 Mar 2021 09:38:45 -0500 Received: from mail.kernel.org ([198.145.29.99]:46182 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231246AbhCHOiV (ORCPT ); Mon, 8 Mar 2021 09:38:21 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 491A8651AF; Mon, 8 Mar 2021 14:38:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1615214301; bh=xUkap4mngTV+pjAfYLVmPPAgPzqiFl5Y3b7clSrqxNE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XUr1kAp/wcltPWZPPgh2hrzzLDbeNBzkAFUiiuZsh/5zguAdt6kf8MSe4fcNFmvgK +XLarVPYeHlifjSe5begeeW9jdu/30EhNo2T9GqbPI2yjAtTazUx10V4+dzskWpuIC V+C/tRMR569C0AjCG7WLPYMNrcvJYWgdJ+8cf/PGqf9cBmnj+P2RmTB96Ccz5eOvA7 QnV4MKJJbxXhqOPRI7vphwkS4VgvYdRJRdGgnQONlA4U05PYSz5b/FKZqXt4QRJO57 YjFzBG5uxUPtKvXEXnRUdeMa1JWj/nasuf3pLLCvXyRMHwOaFszsaC11bmn4Yx4SOo m4IX4KbXm60gQ== Date: Mon, 8 Mar 2021 14:38:16 +0000 From: Will Deacon To: Sami Tolvanen Cc: Marc Zyngier , James Morse , Nathan Chancellor , Nick Desaulniers , Ard Biesheuvel , Kees Cook , Julien Thierry , Suzuki K Poulose , Catalin Marinas , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org Subject: Re: [PATCH] KVM: arm64: Don't use cbz/adr with external symbols Message-ID: <20210308143815.GA26312@willie-the-truck> References: <20210305202124.3768527-1-samitolvanen@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210305202124.3768527-1-samitolvanen@google.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 05, 2021 at 12:21:24PM -0800, Sami Tolvanen wrote: > allmodconfig + CONFIG_LTO_CLANG_THIN=y fails to build due to following > linker errors: > > ld.lld: error: irqbypass.c:(function __guest_enter: .text+0x21CC): > relocation R_AARCH64_CONDBR19 out of range: 2031220 is not in > [-1048576, 1048575]; references hyp_panic > >>> defined in vmlinux.o > > ld.lld: error: irqbypass.c:(function __guest_enter: .text+0x21E0): > relocation R_AARCH64_ADR_PREL_LO21 out of range: 2031200 is not in > [-1048576, 1048575]; references hyp_panic > >>> defined in vmlinux.o > > This is because with LTO, the compiler ends up placing hyp_panic() > more than 1MB away from __guest_enter(). Use an unconditional branch > and adr_l instead to fix the issue. > > Link: https://github.com/ClangBuiltLinux/linux/issues/1317 > Reported-by: Nathan Chancellor > Suggested-by: Marc Zyngier > Suggested-by: Ard Biesheuvel > Signed-off-by: Sami Tolvanen > --- > arch/arm64/kvm/hyp/entry.S | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) Acked-by: Will Deacon Will From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.3 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9DFFBC433DB for ; Mon, 8 Mar 2021 14:38:28 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id 10A11651E8 for ; Mon, 8 Mar 2021 14:38:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 10A11651E8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 8E42B4B5F0; Mon, 8 Mar 2021 09:38:27 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@kernel.org Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id yO6TJJCGSLfw; Mon, 8 Mar 2021 09:38:26 -0500 (EST) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 50A924B594; Mon, 8 Mar 2021 09:38:26 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 9E7AC4B594 for ; Mon, 8 Mar 2021 09:38:24 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Jw0+HvwApyzm for ; Mon, 8 Mar 2021 09:38:23 -0500 (EST) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id 5072F4B56E for ; Mon, 8 Mar 2021 09:38:23 -0500 (EST) Received: by mail.kernel.org (Postfix) with ESMTPSA id 491A8651AF; Mon, 8 Mar 2021 14:38:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1615214301; bh=xUkap4mngTV+pjAfYLVmPPAgPzqiFl5Y3b7clSrqxNE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XUr1kAp/wcltPWZPPgh2hrzzLDbeNBzkAFUiiuZsh/5zguAdt6kf8MSe4fcNFmvgK +XLarVPYeHlifjSe5begeeW9jdu/30EhNo2T9GqbPI2yjAtTazUx10V4+dzskWpuIC V+C/tRMR569C0AjCG7WLPYMNrcvJYWgdJ+8cf/PGqf9cBmnj+P2RmTB96Ccz5eOvA7 QnV4MKJJbxXhqOPRI7vphwkS4VgvYdRJRdGgnQONlA4U05PYSz5b/FKZqXt4QRJO57 YjFzBG5uxUPtKvXEXnRUdeMa1JWj/nasuf3pLLCvXyRMHwOaFszsaC11bmn4Yx4SOo m4IX4KbXm60gQ== Date: Mon, 8 Mar 2021 14:38:16 +0000 From: Will Deacon To: Sami Tolvanen Subject: Re: [PATCH] KVM: arm64: Don't use cbz/adr with external symbols Message-ID: <20210308143815.GA26312@willie-the-truck> References: <20210305202124.3768527-1-samitolvanen@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210305202124.3768527-1-samitolvanen@google.com> User-Agent: Mutt/1.10.1 (2018-07-13) Cc: Kees Cook , Marc Zyngier , Nick Desaulniers , linux-kernel@vger.kernel.org, kvmarm@lists.cs.columbia.edu, Nathan Chancellor , linux-arm-kernel@lists.infradead.org, Catalin Marinas X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu On Fri, Mar 05, 2021 at 12:21:24PM -0800, Sami Tolvanen wrote: > allmodconfig + CONFIG_LTO_CLANG_THIN=y fails to build due to following > linker errors: > > ld.lld: error: irqbypass.c:(function __guest_enter: .text+0x21CC): > relocation R_AARCH64_CONDBR19 out of range: 2031220 is not in > [-1048576, 1048575]; references hyp_panic > >>> defined in vmlinux.o > > ld.lld: error: irqbypass.c:(function __guest_enter: .text+0x21E0): > relocation R_AARCH64_ADR_PREL_LO21 out of range: 2031200 is not in > [-1048576, 1048575]; references hyp_panic > >>> defined in vmlinux.o > > This is because with LTO, the compiler ends up placing hyp_panic() > more than 1MB away from __guest_enter(). Use an unconditional branch > and adr_l instead to fix the issue. > > Link: https://github.com/ClangBuiltLinux/linux/issues/1317 > Reported-by: Nathan Chancellor > Suggested-by: Marc Zyngier > Suggested-by: Ard Biesheuvel > Signed-off-by: Sami Tolvanen > --- > arch/arm64/kvm/hyp/entry.S | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) Acked-by: Will Deacon Will _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A863DC433DB for ; Mon, 8 Mar 2021 14:40:15 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4170561583 for ; Mon, 8 Mar 2021 14:40:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4170561583 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=QR/Nx3Vvr2/MapV0JoSlmy7Z+C2v/X/zGbgM01oN5BM=; b=EaY7tRx1AiJMNzSApWE+X9tRZ OhH0I/dgkcOLbYrKztsk1Mj12JsnaXMZ5jYs4z0GyeHm6QiVXYiKHHxHE5Eq5eyzciNtWZmcYYjYn F3Y8jCJdsjd6fz0nzEXKO2N62mJWWp94VH84FTvK6kklra14wHE6vGgyEWvnxi5HMELP6slxk3wFT N9PknCiIgS+ccFZWR5ToHEanHidKH1DDcpC5rsnwL1lVI34cz1dLJL2zjF9y+IGpdEzzo84krseNZ g8pqn1s+xL5fzBJp2q0rRCNryHMlwbRCFfqmff89mq9boA8KOEII8MJXD0JD+q4SWDMu66o5OHuPg /jKv943Eg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lJH1h-000HFJ-7e; Mon, 08 Mar 2021 14:38:30 +0000 Received: from mail.kernel.org ([198.145.29.99]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lJH1a-000HDd-TA for linux-arm-kernel@lists.infradead.org; Mon, 08 Mar 2021 14:38:25 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 491A8651AF; Mon, 8 Mar 2021 14:38:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1615214301; bh=xUkap4mngTV+pjAfYLVmPPAgPzqiFl5Y3b7clSrqxNE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XUr1kAp/wcltPWZPPgh2hrzzLDbeNBzkAFUiiuZsh/5zguAdt6kf8MSe4fcNFmvgK +XLarVPYeHlifjSe5begeeW9jdu/30EhNo2T9GqbPI2yjAtTazUx10V4+dzskWpuIC V+C/tRMR569C0AjCG7WLPYMNrcvJYWgdJ+8cf/PGqf9cBmnj+P2RmTB96Ccz5eOvA7 QnV4MKJJbxXhqOPRI7vphwkS4VgvYdRJRdGgnQONlA4U05PYSz5b/FKZqXt4QRJO57 YjFzBG5uxUPtKvXEXnRUdeMa1JWj/nasuf3pLLCvXyRMHwOaFszsaC11bmn4Yx4SOo m4IX4KbXm60gQ== Date: Mon, 8 Mar 2021 14:38:16 +0000 From: Will Deacon To: Sami Tolvanen Cc: Marc Zyngier , James Morse , Nathan Chancellor , Nick Desaulniers , Ard Biesheuvel , Kees Cook , Julien Thierry , Suzuki K Poulose , Catalin Marinas , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org Subject: Re: [PATCH] KVM: arm64: Don't use cbz/adr with external symbols Message-ID: <20210308143815.GA26312@willie-the-truck> References: <20210305202124.3768527-1-samitolvanen@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210305202124.3768527-1-samitolvanen@google.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210308_143823_349338_9782BE8C X-CRM114-Status: GOOD ( 12.36 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Mar 05, 2021 at 12:21:24PM -0800, Sami Tolvanen wrote: > allmodconfig + CONFIG_LTO_CLANG_THIN=y fails to build due to following > linker errors: > > ld.lld: error: irqbypass.c:(function __guest_enter: .text+0x21CC): > relocation R_AARCH64_CONDBR19 out of range: 2031220 is not in > [-1048576, 1048575]; references hyp_panic > >>> defined in vmlinux.o > > ld.lld: error: irqbypass.c:(function __guest_enter: .text+0x21E0): > relocation R_AARCH64_ADR_PREL_LO21 out of range: 2031200 is not in > [-1048576, 1048575]; references hyp_panic > >>> defined in vmlinux.o > > This is because with LTO, the compiler ends up placing hyp_panic() > more than 1MB away from __guest_enter(). Use an unconditional branch > and adr_l instead to fix the issue. > > Link: https://github.com/ClangBuiltLinux/linux/issues/1317 > Reported-by: Nathan Chancellor > Suggested-by: Marc Zyngier > Suggested-by: Ard Biesheuvel > Signed-off-by: Sami Tolvanen > --- > arch/arm64/kvm/hyp/entry.S | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) Acked-by: Will Deacon Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel