From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5EB81C433E9 for ; Tue, 9 Mar 2021 20:03:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2EA7964F36 for ; Tue, 9 Mar 2021 20:03:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231652AbhCIUCq (ORCPT ); Tue, 9 Mar 2021 15:02:46 -0500 Received: from mail.kernel.org ([198.145.29.99]:48238 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230431AbhCIUCb (ORCPT ); Tue, 9 Mar 2021 15:02:31 -0500 Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 13CE960C3E; Tue, 9 Mar 2021 20:02:29 +0000 (UTC) Date: Tue, 9 Mar 2021 15:02:27 -0500 From: Steven Rostedt To: David Ahern Cc: Tony Lu , davem@davemloft.net, mingo@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: add net namespace inode for all net_dev events Message-ID: <20210309150227.48281a18@gandalf.local.home> In-Reply-To: <5fda3ef7-d760-df4f-e076-23b635f6c758@gmail.com> References: <20210309044349.6605-1-tonylu@linux.alibaba.com> <20210309124011.709c6cd3@gandalf.local.home> <5fda3ef7-d760-df4f-e076-23b635f6c758@gmail.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 9 Mar 2021 12:53:37 -0700 David Ahern wrote: > Changing the order of the fields will impact any bpf programs expecting > the existing format I thought bpf programs were not API. And why are they not parsing this information? They have these offsets hard coded???? Why would they do that! The information to extract the data where ever it is has been there from day 1! Way before BPF ever had access to trace events. Please, STOP HARD CODING FIELD OFFSETS!!!! This is why people do not want to use trace points in the first place. Because tools do stupid things. -- Steve