[PATCH v3 1/1] NFSD: fix error handling in NFSv4.0 callbacks

From: Olga Kornievskaia <olga.kornievskaia@gmail.com>
To: bfields@redhat.com, chuck.lever@oracle.com
Cc: linux-nfs@vger.kernel.org
Subject: [PATCH v3 1/1] NFSD: fix error handling in NFSv4.0 callbacks
Date: Tue,  9 Mar 2021 13:23:37 -0500	[thread overview]
Message-ID: <20210309182337.62308-1-olga.kornievskaia@gmail.com> (raw)

If the server's attempts at sending a callback request fails either due
to connection or authentication issues, the server needs to set
NFS4ERR_CB_PATH_DOWN in response to RENEW so that client can recover.

Suggested-by: Bruce Fields <bfields@redhat.com>
Signed-off-by: Olga Kornievskaia <kolga@netapp.com>
---
 fs/nfsd/nfs4callback.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/fs/nfsd/nfs4callback.c b/fs/nfsd/nfs4callback.c
index 052be5bf9ef5..f436d2ca5223 100644
--- a/fs/nfsd/nfs4callback.c
+++ b/fs/nfsd/nfs4callback.c
@@ -1186,11 +1186,8 @@ static void nfsd4_cb_done(struct rpc_task *task, void *calldata)
 		rpc_restart_call_prepare(task);
 		return;
 	case 1:
-		switch (task->tk_status) {
-		case -EIO:
-		case -ETIMEDOUT:
+		if (task->tk_status)
 			nfsd4_mark_cb_down(clp, task->tk_status);
-		}
 		break;
 	default:
 		BUG();
-- 
2.27.0

