All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Documentation: sysrq: update description about sysrq crash
@ 2021-03-09 19:15 Gao Xiang
  2021-03-15 20:23 ` Jonathan Corbet
  0 siblings, 1 reply; 2+ messages in thread
From: Gao Xiang @ 2021-03-09 19:15 UTC (permalink / raw)
  To: linux-doc, Jonathan Corbet
  Cc: linux-kernel, Gao Xiang, Matthias Kaehlcke, Greg Kroah-Hartman, Zefan Li

After commit 8341f2f222d7 ("sysrq: Use panic() to force a crash"),
a crash was not generated by dereferencing a NULL pointer anymore.

Let's update documentation as well to make it less misleading.

Cc: Matthias Kaehlcke <mka@chromium.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jonathan Corbet <corbet@lwn.net>
Cc: Zefan Li <lizefan.x@bytedance.com>
Signed-off-by: Gao Xiang <hsiangkao@redhat.com>
---
 Documentation/admin-guide/sysrq.rst | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/admin-guide/sysrq.rst b/Documentation/admin-guide/sysrq.rst
index 67dfa4c29093..60ce5f5ebab6 100644
--- a/Documentation/admin-guide/sysrq.rst
+++ b/Documentation/admin-guide/sysrq.rst
@@ -90,8 +90,8 @@ Command	    Function
 ``b``	    Will immediately reboot the system without syncing or unmounting
             your disks.
 
-``c``	    Will perform a system crash by a NULL pointer dereference.
-            A crashdump will be taken if configured.
+``c``	    Will perform a system crash and a crashdump will be taken
+            if configured.
 
 ``d``	    Shows all locks that are held.
 
-- 
2.27.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] Documentation: sysrq: update description about sysrq crash
  2021-03-09 19:15 [PATCH] Documentation: sysrq: update description about sysrq crash Gao Xiang
@ 2021-03-15 20:23 ` Jonathan Corbet
  0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Corbet @ 2021-03-15 20:23 UTC (permalink / raw)
  To: Gao Xiang, linux-doc
  Cc: linux-kernel, Gao Xiang, Matthias Kaehlcke, Greg Kroah-Hartman, Zefan Li

Gao Xiang <hsiangkao@redhat.com> writes:

> After commit 8341f2f222d7 ("sysrq: Use panic() to force a crash"),
> a crash was not generated by dereferencing a NULL pointer anymore.
>
> Let's update documentation as well to make it less misleading.
>
> Cc: Matthias Kaehlcke <mka@chromium.org>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Jonathan Corbet <corbet@lwn.net>
> Cc: Zefan Li <lizefan.x@bytedance.com>
> Signed-off-by: Gao Xiang <hsiangkao@redhat.com>
> ---
>  Documentation/admin-guide/sysrq.rst | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/admin-guide/sysrq.rst b/Documentation/admin-guide/sysrq.rst
> index 67dfa4c29093..60ce5f5ebab6 100644
> --- a/Documentation/admin-guide/sysrq.rst
> +++ b/Documentation/admin-guide/sysrq.rst
> @@ -90,8 +90,8 @@ Command	    Function
>  ``b``	    Will immediately reboot the system without syncing or unmounting
>              your disks.
>  
> -``c``	    Will perform a system crash by a NULL pointer dereference.
> -            A crashdump will be taken if configured.
> +``c``	    Will perform a system crash and a crashdump will be taken
> +            if configured.

Makes sense. Applied, thanks.

jon

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-03-15 20:24 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-09 19:15 [PATCH] Documentation: sysrq: update description about sysrq crash Gao Xiang
2021-03-15 20:23 ` Jonathan Corbet

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.