From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2842AC433DB for ; Tue, 9 Mar 2021 19:44:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CEC0C65229 for ; Tue, 9 Mar 2021 19:44:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231468AbhCIToR (ORCPT ); Tue, 9 Mar 2021 14:44:17 -0500 Received: from mx2.suse.de ([195.135.220.15]:43306 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231326AbhCIToH (ORCPT ); Tue, 9 Mar 2021 14:44:07 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id EC710AC1F; Tue, 9 Mar 2021 19:44:05 +0000 (UTC) Date: Tue, 9 Mar 2021 20:44:04 +0100 From: Michal =?iso-8859-1?Q?Such=E1nek?= To: Masahiro Yamada Cc: linux-arm-kernel , Catalin Marinas , Will Deacon , Linux Kernel Mailing List Subject: Re: [PATCH] arm64: make STACKPROTECTOR_PER_TASK configurable. Message-ID: <20210309194404.GC6564@kitsune.suse.cz> References: <20210309123544.14040-1-msuchanek@suse.de> <20210309133523.GX6564@kitsune.suse.cz> <20210309151046.GZ6564@kitsune.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.11.3 (2019-02-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 10, 2021 at 04:07:00AM +0900, Masahiro Yamada wrote: > On Wed, Mar 10, 2021 at 12:10 AM Michal Suchánek wrote: > > > > On Tue, Mar 09, 2021 at 11:53:21PM +0900, Masahiro Yamada wrote: > > > On Tue, Mar 9, 2021 at 10:35 PM Michal Suchánek wrote: > > > > > > > > On Tue, Mar 09, 2021 at 10:22:36PM +0900, Masahiro Yamada wrote: > > > > > On Tue, Mar 9, 2021 at 9:35 PM Michal Suchanek wrote: > > > > > > > > > > > > When using dummy-tools STACKPROTECTOR_PER_TASK is unconditionally > > > > > > selected. This defeats the purpose of the all-enabled tool. > > > > > > > > > > > > Description copied from arm > > > > > > > > > > > > Cc: Masahiro Yamada > > > > > > Signed-off-by: Michal Suchanek > > > > > > > > > > > > > > > Could you explain what problem > > > > > this patch is trying to solve? > > > > > > > > The option cannot be disabled when compiler has the required capability. > > > > > > > > > Yes. > > > Currently, this symbol claims "def_bool y", > > > so there is no way to disable it. > > > > > > But, it comes from the nature of Kconfig in general. > > > > > > dummy-tools is completely unrelated here. > > > > dummy-tools makes all configuration options available in order to be > > able to author configuration files on system different from the one > > where the kernel is built. This prevents authoring a configuration file > > with this option disabled. > > > No. > dummy-tools enables as many $(cc-option, ...) > and $(shell, ...) as possible. That's it. > > > In my understanding, STACKPROTECTOR_PER_TASK > should not be user-configurable. > That is why 'def_bool y'. How do you author a specific configuration with dummy-tools when options are allowed to unconditionally follow these options that dummy-tools enables? Thanks Michal From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2B56C433E0 for ; Tue, 9 Mar 2021 19:45:34 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 590AD6522D for ; Tue, 9 Mar 2021 19:45:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 590AD6522D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=IkUHHoNORhYdrA712CxJXn8MgHFzehACAYxxAVCeAHM=; b=VI8XAn8ePlM66S7ThChrxFkdg rs3ffGDMMd5a5SE++FJDgAUzGgemEdkMtbPcjPosZGn1GL0YGpVxHtN59nBgY+V9TmR6sASvlXnXd 6rmUyxhQBJRAI+keEZdz/YQQwKRugqW+lqKctqHSDU21gaxsw3INS8qfVAxenrsMr2/5w5X/SHKCC S3FPTpZlpL8S4853y64KAOzSdiC5VgIgvcguZuLQQGiBbdr7KkNAZpYKkyjlt/uaMxc6sH5slid5U J3v2t9qh3YxHnDxvjI9ImX9hwGgs8ToLvo4WXPu/7tUTmuW1DdgD7q/3Amvr+umBI0IQ8cDkyiQjq NfiEQBM+g==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lJiH5-005Jqa-2h; Tue, 09 Mar 2021 19:44:11 +0000 Received: from mx2.suse.de ([195.135.220.15]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lJiH0-005Jpx-IO for linux-arm-kernel@lists.infradead.org; Tue, 09 Mar 2021 19:44:08 +0000 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id EC710AC1F; Tue, 9 Mar 2021 19:44:05 +0000 (UTC) Date: Tue, 9 Mar 2021 20:44:04 +0100 From: Michal =?iso-8859-1?Q?Such=E1nek?= To: Masahiro Yamada Cc: linux-arm-kernel , Catalin Marinas , Will Deacon , Linux Kernel Mailing List Subject: Re: [PATCH] arm64: make STACKPROTECTOR_PER_TASK configurable. Message-ID: <20210309194404.GC6564@kitsune.suse.cz> References: <20210309123544.14040-1-msuchanek@suse.de> <20210309133523.GX6564@kitsune.suse.cz> <20210309151046.GZ6564@kitsune.suse.cz> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.3 (2019-02-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210309_194406_847516_6B15FA49 X-CRM114-Status: GOOD ( 23.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Mar 10, 2021 at 04:07:00AM +0900, Masahiro Yamada wrote: > On Wed, Mar 10, 2021 at 12:10 AM Michal Such=E1nek wr= ote: > > > > On Tue, Mar 09, 2021 at 11:53:21PM +0900, Masahiro Yamada wrote: > > > On Tue, Mar 9, 2021 at 10:35 PM Michal Such=E1nek = wrote: > > > > > > > > On Tue, Mar 09, 2021 at 10:22:36PM +0900, Masahiro Yamada wrote: > > > > > On Tue, Mar 9, 2021 at 9:35 PM Michal Suchanek wrote: > > > > > > > > > > > > When using dummy-tools STACKPROTECTOR_PER_TASK is unconditional= ly > > > > > > selected. This defeats the purpose of the all-enabled tool. > > > > > > > > > > > > Description copied from arm > > > > > > > > > > > > Cc: Masahiro Yamada > > > > > > Signed-off-by: Michal Suchanek > > > > > > > > > > > > > > > Could you explain what problem > > > > > this patch is trying to solve? > > > > > > > > The option cannot be disabled when compiler has the required capabi= lity. > > > > > > > > > Yes. > > > Currently, this symbol claims "def_bool y", > > > so there is no way to disable it. > > > > > > But, it comes from the nature of Kconfig in general. > > > > > > dummy-tools is completely unrelated here. > > > > dummy-tools makes all configuration options available in order to be > > able to author configuration files on system different from the one > > where the kernel is built. This prevents authoring a configuration file > > with this option disabled. > = > = > No. > dummy-tools enables as many $(cc-option, ...) > and $(shell, ...) as possible. That's it. > = > = > In my understanding, STACKPROTECTOR_PER_TASK > should not be user-configurable. > That is why 'def_bool y'. How do you author a specific configuration with dummy-tools when options are allowed to unconditionally follow these options that dummy-tools enables? Thanks Michal _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel