From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22974C433DB for ; Wed, 10 Mar 2021 02:34:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CF8CF64F8A for ; Wed, 10 Mar 2021 02:34:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232168AbhCJCeM (ORCPT ); Tue, 9 Mar 2021 21:34:12 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:49349 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231703AbhCJCeH (ORCPT ); Tue, 9 Mar 2021 21:34:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1615343646; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8GwwUcOm0gDboHFJnkVDP021OHeO7lY2XNY3kkjyYDQ=; b=WIhByZknq4i/ReV9g2OG6zxKmvILYaVDNmT8CEMnGVEFaAuAOcopQogAQRaJgVnuBPOYNM ODbdNrRr7Z+iiuqkl1UXhlfIF7ppU7Bw2lULDVMW9/dr4BhiByT5g1vY5dd7g3ud9u5cWp JSKD/zyTQEpcG7kiM99JC+gW9vUEFu4= Received: from mail-pg1-f200.google.com (mail-pg1-f200.google.com [209.85.215.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-303-BmFU5fwLME6FqHPzt5zOHQ-1; Tue, 09 Mar 2021 21:34:05 -0500 X-MC-Unique: BmFU5fwLME6FqHPzt5zOHQ-1 Received: by mail-pg1-f200.google.com with SMTP id m5so8776051pgu.21 for ; Tue, 09 Mar 2021 18:34:04 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=8GwwUcOm0gDboHFJnkVDP021OHeO7lY2XNY3kkjyYDQ=; b=WHAQMaep9sXFTron0pYWVWKUwQRO5Z2R3B7VHV1CioEZF5DR/uHcWVORuYfrY0TlG1 s+2MjwbLjG5srocVSvvCoPPxx9aA6nukwZxNLIB2EaQvjNOQ88E3dPYksgVjJEtoJdK2 RhH8SCBrvlw9ZpzBgjiu+2DQL71o3UXkeiISbbhQebT2SWqBzXROfMijXyUqaTDR9ZKd 31bB/9jIsBp3mYtg+LmHd1S9u/FYQhCe13HpbRL94Glh11w7QXAJtmMgCkSKDAprY7sI mxrg01aRdJDQIW1HBuEyksjDsiiqpjkagBb66ecpmEbzV9hsRlDAYcECS0S/6McvWAW6 wACA== X-Gm-Message-State: AOAM531BaHZC01ajmCg/A0fxsjgB+54jGd8bqNTxZgiKMz2azmsa/FnS nlzH0YQRiDXW8Rx+dsYt611C9zF85jc5B1piKmcLEnItqsvKbNUCRL4DoLp7Ytiw50frGjzFLLi Nr7zQWntGjnWCzE7LTg== X-Received: by 2002:a65:430b:: with SMTP id j11mr785263pgq.143.1615343643997; Tue, 09 Mar 2021 18:34:03 -0800 (PST) X-Google-Smtp-Source: ABdhPJyYehmKoPCKeR7JcRYI46t1GlQkbwkAxXBSH0BFvQ0+b+8W0byext3PvqvQUVObbQX200m5Iw== X-Received: by 2002:a65:430b:: with SMTP id j11mr785228pgq.143.1615343643563; Tue, 09 Mar 2021 18:34:03 -0800 (PST) Received: from xiangao.remote.csb ([209.132.188.80]) by smtp.gmail.com with ESMTPSA id 14sm14383070pfy.55.2021.03.09.18.34.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Mar 2021 18:34:03 -0800 (PST) Date: Wed, 10 Mar 2021 10:33:53 +0800 From: Gao Xiang To: "Darrick J. Wong" Cc: linux-xfs@vger.kernel.org, fstests@vger.kernel.org Subject: Re: [WIP] [RFC PATCH] xfs: add test on shrinking unused space in the last AG Message-ID: <20210310023353.GC4003044@xiangao.remote.csb> References: <20201028230909.639698-1-hsiangkao@redhat.com> <20210310004324.GE3499219@localhost.localdomain> <20210310020947.GC3419940@magnolia> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210310020947.GC3419940@magnolia> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org Hi Darrick, On Tue, Mar 09, 2021 at 06:09:47PM -0800, Darrick J. Wong wrote: ... > > > > As Darrick has reviewed, I have one more question. Looks like we can shrink a > > mounted xfs via giving a smaller size to xfs_growfs. > > > > If xfs_growfs or kernel doesn't support 'shrink', I think the whole test will > > be failed. So maybe we need a _require_* function to check if current xfs > > support shrinking feature at first? > > Also, it's time to send the xfs_growfs patches to the list so I can > replicate the tests on my own test vms. There was a preliminary version of xfsprogs sent out before to match this version: https://lore.kernel.org/r/20201028114010.545331-1-hsiangkao@redhat.com https://lore.kernel.org/linux-xfs/20201028114010.545331-1-hsiangkao@redhat.com/raw This added a EXPERIMENTAL warning but without a new argument for shrinking. Thanks, Gao Xiang