From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8C2EC433E6 for ; Wed, 10 Mar 2021 05:25:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8582264FF4 for ; Wed, 10 Mar 2021 05:25:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231574AbhCJFZM (ORCPT ); Wed, 10 Mar 2021 00:25:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54534 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232111AbhCJFYo (ORCPT ); Wed, 10 Mar 2021 00:24:44 -0500 Received: from mail.skyhub.de (mail.skyhub.de [IPv6:2a01:4f8:190:11c2::b:1457]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 701F9C06174A; Tue, 9 Mar 2021 21:24:44 -0800 (PST) Received: from zn.tnic (p200300ec2f0a99002de44af59edd037d.dip0.t-ipconnect.de [IPv6:2003:ec:2f0a:9900:2de4:4af5:9edd:37d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 6DDB11EC04D6; Wed, 10 Mar 2021 06:24:40 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1615353880; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=9Iez3Uc9i6tAL+dBIdH8Ci33dxmAZKG3ixkVqeyVZyA=; b=rATf0qufUx9W34wrxjGVJaczQ5Tv+I0c/aJtUlrC3sU9X82m0YS1UvaIdMjaHpKymBdHUZ KwEIVTNlIrujXEiopDI8vQmVsL5Nb1rGbkak23pTZanRYmlO46X2dAlVnq7Cg95soGUpTp knWy7tPjBcJcCAbqNLX85xWOwIE47QA= Date: Wed, 10 Mar 2021 06:24:36 +0100 From: Borislav Petkov To: Mark Brown Cc: linux-kernel@vger.kernel.org, Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Heiko Carstens , Christian Borntraeger , Josh Poimboeuf , Jiri Kosina , Petr Mladek , Joe Lawrence , x86@kernel.org, linux-s390@vger.kernel.org, live-patching@vger.kernel.org, Vasily Gorbik , Miroslav Benes Subject: Re: [PATCH] stacktrace: Move documentation for arch_stack_walk_reliable() to header Message-ID: <20210310052436.GA23521@zn.tnic> References: <20210309194125.652-1-broonie@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210309194125.652-1-broonie@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 09, 2021 at 07:41:25PM +0000, Mark Brown wrote: > Currently arch_stack_wallk_reliable() is documented with an identical > comment in both x86 and S/390 implementations which is a bit redundant. > Move this to the header and convert to kerneldoc while we're at it. > > Cc: Thomas Gleixner > Cc: Ingo Molnar > Cc: Borislav Petkov > Cc: "H. Peter Anvin" > Cc: Heiko Carstens > Cc: Christian Borntraeger > Cc: Josh Poimboeuf > Cc: Jiri Kosina > Cc: Petr Mladek > Cc: Joe Lawrence > Cc: x86@kernel.org > Cc: linux-s390@vger.kernel.org > Cc: live-patching@vger.kernel.org > Signed-off-by: Mark Brown > Acked-by: Vasily Gorbik > Reviewed-by: Miroslav Benes > --- > arch/s390/kernel/stacktrace.c | 6 ------ > arch/x86/kernel/stacktrace.c | 6 ------ > include/linux/stacktrace.h | 19 +++++++++++++++++++ > 3 files changed, 19 insertions(+), 12 deletions(-) LGTM. Holler if I should take this through tip. Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette