From: Lee Jones <lee.jones@linaro.org>
To: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
Cc: mazziesaccount@gmail.com, Rob Herring <robh+dt@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Alessandro Zummo <a.zummo@towertech.it>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-power@fi.rohmeurope.com, linux-clk@vger.kernel.org,
linux-gpio@vger.kernel.org, linux-rtc@vger.kernel.org
Subject: Re: [PATCH v3 07/15] mfd: Support for ROHM BD71815 PMIC core
Date: Wed, 10 Mar 2021 10:40:58 +0000 [thread overview]
Message-ID: <20210310104058.GH701493@dell> (raw)
In-Reply-To: <aaec00c776c83d301cfe66685ca9c8e01cccc9d8.1615198094.git.matti.vaittinen@fi.rohmeurope.com>
On Mon, 08 Mar 2021, Matti Vaittinen wrote:
> Add core support for ROHM BD71815 Power Management IC.
>
> The IC integrates regulators, a battery charger with a coulomb counter,
> a real-time clock (RTC), clock gate and general-purpose outputs (GPO).
>
> Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
> ---
> Changes since v2:
> - styling / clean-ups suggested by Lee
> - corrected clk-mode dt property values to match changed bindings
>
> drivers/mfd/Kconfig | 15 +-
> drivers/mfd/rohm-bd71828.c | 486 +++++++++++++++++++-------
> include/linux/mfd/rohm-bd71815.h | 563 +++++++++++++++++++++++++++++++
> include/linux/mfd/rohm-bd71828.h | 3 +
> 4 files changed, 934 insertions(+), 133 deletions(-)
> create mode 100644 include/linux/mfd/rohm-bd71815.h
[...]
> diff --git a/include/linux/mfd/rohm-bd71815.h b/include/linux/mfd/rohm-bd71815.h
> new file mode 100644
> index 000000000000..9927aadac234
> --- /dev/null
> +++ b/include/linux/mfd/rohm-bd71815.h
> @@ -0,0 +1,563 @@
> +/* SPDX-License-Identifier: GPL-2.0-or-later */
> +/*
> + *
Nit: If you rework this for any reason, please remove this line.
For my own reference (apply this as-is to your sign-off block):
Acked-for-MFD-by: Lee Jones <lee.jones@linaro.org>
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2021-03-10 10:41 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-08 10:39 [PATCH v3 00/15] Support ROHM BD71815 PMIC Matti Vaittinen
2021-03-08 10:39 ` [PATCH v3 01/15] rtc: bd70528: Do not require parent data Matti Vaittinen
2021-03-08 10:39 ` [PATCH v3 02/15] mfd: bd718x7: simplify by cleaning unnecessary device data Matti Vaittinen
2021-03-08 10:40 ` [PATCH v3 03/15] dt_bindings: bd71828: Add clock output mode Matti Vaittinen
2021-03-08 10:40 ` [PATCH v3 04/15] dt_bindings: regulator: Add ROHM BD71815 PMIC regulators Matti Vaittinen
2021-03-08 10:40 ` [PATCH v3 05/15] dt_bindings: mfd: Add ROHM BD71815 PMIC Matti Vaittinen
2021-03-08 17:39 ` Rob Herring
2021-03-09 12:51 ` Matti Vaittinen
2021-03-09 15:11 ` Rob Herring
2021-03-10 6:30 ` Matti Vaittinen
2021-03-08 10:41 ` [PATCH v3 06/15] mfd: Add ROHM BD71815 ID Matti Vaittinen
2021-03-10 10:36 ` Lee Jones
2021-03-10 11:07 ` Vaittinen, Matti
2021-03-10 11:17 ` Lee Jones
2021-03-10 13:02 ` Matti Vaittinen
2021-03-10 13:31 ` Lee Jones
2021-03-10 14:39 ` Matti Vaittinen
2021-03-10 16:38 ` Lee Jones
2021-03-08 10:42 ` [PATCH v3 07/15] mfd: Support for ROHM BD71815 PMIC core Matti Vaittinen
2021-03-10 10:40 ` Lee Jones [this message]
2021-03-08 10:43 ` [PATCH v3 08/15] gpio: support ROHM BD71815 GPOs Matti Vaittinen
2021-03-08 10:43 ` [PATCH v3 09/15] regulator: helpers: Export helper voltage listing Matti Vaittinen
2021-03-08 10:44 ` [PATCH v3 11/15] regulator: rohm-regulator: Support SNVS HW state Matti Vaittinen
2021-03-10 10:43 ` Lee Jones
2021-03-08 10:44 ` [PATCH v3 12/15] regulator: Support ROHM BD71815 regulators Matti Vaittinen
2021-03-08 10:45 ` [PATCH v3 13/15] clk: bd718x7: Add support for clk gate on ROHM BD71815 PMIC Matti Vaittinen
2021-03-08 10:45 ` [PATCH v3 14/15] rtc: bd70528: Support RTC on ROHM BD71815 Matti Vaittinen
2021-03-08 10:45 ` [PATCH v3 15/15] MAINTAINERS: Add ROHM BD71815AGW Matti Vaittinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210310104058.GH701493@dell \
--to=lee.jones@linaro.org \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=bgolaszewski@baylibre.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-power@fi.rohmeurope.com \
--cc=linux-rtc@vger.kernel.org \
--cc=matti.vaittinen@fi.rohmeurope.com \
--cc=mazziesaccount@gmail.com \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.