All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ido Schimmel <idosch@idosch.org>
To: netdev@vger.kernel.org
Cc: davem@davemloft.net, kuba@kernel.org, jiri@nvidia.com,
	danieller@nvidia.com, amcohen@nvidia.com, petrm@nvidia.com,
	mlxsw@nvidia.com, Ido Schimmel <idosch@nvidia.com>
Subject: [PATCH net-next 5/6] mlxsw: core: Expose MFDE.log_ip to devlink health
Date: Wed, 10 Mar 2021 13:02:19 +0200	[thread overview]
Message-ID: <20210310110220.2534350-6-idosch@idosch.org> (raw)
In-Reply-To: <20210310110220.2534350-1-idosch@idosch.org>

From: Danielle Ratson <danieller@nvidia.com>

Add the MFDE.log_ip field to devlink health reporter in order to ease
firmware debug. This field encodes the instruction pointer that triggered
the CR space timeout.

Signed-off-by: Danielle Ratson <danieller@nvidia.com>
Reviewed-by: Jiri Pirko <jiri@nvidia.com>
Signed-off-by: Ido Schimmel <idosch@nvidia.com>
---
 drivers/net/ethernet/mellanox/mlxsw/core.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/net/ethernet/mellanox/mlxsw/core.c b/drivers/net/ethernet/mellanox/mlxsw/core.c
index 52fdc34251ba..c53461ac4e10 100644
--- a/drivers/net/ethernet/mellanox/mlxsw/core.c
+++ b/drivers/net/ethernet/mellanox/mlxsw/core.c
@@ -1806,6 +1806,10 @@ static int mlxsw_core_health_fw_fatal_dump(struct devlink_health_reporter *repor
 		err = devlink_fmsg_u8_pair_put(fmsg, "log_irisc_id", val);
 		if (err)
 			return err;
+		val = mlxsw_reg_mfde_log_ip_get(mfde_pl);
+		err = devlink_fmsg_u64_pair_put(fmsg, "log_ip", val);
+		if (err)
+			return err;
 	} else if (event_id == MLXSW_REG_MFDE_EVENT_ID_KVD_IM_STOP) {
 		val = mlxsw_reg_mfde_pipes_mask_get(mfde_pl);
 		err = devlink_fmsg_u32_pair_put(fmsg, "pipes_mask", val);
-- 
2.29.2


  parent reply	other threads:[~2021-03-10 11:04 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-10 11:02 [PATCH net-next 0/6] mlxsw: Misc updates Ido Schimmel
2021-03-10 11:02 ` [PATCH net-next 1/6] mlxsw: spectrum: Reword an error message for Q-in-Q veto Ido Schimmel
2021-03-10 11:02 ` [PATCH net-next 2/6] mlxsw: reg: Fix comment about slot_index field in PMAOS register Ido Schimmel
2021-03-10 11:02 ` [PATCH net-next 3/6] mlxsw: spectrum: Bump minimum FW version to xx.2008.2406 Ido Schimmel
2021-03-10 11:02 ` [PATCH net-next 4/6] mlxsw: reg: Extend MFDE register with new log_ip field Ido Schimmel
2021-03-10 11:02 ` Ido Schimmel [this message]
2021-03-10 11:02 ` [PATCH net-next 6/6] mlxsw: Adjust some MFDE fields shift and size to fw implementation Ido Schimmel
2021-03-10 21:10 ` [PATCH net-next 0/6] mlxsw: Misc updates patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210310110220.2534350-6-idosch@idosch.org \
    --to=idosch@idosch.org \
    --cc=amcohen@nvidia.com \
    --cc=danieller@nvidia.com \
    --cc=davem@davemloft.net \
    --cc=idosch@nvidia.com \
    --cc=jiri@nvidia.com \
    --cc=kuba@kernel.org \
    --cc=mlxsw@nvidia.com \
    --cc=netdev@vger.kernel.org \
    --cc=petrm@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.