From: Gerd Hoffmann <kraxel@redhat.com>
To: Akihiko Odaki <akihiko.odaki@gmail.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
qemu Developers <qemu-devel@nongnu.org>
Subject: Re: [PATCH 2/2] ui/cocoa: Do not rely on the first argument
Date: Wed, 10 Mar 2021 13:22:23 +0100 [thread overview]
Message-ID: <20210310122223.fq3zae5y42kmpl66@sirius.home.kraxel.org> (raw)
In-Reply-To: <CAMVc7JWO0o9NUwPaE6wBMG+u7zHocWDPxr-6o3OcS5Zm0oT+HA@mail.gmail.com>
> > > + if (bundle) {
> >
> > Does this break about window if the executable is not in a bundle (like
> > when run from the command line after compiling)? Shouldn't you only put
> > the qemu_name in this if and have some default name if bundle is not
> > available (or fall back to argv[0] in that case?
> >
> > Regards,
> > BALATON Zoltan
> >
>
> No, it just doesn't show the application name. Everything else is fine.
Having a fallback would still be nice, even if it is just the fixed
string "qemu". Starting a fresh build without installing it first is
common while developing.
take care,
Gerd
next prev parent reply other threads:[~2021-03-10 12:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-09 12:22 [PATCH 1/2] ui/cocoa: Show QEMU icon in the about window Akihiko Odaki
2021-03-09 12:22 ` [PATCH 2/2] ui/cocoa: Do not rely on the first argument Akihiko Odaki
2021-03-09 13:10 ` BALATON Zoltan
2021-03-10 3:31 ` Akihiko Odaki
2021-03-10 12:22 ` Gerd Hoffmann [this message]
2021-03-10 15:49 ` Akihiko Odaki
2021-03-11 8:31 ` Gerd Hoffmann
2021-03-10 12:23 ` [PATCH 1/2] ui/cocoa: Show QEMU icon in the about window Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210310122223.fq3zae5y42kmpl66@sirius.home.kraxel.org \
--to=kraxel@redhat.com \
--cc=akihiko.odaki@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.