From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,HK_RANDOM_FROM,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99407C433DB for ; Wed, 10 Mar 2021 21:59:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5E58464FAB for ; Wed, 10 Mar 2021 21:59:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232915AbhCJV66 (ORCPT ); Wed, 10 Mar 2021 16:58:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44252 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232907AbhCJV6g (ORCPT ); Wed, 10 Mar 2021 16:58:36 -0500 Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com [IPv6:2a00:1450:4864:20::42b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 15C97C061574 for ; Wed, 10 Mar 2021 13:58:36 -0800 (PST) Received: by mail-wr1-x42b.google.com with SMTP id u14so25028846wri.3 for ; Wed, 10 Mar 2021 13:58:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:message-id:references:mime-version:content-disposition :in-reply-to:subject:resent-from:resent-to:resent-cc:date:user-agent :content-transfer-encoding; bh=f6b0ySB65gAluU5jkcMgJzHgnrlwCgvwd9FpZIquqBY=; b=sTiEgF9Iv4fCiL3Fy32ZvjCnLrs4D6vQuKqN8uoGBKyfVHIPjm2LrzI8//JvGYCb1y s3lID+lzc+0jNED80PzqxXrm5XnE6xKbobpg7KnI66V/f6DAnsPTBX6u7Yhu7VW0eF7Q OizfaRos09J1eykOY5BifFAYVZs3y7R2g4sOT9qIo0lb3KtXFUePcpPcdHqDZxQ+HnjU NGNJp9eEIntQQdvuL5IUzGJEbcYPVM9goGKtf5xYASKnQ6Z8LvXV5I0ieJZEHfmu4CHT IYaEv0xaruNH2stzyvklmuEx4gE3ghrwZ4JqOMPEpxucYG+/GaEfYiSEsk/xkMUERQ8V 3tug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:message-id:references:mime-version :content-disposition:in-reply-to:subject:resent-from:resent-to :resent-cc:date:user-agent:content-transfer-encoding; bh=f6b0ySB65gAluU5jkcMgJzHgnrlwCgvwd9FpZIquqBY=; b=NovMd+/ioBcAZ0vaddW/bcRL0ti2/JX/U8mO5Ml2N9AzzrC+wveiRnITsQyFt+E61L KRXbF0YOy19GOJxClZFBglArqnzRDKhnvA/bc3u/8OEwc8oNDeP4jVwloHYLQ/JNobap fr2KS50p4k5x7Fqgth6nCrkSBlbGeGQwN857IVkTP+C96p+O+rsj3dSD6pvcX8qpt8Lc RW897zHQS9IkOm5g0fUjVKqtx5JoZvFB+q6RgFBpZFaWsf+OOlvpNzj2KCMJW5oMVkqV wYSUE76tA9ewpRrBMrBqLbdZRZTC9ke6LNVuhoVYcZ32Q5JGCAwnSp6kQ2f7bHT1hStV mqXg== X-Gm-Message-State: AOAM532VUviAe72oOspvbGEk7WYTk4YIRGCnOUm9fjJtDvtQphwMg4p6 4Ag/UAcdurH3LazOiBaOIWbrjVxRKssEiw== X-Google-Smtp-Source: ABdhPJzAqp1TDvBlhWhHs4lT0gM4vzEdEygAfn3QYyV1nKIi3kGqgBleYJHJyCu3Cupn/+7/E54qxA== X-Received: by 2002:adf:e412:: with SMTP id g18mr5656234wrm.159.1615413514837; Wed, 10 Mar 2021 13:58:34 -0800 (PST) Received: from [192.168.43.236] ([5.171.80.77]) by smtp.gmail.com with ESMTPSA id u15sm684371wmq.4.2021.03.10.13.58.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Mar 2021 13:58:34 -0800 (PST) Received: from agape.jhs ([151.47.162.135]) by smtp.gmail.com with ESMTPSA id f21sm10126639ejw.124.2021.03.10.08.09.50 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Mar 2021 08:09:50 -0800 (PST) From: Fabio Aiuto To: Greg KH Message-ID: <20210310160946.GA6421@agape.jhs> References: <20210310153717.GA5741@agape.jhs> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [PATCH] staging: rtl8723bs: align comments Date: Wed, 10 Mar 2021 22:58:32 +0100 User-Agent: Evolution 3.30.5-1.1 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 10, 2021 at 04:51:44PM +0100, Greg KH wrote: > On Wed, Mar 10, 2021 at 04:37:21PM +0100, Fabio Aiuto wrote: > > fix the following checkpatch warnings: > >=20 > > WARNING: Block comments use * on subsequent lines > > + /* > > + AMPDU_para [1:0]:Max AMPDU Len =3D> 0:8k , 1:16k, 2:32k, 3:64k > > -- > > WARNING: Block comments use * on subsequent lines > > +/* > > +op_mode > >=20 > > Signed-off-by: Fabio Aiuto > > --- > > drivers/staging/rtl8723bs/core/rtw_ap.c | 28 ++++++++++++------------- > > 1 file changed, 14 insertions(+), 14 deletions(-) > >=20 > > diff --git a/drivers/staging/rtl8723bs/core/rtw_ap.c b/drivers/staging/= rtl8723bs/core/rtw_ap.c > > index b6f944b37b08..3a0e4f64466a 100644 > > --- a/drivers/staging/rtl8723bs/core/rtw_ap.c > > +++ b/drivers/staging/rtl8723bs/core/rtw_ap.c > > @@ -721,9 +721,9 @@ static void update_hw_ht_param(struct adapter *pada= pter) > > =20 > > /* handle A-MPDU parameter field */ > > /* > > - AMPDU_para [1:0]:Max AMPDU Len =3D> 0:8k , 1:16k, 2:32k, 3:64k > > - AMPDU_para [4:2]:Min MPDU Start Spacing > > - */ > > + * AMPDU_para [1:0]:Max AMPDU Len =3D> 0:8k , 1:16k, 2:32k, 3:64k > > + * AMPDU_para [4:2]:Min MPDU Start Spacing > > + */ > > max_AMPDU_len =3D pmlmeinfo->HT_caps.u.HT_cap_element.AMPDU_para & 0x= 03; > > =20 > > min_MPDU_spacing =3D ( > > @@ -1815,17 +1815,17 @@ void update_beacon(struct adapter *padapter, u8= ie_id, u8 *oui, u8 tx) > > } > > =20 > > /* > > -op_mode > > -Set to 0 (HT pure) under the following conditions > > - - all STAs in the BSS are 20/40 MHz HT in 20/40 MHz BSS or > > - - all STAs in the BSS are 20 MHz HT in 20 MHz BSS > > -Set to 1 (HT non-member protection) if there may be non-HT STAs > > - in both the primary and the secondary channel > > -Set to 2 if only HT STAs are associated in BSS, > > - however and at least one 20 MHz HT STA is associated > > -Set to 3 (HT mixed mode) when one or more non-HT STAs are associated > > - (currently non-GF HT station is considered as non-HT STA also) > > -*/ > > + *op_mode > > + *Set to 0 (HT pure) under the following conditions > > + * - all STAs in the BSS are 20/40 MHz HT in 20/40 MHz BSS or > > + * - all STAs in the BSS are 20 MHz HT in 20 MHz BSS > > + *Set to 1 (HT non-member protection) if there may be non-HT STAs > > + * in both the primary and the secondary channel > > + *Set to 2 if only HT STAs are associated in BSS, > > + * however and at least one 20 MHz HT STA is associated > > + *Set to 3 (HT mixed mode) when one or more non-HT STAs are associated > > + * (currently non-GF HT station is considered as non-HT STA also) > > + */ >=20 > Add a space after the ' ' to make it look correct please. >=20 > thanks, >=20 > greg k-h I am sorry, I fear I don't understand, checkpatch.sh script says the patch = is ok. Where have I to add a ' ' (a blank?)? thank you, fabio From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,HK_RANDOM_FROM,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F47CC433DB for ; Wed, 10 Mar 2021 22:14:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5F10164FAF for ; Wed, 10 Mar 2021 22:14:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233346AbhCJWNy (ORCPT ); Wed, 10 Mar 2021 17:13:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47538 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233889AbhCJWNi (ORCPT ); Wed, 10 Mar 2021 17:13:38 -0500 Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E9BBAC061574 for ; Wed, 10 Mar 2021 14:13:37 -0800 (PST) Received: by mail-wm1-x335.google.com with SMTP id t5-20020a1c77050000b029010e62cea9deso11624691wmi.0 for ; Wed, 10 Mar 2021 14:13:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:message-id:references:mime-version:content-disposition :in-reply-to:subject:resent-from:resent-to:resent-cc:date:user-agent :content-transfer-encoding; bh=f6b0ySB65gAluU5jkcMgJzHgnrlwCgvwd9FpZIquqBY=; b=dUOutTFWzecLpw/uH1JQ7qFklqMkd1HC0mHP4hUFIznvT0XIZcvRdVnhV4JznL1zyg GcorLaiY44LNgaoPg283+dUDbyX4eawoN4xnjnmeb0dvehqLfIfj7LfnseGbl5Fn/nyb kt5dbbShu6NOpJjSQ+pVy1PHHWIaLszqK/HJpZp5F4SpEwA+HlJLSDsRXjvsC5BIhMAH g5bR004z4zxJpfr5HCYMjrmDzlZm8O7P9bBGPk/7Vsf4AZp0Igv4Mie/diTvrTfj7LIs vLXdT0N7Gmv1k6vL0+Ve/Z5YLdt5bh1FxEryctQwrAHPPCCeOONFfEPGuCQopZ2fUv5G nnwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:message-id:references:mime-version :content-disposition:in-reply-to:subject:resent-from:resent-to :resent-cc:date:user-agent:content-transfer-encoding; bh=f6b0ySB65gAluU5jkcMgJzHgnrlwCgvwd9FpZIquqBY=; b=GIIVnCL8qinVDkPi9xPysAeGEWHHXEZ7RDKmCCDVaIobAfSvf6mcPIK8HWckbxaCat JepaCVCL5/KESjo2cFEAw4hfWgWfhtkoxFyk360KGEqJMFGbD/NdYyJmDcmODDI3gjCt QU0TFKlhlMJbfISn49SMppHJXH1/b/9v5YFXPkX9BHFRiM3UuOT0RglWMtDzkF2n5MAc DQtfZJxb+ALQ64KTJyA8p+sKVcQG8aZVvslahN5qELq1cmEpUrI1UU5NhqzVj8sP8iIx k+0kg43QoxXOBrAexlNHv+Q10WkhMwdyeZTZfzBj2/JCVkfpIb9v0VuhxqS5eFLBkSvV EK5g== X-Gm-Message-State: AOAM532TmjTBZqPjfME7ZTsjoWqs0qL2wxBZ0UkGEN4OFtqxD7ex9lWa Kfxe3I/GmLevqXnB9HJqrHYuoaVexcY= X-Google-Smtp-Source: ABdhPJy+jaRhQfyr5OAeh4pDipJ/SdY0izbXnb/3YYJI9iW5xj0hYSCcuVsquyReoZH6DrILWwTnWw== X-Received: by 2002:a05:600c:19ce:: with SMTP id u14mr4701474wmq.109.1615414416742; Wed, 10 Mar 2021 14:13:36 -0800 (PST) Received: from [192.168.43.236] ([5.171.72.165]) by smtp.gmail.com with ESMTPSA id b65sm760286wmh.4.2021.03.10.14.13.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Mar 2021 14:13:36 -0800 (PST) Received: from agape.jhs ([151.47.162.135]) by smtp.gmail.com with ESMTPSA id f21sm10126639ejw.124.2021.03.10.08.09.50 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Mar 2021 08:09:50 -0800 (PST) From: Fabio Aiuto To: Greg KH Message-ID: <20210310160946.GA6421@agape.jhs> References: <20210310153717.GA5741@agape.jhs> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [PATCH] staging: rtl8723bs: align comments Date: Wed, 10 Mar 2021 23:13:35 +0100 User-Agent: Evolution 3.30.5-1.1 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Message-ID: <20210310221335.DZOp69vkbmeVNY1k5dzKUehkQmx6NxasIAHjl53nIEw@z> On Wed, Mar 10, 2021 at 04:51:44PM +0100, Greg KH wrote: > On Wed, Mar 10, 2021 at 04:37:21PM +0100, Fabio Aiuto wrote: > > fix the following checkpatch warnings: > >=20 > > WARNING: Block comments use * on subsequent lines > > + /* > > + AMPDU_para [1:0]:Max AMPDU Len =3D> 0:8k , 1:16k, 2:32k, 3:64k > > -- > > WARNING: Block comments use * on subsequent lines > > +/* > > +op_mode > >=20 > > Signed-off-by: Fabio Aiuto > > --- > > drivers/staging/rtl8723bs/core/rtw_ap.c | 28 ++++++++++++------------- > > 1 file changed, 14 insertions(+), 14 deletions(-) > >=20 > > diff --git a/drivers/staging/rtl8723bs/core/rtw_ap.c b/drivers/staging/= rtl8723bs/core/rtw_ap.c > > index b6f944b37b08..3a0e4f64466a 100644 > > --- a/drivers/staging/rtl8723bs/core/rtw_ap.c > > +++ b/drivers/staging/rtl8723bs/core/rtw_ap.c > > @@ -721,9 +721,9 @@ static void update_hw_ht_param(struct adapter *pada= pter) > > =20 > > /* handle A-MPDU parameter field */ > > /* > > - AMPDU_para [1:0]:Max AMPDU Len =3D> 0:8k , 1:16k, 2:32k, 3:64k > > - AMPDU_para [4:2]:Min MPDU Start Spacing > > - */ > > + * AMPDU_para [1:0]:Max AMPDU Len =3D> 0:8k , 1:16k, 2:32k, 3:64k > > + * AMPDU_para [4:2]:Min MPDU Start Spacing > > + */ > > max_AMPDU_len =3D pmlmeinfo->HT_caps.u.HT_cap_element.AMPDU_para & 0x= 03; > > =20 > > min_MPDU_spacing =3D ( > > @@ -1815,17 +1815,17 @@ void update_beacon(struct adapter *padapter, u8= ie_id, u8 *oui, u8 tx) > > } > > =20 > > /* > > -op_mode > > -Set to 0 (HT pure) under the following conditions > > - - all STAs in the BSS are 20/40 MHz HT in 20/40 MHz BSS or > > - - all STAs in the BSS are 20 MHz HT in 20 MHz BSS > > -Set to 1 (HT non-member protection) if there may be non-HT STAs > > - in both the primary and the secondary channel > > -Set to 2 if only HT STAs are associated in BSS, > > - however and at least one 20 MHz HT STA is associated > > -Set to 3 (HT mixed mode) when one or more non-HT STAs are associated > > - (currently non-GF HT station is considered as non-HT STA also) > > -*/ > > + *op_mode > > + *Set to 0 (HT pure) under the following conditions > > + * - all STAs in the BSS are 20/40 MHz HT in 20/40 MHz BSS or > > + * - all STAs in the BSS are 20 MHz HT in 20 MHz BSS > > + *Set to 1 (HT non-member protection) if there may be non-HT STAs > > + * in both the primary and the secondary channel > > + *Set to 2 if only HT STAs are associated in BSS, > > + * however and at least one 20 MHz HT STA is associated > > + *Set to 3 (HT mixed mode) when one or more non-HT STAs are associated > > + * (currently non-GF HT station is considered as non-HT STA also) > > + */ >=20 > Add a space after the ' ' to make it look correct please. >=20 > thanks, >=20 > greg k-h I am sorry, I fear I don't understand, checkpatch.sh script says the patch = is ok. Where have I to add a ' ' (a blank?)? thank you, fabio From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,HK_RANDOM_FROM,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21AADC433DB for ; Wed, 10 Mar 2021 21:59:06 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9F92764E27 for ; Wed, 10 Mar 2021 21:59:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9F92764E27 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 519AE414D4; Wed, 10 Mar 2021 21:59:03 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id g8o0Lxg6-ADR; Wed, 10 Mar 2021 21:59:00 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp2.osuosl.org (Postfix) with ESMTP id 8BC7642FB1; Wed, 10 Mar 2021 21:58:48 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id 849F31BF37E for ; Wed, 10 Mar 2021 21:58:45 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 7ABD6605C1 for ; Wed, 10 Mar 2021 21:58:43 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp3.osuosl.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 97Lgb7r7gHn7 for ; Wed, 10 Mar 2021 21:58:40 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [IPv6:2a00:1450:4864:20::42f]) by smtp3.osuosl.org (Postfix) with ESMTPS id 9746D600D4 for ; Wed, 10 Mar 2021 21:58:36 +0000 (UTC) Received: by mail-wr1-x42f.google.com with SMTP id b18so25016911wrn.6 for ; Wed, 10 Mar 2021 13:58:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:message-id:references:mime-version:content-disposition :in-reply-to:subject:resent-from:resent-to:resent-cc:date:user-agent :content-transfer-encoding; bh=f6b0ySB65gAluU5jkcMgJzHgnrlwCgvwd9FpZIquqBY=; b=sTiEgF9Iv4fCiL3Fy32ZvjCnLrs4D6vQuKqN8uoGBKyfVHIPjm2LrzI8//JvGYCb1y s3lID+lzc+0jNED80PzqxXrm5XnE6xKbobpg7KnI66V/f6DAnsPTBX6u7Yhu7VW0eF7Q OizfaRos09J1eykOY5BifFAYVZs3y7R2g4sOT9qIo0lb3KtXFUePcpPcdHqDZxQ+HnjU NGNJp9eEIntQQdvuL5IUzGJEbcYPVM9goGKtf5xYASKnQ6Z8LvXV5I0ieJZEHfmu4CHT IYaEv0xaruNH2stzyvklmuEx4gE3ghrwZ4JqOMPEpxucYG+/GaEfYiSEsk/xkMUERQ8V 3tug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:message-id:references:mime-version :content-disposition:in-reply-to:subject:resent-from:resent-to :resent-cc:date:user-agent:content-transfer-encoding; bh=f6b0ySB65gAluU5jkcMgJzHgnrlwCgvwd9FpZIquqBY=; b=MV+CHAZx/vJitSjbFlFhZeMuk8BqPc+4IbILQSZ5zbArZN4vIfhget4bUNpylHOPNR emVGIBlRatgf8+f4O+R+oWbslzcX6LTqc71KwqqvSGoOLxg6DG3Dkzr/ujlmQmFaENfW as/c3pbQ0lXg0dGPZFpqG6rtz8qfWrp1hjWqI6fl0kGpBj2aulKoTnFdqTtiVAvukLfk kf/CExSXscXN0Qli9R8rnYq85/s+32dr9Tor8orm/T76bQVBeYrOUEJATqXsg5TF3KkP pa0uxtlQ7zrAIzFPlHBkgfOHUdqKGeb81qEvIhF88Cm/RPMBfv++7KhA+5EbTtfc6MRa uRgA== X-Gm-Message-State: AOAM533F9QsmheHk8PuwO5iQR/RAxey4SGW7ticvt/acDV5X5iKoARRH 5tBSEYBWzV0YFblH7NhRdSM= X-Google-Smtp-Source: ABdhPJzAqp1TDvBlhWhHs4lT0gM4vzEdEygAfn3QYyV1nKIi3kGqgBleYJHJyCu3Cupn/+7/E54qxA== X-Received: by 2002:adf:e412:: with SMTP id g18mr5656234wrm.159.1615413514837; Wed, 10 Mar 2021 13:58:34 -0800 (PST) Received: from [192.168.43.236] ([5.171.80.77]) by smtp.gmail.com with ESMTPSA id u15sm684371wmq.4.2021.03.10.13.58.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Mar 2021 13:58:34 -0800 (PST) Received: from agape.jhs ([151.47.162.135]) by smtp.gmail.com with ESMTPSA id f21sm10126639ejw.124.2021.03.10.08.09.50 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Mar 2021 08:09:50 -0800 (PST) From: Fabio Aiuto To: Greg KH Message-ID: <20210310160946.GA6421@agape.jhs> References: <20210310153717.GA5741@agape.jhs> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Subject: Re: [PATCH] staging: rtl8723bs: align comments Resent-From: Fabio Aiuto Resent-To: Greg KH Resent-Cc: "devel@driverdev.osuosl.org" , "linux-kernel@vger.kernel.org" Date: Wed, 10 Mar 2021 22:58:32 +0100 User-Agent: Evolution 3.30.5-1.1 Resent-Message-Id: <20210310215843.7ABD6605C1@smtp3.osuosl.org> Resent-Date: Wed, 10 Mar 2021 21:58:43 +0000 (UTC) X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" On Wed, Mar 10, 2021 at 04:51:44PM +0100, Greg KH wrote: > On Wed, Mar 10, 2021 at 04:37:21PM +0100, Fabio Aiuto wrote: > > fix the following checkpatch warnings: > > > > WARNING: Block comments use * on subsequent lines > > + /* > > + AMPDU_para [1:0]:Max AMPDU Len => 0:8k , 1:16k, 2:32k, 3:64k > > -- > > WARNING: Block comments use * on subsequent lines > > +/* > > +op_mode > > > > Signed-off-by: Fabio Aiuto > > --- > > drivers/staging/rtl8723bs/core/rtw_ap.c | 28 ++++++++++++------------- > > 1 file changed, 14 insertions(+), 14 deletions(-) > > > > diff --git a/drivers/staging/rtl8723bs/core/rtw_ap.c b/drivers/staging/rtl8723bs/core/rtw_ap.c > > index b6f944b37b08..3a0e4f64466a 100644 > > --- a/drivers/staging/rtl8723bs/core/rtw_ap.c > > +++ b/drivers/staging/rtl8723bs/core/rtw_ap.c > > @@ -721,9 +721,9 @@ static void update_hw_ht_param(struct adapter *padapter) > > > > /* handle A-MPDU parameter field */ > > /* > > - AMPDU_para [1:0]:Max AMPDU Len => 0:8k , 1:16k, 2:32k, 3:64k > > - AMPDU_para [4:2]:Min MPDU Start Spacing > > - */ > > + * AMPDU_para [1:0]:Max AMPDU Len => 0:8k , 1:16k, 2:32k, 3:64k > > + * AMPDU_para [4:2]:Min MPDU Start Spacing > > + */ > > max_AMPDU_len = pmlmeinfo->HT_caps.u.HT_cap_element.AMPDU_para & 0x03; > > > > min_MPDU_spacing = ( > > @@ -1815,17 +1815,17 @@ void update_beacon(struct adapter *padapter, u8 ie_id, u8 *oui, u8 tx) > > } > > > > /* > > -op_mode > > -Set to 0 (HT pure) under the following conditions > > - - all STAs in the BSS are 20/40 MHz HT in 20/40 MHz BSS or > > - - all STAs in the BSS are 20 MHz HT in 20 MHz BSS > > -Set to 1 (HT non-member protection) if there may be non-HT STAs > > - in both the primary and the secondary channel > > -Set to 2 if only HT STAs are associated in BSS, > > - however and at least one 20 MHz HT STA is associated > > -Set to 3 (HT mixed mode) when one or more non-HT STAs are associated > > - (currently non-GF HT station is considered as non-HT STA also) > > -*/ > > + *op_mode > > + *Set to 0 (HT pure) under the following conditions > > + * - all STAs in the BSS are 20/40 MHz HT in 20/40 MHz BSS or > > + * - all STAs in the BSS are 20 MHz HT in 20 MHz BSS > > + *Set to 1 (HT non-member protection) if there may be non-HT STAs > > + * in both the primary and the secondary channel > > + *Set to 2 if only HT STAs are associated in BSS, > > + * however and at least one 20 MHz HT STA is associated > > + *Set to 3 (HT mixed mode) when one or more non-HT STAs are associated > > + * (currently non-GF HT station is considered as non-HT STA also) > > + */ > > Add a space after the ' ' to make it look correct please. > > thanks, > > greg k-h I am sorry, I fear I don't understand, checkpatch.sh script says the patch is ok. Where have I to add a ' ' (a blank?)? thank you, fabio _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,HK_RANDOM_FROM,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8038C43381 for ; Wed, 10 Mar 2021 22:17:55 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8C9AF64FAF for ; Wed, 10 Mar 2021 22:17:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8C9AF64FAF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 4E7FD83E23; Wed, 10 Mar 2021 22:17:53 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id wik3frnGox-4; Wed, 10 Mar 2021 22:17:52 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp1.osuosl.org (Postfix) with ESMTP id 7F3C983E20; Wed, 10 Mar 2021 22:17:40 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id 5A79F1BF29E for ; Wed, 10 Mar 2021 22:13:45 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 530CB42FF2 for ; Wed, 10 Mar 2021 22:13:43 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp2.osuosl.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id JbClcZNVKMda for ; Wed, 10 Mar 2021 22:13:42 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [IPv6:2a00:1450:4864:20::336]) by smtp2.osuosl.org (Postfix) with ESMTPS id 7616942FB1 for ; Wed, 10 Mar 2021 22:13:40 +0000 (UTC) Received: by mail-wm1-x336.google.com with SMTP id 124-20020a1c00820000b029010b871409cfso11997465wma.4 for ; Wed, 10 Mar 2021 14:13:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:message-id:references:mime-version:content-disposition :in-reply-to:subject:resent-from:resent-to:resent-cc:date:user-agent :content-transfer-encoding; bh=f6b0ySB65gAluU5jkcMgJzHgnrlwCgvwd9FpZIquqBY=; b=dUOutTFWzecLpw/uH1JQ7qFklqMkd1HC0mHP4hUFIznvT0XIZcvRdVnhV4JznL1zyg GcorLaiY44LNgaoPg283+dUDbyX4eawoN4xnjnmeb0dvehqLfIfj7LfnseGbl5Fn/nyb kt5dbbShu6NOpJjSQ+pVy1PHHWIaLszqK/HJpZp5F4SpEwA+HlJLSDsRXjvsC5BIhMAH g5bR004z4zxJpfr5HCYMjrmDzlZm8O7P9bBGPk/7Vsf4AZp0Igv4Mie/diTvrTfj7LIs vLXdT0N7Gmv1k6vL0+Ve/Z5YLdt5bh1FxEryctQwrAHPPCCeOONFfEPGuCQopZ2fUv5G nnwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:message-id:references:mime-version :content-disposition:in-reply-to:subject:resent-from:resent-to :resent-cc:date:user-agent:content-transfer-encoding; bh=f6b0ySB65gAluU5jkcMgJzHgnrlwCgvwd9FpZIquqBY=; b=Fo5SuQKd3m0YJBya/rs/Oz7GD76MrXaQ3LhDf5hY/HFJh9sfMekNvH2ibLJcvPYNg1 G+sx0LrPRsEWpYaf3H9YIWH95DGVdnffw8aJKzxihsRipvvpp519JMeU0BUQ+/s16xbW T8MCGmMWWuk+vcLOEp1PqAcuikZh1iOsQAN0o+6h7mguM2aGhnoMD5+TpsVc40crMMND 9pQEdZzqdAnX2TxGAdtWmfY/JzhsXWITM3NLV/8iA37wW3Ij7vvbYkt/gqHgB5ICo7qS hdcx9J85juYW6LwuK6tKBzuYbdtwCb14oPdqVs+4i8s8trcJsEpSr+PRUFCtM59GN+vw lD3w== X-Gm-Message-State: AOAM532XnO/w+//cDLuakrJgPULJzxl7RtKlovbQGh46nb6/8R2zzQIM Qza+XAOqDqMXmD3FT7c1CsI= X-Google-Smtp-Source: ABdhPJy+jaRhQfyr5OAeh4pDipJ/SdY0izbXnb/3YYJI9iW5xj0hYSCcuVsquyReoZH6DrILWwTnWw== X-Received: by 2002:a05:600c:19ce:: with SMTP id u14mr4701474wmq.109.1615414416742; Wed, 10 Mar 2021 14:13:36 -0800 (PST) Received: from [192.168.43.236] ([5.171.72.165]) by smtp.gmail.com with ESMTPSA id b65sm760286wmh.4.2021.03.10.14.13.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Mar 2021 14:13:36 -0800 (PST) Received: from agape.jhs ([151.47.162.135]) by smtp.gmail.com with ESMTPSA id f21sm10126639ejw.124.2021.03.10.08.09.50 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Mar 2021 08:09:50 -0800 (PST) From: Fabio Aiuto To: Greg KH Message-ID: <20210310160946.GA6421@agape.jhs> References: <20210310153717.GA5741@agape.jhs> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Subject: Re: [PATCH] staging: rtl8723bs: align comments Resent-From: Fabio Aiuto Resent-To: Greg KH Resent-Cc: "devel@driverdev.osuosl.org" , "linux-kernel@vger.kernel.org" Date: Wed, 10 Mar 2021 23:13:35 +0100 User-Agent: Evolution 3.30.5-1.1 Resent-Message-Id: <20210310221343.530CB42FF2@smtp2.osuosl.org> Resent-Date: Wed, 10 Mar 2021 22:13:43 +0000 (UTC) X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" Message-ID: <20210310221335.mtkLxIBRb8ILUOjkFVLAXFUFjb3xIA_LNjWNxHv89TA@z> On Wed, Mar 10, 2021 at 04:51:44PM +0100, Greg KH wrote: > On Wed, Mar 10, 2021 at 04:37:21PM +0100, Fabio Aiuto wrote: > > fix the following checkpatch warnings: > > > > WARNING: Block comments use * on subsequent lines > > + /* > > + AMPDU_para [1:0]:Max AMPDU Len => 0:8k , 1:16k, 2:32k, 3:64k > > -- > > WARNING: Block comments use * on subsequent lines > > +/* > > +op_mode > > > > Signed-off-by: Fabio Aiuto > > --- > > drivers/staging/rtl8723bs/core/rtw_ap.c | 28 ++++++++++++------------- > > 1 file changed, 14 insertions(+), 14 deletions(-) > > > > diff --git a/drivers/staging/rtl8723bs/core/rtw_ap.c b/drivers/staging/rtl8723bs/core/rtw_ap.c > > index b6f944b37b08..3a0e4f64466a 100644 > > --- a/drivers/staging/rtl8723bs/core/rtw_ap.c > > +++ b/drivers/staging/rtl8723bs/core/rtw_ap.c > > @@ -721,9 +721,9 @@ static void update_hw_ht_param(struct adapter *padapter) > > > > /* handle A-MPDU parameter field */ > > /* > > - AMPDU_para [1:0]:Max AMPDU Len => 0:8k , 1:16k, 2:32k, 3:64k > > - AMPDU_para [4:2]:Min MPDU Start Spacing > > - */ > > + * AMPDU_para [1:0]:Max AMPDU Len => 0:8k , 1:16k, 2:32k, 3:64k > > + * AMPDU_para [4:2]:Min MPDU Start Spacing > > + */ > > max_AMPDU_len = pmlmeinfo->HT_caps.u.HT_cap_element.AMPDU_para & 0x03; > > > > min_MPDU_spacing = ( > > @@ -1815,17 +1815,17 @@ void update_beacon(struct adapter *padapter, u8 ie_id, u8 *oui, u8 tx) > > } > > > > /* > > -op_mode > > -Set to 0 (HT pure) under the following conditions > > - - all STAs in the BSS are 20/40 MHz HT in 20/40 MHz BSS or > > - - all STAs in the BSS are 20 MHz HT in 20 MHz BSS > > -Set to 1 (HT non-member protection) if there may be non-HT STAs > > - in both the primary and the secondary channel > > -Set to 2 if only HT STAs are associated in BSS, > > - however and at least one 20 MHz HT STA is associated > > -Set to 3 (HT mixed mode) when one or more non-HT STAs are associated > > - (currently non-GF HT station is considered as non-HT STA also) > > -*/ > > + *op_mode > > + *Set to 0 (HT pure) under the following conditions > > + * - all STAs in the BSS are 20/40 MHz HT in 20/40 MHz BSS or > > + * - all STAs in the BSS are 20 MHz HT in 20 MHz BSS > > + *Set to 1 (HT non-member protection) if there may be non-HT STAs > > + * in both the primary and the secondary channel > > + *Set to 2 if only HT STAs are associated in BSS, > > + * however and at least one 20 MHz HT STA is associated > > + *Set to 3 (HT mixed mode) when one or more non-HT STAs are associated > > + * (currently non-GF HT station is considered as non-HT STA also) > > + */ > > Add a space after the ' ' to make it look correct please. > > thanks, > > greg k-h I am sorry, I fear I don't understand, checkpatch.sh script says the patch is ok. Where have I to add a ' ' (a blank?)? thank you, fabio _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel