From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48598C433E6 for ; Wed, 10 Mar 2021 23:11:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1B82964FC3 for ; Wed, 10 Mar 2021 23:11:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233367AbhCJXKb (ORCPT ); Wed, 10 Mar 2021 18:10:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59806 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231478AbhCJXK3 (ORCPT ); Wed, 10 Mar 2021 18:10:29 -0500 Received: from mail-ej1-x634.google.com (mail-ej1-x634.google.com [IPv6:2a00:1450:4864:20::634]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7C4D0C061574; Wed, 10 Mar 2021 15:10:29 -0800 (PST) Received: by mail-ej1-x634.google.com with SMTP id p7so30833969eju.6; Wed, 10 Mar 2021 15:10:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=+Y9MjRts8tJjHgCUb2Iq9KHOIcaGo0V2pW4Fp5XYQq0=; b=t5WCXHDCAqWoOY8vvWjS/p98fmmrH0F+h6H5pURHoN8BEnzWfMl2aouEntq+FPFgI9 GDAzlnWeW+3+Ghn6KfC1qbH0xHIAJVanWaGJPS+mfIhc9LA0KDmrNf0JmmS6JkAIXfTn /t+WKh1rgyDH/B0i4ehnaSTcLCxwlMf5TJNzPTY1W9s6J8jKgqKnU1CO3EwrJCdAJ4Vz 49HDZntyJHHxlg4EH4m3n64MwXfiEkj09hIU+Bc0shA3TiMMVeIqzid6HY0euxrBoNh/ 5AcPlr1Ind4FFNh18T3wydqCHQcGlNoQWz5jwUYVMeWaY0xm6cjGMNJVoEf3n0ZNwu9C fyIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=+Y9MjRts8tJjHgCUb2Iq9KHOIcaGo0V2pW4Fp5XYQq0=; b=LDw5/a3wro/0WSaiAKTJw6gCO1BvotWfl90unpxHjXClA4K8q4qiX4hdhATofd3erA G86ocpkpR8CDGu5YHNd9bk/sYphH+aCfLwBwK6GlpYRax5Rcpm6OrmtzQIPXb32mXmRT eiQB/9DDpUEK94Rg0dNGPTAunnrtJWIYqrx/tBhLCrOXOd4+C7WI6E3tUm14UT7QmTwT F/x1x9rtP/RG/cc3Hoxc66HrWXar+Cd10RYV2Ot6WalRMcPWz6gL5mgjcCaI6/prIzqR FQ+F3/84tufkOS6/vKBRpUOHxOjSJ3AWP/GEar6eVBdDc2uFl2v+i3U4/w0OtHedz4oR g85A== X-Gm-Message-State: AOAM5326ejaCWizyM4sUEJqnFRwWWoJyf7k4Y53Yp1jndNdn4s8WxOnE DQyH+n2gploToN2EYkF1MXo= X-Google-Smtp-Source: ABdhPJzpCw/su5dc23eER+GYr7msTlNS7+5Mn+Zm9/S1spB5ac9PVKV85UZGOsHF3uMOZxcT9C+f7A== X-Received: by 2002:a17:906:95d1:: with SMTP id n17mr242829ejy.394.1615417828283; Wed, 10 Mar 2021 15:10:28 -0800 (PST) Received: from skbuf ([188.25.219.167]) by smtp.gmail.com with ESMTPSA id gq25sm387319ejb.85.2021.03.10.15.10.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Mar 2021 15:10:27 -0800 (PST) Date: Thu, 11 Mar 2021 01:10:26 +0200 From: Vladimir Oltean To: Ilya Lipnitskiy Cc: Sean Wang , Landen Chao , Andrew Lunn , Vivien Didelot , Florian Fainelli , "David S. Miller" , Jakub Kicinski , Matthias Brugger , Philipp Zabel , Russell King , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] net: dsa: mt7530: setup core clock even in TRGMII mode Message-ID: <20210310231026.lhxakeldngkr7prm@skbuf> References: <20210310211420.649985-1-ilya.lipnitskiy@gmail.com> <20210310211420.649985-3-ilya.lipnitskiy@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210310211420.649985-3-ilya.lipnitskiy@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Ilya, On Wed, Mar 10, 2021 at 01:14:20PM -0800, Ilya Lipnitskiy wrote: > 3f9ef7785a9c ("MIPS: ralink: manage low reset lines") made it so mt7530 > actually resets the switch on platforms such as mt7621 (where bit 2 is > the reset line for the switch). That exposed an issue where the switch > would not function properly in TRGMII mode after a reset. > > Reconfigure core clock in TRGMII mode to fix the issue. > > Also, disable both core and TRGMII Tx clocks prior to reconfiguring. > Previously, only the core clock was disabled, but not TRGMII Tx clock. > > Tested on Ubiquity ER-X (MT7621) with TRGMII mode enabled. > > Signed-off-by: Ilya Lipnitskiy > --- For the networking subsystem there are two git trees, "net" for bugfixes and "net-next" for new features, and we specify the target tree using git send-email --subject-prefix="PATCH net-next". I assume you would like the v5.12 kernel to actually be functional on the Ubiquiti ER-X switch, so I would recommend keeping this patch minimal and splitting it out from the current series, and targeting it towards the "net" tree, which will eventually get merged into one of the v5.12 rc's and then into the final version. The other patches won't go into v5.12 but into v5.13, hence the "next" name. Also add these lines in your .gitconfig: [core] abbrev = 12 [pretty] fixes = Fixes: %h (\"%s\") and run: git show 3f9ef7785a9c --pretty=fixes Fixes: 3f9ef7785a9c ("MIPS: ralink: manage low reset lines") and paste that "Fixes:" line in the commit message, right above your Signed-off-by: tag. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C735C433E0 for ; Wed, 10 Mar 2021 23:12:00 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A197464FAE for ; Wed, 10 Mar 2021 23:11:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A197464FAE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=tyMzPoZ9kgKApd/iaif2nHX3PTk6OiwmYEu6LHd/HIk=; b=inRMRzHaHC1KuIKJcOQHElx04 aswwCK6qef3aUaM20A7Zp7YOnS8VdXNoGJrPDjOu30n/c7YnyYKKFxGHdfQ26Slfz/QanLoE1Dp8L AhfO6iXuoqlO7ryVlNMihBTJofMf2MDjjjRts3jV9okzv3bdxjRDUB5Gr8PFlXy4Lh7mMgxtmGfRo TRL5ST4UI8XAR3kf9R3dtKbi7KgIoUZ1yVEyr5+Mhm9aAiD4Xot22k77wAT2qXbYwjsaAdAnvS7XV whfoAk1DSt35XSztk5nuJGdaVXlirRhUDE6nMMoEMI/pbFNexEBFfo5JLkiaCX2TIm5A0qpxheNE+ bJ/JTQOKg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lK7yM-007xkI-3F; Wed, 10 Mar 2021 23:10:34 +0000 Received: from mail-ej1-x634.google.com ([2a00:1450:4864:20::634]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lK7yH-007xjq-8u; Wed, 10 Mar 2021 23:10:30 +0000 Received: by mail-ej1-x634.google.com with SMTP id c10so42125672ejx.9; Wed, 10 Mar 2021 15:10:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=+Y9MjRts8tJjHgCUb2Iq9KHOIcaGo0V2pW4Fp5XYQq0=; b=t5WCXHDCAqWoOY8vvWjS/p98fmmrH0F+h6H5pURHoN8BEnzWfMl2aouEntq+FPFgI9 GDAzlnWeW+3+Ghn6KfC1qbH0xHIAJVanWaGJPS+mfIhc9LA0KDmrNf0JmmS6JkAIXfTn /t+WKh1rgyDH/B0i4ehnaSTcLCxwlMf5TJNzPTY1W9s6J8jKgqKnU1CO3EwrJCdAJ4Vz 49HDZntyJHHxlg4EH4m3n64MwXfiEkj09hIU+Bc0shA3TiMMVeIqzid6HY0euxrBoNh/ 5AcPlr1Ind4FFNh18T3wydqCHQcGlNoQWz5jwUYVMeWaY0xm6cjGMNJVoEf3n0ZNwu9C fyIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=+Y9MjRts8tJjHgCUb2Iq9KHOIcaGo0V2pW4Fp5XYQq0=; b=qRYfykMjXTxlrZ3SLYHmObLPq4GPlyPbTMquBTIJv6RVcH0E9BYtjZCgxdLMvL/g5k uiR4pUU8NdOEFtOdxUelKIdkkfTOvqLaTCsjAagK9zR/t3w9Yy/WTNeqJPtJi/6FLAGm cs+HRzLQOpokn1TwEHml8I9fzOBTUfnbCPhOYiqYShz8n7F5FqjSmpqxfrRGPzkXHAbS Ra5U4EYRQlyNumd2tmgyIqf0UKRzyRzT4Q8vSUBLFQPYy8Uj7cvAs5vwFt3mTQdKdQQS 94GGr6fSDdsEO+ZQ26PDptyh1cQYxjdRv+w8Q9GW6HadnoA1xZR2YVXal1Tb34wD24XL kAwA== X-Gm-Message-State: AOAM532tzlRofHcvlAAzvamvf060pKlFYY5zcW5QHl7IOhpGR1fXCH77 wT0YsCynYOoDNNHalegvUBM= X-Google-Smtp-Source: ABdhPJzpCw/su5dc23eER+GYr7msTlNS7+5Mn+Zm9/S1spB5ac9PVKV85UZGOsHF3uMOZxcT9C+f7A== X-Received: by 2002:a17:906:95d1:: with SMTP id n17mr242829ejy.394.1615417828283; Wed, 10 Mar 2021 15:10:28 -0800 (PST) Received: from skbuf ([188.25.219.167]) by smtp.gmail.com with ESMTPSA id gq25sm387319ejb.85.2021.03.10.15.10.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Mar 2021 15:10:27 -0800 (PST) Date: Thu, 11 Mar 2021 01:10:26 +0200 From: Vladimir Oltean To: Ilya Lipnitskiy Cc: Sean Wang , Landen Chao , Andrew Lunn , Vivien Didelot , Florian Fainelli , "David S. Miller" , Jakub Kicinski , Matthias Brugger , Philipp Zabel , Russell King , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] net: dsa: mt7530: setup core clock even in TRGMII mode Message-ID: <20210310231026.lhxakeldngkr7prm@skbuf> References: <20210310211420.649985-1-ilya.lipnitskiy@gmail.com> <20210310211420.649985-3-ilya.lipnitskiy@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210310211420.649985-3-ilya.lipnitskiy@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210310_231029_351751_F0C1D176 X-CRM114-Status: GOOD ( 15.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello Ilya, On Wed, Mar 10, 2021 at 01:14:20PM -0800, Ilya Lipnitskiy wrote: > 3f9ef7785a9c ("MIPS: ralink: manage low reset lines") made it so mt7530 > actually resets the switch on platforms such as mt7621 (where bit 2 is > the reset line for the switch). That exposed an issue where the switch > would not function properly in TRGMII mode after a reset. > > Reconfigure core clock in TRGMII mode to fix the issue. > > Also, disable both core and TRGMII Tx clocks prior to reconfiguring. > Previously, only the core clock was disabled, but not TRGMII Tx clock. > > Tested on Ubiquity ER-X (MT7621) with TRGMII mode enabled. > > Signed-off-by: Ilya Lipnitskiy > --- For the networking subsystem there are two git trees, "net" for bugfixes and "net-next" for new features, and we specify the target tree using git send-email --subject-prefix="PATCH net-next". I assume you would like the v5.12 kernel to actually be functional on the Ubiquiti ER-X switch, so I would recommend keeping this patch minimal and splitting it out from the current series, and targeting it towards the "net" tree, which will eventually get merged into one of the v5.12 rc's and then into the final version. The other patches won't go into v5.12 but into v5.13, hence the "next" name. Also add these lines in your .gitconfig: [core] abbrev = 12 [pretty] fixes = Fixes: %h (\"%s\") and run: git show 3f9ef7785a9c --pretty=fixes Fixes: 3f9ef7785a9c ("MIPS: ralink: manage low reset lines") and paste that "Fixes:" line in the commit message, right above your Signed-off-by: tag. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81C69C433DB for ; Wed, 10 Mar 2021 23:10:48 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2A0A464FAE for ; Wed, 10 Mar 2021 23:10:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2A0A464FAE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=PfXRIcBwp9QjTJsQMGapAjb5R0LwoX8t1M4m48ANYo0=; b=BhC7XhGTbPL1MuqvRdvPZcGfP DAGU2f3Xa8qx8TKhha+Zp4r63Gx/XV+4uc5oH28z68TZxPrjH3Zcw1qvUkmAIaeDSGHB7wxPvAV46 9+HYFSRM0jNOYCbPphq25lpzzP3zcXQXBaeIef+uBg364ls586Snv/fG/yXfRBt5hrjl6vGuQfNiI Epghybjb6Veau5kz12GAsOXAyrplQSeWrVBlNWeGB6pNLfm1o31+Ov3Fa17nzDLZ+YRdYFZXJPqif Xi3zqEG+PVTLXmeBbo1JuFGqX/JKpeIqe6nXUQfY3iT6sWGmQNPZtiDhSJaIfwHJze25yOAOkuchI V1e39hLPw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lK7yR-007xkb-Uu; Wed, 10 Mar 2021 23:10:40 +0000 Received: from mail-ej1-x634.google.com ([2a00:1450:4864:20::634]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lK7yH-007xjq-8u; Wed, 10 Mar 2021 23:10:30 +0000 Received: by mail-ej1-x634.google.com with SMTP id c10so42125672ejx.9; Wed, 10 Mar 2021 15:10:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=+Y9MjRts8tJjHgCUb2Iq9KHOIcaGo0V2pW4Fp5XYQq0=; b=t5WCXHDCAqWoOY8vvWjS/p98fmmrH0F+h6H5pURHoN8BEnzWfMl2aouEntq+FPFgI9 GDAzlnWeW+3+Ghn6KfC1qbH0xHIAJVanWaGJPS+mfIhc9LA0KDmrNf0JmmS6JkAIXfTn /t+WKh1rgyDH/B0i4ehnaSTcLCxwlMf5TJNzPTY1W9s6J8jKgqKnU1CO3EwrJCdAJ4Vz 49HDZntyJHHxlg4EH4m3n64MwXfiEkj09hIU+Bc0shA3TiMMVeIqzid6HY0euxrBoNh/ 5AcPlr1Ind4FFNh18T3wydqCHQcGlNoQWz5jwUYVMeWaY0xm6cjGMNJVoEf3n0ZNwu9C fyIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=+Y9MjRts8tJjHgCUb2Iq9KHOIcaGo0V2pW4Fp5XYQq0=; b=qRYfykMjXTxlrZ3SLYHmObLPq4GPlyPbTMquBTIJv6RVcH0E9BYtjZCgxdLMvL/g5k uiR4pUU8NdOEFtOdxUelKIdkkfTOvqLaTCsjAagK9zR/t3w9Yy/WTNeqJPtJi/6FLAGm cs+HRzLQOpokn1TwEHml8I9fzOBTUfnbCPhOYiqYShz8n7F5FqjSmpqxfrRGPzkXHAbS Ra5U4EYRQlyNumd2tmgyIqf0UKRzyRzT4Q8vSUBLFQPYy8Uj7cvAs5vwFt3mTQdKdQQS 94GGr6fSDdsEO+ZQ26PDptyh1cQYxjdRv+w8Q9GW6HadnoA1xZR2YVXal1Tb34wD24XL kAwA== X-Gm-Message-State: AOAM532tzlRofHcvlAAzvamvf060pKlFYY5zcW5QHl7IOhpGR1fXCH77 wT0YsCynYOoDNNHalegvUBM= X-Google-Smtp-Source: ABdhPJzpCw/su5dc23eER+GYr7msTlNS7+5Mn+Zm9/S1spB5ac9PVKV85UZGOsHF3uMOZxcT9C+f7A== X-Received: by 2002:a17:906:95d1:: with SMTP id n17mr242829ejy.394.1615417828283; Wed, 10 Mar 2021 15:10:28 -0800 (PST) Received: from skbuf ([188.25.219.167]) by smtp.gmail.com with ESMTPSA id gq25sm387319ejb.85.2021.03.10.15.10.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Mar 2021 15:10:27 -0800 (PST) Date: Thu, 11 Mar 2021 01:10:26 +0200 From: Vladimir Oltean To: Ilya Lipnitskiy Cc: Sean Wang , Landen Chao , Andrew Lunn , Vivien Didelot , Florian Fainelli , "David S. Miller" , Jakub Kicinski , Matthias Brugger , Philipp Zabel , Russell King , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] net: dsa: mt7530: setup core clock even in TRGMII mode Message-ID: <20210310231026.lhxakeldngkr7prm@skbuf> References: <20210310211420.649985-1-ilya.lipnitskiy@gmail.com> <20210310211420.649985-3-ilya.lipnitskiy@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210310211420.649985-3-ilya.lipnitskiy@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210310_231029_351751_F0C1D176 X-CRM114-Status: GOOD ( 15.35 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Hello Ilya, On Wed, Mar 10, 2021 at 01:14:20PM -0800, Ilya Lipnitskiy wrote: > 3f9ef7785a9c ("MIPS: ralink: manage low reset lines") made it so mt7530 > actually resets the switch on platforms such as mt7621 (where bit 2 is > the reset line for the switch). That exposed an issue where the switch > would not function properly in TRGMII mode after a reset. > > Reconfigure core clock in TRGMII mode to fix the issue. > > Also, disable both core and TRGMII Tx clocks prior to reconfiguring. > Previously, only the core clock was disabled, but not TRGMII Tx clock. > > Tested on Ubiquity ER-X (MT7621) with TRGMII mode enabled. > > Signed-off-by: Ilya Lipnitskiy > --- For the networking subsystem there are two git trees, "net" for bugfixes and "net-next" for new features, and we specify the target tree using git send-email --subject-prefix="PATCH net-next". I assume you would like the v5.12 kernel to actually be functional on the Ubiquiti ER-X switch, so I would recommend keeping this patch minimal and splitting it out from the current series, and targeting it towards the "net" tree, which will eventually get merged into one of the v5.12 rc's and then into the final version. The other patches won't go into v5.12 but into v5.13, hence the "next" name. Also add these lines in your .gitconfig: [core] abbrev = 12 [pretty] fixes = Fixes: %h (\"%s\") and run: git show 3f9ef7785a9c --pretty=fixes Fixes: 3f9ef7785a9c ("MIPS: ralink: manage low reset lines") and paste that "Fixes:" line in the commit message, right above your Signed-off-by: tag. _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek