Re: [PATCH 2/2] remoteproc: qcom: q6v5_wpss: Add support for sc7280 WPSS

From: kernel test robot <lkp@intel.com>
To: Rakesh Pillai <pillair@codeaurora.org>,
	agross@kernel.org, bjorn.andersson@linaro.org, ohad@wizery.com,
	mathieu.poirier@linaro.org, robh+dt@kernel.org,
	p.zabel@pengutronix.de
Cc: kbuild-all@lists.01.org, sibis@codeaurora.org,
	linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org,
	devicetree@vger.kernel.org
Subject: Re: [PATCH 2/2] remoteproc: qcom: q6v5_wpss: Add support for sc7280 WPSS
Date: Thu, 11 Mar 2021 03:12:21 +0800	[thread overview]
Message-ID: <202103110321.TigGkWdB-lkp@intel.com> (raw)
In-Reply-To: <1615361290-19238-3-git-send-email-pillair@codeaurora.org>

[-- Attachment #1: Type: text/plain, Size: 3235 bytes --]

Hi Rakesh,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on robh/for-next]
[also build test ERROR on linus/master v5.12-rc2 next-20210310]
[cannot apply to hwspinlock/for-next remoteproc/for-next rpmsg/for-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Rakesh-Pillai/Add-support-for-sc7280-WPSS-PIL-loading/20210310-153802
base:   https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
config: arm64-allyesconfig (attached as .config)
compiler: aarch64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/870fc6e5ff6910ff2f19d07840e300f66f1fd668
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Rakesh-Pillai/Add-support-for-sc7280-WPSS-PIL-loading/20210310-153802
        git checkout 870fc6e5ff6910ff2f19d07840e300f66f1fd668
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> drivers/remoteproc/qcom_q6v5_adsp.c:574:19: error: expected '}' before ';' token
     574 |  .auto_boot = true;
         |                   ^
   drivers/remoteproc/qcom_q6v5_adsp.c:567:56: note: to match this '{'
     567 | static const struct adsp_pil_data adsp_resource_init = {
         |                                                        ^
   drivers/remoteproc/qcom_q6v5_adsp.c:589:19: error: expected '}' before ';' token
     589 |  .auto_boot = true;
         |                   ^
   drivers/remoteproc/qcom_q6v5_adsp.c:582:56: note: to match this '{'
     582 | static const struct adsp_pil_data cdsp_resource_init = {
         |                                                        ^
   drivers/remoteproc/qcom_q6v5_adsp.c:604:20: error: expected '}' before ';' token
     604 |  .auto_boot = false;
         |                    ^
   drivers/remoteproc/qcom_q6v5_adsp.c:597:56: note: to match this '{'
     597 | static const struct adsp_pil_data wpss_resource_init = {
         |                                                        ^

vim +574 drivers/remoteproc/qcom_q6v5_adsp.c

   566	
   567	static const struct adsp_pil_data adsp_resource_init = {
   568		.crash_reason_smem = 423,
   569		.firmware_name = "adsp.mdt",
   570		.ssr_name = "lpass",
   571		.sysmon_name = "adsp",
   572		.ssctl_id = 0x14,
   573		.is_wpss = false,
 > 574		.auto_boot = true;
   575		.clk_ids = (const char*[]) {
   576			"sway_cbcr", "lpass_ahbs_aon_cbcr", "lpass_ahbm_aon_cbcr",
   577			"qdsp6ss_xo", "qdsp6ss_sleep", "qdsp6ss_core", NULL
   578		},
   579		.num_clks = 7,
   580	};
   581	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 76927 bytes --]