From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1E9DC433E0 for ; Thu, 11 Mar 2021 10:22:17 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E29F764FAA for ; Thu, 11 Mar 2021 10:22:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E29F764FAA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:46132 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lKISL-0002XX-LV for qemu-devel@archiver.kernel.org; Thu, 11 Mar 2021 05:22:13 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:42656) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lKIRb-0001xK-A9 for qemu-devel@nongnu.org; Thu, 11 Mar 2021 05:21:27 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:53951) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1lKIRX-0006Fw-1B for qemu-devel@nongnu.org; Thu, 11 Mar 2021 05:21:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1615458081; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=970qm4hwZ2zwEvWb2oKs8qK2FoGDx8y39bxuwWrifGw=; b=CPunI40+qDkOGaBRMgw0DdMBIjZY5+yZxsleIBYZm5CpkqdL9lMRSC7ZVVpwMin3K5JCXL k/I/0wgCvmuqauQXQ9iUrzI/IkE+yfLeEW4k/kR5wBSsKMIbdg1Spre/vb/44vTXB8bOcM KnAZ7D+KZh9Cpya0hy3a5hxWWyni2uU= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-420-VR8QuulSOjawhfAR1FsZ_A-1; Thu, 11 Mar 2021 05:21:19 -0500 X-MC-Unique: VR8QuulSOjawhfAR1FsZ_A-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E901710866A5; Thu, 11 Mar 2021 10:21:17 +0000 (UTC) Received: from gondolin (ovpn-112-225.ams2.redhat.com [10.36.112.225]) by smtp.corp.redhat.com (Postfix) with ESMTP id 262F660BF3; Thu, 11 Mar 2021 10:21:12 +0000 (UTC) Date: Thu, 11 Mar 2021 11:21:10 +0100 From: Cornelia Huck To: David Hildenbrand Subject: Re: [PATCH v4] target/s390x: Implement the MVPG condition-code-option bit Message-ID: <20210311112110.74fd6122.cohuck@redhat.com> In-Reply-To: <204A69C9-45EF-4613-8BC4-E2CF18E63180@redhat.com> References: <5630635a-f605-dd73-4b06-844988f17dc6@redhat.com> <204A69C9-45EF-4613-8BC4-E2CF18E63180@redhat.com> Organization: Red Hat GmbH MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=cohuck@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=63.128.21.124; envelope-from=cohuck@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.243, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Huth , Janosch Frank , Richard Henderson , qemu-devel@nongnu.org, qemu-s390x@nongnu.org, Claudio Imbrenda Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, 10 Mar 2021 21:49:22 +0100 David Hildenbrand wrote: > > Am 09.03.2021 um 22:05 schrieb Thomas Huth : > >=20 > > =EF=BB=BFOn 04/03/2021 09.10, David Hildenbrand wrote: =20 > >>> On 03.03.21 22:36, Richard Henderson wrote: > >>> On 3/3/21 1:22 PM, David Hildenbrand wrote: =20 > >>>> =20 > >>>>> Am 03.03.2021 um 22:19 schrieb Richard Henderson : > >>>>>=20 > >>>>> =EF=BB=BFOn 3/3/21 1:11 PM, David Hildenbrand wrote: =20 > >>>>>> MMIO on s390x? :) =20 > >>>>>=20 > >>>>> hw/s390x/s390-pci-bus.c, memory_region_init_io*(). > >>>>> =20 > >>>>=20 > >>>> ... part of system address space where a CPU could stumble over it? = =20 > >>>=20 > >>> Impossible to tell within 3 layers of object wrappers. :-( > >>> I suppose I have no idea how "pci" was hacked onto s390x. =20 > >> You've used the right words to describe "pci" (!) on s390x. > >> IIRC, there is no MMIO: configuration space accesses etc. are performe= d using special access instructions - which will "emulate" the MMIO access = performed on other archs via simple read/write instructions. > >> Ordinary instructions (e.g., mvpg) that operate on the system address = space should never stumble over MMIO regions - because that concept does no= t exist on s390x. =20 > >=20 > > Sorry, guys, you've lost me here ... is there now something left to do = for this patch or is it good as it is? =20 >=20 > I think that check for invalid TLB should be replaced by a check against = host =3D=3D NULL. >=20 Just a reminder that softfreeze is on Tuesday next week, and I'd like to send a pull request by Monday. So a v5 should arrive soon to make it :)