All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
	"Daniel P.Berrangé" <berrange@redhat.com>,
	"Markus Armbruster" <armbru@redhat.com>,
	"Samuel Thibault" <samuel.thibault@ens-lyon.org>,
	qemu-devel@nongnu.org
Subject: Re: [PATCH 3/4] usb: Un-deprecate -usbdevice (except for -usbdevice audio which gets removed)
Date: Thu, 11 Mar 2021 12:37:38 +0100	[thread overview]
Message-ID: <20210311113738.exhvhskqnpguafyz@sirius.home.kraxel.org> (raw)
In-Reply-To: <1f5ff060-5ec6-22bb-8b23-a558d6520894@redhat.com>

  Hi,

> >  It is arguably the case for disk,
> > serial, net, and host, yet we removed those anyway, to make the regular
> > and more expressive interface the only one.
> 
> The problem with those devices was that they used their own parameter
> parsing code,

Yes, that was IMHO the most important issue.  Two ways to configure
devices, the usual properties and the hand-crafted and often buggy
device-specific parsers.

Now we are down to simple aliasing without parameter support, except
for braille which has the special chardev handling.  Given we keep
braille support anyway there is little reason to drop the aliasing
support for the other devices which don't require parameters.  It's
literally a single line of code per device, hardly a big maintainance
burden.  The benefit is we don't invalidate tons of webpages which
document "-usbdevice tablet" and the like.

> We didn't make up our minds for three years now. In my eyes that's a
> decision for keeping -usbdevice braille around.

Another option could be to integrate the braille bits into the
usb-braille device, then kill the separate chardev.  Which would
also drop support for serial braille devices.  Not sure how much
of a problem that would be these days.  But that likewise needs
someone to step up doing the work ...

take care,
  Gerd



  reply	other threads:[~2021-03-11 11:38 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-10 17:33 [PATCH 0/4] Clean up the -usbdevice mess Thomas Huth
2021-03-10 17:33 ` [PATCH 1/4] usb: remove support for -usbdevice parameters Thomas Huth
2021-03-10 18:19   ` Eric Blake
2021-03-10 17:33 ` [PATCH 2/4] usb: remove '-usbdevice u2f-key' Thomas Huth
2021-03-10 17:33 ` [PATCH 3/4] usb: Un-deprecate -usbdevice (except for -usbdevice audio which gets removed) Thomas Huth
2021-03-11  8:38   ` Markus Armbruster
2021-03-11  9:14     ` Thomas Huth
2021-03-11 11:37       ` Gerd Hoffmann [this message]
2021-03-11 11:45         ` Samuel Thibault
2021-03-11 10:29     ` Paolo Bonzini
2021-03-10 17:33 ` [PATCH 4/4] usb: Document the missing -usbdevice options Thomas Huth
2021-03-11  8:41 ` [PATCH 0/4] Clean up the -usbdevice mess Gerd Hoffmann
2021-03-11  9:28 ` [PATCH 5/4] usb: Remove "-usbdevice ccid" Thomas Huth
2021-03-17  6:04   ` Thomas Huth
2021-03-17  6:40     ` Gerd Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210311113738.exhvhskqnpguafyz@sirius.home.kraxel.org \
    --to=kraxel@redhat.com \
    --cc=armbru@redhat.com \
    --cc=berrange@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=samuel.thibault@ens-lyon.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.