From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01403C433E0 for ; Thu, 11 Mar 2021 16:10:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B7B1764FE5 for ; Thu, 11 Mar 2021 16:10:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234258AbhCKQJt (ORCPT ); Thu, 11 Mar 2021 11:09:49 -0500 Received: from mail.kernel.org ([198.145.29.99]:49948 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234176AbhCKQJ1 (ORCPT ); Thu, 11 Mar 2021 11:09:27 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 5ADE964D5D; Thu, 11 Mar 2021 16:09:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1615478966; bh=CMKCM7h0YQHLp6ZA1+GQSMClZW5GB0avjdcUEF2pvzs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Fwm0z8S4cbkmBI9wGOic+8gXazddLFOq+1WS0pmt2WIgCo8ilgf2CYIvNtECwnV+Y XaYEthzmQGBxR89fkBTfPZzUWe/Rr7c18eePTkUBJiBMw1JJasc4DXIUSo2ALGxOFB zlNhoVrlBOs+l8JYlCyyP/4JfnKQRuFEeoLQIl7oyBVsgZ5nT0XDiRARuJPIp3wArB AesXYfsTIGOsKHVN4B7fIwl8+EBKKYvx5V94kYCyF/ZupTGHO167M0sXqq28Xh8q6f kWn+P9jA33sbDslbET4BuzIGsvfgVYLaTaIdV6cQTkeQ+3xJKSPcBgxTKW0zfvaIWM 1qXrNDcdpNpZA== Date: Thu, 11 Mar 2021 16:09:19 +0000 From: Will Deacon To: Quentin Perret Cc: catalin.marinas@arm.com, maz@kernel.org, james.morse@arm.com, julien.thierry.kdev@gmail.com, suzuki.poulose@arm.com, android-kvm@google.com, linux-kernel@vger.kernel.org, kernel-team@android.com, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, tabba@google.com, mark.rutland@arm.com, dbrazdil@google.com, mate.toth-pal@arm.com, seanjc@google.com, robh+dt@kernel.org, ardb@kernel.org Subject: Re: [PATCH v4 06/34] KVM: arm64: Factor memory allocation out of pgtable.c Message-ID: <20210311160919.GA31206@willie-the-truck> References: <20210310175751.3320106-1-qperret@google.com> <20210310175751.3320106-7-qperret@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210310175751.3320106-7-qperret@google.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 10, 2021 at 05:57:23PM +0000, Quentin Perret wrote: > In preparation for enabling the creation of page-tables at EL2, factor > all memory allocation out of the page-table code, hence making it > re-usable with any compatible memory allocator. > > No functional changes intended. > > Signed-off-by: Quentin Perret > --- > arch/arm64/include/asm/kvm_pgtable.h | 41 +++++++++++- > arch/arm64/kvm/hyp/pgtable.c | 98 +++++++++++++++++----------- > arch/arm64/kvm/mmu.c | 66 ++++++++++++++++++- > 3 files changed, 163 insertions(+), 42 deletions(-) Thanks, looks good to me now: Acked-by: Will Deacon Will From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 796A2C433DB for ; Thu, 11 Mar 2021 16:09:41 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id BF1C864FE5 for ; Thu, 11 Mar 2021 16:09:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BF1C864FE5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 143A44B4D9; Thu, 11 Mar 2021 11:09:40 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@kernel.org Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ETUroLglccZ7; Thu, 11 Mar 2021 11:09:35 -0500 (EST) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 6AC2C4B4FD; Thu, 11 Mar 2021 11:09:35 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 82BD24B4C7 for ; Thu, 11 Mar 2021 11:09:34 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id zEHdNqC-UCay for ; Thu, 11 Mar 2021 11:09:29 -0500 (EST) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id 6BE3E4B49C for ; Thu, 11 Mar 2021 11:09:29 -0500 (EST) Received: by mail.kernel.org (Postfix) with ESMTPSA id 5ADE964D5D; Thu, 11 Mar 2021 16:09:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1615478966; bh=CMKCM7h0YQHLp6ZA1+GQSMClZW5GB0avjdcUEF2pvzs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Fwm0z8S4cbkmBI9wGOic+8gXazddLFOq+1WS0pmt2WIgCo8ilgf2CYIvNtECwnV+Y XaYEthzmQGBxR89fkBTfPZzUWe/Rr7c18eePTkUBJiBMw1JJasc4DXIUSo2ALGxOFB zlNhoVrlBOs+l8JYlCyyP/4JfnKQRuFEeoLQIl7oyBVsgZ5nT0XDiRARuJPIp3wArB AesXYfsTIGOsKHVN4B7fIwl8+EBKKYvx5V94kYCyF/ZupTGHO167M0sXqq28Xh8q6f kWn+P9jA33sbDslbET4BuzIGsvfgVYLaTaIdV6cQTkeQ+3xJKSPcBgxTKW0zfvaIWM 1qXrNDcdpNpZA== Date: Thu, 11 Mar 2021 16:09:19 +0000 From: Will Deacon To: Quentin Perret Subject: Re: [PATCH v4 06/34] KVM: arm64: Factor memory allocation out of pgtable.c Message-ID: <20210311160919.GA31206@willie-the-truck> References: <20210310175751.3320106-1-qperret@google.com> <20210310175751.3320106-7-qperret@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210310175751.3320106-7-qperret@google.com> User-Agent: Mutt/1.10.1 (2018-07-13) Cc: android-kvm@google.com, catalin.marinas@arm.com, mate.toth-pal@arm.com, seanjc@google.com, tabba@google.com, linux-kernel@vger.kernel.org, robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org, maz@kernel.org, kernel-team@android.com, kvmarm@lists.cs.columbia.edu X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu On Wed, Mar 10, 2021 at 05:57:23PM +0000, Quentin Perret wrote: > In preparation for enabling the creation of page-tables at EL2, factor > all memory allocation out of the page-table code, hence making it > re-usable with any compatible memory allocator. > > No functional changes intended. > > Signed-off-by: Quentin Perret > --- > arch/arm64/include/asm/kvm_pgtable.h | 41 +++++++++++- > arch/arm64/kvm/hyp/pgtable.c | 98 +++++++++++++++++----------- > arch/arm64/kvm/mmu.c | 66 ++++++++++++++++++- > 3 files changed, 163 insertions(+), 42 deletions(-) Thanks, looks good to me now: Acked-by: Will Deacon Will _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 183E4C433E0 for ; Thu, 11 Mar 2021 16:11:05 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8C25C64FA3 for ; Thu, 11 Mar 2021 16:11:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8C25C64FA3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=MvZPfbioB3Wa5smhlhjgvjClHGDu23EdtdjCxQAuREw=; b=Zdwy5LNjJPc/9O9/tiP5DIkqq aJkEfY1M+KNfz4OBS40eM+T5iw/OFzP5Y8xd4dg5WFPhtUVTJEYG5G3KZwxddbF1y5A4lO2fgj+qR 8G1M3c04LpLsM92sj+NzeGq25enZ4Y2jZwTNl9pFDN8giPkOof2pZOfZHilLPI2CY2cHM3pAOJcnA i0sJerHmXbSzYRQztCw85vbVEO/6f1n9I5j1aWxg2KznIcK43DVcOYb+R07zUovJnO/y1vFl6dcbY 3XQgtyRUeDg3+ZqvdMj4mzkpUtScDFnWAuQJX6XRnOvg+tSe0YUCGrZpl0fDN8YhxN6HZ3kMM12Kk gN6qim69Q==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lKNsV-009X66-7z; Thu, 11 Mar 2021 16:09:35 +0000 Received: from mail.kernel.org ([198.145.29.99]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lKNsP-009X4e-UU for linux-arm-kernel@lists.infradead.org; Thu, 11 Mar 2021 16:09:31 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 5ADE964D5D; Thu, 11 Mar 2021 16:09:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1615478966; bh=CMKCM7h0YQHLp6ZA1+GQSMClZW5GB0avjdcUEF2pvzs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Fwm0z8S4cbkmBI9wGOic+8gXazddLFOq+1WS0pmt2WIgCo8ilgf2CYIvNtECwnV+Y XaYEthzmQGBxR89fkBTfPZzUWe/Rr7c18eePTkUBJiBMw1JJasc4DXIUSo2ALGxOFB zlNhoVrlBOs+l8JYlCyyP/4JfnKQRuFEeoLQIl7oyBVsgZ5nT0XDiRARuJPIp3wArB AesXYfsTIGOsKHVN4B7fIwl8+EBKKYvx5V94kYCyF/ZupTGHO167M0sXqq28Xh8q6f kWn+P9jA33sbDslbET4BuzIGsvfgVYLaTaIdV6cQTkeQ+3xJKSPcBgxTKW0zfvaIWM 1qXrNDcdpNpZA== Date: Thu, 11 Mar 2021 16:09:19 +0000 From: Will Deacon To: Quentin Perret Cc: catalin.marinas@arm.com, maz@kernel.org, james.morse@arm.com, julien.thierry.kdev@gmail.com, suzuki.poulose@arm.com, android-kvm@google.com, linux-kernel@vger.kernel.org, kernel-team@android.com, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, tabba@google.com, mark.rutland@arm.com, dbrazdil@google.com, mate.toth-pal@arm.com, seanjc@google.com, robh+dt@kernel.org, ardb@kernel.org Subject: Re: [PATCH v4 06/34] KVM: arm64: Factor memory allocation out of pgtable.c Message-ID: <20210311160919.GA31206@willie-the-truck> References: <20210310175751.3320106-1-qperret@google.com> <20210310175751.3320106-7-qperret@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210310175751.3320106-7-qperret@google.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210311_160930_194721_12CC7144 X-CRM114-Status: UNSURE ( 9.24 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Mar 10, 2021 at 05:57:23PM +0000, Quentin Perret wrote: > In preparation for enabling the creation of page-tables at EL2, factor > all memory allocation out of the page-table code, hence making it > re-usable with any compatible memory allocator. > > No functional changes intended. > > Signed-off-by: Quentin Perret > --- > arch/arm64/include/asm/kvm_pgtable.h | 41 +++++++++++- > arch/arm64/kvm/hyp/pgtable.c | 98 +++++++++++++++++----------- > arch/arm64/kvm/mmu.c | 66 ++++++++++++++++++- > 3 files changed, 163 insertions(+), 42 deletions(-) Thanks, looks good to me now: Acked-by: Will Deacon Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel