All of lore.kernel.org
 help / color / mirror / Atom feed
From: Edmundo Carmona Antoranz <eantoranz@gmail.com>
To: kernel-janitors@vger.kernel.org
Cc: arnd@arndb.de, Edmundo Carmona Antoranz <eantoranz@gmail.com>
Subject: [PATCH] staging: vt665x: fix alignment constraints
Date: Thu, 11 Mar 2021 23:43:25 -0600	[thread overview]
Message-ID: <20210312054325.1706332-1-eantoranz@gmail.com> (raw)

Removing 2 instances of alignment warnings

drivers/staging/vt6655/rxtx.h:153:1: warning: alignment 1 of ‘struct vnt_cts’ is less than 2 [-Wpacked-not-aligned]
drivers/staging/vt6655/rxtx.h:163:1: warning: alignment 1 of ‘struct vnt_cts_fb’ is less than 2 [-Wpacked-not-aligned]

This patch is related to 2faf12c57ef (staging: vt665x: fix alignment constraints, 2021-02-04)

The root cause seems to be that _because_ struct ieee80211_cts is marked as __aligned(2),
this requires any encapsulating struct to also have an alignment of 2.

Signed-off-by: Edmundo Carmona Antoranz <eantoranz@gmail.com>
---
 drivers/staging/vt6655/rxtx.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/vt6655/rxtx.h b/drivers/staging/vt6655/rxtx.h
index e7061d383306..c3c2c1566882 100644
--- a/drivers/staging/vt6655/rxtx.h
+++ b/drivers/staging/vt6655/rxtx.h
@@ -150,7 +150,7 @@ struct vnt_cts {
 	u16 reserved;
 	struct ieee80211_cts data;
 	u16 reserved2;
-} __packed;
+} __packed __aligned(2);
 
 struct vnt_cts_fb {
 	struct vnt_phy_field b;
@@ -160,7 +160,7 @@ struct vnt_cts_fb {
 	__le16 cts_duration_ba_f1;
 	struct ieee80211_cts data;
 	u16 reserved2;
-} __packed;
+} __packed __aligned(2);
 
 struct vnt_tx_fifo_head {
 	u8 tx_key[WLAN_KEY_LEN_CCMP];
-- 
2.30.1


             reply	other threads:[~2021-03-12  5:44 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-12  5:43 Edmundo Carmona Antoranz [this message]
2021-03-12  5:50 ` [PATCH] staging: vt665x: fix alignment constraints Edmundo Carmona Antoranz
2021-03-12  9:18   ` Arnd Bergmann
2021-03-12 12:56     ` Edmundo Carmona Antoranz
2021-03-12 14:31       ` Arnd Bergmann
2021-03-12 14:51         ` Edmundo Carmona Antoranz
  -- strict thread matches above, loose matches on Subject: below --
2021-03-16 18:17 Edmundo Carmona Antoranz
2021-03-16 18:17 ` Edmundo Carmona Antoranz
2021-03-16 18:30 ` Arnd Bergmann
2021-03-16 18:30   ` Arnd Bergmann
2021-02-04 16:27 Arnd Bergmann
2021-02-04 16:27 ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210312054325.1706332-1-eantoranz@gmail.com \
    --to=eantoranz@gmail.com \
    --cc=arnd@arndb.de \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.